From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3351FC282DE for ; Thu, 13 Mar 2025 08:22:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4824B280003; Thu, 13 Mar 2025 04:22:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43246280001; Thu, 13 Mar 2025 04:22:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AB8A280003; Thu, 13 Mar 2025 04:22:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0F529280001 for ; Thu, 13 Mar 2025 04:22:55 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D6DC1BA3EA for ; Thu, 13 Mar 2025 08:22:55 +0000 (UTC) X-FDA: 83215837110.05.0B8AC29 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 50F2A140004 for ; Thu, 13 Mar 2025 08:22:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iCVoRzcx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741854173; a=rsa-sha256; cv=none; b=jT2l0cAs6O7BFH8VoSAf0OTYR8j/g3ZzQNqwzfxLmRpPdYIIb0UsHGGXorUrxYtjs7VI/e gKS4s+TWv25qfm3SJf9+uuJDZFXSW6eIIFaPqvvDuBXyIBjWZztUSQ7equE8Z6VxFIEs8S ZjbLc8zfYvmYms1dRb7+XVE1CmND7TU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iCVoRzcx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741854173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JKb8bhfHMFiRwZ59jdxdcm6FlzuySG9mYwbfnUAEPPE=; b=gK/UxbkCtBEDt7HSDKIaQpl6zioqoEpeVuBUO2i/VTQMKkna9KuKygweu5emqoBx8XtVaj 9r2zbrswOxaTci3qZgkx12GSwVixowk2MPpA/rpQX/ZvP3NDc7qsCzeosVAcwhBV9n/OD4 0s7PyPRcYzWYN995kj/hkyKfWwvwfv8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741854172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JKb8bhfHMFiRwZ59jdxdcm6FlzuySG9mYwbfnUAEPPE=; b=iCVoRzcxzBnK36o0+ErE3ajd9wWYcQxZnhFwSR7kIm5mJ4D4J/xvbXhD9KR6UzoLetGb6h y/M0UAbz/RfKppaZAhc/EMufoYy8P5HjgZoiIG0gQ3ouz0DaDb0pbJzBuf/iC5RuekaISR C5p1O3QR6/a9FKmavI8QrYSQRiKgynE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-Wvs5imcMMlWUkIlpnSKo1w-1; Thu, 13 Mar 2025 04:22:51 -0400 X-MC-Unique: Wvs5imcMMlWUkIlpnSKo1w-1 X-Mimecast-MFC-AGG-ID: Wvs5imcMMlWUkIlpnSKo1w_1741854170 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39134c762ebso261516f8f.0 for ; Thu, 13 Mar 2025 01:22:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741854170; x=1742458970; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JKb8bhfHMFiRwZ59jdxdcm6FlzuySG9mYwbfnUAEPPE=; b=hFhjdGSATeUUBimJrFWD7Xmk7zflgyV1P2v0fI1y985hGRHGZAS4DaFmdTRsAPO2h0 tYFrheVgvCsIUiU0KmJg3d9DTRIETKOUInCzQFCB3qYHFsEDudLFa7UP1oREaHA2G/w6 2VmRTIt5UcIJVxA5pSd2T3ddfd+mVRZv4NW2KZNlF+3ZBgJDohacNSX+Clyj7TzRyESI vFdBo554QxBKyC4huB3wBmWdnAbt6F/nU0xrHmLjRewmiHFSyxw3UaLoO2qakjrmQ2OF ffQYsOO140gkxyNNaYs/O/d/Htzwzxw8y0IfxGmhRTX+vIUfA8Vo1dpsVJC405OOSo1F VXww== X-Forwarded-Encrypted: i=1; AJvYcCXjlX7u7CrsMHwbSNEswWm5Zf338mdP6pYJkntvbGojXj9qG5iNSI9lHuipX2OPSIt+dIclNN1saQ==@kvack.org X-Gm-Message-State: AOJu0YzNuF1je0KhOfedfphfAtCcpqN78aN/Ro9FuYKwUaTLBbfYn6K4 dBqVscEARj8C61gE8P0848K2T0jYIHqXnXftzmb7Ea/sDzCkN0AI/iaT/Ke5gpvJc+0Iqn7JUtR 318UdHBKmKwi5Y1Nz+0ZKkMD7jVD8ztz6IRS2rJbngH12Vnd4 X-Gm-Gg: ASbGnctDxAkKjDThaJHsmKntPWVJHV7i5eTVyeagb0QHj1Yc4k+1v2mJePvj2ZWSKhI GYNB50hz9AurbXom7X4gjgGHDfDaFG2+TJtlng4JzOe1ZZft8y5m/A5WJqSlJaNJOG5KlD0i3oL fG2dSKpww9HnOlRPEMidI8eJgxabCwDDMwtfbgG1vIXHSje1Fjmk5FgCLWU5fMjVG47Do3wxqq9 nik1Nrqj7wNQdg4peCuqg4AV2Phy6cOA3zel9Y8pY1ieSZ8rJa8EMne4TxVhJWaGAc/e8A6cUl+ hQvc8QwmYIslnw3s4tOJHSZb6YInO8cCozHJuNqhRFKRDwRNFs/FmkxUIr6J+d1Hn0y8CZTuGWR fTeuik47rZcLt002v6Ixd1J7l7n3xRE/6naa1iriD2Hw= X-Received: by 2002:a5d:59a7:0:b0:391:1139:2653 with SMTP id ffacd0b85a97d-39132de145bmr19688703f8f.52.1741854170239; Thu, 13 Mar 2025 01:22:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE43rHs3WgvOTi5LsVwj2SLALb9R3gJ6Te0W53zkDxInnxOJ+3GIwgQhD4YjNmuEA7ot9BSDw== X-Received: by 2002:a5d:59a7:0:b0:391:1139:2653 with SMTP id ffacd0b85a97d-39132de145bmr19688649f8f.52.1741854169787; Thu, 13 Mar 2025 01:22:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:7c00:4ac1:c2c4:4167:8a0f? (p200300d82f1a7c004ac1c2c441678a0f.dip0.t-ipconnect.de. [2003:d8:2f1a:7c00:4ac1:c2c4:4167:8a0f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c8975ae2sm1308783f8f.51.2025.03.13.01.22.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Mar 2025 01:22:49 -0700 (PDT) Message-ID: Date: Thu, 13 Mar 2025 09:22:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 1/5] meminfo: add a per node counter for balloon drivers To: Nico Pache Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-2-npache@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: imDFaZeiTu6tMk68oZ4dW3RGH7hOK5N-YWiQo02NtBY_1741854170 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: js8q1ktdqg46txffioxd5f5rhgf978tt X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 50F2A140004 X-Rspam-User: X-HE-Tag: 1741854173-256712 X-HE-Meta: U2FsdGVkX1+HROlXg22vCYbezTYMVmQPGRYTabGhMyZjyPK7b4smayiNM9PSG593V7mYTRnyxTJt5mMMiJjjarn+cAaQwZ8Avmku2fX38twTVGBDJ7vZg7afK9oQdm71jwFh2LTUnchN3zI7FIkY3eQxcqy6WuSjglRGFHHHc1Ce/lHAV+rJiSCOoIcXNskCgejElqRrbNlz7eMx2BeG3ulw5x1afrIIFUIJ8ar4J+nLr6L5L6X7wYo1VlM4p/Kbc9zNeZ+GTMGscPrDwh0SaWDHjxpSsAnkoazZ+YOjwdYE3gckNYM2s5U3GQoKmGBI7a95nRSP+9zBmnybgYBzVp11GqU7sW/nA4Qht5YR2yQsW+elam1NodKqCfx4weB72KN74YVbAxGlqhqd+vIk4nkKJ0tWFSA+n+/mFivmRd/u2QHP2VNJW4rmk07VusnB7brjlksrhikVVDpLM0hmUR9yV1eBZqY+55vm0qMwTZgO/E47ylPfh1wjw/qxq1nXcr8fpvKddjOfROcfxECxKGK6jDMgtPCpZ7ewXUop+Bo4HIrAcP6a//ejsUas50oPDGFKNnScr5nxjnfRSzPIa6Lr1ULhFA4EpH3Ugv4Ch2LMr+vvowvcKUYng7H6254IoMmTsSyEpeIKXW53Nc5RLvXGoRHHN94B1xJO3fVO9xFI45Jca8VcxuaAoA6AfNm6L/QQvDn1vI5j07dXWcH2XUs6yx8Xg4FYaCu8r7qRsNZUmYgXL9RhB8Tw/di0xXLqJXEGzayG7nzyzoeC3nU5RvFTzOHlJ4iLHevo/wm7bAfSjCWLrc+aakEE1Wao7Ll8xjHx2QxsQKegQJncdMm59voP4VU3zS9LERCp1fiRRml2CWkLpDsG4icEci6WLIPKPzJEbeHejHd5btHKriIlu/FkNvdwPrLE/RGyaGQv12vHUQEUQ78bnFjB3LZeDDodBOgv+5o3ki/PSLNVPVT zdGBpEqp mFGiupx2c7Nd6tcNqcJkyrqqqlAx7wuJntFTtuJM9PuxNZboxIODFwTuDFSb1RZQM3TNgSfkqtgbR4HxpBbptCPNtprRgWuFeU1FRksUpvUezDS2HyfwpTjZoPKy8cv5B6JM/F5BAP3k1prk8CJppjazTp2vwlXigqISGh+tMYkGWqObnDqs44/ErtaZ9/sOXE+fLiT50BB/extpnTLlD7st1q50pRD40Xweocoeoj0Tn3sxbwYWHfgJUdkEoWaFHKpDhl8HAeV6TBlGpF8k5Kbwqae6cTMpNFJJEkL8O7fvI9j3ofUKfaodUIh/HTP2REi3qqlltjkac87b37qx1AG0NLMUUss571bIDy2/1eacHeSsPUuR8kXhAnprK8R1JLjva/uVeD2fOOgMXhqHNw/pUErodboyqc+ECrneiygx+8iXnkJdzeUrTsorzTrAdUrt7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.03.25 00:04, Nico Pache wrote: > On Wed, Mar 12, 2025 at 4:19 PM David Hildenbrand wrote: >> >> On 12.03.25 01:06, Nico Pache wrote: >>> Add NR_BALLOON_PAGES counter to track memory used by balloon drivers and >>> expose it through /proc/meminfo and other memory reporting interfaces. >> >> In balloon_page_enqueue_one(), we perform a >> >> __count_vm_event(BALLOON_INFLATE) >> >> and in balloon_page_list_dequeue >> >> __count_vm_event(BALLOON_DEFLATE); >> >> >> Should we maybe simply do the per-node accounting similarly there? > > I think the issue is that some balloon drivers use the > balloon_compaction interface while others use their own. > > This would require unifying all the drivers under a single api which > may be tricky if they all have different behavior Why would that be required? Simply implement it in the balloon compaction logic, and in addition separately in the ones that don't implement it. That's the same as how we handle PageOffline today. In summary, we have virtio-balloon: balloon compaction hv-balloon: no balloon compaction xen-balloon: no balloon compaction vmx-balloon: balloon compaction pseries-cmm: balloon compaction So you'd handle 3 balloon drivers in one go. (this series didn't touch pseries-cmm) -- Cheers, David / dhildenb