From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C817C433DB for ; Wed, 24 Mar 2021 07:11:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7B26619EC for ; Wed, 24 Mar 2021 07:11:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7B26619EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5BBAC6B028E; Wed, 24 Mar 2021 03:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 592F76B0292; Wed, 24 Mar 2021 03:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C596B029A; Wed, 24 Mar 2021 03:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 2538B6B028E for ; Wed, 24 Mar 2021 03:11:14 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E48272C78 for ; Wed, 24 Mar 2021 07:11:13 +0000 (UTC) X-FDA: 77953896426.38.A443959 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 9246E2000262 for ; Wed, 24 Mar 2021 07:11:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YH7O8l2aA851k8wCoQPHKlADVD6S8rwNnTnZ0niml0j2SYHh8ENinS5U0jqJcO5Q+a2903MJ/GjmDHvM8rzR/c3bDN/EVHjpS9isDjS/hQ+/01TUIX3QZKrKq6FGRnLdifDysJDdxLGWbVM+ribWVeSYI1fhZciIbto/zEYhAV735T/Y+pfUwGAD+IBbgpSqtdSd2rX2JWBjT0YtLJBy+1E2yVYk9zAlXXqF5ocqXhZeP0TGluN6F2mnmqIr232SayDynetWaQmw1370934mp+l7EdZ/XBUykltbCRTmTkbQDqaZyWp/l82qy3Q2zImuBNSRrKIEGmDCurS0rtYNzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7VeeScmoMLSGZJEsFlNC9F+knY6ybldvtF8HGSnBmE=; b=Vek93sACFpB0MKGx3EFXZ+vZxWWbIgoF2OCEUl6jn7tVYsz9Pfn9PdGaKszQwdu8qvZdZ4NY9WHktdZO/8qjPhkBO15r2z/FlbpKJh4mDZ/7PKpGr160JVlNfHrYKhVj+VmRzDj+UPyPxT8m6Ze4VruxzA9OC9ZFBYlsqDf/3IM7JMXPeHFZCz0LL0xKv1BNE5ofyifqrntWlwbn2I0FtBzixAGCcLjxvnz3QnkyjYnnVTDLped+h3zGG7Nk6QR6lLo7R99d7LEMb1/9jrH/lAPDnxNxV883Jb0NgZ4f/FtZzWtfUmtAJ7/Ws/nkPKVo3y0oASq2p07hZQfOkTu+sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=kvack.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7VeeScmoMLSGZJEsFlNC9F+knY6ybldvtF8HGSnBmE=; b=C/LspvQxXe4Jf9Onj2b2cVUIXkNekoc5UsYAqOoLDIFhwptbXqQlF0/bbcXShVnfKhpVBzWCPCBDgYQo6fHtmzu2SjuGu2A73E5LwrpHePFKrygrdzLt40XP92+4ZTNzHqnNFI7AE/zTxGVYVXZltVuYGh6y75gthAXrRZOEGWfbzD6oW2ByiRVjR9dEZAdmjj3E4sW7NGq0ARw94fr2ysaFoSqEVfZiu0Y+UlN0SJIPGEaAyvbugRkN5C50IlRVljYqope1K6e9fvT+1g4RKZ7ri+V9c+PTnWdHgpLjmpdWbXuQqg74Zv8pbMAJPn+hKvKcaxpzQZS+yWev4HB/1g== Received: from BN6PR1701CA0017.namprd17.prod.outlook.com (2603:10b6:405:15::27) by CH0PR12MB5267.namprd12.prod.outlook.com (2603:10b6:610:d2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 24 Mar 2021 07:11:12 +0000 Received: from BN8NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:405:15:cafe::ad) by BN6PR1701CA0017.outlook.office365.com (2603:10b6:405:15::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 24 Mar 2021 07:11:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; kvack.org; dkim=none (message not signed) header.d=none;kvack.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT023.mail.protection.outlook.com (10.13.177.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3955.18 via Frontend Transport; Wed, 24 Mar 2021 07:11:11 +0000 Received: from [10.2.88.242] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 24 Mar 2021 07:10:18 +0000 Subject: Re: [PATCH v6] mm: cma: support sysfs To: Minchan Kim CC: Andrew Morton , linux-mm , LKML , , , , , References: <20210324010547.4134370-1-minchan@kernel.org> <71b7914d-d9ff-2200-d6c9-6eab28499887@nvidia.com> From: John Hubbard Message-ID: Date: Wed, 24 Mar 2021 00:10:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd2c9d5f-dd7c-482c-db4f-08d8ee940166 X-MS-TrafficTypeDiagnostic: CH0PR12MB5267: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qw9dAQwm51MUFk8so3O6QclHPyIeiU9COTNSZutAd5yPYRRX2+2KUkdGOBa7Zz3Us7SODk1p6aTeitULRqLlFJtgMlRYOKi1FK+3xWXcytE2/CJk5pbHjKIf8FU4smozjNKFgNab/sPpSQDaqtNE7UeTGqreUbX7zTS3Kmvw4mlzpYtlvVc/cdKgksIi3ZeJSJhW7SEXQ0rtM+VQsPVa3O09dqx36w7YacylvKAG0QfoNDopQDyo5GqJ68v0d+5fcBi7FmI5xpKZY1qQrNv0004us6Jf+ErxKM3SL1ExDugdQe1xr2gHhbL3ve8aK/IJ3wiPRnL2WBg/+XgGPDf0pIHrVeGX7Di1TyKlstfaRRC0ePUnMj2Rtesd34joA7B0yI8tMJ7PIvZPURWFHeuh0qv0bqJ9jB1sxbF6j45Xreqaaz8r1+98ljd71EfulK3A/zmwVpO8uJJsXs17bWd7xn2gqAaPqCEkx0fJHgEfuEwL6Z6JLiUitx5YYOgSnBiwC8OORP2QQ4xU9XT7+3DXn+9lmnmZsTUzb2G3Ji5gXeMZ+MmtZJ6QJAsgi3kBTdCdFukqVH0RUCn7zj9en5M0jjTN2w6iQLLBzYdQHoGW0tXLvsF9+0GUW84gyeXUSF2jXpYOwnFbeSrcSCGwOX+tibRczgjifkI5oM4WAL2djJvzVtZtcXakErZDpqcSXph3 X-Forefront-Antispam-Report: CIP:216.228.112.34;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:schybrid03.nvidia.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(136003)(376002)(36840700001)(46966006)(53546011)(336012)(2616005)(70586007)(426003)(356005)(31696002)(16526019)(186003)(26005)(7636003)(70206006)(86362001)(2906002)(82740400003)(54906003)(36756003)(4326008)(31686004)(36906005)(47076005)(4744005)(36860700001)(8936002)(5660300002)(6916009)(478600001)(16576012)(8676002)(316002)(82310400003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 07:11:11.7404 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd2c9d5f-dd7c-482c-db4f-08d8ee940166 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5267 X-Stat-Signature: qffupy6m63awsxzqxi9qxszg6b3p36pq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9246E2000262 Received-SPF: none (nvidia.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=NAM12-DM6-obe.outbound.protection.outlook.com; client-ip=40.107.243.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616569872-749561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/23/21 11:57 PM, Minchan Kim wrote: ... >> , how about approximately this: >> >> struct cma_kobject_wrapper { >> struct cma *parent; >> struct kobject kobj; >> }; >> >> struct cma { >> ... >> struct cma_kobject_wrapper *cma_kobj_wrapper; >> }; >> >> >> ...thus allowing readers of cma_sysfs.c to read that file more easily. > > I agree cma->kobj->kobj is awkward but personally, I don't like the > naming: cma_kobject_wrapper parent pointer. cma_kobject is alredy > wrapper so it sounds me redundant and it's not a parent in same > hierarchy. > > Since the kobj->kobj is just one line in the code(I don't imagine > it could grow up in cma_sysfs in future), I don't think it would > be a problem. If we really want to make it more clear, maybe? > > cma->cma_kobj->kobj > > It would be consistent with other variables in cma_sysfs_init. > OK, that's at least better than it was. thanks, -- John Hubbard NVIDIA