From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191B9C7EE29 for ; Fri, 9 Jun 2023 09:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D0968E0003; Fri, 9 Jun 2023 05:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97F8C8E0001; Fri, 9 Jun 2023 05:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FACF8E0003; Fri, 9 Jun 2023 05:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6965A8E0001 for ; Fri, 9 Jun 2023 05:04:38 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2D6BF401AD for ; Fri, 9 Jun 2023 09:04:38 +0000 (UTC) X-FDA: 80882623836.20.AE2E766 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id DEDA2180021 for ; Fri, 9 Jun 2023 09:04:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ehUwn+5f; spf=pass (imf24.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686301476; a=rsa-sha256; cv=none; b=kYiAdPSqtBiBxmXjueUeyif2iCNZzrJlTNqNTFAjmZcf2hqpH7pyExiZ9V22ZnZpNhhzxA jIRx+iHsrI6sZ3xmWfGEZyH0If3rxM0dRpijcLtz5qzbYQlJHGjmGO3EX3rHGgikxNUoAk tHSSUxTOjJCYl6TgIjpKjLJSaiNs5ms= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ehUwn+5f; spf=pass (imf24.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686301476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TLk6gSKtsM+p9Rtgq5+IZGVTEjc3fvT8GmlHeUGj3wU=; b=HEQo0p67Xh4m6TLONGiRj+zWGgFBoTQUX10wsYROyUh4h/4jkR9vBPIfOt5sVrhKVtvmL1 17QYc068LeGjqAk/aA1U8ursVAKSllUx4NX1gIl33UuBUIpYH3OKb89vr5y33ISk2ws2DG K5YiJCQJhL37dDuOd21Dze/bOxaCSHc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLk6gSKtsM+p9Rtgq5+IZGVTEjc3fvT8GmlHeUGj3wU=; b=ehUwn+5fAisgAEtAIMl5EIJdeclqSq8CTML5XxKV3vnBdSoKWM2gHwMxwSDWO0iw5VXJLh 8SS/MgxwDJJJA3Tt6AO+Slri6c8ud7wu7sku5IGptOdbBlKOktrAg+YkIdnNEDgtpKVACA bxrEekcdTsq3Acc+35VY7WKEzTLjEFM= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-0cVvXQi_PvuSVgmeyy0-1g-1; Fri, 09 Jun 2023 05:04:34 -0400 X-MC-Unique: 0cVvXQi_PvuSVgmeyy0-1g-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-94a35b0d4ceso149183666b.3 for ; Fri, 09 Jun 2023 02:04:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301473; x=1688893473; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TLk6gSKtsM+p9Rtgq5+IZGVTEjc3fvT8GmlHeUGj3wU=; b=ZAFFGsWpVO2DRQN8RZWfojI+G8aLxmRBjs6hOG/u2eTIMe02T8IAsnzL7oDdjY1ho/ baYSBaftyNmkbt5nuR7PbmtcvJfxYLV/zgK1SjhRJFeBFAQJiIQ6TsCZOQuWezxO1kLk l/CZ7r4Imi92Dq/VaVor1lYnCBmMjCz/b6epGY6gwLQ9hhOp42rj4XIzqDGr3HZ1VMWz jDw6q+H9/WUckWHnlf3mw1TVqEBQ6eU2lLMB//B4yv7mlNAlnb79bdS93Y3Dmut2RC54 aV/usNFO1URWg3EXmynTXmoXgFZW/jEzOWseLRLE0kvFEFrvjGpUOCEsHKGAkmSUcZ6q JUtw== X-Gm-Message-State: AC+VfDxQm5TGLWmftuNjZs5M8KptPyt8AA+2B2gbPOxwFh/F1GwxPqx6 TWUcNCn5QEAiBbUqKrgdBxj5+5cCJ4w3PGT1Zh0VjnoEAPlppfuhmoA0Zs4IZ13pNlNkijG4jZb VMkDyUQ83P08= X-Received: by 2002:a17:907:c15:b0:94e:1764:b09b with SMTP id ga21-20020a1709070c1500b0094e1764b09bmr1027449ejc.45.1686301472967; Fri, 09 Jun 2023 02:04:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4KrasOi5l6sCNShc9kV8qfG1eq+fRbvkSLL3UxeHKWwdsKczbSQdc/+63BzxHLxAbWxA2H7A== X-Received: by 2002:a17:907:c15:b0:94e:1764:b09b with SMTP id ga21-20020a1709070c1500b0094e1764b09bmr1027414ejc.45.1686301472616; Fri, 09 Jun 2023 02:04:32 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id v5-20020a170906858500b0096f72424e00sm1013932ejx.131.2023.06.09.02.04.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:04:32 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:04:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() To: Jason Gunthorpe , Yu Zhao Cc: Andrew Morton , Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-2-yuzhao@google.com> From: Paolo Bonzini In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DEDA2180021 X-Stat-Signature: 7aiwsek13qp6xhoqa7fddaywifipri1t X-Rspam-User: X-HE-Tag: 1686301475-864905 X-HE-Meta: U2FsdGVkX1+1w4lFyeuCEZyd3QYtufWmriDmgEZIQHqN9JQeWQxe1BFqmdy0zUooSYi6nCi2JGRB/7W4GsB1KYkUv2CZfbKIMOgzpGGA3+f1RTjtL7Fcenkh+czla2JHSijWYiEpIUsBuuQkKZjrZuqGOYGdB7ZKZlhxeB1uTV2mowSuR3ZyxwID9WOS9LnrkmJ+PJ0xPuU1LLMbf8qrI+Nq/uoNLXjrWty77+5RUdJlLs0Y6nGR9Urw7FhRLQtk+tzxFu3UmKXjs+Rv7fdHesWeGIswz/Sj6mh/AqsnFAuW7eOjd2RVBpORi1CkmhBcinQbxJFpYxFubQPXdU6z1SH0h3It998ifGO2M62dgtmYTzs+YTJDpphS//5gh8cUMhDY469SjoSAai0ysjPctryig2LFaT32X+e7ay5VLmlzb6k6PciP8V3dk7XjmcNqq7QEG9LdCnk5AgNx7zzoH8oAaCRla6zWrxGKPPtql6E7msz6FT1TDKIxJX8/0m849x9fOrUfcOwzkJEU1WtNoZhMcZ1WoProwBlBVoNnNZwI+RjC1eRmeuNzpjcks2JScDEB3Q2xjJ6Ywc3khG1dFbk0US7YTBON7VE02BpqEarJgGAjo9UyWtLQQ/A6cyngjiDJxH6duqZ/LODRc4aRJyw6u5rYhRjXzympxyfpFQYi6i9hE+RFo0x1uhwXyAtEWh+SZpDsHz76GQOIUtTPgrZ5RzkSDEPYAnsTbGpD/hk0AT9XVxjxLYowQAtCrKo+A4gGTwG6cdBeDM7EsJBM6izzNhneBjEe6rLVU75MZKSLVfxfbhJWlF+CQ853R8zN4rMuYTvdOkVS8qewWQNfGOPDG5fbe6RTP5PKdgZfZ55siucD2tCRE997rdFEn4dyDrchNMWOr1h2iv4MXfT9PBWGwYK5ObqhL1DD5jJ2ZjM/tDO3Vjj92eu746CVTwW1OtVGMt29t6CNnPitkaX h92w6Wfn l5uGLqGAjsE0FBeADpiONYCUILpMmCILn93vpUzxGk6IEJSU3McWz8t1pc9/tE6W9Utx8Flr03AM2xle/ltr9fRcRkb1sWRW+9HEw02CGhBpZr/F1JQRQCDS0hQCzztsOjlnjDubTrYdV6VOvely55c0uiLQjGtAqQyPMF9cSVgJ4oKrDkLiGWwFW7vCRkOfBQaIdSyTJkz/2QYfq79XIw4DfE2qcV3MiC6lHAdMhq3zGJTDizqNyKCd61jnhHhiU8AJDPBMtXnkUUZysFwgFc8zLUDQGz1Kihta75+lExwA1VE28f8UN82ipL5x3mzp05a/Ozjmq5CO4bDGRUZHgdrrfy+Xs9H9tdVrAEg9W99KtQlOBFwGcFljurDPpUoHcmEqheC6gl+MaHac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/23 21:17, Jason Gunthorpe wrote: >> + int (*test_clear_young)(struct mmu_notifier *mn, struct mm_struct *mm, >> + unsigned long start, unsigned long end, >> + bool clear, unsigned long *bitmap); >> + > Why leave clear_young behind? Just make a NULL bitmap mean > clear_young? It goes away in patch 2, together with: @@ -437,7 +412,7 @@ static inline int mmu_notifier_clear_young(struct mm_struct *mm, unsigned long end) { if (mm_has_notifiers(mm)) - return __mmu_notifier_clear_young(mm, start, end); + return __mmu_notifier_test_clear_young(mm, start, end, true, NULL); return 0; } @@ -445,7 +420,7 @@ static inline int mmu_notifier_test_young(struct mm_struct *mm, unsigned long address) { if (mm_has_notifiers(mm)) - return __mmu_notifier_test_young(mm, address); + return __mmu_notifier_test_clear_young(mm, address, address + 1, false, NULL); return 0; } Paolo