From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC0BC02185 for ; Sat, 18 Jan 2025 03:25:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F93B6B0082; Fri, 17 Jan 2025 22:25:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A8FE6B0083; Fri, 17 Jan 2025 22:25:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 796DA6B0085; Fri, 17 Jan 2025 22:25:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 521FA6B0082 for ; Fri, 17 Jan 2025 22:25:38 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F3791A13D8 for ; Sat, 18 Jan 2025 03:25:37 +0000 (UTC) X-FDA: 83019132714.26.6691C8D Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf17.hostedemail.com (Postfix) with ESMTP id 86DED40008 for ; Sat, 18 Jan 2025 03:25:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=kciYWkRn; spf=pass (imf17.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737170735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FA6xT1Fn7iSkDO00AAPe6p1EmFdXA/BcGiOnCvLrOnM=; b=Se+R4DgRI/fYYwPrPC/8I69LeUky0xlX4c85nDpWtawrxTod3Hr42DNCdt97ARn5/cEkRd n0u0F9j6DW3gmSeLxjmKLi/0jwC5AwSadzrtcSAfN5F1T3WOcO1r36TLtggIm8G1k4GZ2j h6cA8aIvEx7v4MZuBCHCdJadESrbFTA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737170735; a=rsa-sha256; cv=none; b=WKiN6PI9hh90JxCoGBmO5zi7qCoGUowMDNkEPKAdDQWFfj91+BjLj8z76yqzCmL8BU47om 1oSzDNBUReuGJajWFdh07ifiMPwOIkBN84UwACXz1z77bhoj8TXRmhdsQhkKnRrZ4x0tB7 UMHEZtrXU9eZ+ahbu6l1bugdhzn3aRA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=kciYWkRn; spf=pass (imf17.hostedemail.com: domain of jefflexu@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=jefflexu@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1737170729; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=FA6xT1Fn7iSkDO00AAPe6p1EmFdXA/BcGiOnCvLrOnM=; b=kciYWkRn5s19LsNmWUOt6RmnRuwyraUa3mL9qRAUt7xI53jinajS8vCgEypIDx/hWrl4V78gIi2/mjUu0jty+g81RNDU/lA9qgjx/0Dg1+QUNCtXbtw2J3D1ox3i7YZHLTNhTQiCeJNAwFHiYGhhCebPj6lkZBAP3zsl+3zlizA= Received: from 30.221.144.93(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0WNqQkOj_1737170727 cluster:ay36) by smtp.aliyun-inc.com; Sat, 18 Jan 2025 11:25:28 +0800 Message-ID: Date: Sat, 18 Jan 2025 11:25:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/12] mm/filemap: add filemap_fdatawrite_range_kick() helper To: Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com References: <20241220154831.1086649-1-axboe@kernel.dk> <20241220154831.1086649-11-axboe@kernel.dk> Content-Language: en-US From: Jingbo Xu In-Reply-To: <20241220154831.1086649-11-axboe@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 86DED40008 X-Stat-Signature: s9eds1hiho3bf7gsod3oqpws8njricn5 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737170733-719268 X-HE-Meta: U2FsdGVkX1+DD5RkvO3FuwwXijKqcR1JHAuVZBwt6iKk0J1gbPlXOF0JrwkkykKycxluh2pQ7tsshidUcahNfECbu9h12BIvKSI/hrZFXztJTMCV1fWAvhCGVPrIaU6oqSTKCfScipBnYsb2/vzsFJ2ZXzCBSXAAESyo+EwoX++MBaPbbOW4d6WC1+dFBlL5UmiKyOlWBmNpHa7QBOp6oE2xcLWSgAcYT2aUtQJJLy0YYx2W/BXgxZdo4TeoUTJiIn8sKqk2f8Qt+RcfmYTPF3NgmI7ocpVJNElX86/pPptdYY8a5oaRh1Vzfgj/4zUDWQmufKmmjYYmxyWecIkH4Vl+rZ0kEGHRfomm6HCA75CaskwdzHjkcZE0bpfUgbTcWyosE8CqgE76/XTRnmtgdxZPgG6yU93tSsZD+nqEmF15OIzbTL5HdxOlGatF1p7xl8x70C5mXWW8LbFrfgPxoM9rInVlbaGzMP5X1BDcK6CNFSyYPpRQR3XvmIeA63LgcHjDwEYu7lpXyTVTEOnloZNZCZrg6MEM4kZBC7IZZKzd6ahQGQvEV1mjk0t2HeEhmoDuAeUoFj/k6SGrWx6G8cdN7AVxPocwpzV2IopMmpavIT6c17BVgIJm89zihpLCwCTwQHiO1wub9bSBLAhiIBflYjXPE3yyHnVhGCPoM2wrayeMIicIYt1H1p/kM072r+nb9+igRFWAb4n0X3IOW29Fre8kAVuTnWws6WpfMQAQJJ32Woeu8ztPHaR/i4izFvJ7bIXP1SPzCEnNsAgz6d+Lu7t9oDgX8vYq7aRrWKE3nUfhHB4bEJVActGIwk0CVNyl/XpMnCKd7j5HDqVB3EZ1qlv6kv7mFR6ykC6e2iCytpRd9caRtqFLcOM/NkaeRnKSR0SNLvz9gU6V1vphrdPVpbM/HoQjWILYzHWOBUVaVNAkakNDkhtLRRZUBZqXhTOjYWTclSPXZ/wHWAX mdA8HjlI 8gNcAWg46aov9Rzs7aVTnKXoJETpgVzKRisI5QUB/OxEBgRaOhw66WfHYrbJMusgj/APlNPPXNHY+ccn6od3hS5RxQgLOG1pbO8rRhOAKfxuwnXk+eq3rWVDB1ITQfrysoU3mnD6nOa3wl7nh42Iap5zyJTAt+rw2WZWhF9EHjQ+n8P0IsgeoduU3ANKKT8nYnVxgkxdHctUmodb+6T9c75lY+7swnjq3nti1+RCk8XzVDSu3dfYS0KqTwRsJA9o3HttAFUK41S0rExFw8jiF/cu3fxm/+yfufSvEgSpyY2INEj4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/24 11:47 PM, Jens Axboe wrote: > Works like filemap_fdatawrite_range(), except it's a non-integrity data > writeback and hence only starts writeback on the specified range. Will > help facilitate generically starting uncached writeback from > generic_write_sync(), as header dependencies preclude doing this inline > from fs.h. > > Signed-off-by: Jens Axboe > --- > include/linux/fs.h | 2 ++ > mm/filemap.c | 18 ++++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 6a838b5479a6..653b5efa3d3f 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2878,6 +2878,8 @@ extern int __must_check file_fdatawait_range(struct file *file, loff_t lstart, > extern int __must_check file_check_and_advance_wb_err(struct file *file); > extern int __must_check file_write_and_wait_range(struct file *file, > loff_t start, loff_t end); > +int filemap_fdatawrite_range_kick(struct address_space *mapping, loff_t start, > + loff_t end); > > static inline int file_write_and_wait(struct file *file) > { > diff --git a/mm/filemap.c b/mm/filemap.c > index aa0b3af6533d..9842258ba343 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -449,6 +449,24 @@ int filemap_fdatawrite_range(struct address_space *mapping, loff_t start, > } > EXPORT_SYMBOL(filemap_fdatawrite_range); > > +/** > + * filemap_fdatawrite_range_kick - start writeback on a range > + * @mapping: target address_space > + * @start: index to start writeback on > + * @end: last (non-inclusive) index for writeback > + * > + * This is a non-integrity writeback helper, to start writing back folios > + * for the indicated range. > + * > + * Return: %0 on success, negative error code otherwise. > + */ > +int filemap_fdatawrite_range_kick(struct address_space *mapping, loff_t start, > + loff_t end) > +{ > + return __filemap_fdatawrite_range(mapping, start, end, WB_SYNC_NONE); > +} __filemap_fdatawrite_range() actually accepts @end argument as "last (**inclusive**) index". -- Thanks, Jingbo