From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2DFC47DDC for ; Tue, 23 Jan 2024 09:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA0376B0074; Tue, 23 Jan 2024 04:33:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E4F1B6B007E; Tue, 23 Jan 2024 04:33:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF1726B0080; Tue, 23 Jan 2024 04:33:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C2F316B0074 for ; Tue, 23 Jan 2024 04:33:43 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C6E41601EA for ; Tue, 23 Jan 2024 09:33:43 +0000 (UTC) X-FDA: 81710063526.11.A03A07C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id A96BD80011 for ; Tue, 23 Jan 2024 09:33:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706002421; a=rsa-sha256; cv=none; b=vHV2pOZ4dy/1qgPJA5lX6rQjW0hXrEezZt1oDd59Yfj1goy/51vrgOF1F+Jyv2ani4Uizc qI/LiaGbrtT/G1I8awh2iBrHmnHY+gaq8l3b7FOTyxM0pVhPxG0mRCiQwvT07q6jLGUdH7 K4YoVS1ZQs223h3manZknZS5ZFhS/dg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706002421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dZIuaddT9fg4cR/Mq+CWE2/ZzoMXU7r3ms6lYSNC3ms=; b=oadBuhAn8pqPaHRDte3Lc5Ve6tUiZqmqRexx/E+tp1Y4+JfA8cf4nhRHZhlTmI39O5zmEm pTfIFf/Lb4H9Z1CUwFyYTxPLSRzAon0GWHg5vjCavw5XPccgv/2IXmTUDD72R5yupd2cuC 9OpdlXVF56cr+hlUN3Lbz5BmU9CIFAg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1F0D91FB; Tue, 23 Jan 2024 01:34:26 -0800 (PST) Received: from [10.57.77.165] (unknown [10.57.77.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF2463F5A1; Tue, 23 Jan 2024 01:33:39 -0800 (PST) Message-ID: Date: Tue, 23 Jan 2024 09:33:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] selftests/mm: run_vmtests.sh: add missing tests Content-Language: en-GB To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240123073615.920324-1-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: <20240123073615.920324-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A96BD80011 X-Stat-Signature: yd8hn978mz4mzb95j5qf7wucqicaa5yw X-HE-Tag: 1706002421-792168 X-HE-Meta: U2FsdGVkX1+cFeRI1tfogctaYIN+iNqtix4mGP9LKXwQRGOyeafRZ8Jp+jIL9yfFIyLQjjHXA4ABS9R+asW+TLcg7TqSq5BBj3jxnsbjQg/jAKk3lpeRe0fChjTnwZR5IUH8QRQtNjyFwACs8biOoR8EMfFuoAVH+71islsUdbqqb938S+SRph5U7RXt1Pn0gNM8OMwTxu/wIlgNSt4JHrQmFHA92IXoafw5gYINdlUqhpEznzh4PVtTiJceg5OksfCQHPmGTnzSL+bKRJZRLolRWZ66zUPfmnYzYhkN7EKj7MAyWKC1XAGCzU1pgrR0AWoHWte5V/I/aJaG/GTVrrOK0DNWSasiEFCaaGg0y454gSRPxIHpg8uGAKjCM6Ro7E46bqjqu/Yicb+VsEiy3ilqWnkHp05T/lsBFVsrpezt7EfwkYlao7vYeRQci0RvtPcZgsEw+S/jii+rj969XLvBSxyga72NTLmPf8/pmF4+U2sj0qXT6AUwA7ehuDyfeA807itJoca2/N1CHzxaV3qFQR794pkg4OqTMIfq9AW9OzWcjub1e1iExdvwHqGMpvIMYRxvqFPj4/SlmeURVm4QFJupM2bMutpOKRoZcrDxGWgtqvjnASYmF1z0i1BjG+fgOP4HU8P/8GfgJaYxq6JmBXg+YMzGk3r0Ny3veIeeTaN9qba9tP8blHJnmvhUFT+OSYpc7ZOdnKKb0iHEK3RophoC6a2l3Rc2p9Ii5mszqWJeFtZ2eIQg/bvWHvSPkU/Dgdh1bRLfVMRyYAhH60kgzSSFNaRIciaoDSbxxCLZMoon0+AJ1v+RXFvSPy5rHwGrTs3t4q473D9DKXG4A/lUP6bEJoHW3nlCUIDVbsy40X1T2g4kQOeP6PSikgtupuElbccOOl04oOtQMFVQAQK1N58c9lMU/C0LGsqSLkB88wjMEDvwf4KcyDRMnXGxJ3vELoE+pRPDAMS6F/N Lw8efXqq DQ7Lj9jxgm5AkCzCOA3Y0rwkFZVSiIFg9eKKoAci4VdsWTdqeIwnYFmXER+Pq52A+/h8aZGV1TKEHrgURa8Drhj6DG5ezqAT/DICUnhpu49vfvguSo+vjbhGyDBoDmJ9Zg2c9kLUdUhTlPfqDgecfmdhmHNMD7DAOQ0h0sUXmdJefRZg2eebJ23qdMFMyoL79A5l7Rl1pYn8j6c2qZqQUxI6UQkuMkn9uNkGH3Lg1XOU3s0cLhwJAkCG50pLpMXCJvdgCXDp652lqppNY70ZVIKE4Mz3w7q9/HqI37uX8L/PgRabN4g2yNsMbXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/01/2024 07:36, Muhammad Usama Anjum wrote: > Add missing tests to run_vmtests.sh. The mm kselftests are run through > run_vmtests.sh. If a test isn't present in this script, it'll not run > with run_tests or `make -C tools/testing/selftests/mm run_tests`. > > Cc: Ryan Roberts > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Copy the original scripts and their dependence script to install directory as well > --- > tools/testing/selftests/mm/Makefile | 3 +++ > tools/testing/selftests/mm/run_vmtests.sh | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 2453add65d12f..c9c8112a7262e 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -114,6 +114,9 @@ TEST_PROGS := run_vmtests.sh > TEST_FILES := test_vmalloc.sh > TEST_FILES += test_hmm.sh > TEST_FILES += va_high_addr_switch.sh > +TEST_FILES += charge_reserved_hugetlb.sh > +TEST_FILES += write_hugetlb_memory.sh > +TEST_FILES += hugetlb_reparenting_test.sh I see you are exporting 3 scripts, but only invoking 2 of them from run_vmtests.sh below. Is one a helper that gets called indirectly? > > include ../lib.mk > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 246d53a5d7f28..12754af00b39c 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -248,6 +248,9 @@ CATEGORY="hugetlb" run_test ./map_hugetlb > CATEGORY="hugetlb" run_test ./hugepage-mremap > CATEGORY="hugetlb" run_test ./hugepage-vmemmap > CATEGORY="hugetlb" run_test ./hugetlb-madvise > +CATEGORY="hugetlb" run_test ./charge_reserved_hugetlb.sh -cgroup-v2 > +CATEGORY="hugetlb" run_test ./hugetlb_reparenting_test.sh -cgroup-v2 > +CATEGORY="hugetlb" run_test ./hugetlb-read-hwpoison I'm not really a fan of adding this last test here; its destructive because it poisons 8 hugepages. So at a minimum, I think you need to modify the code in run_vmtests.sh to ensure those extra pages are allocated (there is already a section in the script that allocates hugepages). However, given this test is destructive, I'd prefer that it wasn't run as part of the main test set. Because the first time you run it, it will presumably pass, but now some of the hugepages are poisoned so next time you run it, there won't be enough unpoisoned hugepages and a test will fail. So you have very confusing behaviour for a developer who might be running these tests multiple times per boot (e.g. me). Perhaps we can add a -d (destructive) option to the script, and this test will only be run if that option is passed? Thanks, Ryan > > nr_hugepages_tmp=$(cat /proc/sys/vm/nr_hugepages) > # For this test, we need one and just one huge page