From: Chengming Zhou <chengming.zhou@linux.dev>
To: "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Jianfeng Wang <jianfeng.w.wang@oracle.com>,
penberg@kernel.org, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
42.hyeyoo@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] slub: avoid scanning all partial slabs in get_slabinfo()
Date: Fri, 23 Feb 2024 11:36:25 +0800 [thread overview]
Message-ID: <e924c39b-7636-4c34-bfe9-603cf07c21d3@linux.dev> (raw)
In-Reply-To: <6daf88a2-84c2-5ba4-853c-c38cca4a03cb@linux.com>
On 2024/2/23 11:02, Christoph Lameter (Ampere) wrote:
> On Thu, 22 Feb 2024, Chengming Zhou wrote:
>
>> Anyway, I put the code below for discussion...
>
> Can we guestimate the free objects based on the number of partial slabs. That number is available.
>
Yeah, the number of partial slabs is easy to know, but I can't think of a way to
estimate the free objects, since __slab_free() is just double cmpxchg in most cases.
> How accurate need the accounting be? We also have fuzzy accounting in the VM counters.
Maybe not need to be very accurate, some delay/fuzzy should be acceptable.
Another direction I think is that we don't distinguish slabs on cpu partial list or
slabs on node partial list anymore (different with current behavior).
Now we have three scopes:
1. SL_ALL: include all slabs
2. SL_PARTIAL: only include partial slabs on node
3. SL_CPU: only include partail slabs on cpu and the using cpu slab
If we change SL_PARTIAL to mean all partial slabs, it maybe simpler.
Thanks.
next prev parent reply other threads:[~2024-02-23 3:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 21:14 Jianfeng Wang
2024-02-18 19:25 ` David Rientjes
2024-02-19 8:30 ` Vlastimil Babka
2024-02-19 9:29 ` Chengming Zhou
2024-02-19 10:17 ` Vlastimil Babka
2024-02-22 13:20 ` Chengming Zhou
2024-02-23 3:02 ` Christoph Lameter (Ampere)
2024-02-23 3:36 ` Chengming Zhou [this message]
2024-02-23 3:50 ` Christoph Lameter (Ampere)
2024-02-23 5:00 ` Chengming Zhou
2024-02-23 9:24 ` Vlastimil Babka
2024-02-23 9:37 ` Chengming Zhou
2024-02-23 9:46 ` Chengming Zhou
2024-02-23 9:51 ` Vlastimil Babka
2024-02-26 17:38 ` Christoph Lameter (Ampere)
2024-02-27 9:30 ` Chengming Zhou
2024-02-27 22:55 ` Christoph Lameter (Ampere)
2024-02-28 9:51 ` Chengming Zhou
2024-03-14 0:38 ` Jianfeng Wang
2024-03-14 23:45 ` Christoph Lameter (Ampere)
2024-02-23 7:36 ` Jianfeng Wang
2024-02-23 9:17 ` Vlastimil Babka
2024-02-20 18:41 ` Jianfeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e924c39b-7636-4c34-bfe9-603cf07c21d3@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jianfeng.w.wang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox