From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F37C369DC for ; Tue, 29 Apr 2025 16:05:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41C8D6B0007; Tue, 29 Apr 2025 12:05:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CD756B0008; Tue, 29 Apr 2025 12:05:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26CA36B000A; Tue, 29 Apr 2025 12:05:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 00EA86B0007 for ; Tue, 29 Apr 2025 12:05:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 72DC812087A for ; Tue, 29 Apr 2025 16:05:12 +0000 (UTC) X-FDA: 83387555664.02.9EF9CA2 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf15.hostedemail.com (Postfix) with ESMTP id 9DBD4A0028 for ; Tue, 29 Apr 2025 16:05:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=a6Hldany; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745942710; a=rsa-sha256; cv=none; b=hzHC6GLClGIZX02Ok+pRivj8LCOi5gmJRSkEvjlfwPjR735yx9yjyk0mb6xgr/c3xQWybB as/dodt/cfya9TbXbBqzFiVu979PvWskEnlwkSEFvTaEUC01Ix5sIO8pHix5cLQcZ7IfRb b7Q+Q0YFTOwPB7bAjEdH01kNj0RPlOs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=a6Hldany; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745942710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+QzDaNGo5NB7iQMYVe4vJtK6G+OOCC2HWSYEH+vC8Ic=; b=70XgvrlJq8k8tIj3xFSFdyExH+B9ECXzmi4iU9gd+Rf1RfLVOg+d2FfPkjSyTw9xuPFwj4 RcZT/ik38nXVFVoKn8SreFLUhRxsvalcesNQHTDXdxisFc0hbJA4y+xTFwGa7aC5Y6gsou XvdbYgx/NFlR8Wt92bJAk1aNjQYvNoY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745942709; x=1777478709; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kc4wP+JTOQYbzdxScoLeIhj26yfCcr1KXX5njmFEzCM=; b=a6HldanytS69EBDBHc667SXaO5+GYTkIbGJEsZVzr1suvqm1kN4V1gdZ lxgLU2VsbA1O4unC54y9L6xCHI++z0g5DXWQtHJPE85M0Jq6V8B5YsnZH IpQr+3Ak9CyEY/z3t3Ob2mRIy2kC5Oky56HC2uDQqLdBO0THsU6AAUX4C UFQtLZBKwvhkMX1uezwsBy1gcF0rOCYKSk2XLav6DXwKQHT2H53nXgSGI GunRGd3gNmA4oB7wRI6vBYKRWSPmAcefnOrcFKJ33bv2rvlpNALfsLfCg tj0lWleZq4yrFKBflsD5A0PGFecF2KwiF2TLoAWjIAluc8e0btAJibUY3 Q==; X-CSE-ConnectionGUID: FHZwySEuR6KHKMUg2lhoTA== X-CSE-MsgGUID: yoHcow29QmOInJl1avWOsg== X-IronPort-AV: E=McAfee;i="6700,10204,11418"; a="47585042" X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="47585042" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 09:05:07 -0700 X-CSE-ConnectionGUID: 4V1xIgNkRNqS84as7fjsbQ== X-CSE-MsgGUID: qtvKug+WQZ2IK/ghsaacoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,249,1739865600"; d="scan'208";a="139055434" Received: from sramkris-mobl1.amr.corp.intel.com (HELO [10.124.223.107]) ([10.124.223.107]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2025 09:05:05 -0700 Message-ID: Date: Tue, 29 Apr 2025 09:05:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 11/14] x86: add KHO support To: Mike Rapoport Cc: Changyuan Lyu , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, corbet@lwn.net, dave.hansen@linux.intel.com, devicetree@vger.kernel.org, dwmw2@infradead.org, ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com, jgowans@amazon.com, kexec@lists.infradead.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com, mingo@redhat.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterz@infradead.org, ptyadav@amazon.de, robh@kernel.org, rostedt@goodmis.org, saravanak@google.com, skinsburskii@linux.microsoft.com, tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org, x86@kernel.org References: <20250411053745.1817356-1-changyuanl@google.com> <20250411053745.1817356-12-changyuanl@google.com> <35c58191-f774-40cf-8d66-d1e2aaf11a62@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 9DBD4A0028 X-Stat-Signature: kan1tg7k4wojo6f44jktir655xh7acho X-Rspam-User: X-HE-Tag: 1745942709-714624 X-HE-Meta: U2FsdGVkX18Som1tmyR5q9xsHzx7W/4g7BMXGDB07v1jjP1855mj5vb0VnAsB93CtZnJh93zCtjyJEz8GgAkKiqxoVd4wfGSgxqSyFaBLSrps0RcNwEqNkUu4BPG7jRhelkNw1Tav3/NwzALhb9Lv2772MWMrmpKhyq6EoK7lf2znaUs8EZnp4yXJIeP0/18KXQT+rqS5ErWeUauWzFgtHVUjksz1Ot4k3p7tySSci346MkoI3f+RESaD90AyN19XF/Red7uL8KP3d5ZK+GXirHuKKN+2mkmuXjD25T37Hbzw+rG4th/FvkkLyTbbp0gSI18GQpUI+nsGDqbaO2M0LX0AMHFPBZaUPhZs765DmGVCxtcm6qhuuakw0Tn2cnjgI+orkR9QYpDuWPRUhSusoj1E25GNCP2z+nQWSXYWxgluQG7mrYTlnPmNgo66GbGXboqh8vOxOFviW0G1pZ90EXW0MJ7tDRyTS7LMDMBYDF0+ykXV7gsds48u329OZmhv9T+gX7SNYb0VbLVpmBSg82bUWRP1tpt9kf2w0T3Z3/t4RcZhwWiPeDUkK/GTGA9Stxz6p3MerCazziyATGhJshgQ9xu0mNjT2xsGUhg1PoFmm5Scy/8iPElM/Ozoaf2JJPqN9481RdUvKx7EyLFMV5jFTjSAmBueWrj2mmITxsuLIt2l9TO/KP57TNYINMNSKftTXJEglE7dUKt2zTMnQgyDqXq79eK06NKHDP0vzY1WRK58A/84wVlN2KJ+cBY++Qy46UOEVY18kYvu4lup8SPqmPRvvFdjtb8Ca8+l8ijPd/rWbF5Gbo2s5VkNWltPaux/GuJYZ32nSP1ZnhVjAoEzi07WKcF3qFv3XhhEuxIa1KrGheBgjIXRfYIBGBpVIYljqqwqP6BGKFp+h46EC2YUZN7k3j4Hh5pd7lu6+F/CpRWVmM6mczrltAD8eAgxZm0a8jUouiR7oOyCJ/ o6StvHN5 bngTuEpeCtjXUboQToaGHPgqH3B5UZD8gmT2HeXU87Q2rx/Tww7bDstYLdtLrirL4PAQ4ueNvtLlPj1Xzm8QWt/QLaiZl3V1/BpoL/LdOb2c9fYZMfNQ/lvAwKIXd5CE6YTrBgPvd4yyWVj0FbKYIHiw8DOfaHgFMf53xApiutoq+gqNVianPh25OJpRZRx1u311IfUWSrqPAFW47BxZJX9eI9XMMc1s55GO4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/29/25 08:53, Mike Rapoport wrote: > On Mon, Apr 28, 2025 at 03:05:55PM -0700, Dave Hansen wrote: >> On 4/10/25 22:37, Changyuan Lyu wrote: >>> From: Alexander Graf >>> >>> +#ifdef CONFIG_KEXEC_HANDOVER >>> +static bool process_kho_entries(unsigned long minimum, unsigned long image_size) >>> +{ >>> + struct kho_scratch *kho_scratch; >>> + struct setup_data *ptr; >>> + int i, nr_areas = 0; >> >> Do these really need actual #ifdefs or will a nice IS_ENABLED() check >> work instead? >> >>> + ptr = (struct setup_data *)(unsigned long)boot_params_ptr->hdr.setup_data; >> >> What's with the double cast? > > The double cast is required for this to be compiled on 32 bits (just like > in mem_avoid_overlap). The setup_data is all u64 and to cast it to a > pointer on 32 bit it has to go via unsigned long. Let's just make KHO depend on 64BIT, at least on x86. >>> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c >>> index 68530fad05f74..518635cc0876c 100644 >>> --- a/arch/x86/kernel/kexec-bzimage64.c >>> +++ b/arch/x86/kernel/kexec-bzimage64.c >>> @@ -233,6 +233,31 @@ setup_ima_state(const struct kimage *image, struct boot_params *params, >>> #endif /* CONFIG_IMA_KEXEC */ >>> } >>> >>> +static void setup_kho(const struct kimage *image, struct boot_params *params, >>> + unsigned long params_load_addr, >>> + unsigned int setup_data_offset) >>> +{ >>> +#ifdef CONFIG_KEXEC_HANDOVER >> >> Can this #ifdef be replaced with IS_ENABLED()? > > The KHO structures in kexec image are under #ifdef, so it won't compile > with IS_ENABLED(). They shouldn't be. Define them unconditionally, please. ... >> Please axe the #ifdef in the .c file if at all possible, just like the >> others. > > This one follows IMA, but it's easy to make it IS_ENABLED(). It's really up > to x86 folks preference. Last I checked, I'm listed under the big M: for "X86 ARCHITECTURE". ;)