From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1634D0C5F9 for ; Fri, 25 Oct 2024 09:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E2B96B008A; Fri, 25 Oct 2024 05:54:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 493066B008C; Fri, 25 Oct 2024 05:54:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E5AA6B0092; Fri, 25 Oct 2024 05:54:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 120616B008A for ; Fri, 25 Oct 2024 05:54:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D737A1A0748 for ; Fri, 25 Oct 2024 09:54:03 +0000 (UTC) X-FDA: 82711664826.02.99FB9AD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id BB001C0004 for ; Fri, 25 Oct 2024 09:54:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gpXn2BuV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZebhwUxo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gpXn2BuV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZebhwUxo; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729850024; a=rsa-sha256; cv=none; b=aMr0IP4Z3ax5YOPoBx3sgDaWUt+LSm/Nymdbs5FOBX/HXCZmZbLS4BHhoBvnM+Md5UdEXs Se/o6/2PoPeAfMiJyp61mTW/hKV6BIexrhM0L7w7dnPoLDexO3utHEhP5Xzdom6cK4d/lg 2e9d1U8O1mCyZYgHK2uh47HpDPz1/RE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gpXn2BuV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZebhwUxo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gpXn2BuV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZebhwUxo; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729850024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KvxWrZ41ZMAaqHl0Ak7ybPhkjv5DvveN4GYwuAGEno0=; b=4LtcT4LflPwqWZ6IflIWdeCXiRxQnQXeu8g5JFJgTrK7hsJ+itqkp9th3iHvAxou2ADirY j0fBjTO/1dV1vzcZzVOHC3lodgG3m/HCwsGCMC08+GmpbGZth+r9tp5D3qDL/WEALrMnGs X9Fjvs6+px6gEjoj3S0sDEqkQyXHwZY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7170321CFF; Fri, 25 Oct 2024 09:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729850074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KvxWrZ41ZMAaqHl0Ak7ybPhkjv5DvveN4GYwuAGEno0=; b=gpXn2BuVYVMLgm4t7yH2ZA4ZX1OJQR64gQ9yLxoLsWJZDnjdzlsy9YeKe1MN1XGjd3Sl/M oXSxw9jMFPqlAdOamtxMyoKSq1QpUgh7f9/n1Z0dor5j6lCKuMgzqafTOp2SnoPLIpo3jX vy26ev1A4h44pDW76UAou4pPHV2Xu48= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729850074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KvxWrZ41ZMAaqHl0Ak7ybPhkjv5DvveN4GYwuAGEno0=; b=ZebhwUxohutSY7l9zEUBEjwgvsezkggClO/9M4aApqv7LXW9mgQiwWk+MPyXE+XYH5HBd9 4buH46vO3+9JsODg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729850074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KvxWrZ41ZMAaqHl0Ak7ybPhkjv5DvveN4GYwuAGEno0=; b=gpXn2BuVYVMLgm4t7yH2ZA4ZX1OJQR64gQ9yLxoLsWJZDnjdzlsy9YeKe1MN1XGjd3Sl/M oXSxw9jMFPqlAdOamtxMyoKSq1QpUgh7f9/n1Z0dor5j6lCKuMgzqafTOp2SnoPLIpo3jX vy26ev1A4h44pDW76UAou4pPHV2Xu48= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729850074; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KvxWrZ41ZMAaqHl0Ak7ybPhkjv5DvveN4GYwuAGEno0=; b=ZebhwUxohutSY7l9zEUBEjwgvsezkggClO/9M4aApqv7LXW9mgQiwWk+MPyXE+XYH5HBd9 4buH46vO3+9JsODg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4329E132D3; Fri, 25 Oct 2024 09:54:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ASkRENpqG2clfwAAD6G6ig (envelope-from ); Fri, 25 Oct 2024 09:54:34 +0000 Message-ID: Date: Fri, 25 Oct 2024 11:54:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: krealloc: Fix MTE false alarm in __do_krealloc Content-Language: en-US To: Qun-Wei Lin , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Matthias Brugger , AngeloGioacchino Del Regno , Danilo Krummrich Cc: catalin.marinas@arm.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org, Casper Li , Chinwen Chang , Andrew Yang , John Hsu , wsd_upstream@mediatek.com References: <20241025085811.31310-1-qun-wei.lin@mediatek.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241025085811.31310-1-qun-wei.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: BB001C0004 X-Rspamd-Server: rspam01 X-Stat-Signature: 4tok5kfuiwxfmeqfu7go3dsdgud9fdgm X-HE-Tag: 1729850067-981039 X-HE-Meta: U2FsdGVkX1/nvpS5R6ncpLJ0zm+IO4OOIZ4kL5qd6WG7ftiwFQ27T6yC9pumna/+Na0oL1X2Nz2P9ewQDDXeEtSTAWLy3jIDz7/K1jJakWr++m7HlzeB7G1xulrjl14hX3/mWJJOukGiAUcg1IL1kAxW3Guzpb0rE+EaTnYOwMZtiuyd65z6eWpyJR7oR4+r0JFXczLhZqNLq0SAy4MXPottM/PdKWnQGqipz5J6ZLPYqVNI5W5fo//uCuT4l0/PVWH3ow8hUYpxdPUGpo4ryoGzhvyhT0/sfLM4P37ss4NW5c8MJJv+Hziu5Z1BCVnykNKq/nPI8ZfecqGy5ut60yBuyhJFDAINeRvM84bp81eJbaasGksiZpu6t2Irv/jVSM0sVIX1j7XjsrKw9B6Cqhc2C1V38SoDH9eCo/3/ttX+gSJ3GQnw/ZWvfu3Q3ZKx88cntCSy9KDCL9Lkh4zgxyaEoJEkw3XmRenvAcr+V0Zr3prq87DpQLPpdyqDKhg3IKAao6qzQvXOEPx/41pJiJLShp9pxjMRtne/ttddMY02YPFxa1VouYhUTKVMWWYAAqwmGTlDelBE/mk0I4Iw4zEYANs+RJN3sePmW8LQ/TN6S7Eb6ESGG7bpve24Q+hX6QAC4pELmG9U0R6oRKHv3PCP8FjKJC98iEK2pU7cvlYK4sOrbxKoZ8lOHz70dvbykl+ffnr0+MuBqjLylNAnxxDZMfOfSoVLSSEmbIq7fMJMAm15dkZlDekXsHJ6vlBm2Vsm4qKH1xlJ7+D3BXsf7bYhv0bUaoQFAKUNx/7IZWCJqdPiatL//+KhNl1ZLytNyDpux1+hPBHLrLn2cSffcG8z4JmWFifUTgPqT8thPgqRltk6tRiFk7BIFoK1YZdmqLMj1QpecgBl2I0I6deydL0rM/s4Qqq1bbzCDi24DkMa2HqYNi8RVxnGq8OGILyBsBr1w3PoPwpVMxn+Py5 jodDT0Oo 0VnuqdEBGCZLjBdTpbKXSMmM6OQoR4y2EtgoPI8t3ZkeHx1KyRtQ3PI7pp8apW2QD+fnKzUnVcoaOn1x6rp3Hz27VBbpECzKNOujk4ZjLgZ4iJJ0TPciaKR8GOFwA54N8RTrkRLZLgZHCcnXO16ruL5YhU+nnCi/t2dC6Yaf/eKmJA1jfYzfkObmRhsrPSV4HtFkzMa4nSsdA1+GNPytc0j+pqMxsPbpoDYrvmNIVZjIfA+mS28trdLsTV5gwy9qdFJDz2LJn2mldalm2/TDRSeJQxYefr95BoPn5Y6ppkOy3qsfVJR9nwUt2EHa5gHqjIJfmLaW9PCPSdsNFwDsJdo2KUNKqiqQ+jk+7HO+cgUUjhZPC1EZ7WlsIBF6vVuBh+sC9TY9ucKyHnm88mVg9C2lRM0+tFCBqkbDRN9sSsmCqdMY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 10:58, Qun-Wei Lin wrote: > This patch addresses an issue introduced by commit 1a83a716ec233 ("mm: > krealloc: consider spare memory for __GFP_ZERO") which causes MTE > (Memory Tagging Extension) to falsely report a slab-out-of-bounds error. > > The problem occurs when zeroing out spare memory in __do_krealloc. The > original code only considered software-based KASAN and did not account > for MTE. It does not reset the KASAN tag before calling memset, leading > to a mismatch between the pointer tag and the memory tag, resulting > in a false positive. > > Example of the error: > ================================================================== > swapper/0: BUG: KASAN: slab-out-of-bounds in __memset+0x84/0x188 > swapper/0: Write at addr f4ffff8005f0fdf0 by task swapper/0/1 > swapper/0: Pointer tag: [f4], memory tag: [fe] > swapper/0: > swapper/0: CPU: 4 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12. > swapper/0: Hardware name: MT6991(ENG) (DT) > swapper/0: Call trace: > swapper/0: dump_backtrace+0xfc/0x17c > swapper/0: show_stack+0x18/0x28 > swapper/0: dump_stack_lvl+0x40/0xa0 > swapper/0: print_report+0x1b8/0x71c > swapper/0: kasan_report+0xec/0x14c > swapper/0: __do_kernel_fault+0x60/0x29c > swapper/0: do_bad_area+0x30/0xdc > swapper/0: do_tag_check_fault+0x20/0x34 > swapper/0: do_mem_abort+0x58/0x104 > swapper/0: el1_abort+0x3c/0x5c > swapper/0: el1h_64_sync_handler+0x80/0xcc > swapper/0: el1h_64_sync+0x68/0x6c > swapper/0: __memset+0x84/0x188 > swapper/0: btf_populate_kfunc_set+0x280/0x3d8 > swapper/0: __register_btf_kfunc_id_set+0x43c/0x468 > swapper/0: register_btf_kfunc_id_set+0x48/0x60 > swapper/0: register_nf_nat_bpf+0x1c/0x40 > swapper/0: nf_nat_init+0xc0/0x128 > swapper/0: do_one_initcall+0x184/0x464 > swapper/0: do_initcall_level+0xdc/0x1b0 > swapper/0: do_initcalls+0x70/0xc0 > swapper/0: do_basic_setup+0x1c/0x28 > swapper/0: kernel_init_freeable+0x144/0x1b8 > swapper/0: kernel_init+0x20/0x1a8 > swapper/0: ret_from_fork+0x10/0x20 > ================================================================== > > Fixes: 1a83a716ec233 ("mm: krealloc: consider spare memory for > __GFP_ZERO") > Signed-off-by: Qun-Wei Lin Thanks, added to slab hotfixes for 6.12 > --- > mm/slab_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 3d26c257ed8b..3445f4500b54 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1209,7 +1209,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags) > /* Zero out spare memory. */ > if (want_init_on_alloc(flags)) { > kasan_disable_current(); > - memset((void *)p + new_size, 0, ks - new_size); > + memset(kasan_reset_tag((void *)p + new_size), 0, ks - new_size); > kasan_enable_current(); > } >