From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87CEE77188 for ; Thu, 9 Jan 2025 02:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780F38D0002; Wed, 8 Jan 2025 21:33:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70D158D0001; Wed, 8 Jan 2025 21:33:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5853F8D0002; Wed, 8 Jan 2025 21:33:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 345658D0001 for ; Wed, 8 Jan 2025 21:33:15 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E637B80BF2 for ; Thu, 9 Jan 2025 02:33:14 +0000 (UTC) X-FDA: 82986341508.20.EA2CAA0 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf16.hostedemail.com (Postfix) with ESMTP id 0D9AB18000C for ; Thu, 9 Jan 2025 02:33:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736389993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AOmfsT4wXCFW0yFG2LSAy8zw3wDjLoYs/BXxMhXLkRc=; b=dmzKhKYg7UoQHZ8Mmw0y606HX+ObHxaQae3j0XOZxH7ITPpZzZMsQ2fD7910z0qQ1+x1Me i3+vbX+iwr8ExOqdaHVHdlBVC6bqgCbR3746Hjn3Ch4QH3h4Z6fJqmbbIYiLugJaIAW0uD 9gyHoPycUPZ7QktEC3E+z4SnQ2jadK0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736389993; a=rsa-sha256; cv=none; b=P1sKoNUisxq5vvSkOCmzBAMk93E+A3YKF5h1TR2Pry3n+/k4JLXsPhsFJw9ItVlhjwhYM/ OWAl/V3U6xZl4VmtYYMTJA0HesxlNdNdV0zYayPc9f7Q0YR+NZnb6IQ0d7TWApQAj56uAx aM631NYCQA9WTtfpntmLCFGRFutSv2Q= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YT7zd3TwDz2Dk2R; Thu, 9 Jan 2025 10:30:05 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id AA373140159; Thu, 9 Jan 2025 10:33:07 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 9 Jan 2025 10:33:04 +0800 Subject: Re: [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c To: Geert Uytterhoeven References: <20241228145746.2783627-1-yukaixiong@huawei.com> <20241228145746.2783627-15-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: Date: Thu, 9 Jan 2025 10:33:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml500006.china.huawei.com (7.185.36.76) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0D9AB18000C X-Rspam-User: X-Stat-Signature: 4ufe6fo7uiqk4crak8yyeqccdebx4bay X-HE-Tag: 1736389991-605901 X-HE-Meta: U2FsdGVkX1/W5BOUL0b2jlVMIQGey5kGxA1SpxspLh0RpbZYYQNmjStFEJV9jfDtHg30nUOFXe5GFFj556sXzP0rvU11kt7q1zWJhlxkpMl/rkjep2PiESRKpr8K+hTpW5l0vMoYMk7CjXcGYNDHPbSTdDHGd0+zIbgflL8SOSeR596Nx2lmMcH3bkh4pDlSs0l9jtz/mkSSj34Dexjdq6syo5QsVzR0wyhsNP7KcrZYLMxogqJTNniFrnYV/Z8GCqsDgzWGtl5WSSbnhT7vrUbaeZyM4cTGNPmdSIzY59MpfTSx+bGRkOn1n3aUjCQQmaplPi1hANYQJCJNXTVhp00zySkvhfL37Bk5LfWqaIvLw8p/rIHPRTATtWAILnLtotjMwesGm+tyBggnCuAnY8DJxXGOfDxxoaz6Rn8ukSqEZ+tE7DMrWzBsF98B122hZ71oETX9lYRlzv0tIzjyiy7tcoMtTd2RbUF0t1iVwf4fgF/YAEv54ZIn12RlVQBcu5I+wBR8jhq1nnKjEAtvX822przylLbzGWqgXtxwQaYFdCkieDlsxdGfOWYBPgWWSHB63WdvfR8wy1Yo7vuDHV2tV2+ZFvks/3Xua0g2XIv3ydhESdOFeA3K8G/Da4hJgUdUMy0NyrOgQt7Umt+VozuNVUY1eAiYgDLrepxMuj+FIpx9e7zUXUVaE5H1MjtT/l0/hl4C2Pf5mR68vUX8XDWOLpeNN+LW5jpr63HJvMnjUpKlXSFzuTjjG+VtWhfQt5/QUxuN2d/xDIN+SYDNRIAipaOpTNYDbe4aB7ZYF2mB0lqvTu2DmygiO/ycoNbeskNo+Q97v5d/q3lcQ+TtU3/p1VFp1EcnlWJd3m2CukpZ421shKaUmb1AE1Tqi3BdrZCwhApNRWdyqMgjs5bduLKDjrgONEfpI09NWMvjT317YL/8TBODuwaom7tfApQ1C3o9LN2St4Fl1X99HxD HAdEuReY O5iKqiILgUzNeqZWMh2yf/NoJg6rkJO9eOQXyxhD3iqCEXmxw+VXsbWaerOqWFixxqqnz3I3+u638We8RaxmrvrtaU8Sbp9k9KfN+hfwVodi/r/H7x8D0yXiSNUI2NHsTkABHaoaTp+9oE+McppCRto/Dl205xQgQWNVyHIa0jUOeDgvFWC7UKdZwRsag7Q/inyMuLwIjQXOI6nc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/3 19:11, Geert Uytterhoeven wrote: > Hi Kaixiong, > > On Sat, Dec 28, 2024 at 4:07 PM Kaixiong Yu wrote: >> When CONFIG_SUPERH and CONFIG_VSYSCALL are defined, >> vdso_enabled belongs to arch/sh/kernel/vsyscall/vsyscall.c. >> So, move it into its own file. After this patch is applied, >> all sysctls of vm_table would be moved. So, delete vm_table. >> >> Signed-off-by: Kaixiong Yu >> Reviewed-by: Kees Cook >> --- >> v4: >> - const qualify struct ctl_table vdso_table > Thanks for your patch! > > I gave this a try on landisk, and /proc/sys/vm/vdso_enabled > disappeared. > >> --- a/arch/sh/kernel/vsyscall/vsyscall.c >> +++ b/arch/sh/kernel/vsyscall/vsyscall.c >> @@ -55,6 +67,8 @@ int __init vsyscall_init(void) >> &vsyscall_trapa_start, >> &vsyscall_trapa_end - &vsyscall_trapa_start); >> >> + register_sysctl_init("vm", vdso_table); > "failed when register_sysctl_sz vdso_table to vm" > > Adding some debug prints shows that kzalloc() in > __register_sysctl_table() fails, presumably because it is called too > early in the boot process. > >> + >> return 0; >> } > Moving the call to register_sysctl_init() into its own fs_initcall(), > like the gmail-whitespace-damaged patch below, fixes that. > > --- a/arch/sh/kernel/vsyscall/vsyscall.c > +++ b/arch/sh/kernel/vsyscall/vsyscall.c > @@ -67,11 +67,17 @@ int __init vsyscall_init(void) > &vsyscall_trapa_start, > &vsyscall_trapa_end - &vsyscall_trapa_start); > > - register_sysctl_init("vm", vdso_table); > + return 0; > +} > > +static int __init vm_sysctl_init(void) > +{ > + register_sysctl_init("vm", vdso_table); > return 0; > } > > +fs_initcall(vm_sysctl_init); > + > /* Setup a VMA at program startup for the vsyscall page */ > int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) > { > > Gr{oetje,eeting}s, > > Geert Thank you so much for your test and fix patch ! I will fix it in patches series v5. Best ...