From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88376C54788 for ; Wed, 21 Feb 2024 22:19:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 211FD6B0082; Wed, 21 Feb 2024 17:19:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19AC36B0083; Wed, 21 Feb 2024 17:19:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 013EE6B0085; Wed, 21 Feb 2024 17:19:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E280C6B0082 for ; Wed, 21 Feb 2024 17:19:49 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A91A5C0BEA for ; Wed, 21 Feb 2024 22:19:49 +0000 (UTC) X-FDA: 81817229298.26.C978EEA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id 571FC40016 for ; Wed, 21 Feb 2024 22:19:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNAIyQ+a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylT2uZtA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNAIyQ+a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylT2uZtA; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708553987; a=rsa-sha256; cv=none; b=XgO03emswLqZbuDQsXSzalgbW2VarE/Hu9Ov+jq84gxptRyPSrxC/sh+EQP9aT8cPN+pwz rEucNnC0KqhslXMmjbQ1uyTKXktXicU1Zw1cDBZcl1rDYM9CNnYhu+5cjhiXd181E6d/YW jQZkOr8HxUnUo+yAIEytGBoKHJ6+yMA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNAIyQ+a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylT2uZtA; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNAIyQ+a; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylT2uZtA; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708553987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxL/y8ewJsj/ttUnxwt5FKrTF34RqTIXa5SPkRu66jo=; b=69ggGhRr/4jXyvfWr3N4Ko2fUsNthG3gGqc6YNWG60oWP7+8Idp8210kCAorfZ9iD6i/xT Ru2V+gVgySktHBb//1QAns3ms4cHKi0H3hzRYLqv21jOTJcqJpkI8NObi9hgyf8+w8sZSB OB8PraZCHc+JItEnTMSP1Hw4RMUbGKk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B314F22264; Wed, 21 Feb 2024 22:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708553983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxL/y8ewJsj/ttUnxwt5FKrTF34RqTIXa5SPkRu66jo=; b=HNAIyQ+ahHkAIn6rhh4PTHj7GaX8akTDyFZj5HSpNlFr9CBIbh5mYFjhMG1R+ub6boLNec d9UNHYsKgCvb7cVooS57qb/MuNto8z+8MkbRp/2MAoF5pLpchxA/hrNNc6QTAd3v602sNz iWLBLPoV8UYXEVlzPezpD9JcO+eRJnA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708553983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxL/y8ewJsj/ttUnxwt5FKrTF34RqTIXa5SPkRu66jo=; b=ylT2uZtA6ijAAl4YOMxqD0T/sDVxsbh94+eVefkNKCDlOMG8qRhRJMpP1QWeRQ6vTRlOT6 MKoIMLVDL09WjqCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708553983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxL/y8ewJsj/ttUnxwt5FKrTF34RqTIXa5SPkRu66jo=; b=HNAIyQ+ahHkAIn6rhh4PTHj7GaX8akTDyFZj5HSpNlFr9CBIbh5mYFjhMG1R+ub6boLNec d9UNHYsKgCvb7cVooS57qb/MuNto8z+8MkbRp/2MAoF5pLpchxA/hrNNc6QTAd3v602sNz iWLBLPoV8UYXEVlzPezpD9JcO+eRJnA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708553983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxL/y8ewJsj/ttUnxwt5FKrTF34RqTIXa5SPkRu66jo=; b=ylT2uZtA6ijAAl4YOMxqD0T/sDVxsbh94+eVefkNKCDlOMG8qRhRJMpP1QWeRQ6vTRlOT6 MKoIMLVDL09WjqCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8AE6413A69; Wed, 21 Feb 2024 22:19:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vOGYIf921mUObgAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 22:19:43 +0000 Message-ID: Date: Wed, 21 Feb 2024 23:19:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm, slab: use an enum to define SLAB_ cache creation flags Content-Language: en-US To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Cc: Zheng Yejian , Xiongwei Song , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com References: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> <20240220-slab-cleanup-flags-v1-2-e657e373944a@suse.cz> From: Vlastimil Babka In-Reply-To: <20240220-slab-cleanup-flags-v1-2-e657e373944a@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 571FC40016 X-Stat-Signature: y5r3syuy9tzusiphza4j5xe3ifm8augf X-HE-Tag: 1708553987-423588 X-HE-Meta: U2FsdGVkX1+N6hmj+xUG3xjL25xLE5UWH4LPpjarJnhyLWD8pTYSeRPV00KLEwp6ooqMslZukNYiDpUhgwf4x8IW+ee9QqUsWhASBiKapnZuI/pdritZdAr+CHcvqADPXIHQqzE9qtFNTYnyAe4ZwwzUVDRi0b6QIQ088qZ0YqGof3stpAl9N6KQPZxiJ4EDzdA7RdAU4HPVrW9W5nTyozX1j7Itet/tvv9YOvQSHcXPZo4Vxz9m6vjvN9ZTWkItAJ7hLpisn8wR8M8Kie+gAhQ8MG9nY9f+Bd7oV0RC8t/nWncpz/cTkkf0nyQg0429Hi0oBCwE2Ivv6TA927J63ri4dC5lnjYtTG3vuk28YCdiNJK0eELsSfd8NsRHuLvAFDMft5ZLdxZb/uGwPYECBJBOV9PC4dwvHrE2HGd3r0IZ9fFy4Z6D0JvEGKNops33xUL4KJcNPG1dBlAS5XKZHXCGWjbmwh/6MVOoXhmquLgzv+M4gCh4TC88KWLVfk51GYmUYS479iEhLfiJTiz7CjYw42B4oEo2B6pPpgjGw5AleOdRViCFsMGbHMp4GdnK+SwZ0KcEokOQbMe1Y5yZqkUvOm5vLYneEQlFG86y0AKshfy1UlsjY+jQNI30enrBzl1f3WujshR7NmjDIpJAKldayMxnuPsLTqkKDxygWwJUyXJ43k0Rnm+JZ8wk+dFleew3//bMH9FyClfLXhIf71AJ5RLk/kZvGLNIwQ1vlXQ1JShrzvZ07+Nr3S69gXQrbnxECm6ZAdiM5OHfX7v8tkmgqjlmZqMUafPa0Z/tsO+/tGCuWeBFkehtBJUxx1MUThPc65XnEsIr38AV/MMTiyCKY+GGPER94ZVig+/lsJTjA1lCJmohmqjZhUFJFTbH6fYmccjFrA/lrTLnbgp53n5sf+kLDFfI3fzhrHdXmklhoMWXgHd2dhdcRG7+m7Wt2lMpKU+cG6xXIz/P/FL BxTCoizj Sp/gATHYF+ldl8RIcfKdEy0pjtq9DETcbdIWHaNWfc3v4wA+0JL5JTn+0p9dm2WQL4hDhBp1i+XQcZXhmZXZYT1kB7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/20/24 17:58, Vlastimil Babka wrote: > @@ -156,9 +195,9 @@ > /* The following flags affect the page allocator grouping pages by mobility */ > /* Objects are reclaimable */ > #ifndef CONFIG_SLUB_TINY > -#define SLAB_RECLAIM_ACCOUNT ((slab_flags_t __force)0x00020000U) > +#define SLAB_RECLAIM_ACCOUNT __SF_BIT(_SLAB_RECLAIM_ACCOUNT) > #else > -#define SLAB_RECLAIM_ACCOUNT ((slab_flags_t __force)0) > +#define SLAB_RECLAIM_ACCOUNT 0 lkp/sparse tells me this was the wrong way to unify all noop-due-to-config flags [1,2] so in v2 I'll unify all those to ((slab_flags_t __force)0U) also the deprecated SLAB_MEM_SPREAD in patch 1 [1] https://lore.kernel.org/all/202402212310.KPtSDrRy-lkp@intel.com/ [2] https://lore.kernel.org/all/202402211803.Lmf1ANXx-lkp@intel.com/ > #endif > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */