From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40405C7EE22 for ; Thu, 18 May 2023 12:46:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A4A0900004; Thu, 18 May 2023 08:46:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62C59900003; Thu, 18 May 2023 08:46:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F370900004; Thu, 18 May 2023 08:46:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A307900003 for ; Thu, 18 May 2023 08:46:52 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D80EE1C6BA5 for ; Thu, 18 May 2023 12:46:51 +0000 (UTC) X-FDA: 80803350222.03.C9AB83E Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 0B5BC140014 for ; Thu, 18 May 2023 12:46:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Arxzreo1; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf26.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684414009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7B0Wi+x/9/t51/d3MOElUht9OWrjqjL8o0y56mjT0L0=; b=Xrin4FxoFvTrs13V0/bnux9ix4fUckgEVEG8Wu72kYRlLMZ+eYD4Zo2T0U9Ghcot34p63W kGl4S+Nv2u9jUZbo+aLKDgUyeyX61xfOtdprqDyQ8rEEO046fyTLG7usrNMErl+RJ0gZaq dnw+iglE7/M8ah9GzcP7a1f84LWQnck= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Arxzreo1; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf26.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684414009; a=rsa-sha256; cv=none; b=FjIeuWmIha+h5jiIeFcwXlHpqRH7xVc+nPudT4iFbcxQ+d9dpFYuJWN6S0xKADPmOGMq/Y 5v/a4k6ifLx9CeLBV5jHWxwOYgeZT1ib4711ayCnnMEr+u5DpGqwtN3YSyjQpRrE4LwpVR 9dPwncPm7lhK2uf9XFbKI9U/SEuuzCI= Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34ICQfbU021905; Thu, 18 May 2023 12:46:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=7B0Wi+x/9/t51/d3MOElUht9OWrjqjL8o0y56mjT0L0=; b=Arxzreo1KltSETP2xl7mXtDAkKYiGSErf3XT3A273itHeqtD7dnBb6jOiGoYbkmZ+hkJ lpqhD8507QmLPPR2F+fplB9mMxW596Q67dh5Wd5nP2BRADHhsUQf7wYtNFLO1P4+EERt wVGutobO95mpVmFd4x0hQd+KhC9H63ce9pMi2DH4voK1OSeBm3cAshNI/Q0KHXrnzcEF 4S0xwYb/oKbgpgVXjRlqBh+c5ZcCMPVzbTbeYNSBq/MpojCWx+UpVgjNk6AZ0A+XgIy1 hY3iCDKD9J1v+XOZ6MJQORTefzg5hc37mC0Vgtbhp1XqO4XkF+NmVYMWytRQzwctozIw Dg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qn8d2hapa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 12:46:40 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34ICkdXF024419 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 12:46:39 GMT Received: from [10.216.38.166] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Thu, 18 May 2023 05:46:29 -0700 Message-ID: Date: Thu, 18 May 2023 18:16:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V7 2/2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Content-Language: en-US To: Hugh Dickins CC: , , , , , , , , , References: <631e42b6dffdcc4b4b24f5be715c37f78bf903db.1676378702.git.quic_charante@quicinc.com> <2d56e1dd-68b5-c99e-522f-f8dadf6ad69e@google.com> From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: wfrWaWblBL9eRR0HJ4EnJFi6l0XjIFcE X-Proofpoint-GUID: wfrWaWblBL9eRR0HJ4EnJFi6l0XjIFcE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_09,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 mlxlogscore=551 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305180101 X-Stat-Signature: 9rwriii6sqjsyp54ce59aswgeuuhdyow X-Rspam-User: X-Rspamd-Queue-Id: 0B5BC140014 X-Rspamd-Server: rspam07 X-HE-Tag: 1684414008-588978 X-HE-Meta: U2FsdGVkX19CqCd2w1a4FGbE1Jw7AQaYJ7EnaWodjhgPtbsFt9IWt8WTJt4DCdotn6DE6b6mpmRd02+4Qdtmw46Ap+qXgJJR40sbDDm0VnXdISCPrx96zEdQhQXeVpQvOQW62azos5gERnYUZjD1kzqXyidIYmHZ2Ih/p1bbVU2dQKU4t4+WC1lYfi3iQHD4zPB0P46rkuOXGztibv/dsVpynJCbr7nOqd49zNzKMEk/AisqthljzZULDpjTAcaghKj/kSoK/q/BUJXDxwn8nRjYzdWNdZCvaxEBjY/hf9W+rWV5PQs2E+HQCs9DBY6u1YS+lmABmMIIUvFwLDeE5845bAK36DTYmKMMPdHe4pjLt2KwEJk0KydN1JHFdtpE81h31DLLwahLAaste9A7JQpYuhfzmSx4rJwMbswvrPZoY/KMiZ9L394/vcp1lGUMBQRIsYFpNy7a4md7X52yvz750CLMIO+ufCuKRTl8h8GAFfkrAxY8XI6RnmfJPObS0cvaefZg/hSu/dFA2PAGtpUfXhppMyTl696GjA11s0xG9NycZJh0SwiCR+zhKimWl1fdfUk26q/L2f4/nDU7zP+bhh87/Jc3hGUtZO769cSTRywTBpU4A84i1LBQLhd0GwJ3QJXCfeEW34eOmaYZdqzSQoLUSFS36l9ImjgjBiy2gwoDZ4Cv3Rn6zLXymZhfefSgMaJ6L0lhpUb8Duk/UX7Yglq+cAf6nGYA6ah+uZwFcX/N5dAOkoE/fbRmVsw5A4WXX8wT0+k8fH1ICjw98e3gpUS6jbRCXL8lUiKi3PXQU6QTOcsrFwLYOoIyhegzriI4Nr7XCEeOvG27lDWTrUbapUdwTLkwCGtG9Pdx6DRqPptSCPeN6OrTQxK268vECp0p6EqZfgJ4jznxnFh/BHtwyGEH6KshSAe/1yU1Ra2jzbOZ3EmNfeXaCiyYINQbGTcvXT12fQsvite87rQ D77ZW0rs JUywjmEESRXkTB3+8pzXMh/mY/1XviKzwYWFnmvVcTq4hU7Jjtx+z7l3EVKkZgWpQiiJBAK3eBoNZCqLoX4q0PXVDIDdgMiJmZkZfScst1JNnFwS0+9o2kmT8Ht7o8h/xW0cqAr4KY7E9SH0K7swSYKbQz+KcXKD9oj4s/DLfZtVEW0LmkPEtUHrpxSTAtXjgIMctbRGpG4zxfekGE5j+aQNT6L6USw1f0001izcbxWLa0Ga2QLCjy7YN3Fbb2jxDPOrC X-Bogosity: Ham, tests=bogofilter, spamicity=0.366395, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hugh, Thanks for the time and comments on this patch. On 5/17/2023 5:02 PM, Hugh Dickins wrote: >> Sure, will include those range calculations for shmem pages too. > Oh, I forgot this issue, you would have liked me to look at V8 by now, > to see whether I agree with your resolution there. Sorry, no, I've > not been able to divert my concentration to it yet. > > And it's quite likely that I shall disagree, because I've a history of > disagreeing even with myself on such range widening/narrowing issues - > reconciling conflicting precedents is difficult :( > If you can at least help by commenting which part of the patch you disagree with, I can try hard to convince you there:) . >> Please let me know if I'm missing something where I should be counting >> these as NR_ISOLATED. > Please grep for NR_ISOLATED, to see where and how they get manipulated > already, and follow the existing examples. The case that sticks in my > mind is in mm/mempolicy.c, where the migrate_pages() syscall can build > up a gigantic quantity of transiently isolated pages: your syscall can > do the same, so should account for itself in the same way. I had a V8 posted without this into accounting. Let me make the changes to account for the NR_ISOLATED too. > > I'm not claiming that mm/vmscan.c's too_many_isolated(), and the way it > gets used by shrink_inactive_list(), is perfect: not at all. But please > follow existing convention. > > Sorry, that's all for now.