From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC1CC282DE for ; Mon, 10 Mar 2025 18:15:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9B71280026; Mon, 10 Mar 2025 14:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4B3C280005; Mon, 10 Mar 2025 14:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14BB280026; Mon, 10 Mar 2025 14:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 840F2280005 for ; Mon, 10 Mar 2025 14:15:46 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8FE411CB79D for ; Mon, 10 Mar 2025 18:15:46 +0000 (UTC) X-FDA: 83206444692.19.9D99A71 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 3D8631A0025 for ; Mon, 10 Mar 2025 18:15:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741630544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TxMeKvPoRCyjTW/b4t2Xdz35M4pbUU2UZghMfkdNAPU=; b=BQbE69TLVXgOfa7LNx20uq7aABIWazGEJE7bse3s5QemB07G5R93rRJBbKLJpDSu/dIoZp FtfTRomgiJ7Oj4BhNC1Tn8G2doa5frpFjJ8G21kzYCs4SunvuOjg1icj6yEjvwdgdooL8V G9tFjI8UmJZMyMckrkiTkePU2JVqPe0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741630544; a=rsa-sha256; cv=none; b=6y/5+a29PNM/zWpDCmj9P9DCJXBE1MWY5V7MUNmoZd8hCcJDq2FhA3gOpKyHD7GJIXnKPR jNS53VYuwv2xIICY7nwGpvzyOok/Gv2DxGKOG65CjFe+MrlYYV4xBCc5MsERQozH5vN/BX lW1O4WVqr2GArOkjYaQpqMvgTXYeY6Q= Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZBQ4532s9z6K94c; Tue, 11 Mar 2025 02:13:09 +0800 (CST) Received: from frapeml100007.china.huawei.com (unknown [7.182.85.133]) by mail.maildlp.com (Postfix) with ESMTPS id A0AF914011F; Tue, 11 Mar 2025 02:15:39 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100007.china.huawei.com (7.182.85.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 10 Mar 2025 19:15:39 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Mon, 10 Mar 2025 19:15:39 +0100 From: Shiju Jose To: Alison Schofield CC: "linux-cxl@vger.kernel.org" , "dan.j.williams@intel.com" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH 1/8] cxl: Add helper function to retrieve a feature entry Thread-Topic: [PATCH 1/8] cxl: Add helper function to retrieve a feature entry Thread-Index: AQHbiWhwo9sEMJAQkEWXFE66V5STnbNoCC6AgASyHwA= Date: Mon, 10 Mar 2025 18:15:38 +0000 Message-ID: References: <20250227223816.2036-1-shiju.jose@huawei.com> <20250227223816.2036-2-shiju.jose@huawei.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.147.62] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Stat-Signature: bwhb3j9t3kure6au3mohd9nb7btnez37 X-Rspam-User: X-Rspamd-Queue-Id: 3D8631A0025 X-Rspamd-Server: rspam01 X-HE-Tag: 1741630542-722510 X-HE-Meta: U2FsdGVkX1/tQ2D1qS3qRx/sc7I0TmVBeMOLfYJbGRB98lHe0eR6XR5ap9rUwKXujWAFe7BqGbAsQawZx41aS+qV5R65GnSQ0QqZ4NMHNdApcwcGlG8703u00Fpc5UVGstbhk2J3t/ojqNWbCW4i/osEOR32rh7z31Twyzakf8HbsdiHbCRE5WuZILKyKp45Ox4q1mEkPoSRyOM6FFgEwir4by1o+G2GYGiMg9HUnJxqBbJaarC05VOwsR4VVraR+wzag9MhV+OqcYtFb2QCNFcWl3lsl4MFWihlYfprX/p8BxBifD4eJ+PtkF4+csPuJvsHp/o1/OLwKvLEkhMVzqXOVr9E85TMB+hQ6ZqUiAe1TlKvM+xUd60UVjx7+SpBEk2FG4czkj8dz6zL/H5zkdAyM1oRp2HowPnZFK7vG6iY6uz+wFnXeoUzPzA4diClJymPkoMFo/Q3l68mRT8McHRVVPXSSnNnJ6omEXFIqCa9poNrEqK/dKgKxwaFVgbSL5qGsWjOHNgTzWWau8ShzQTocbgbnxs4S94hPXJ5/Mb2lybz6bmR99bS0Lbyvh3f/HvQYignABtl0mRZ+xO2G7uFfDHZXm9zkUgwIu1wU+wGmbDKos158WXNKyJYQZ/c8WrcwDRnqJE49XT9JbZB2GlPn7HCRB23mBVrYsrqO7LLm+Mxu7ejgKc/Q9Gjxc2AkVl7f2TiVM7zQvyIrLPHmj+QvIcdgip7OYWKgjyQQeaIFMCxah2auiG0I3xrC6WBlz3sA6gA+vpwK2CtpyH6wJWpGpFWLtAl8TydT4ncWc41ntLJP1XfYXqkRc+M5sYg2MH3i93nj7fA0FI+fyvH5m1Bd6tOFOE3SXbalWDYsInBtnliHwm0hB05FEhIO470J5peSWhztslzFlnn3JXmsb2t1EGDY2nfeYeecmqql7WJIw2xEWbbBWVju6z2xPQV//qLpLesvMQ/HZS1sbX J5DB6jIw V9PaO08g1THR2efhOupbq0AkEZgEbaafGqdyHgu8b5RL9GxBFdXdirYPAZh66171NGJoVAWzz4ff5pWKDsK34JLMKl/4z+33KlKM/FwvYK7pLUUTBO8XM96D3nApDX5XmRefNABKPt7GMYNTYeWe+aqgg/Idzbe1j4RfhKz2TI1oBv/Ma1ogoeB9K04ltTqERzS/J2+XeIUT0WePqutY6K23i7DWBQ7wod0Bb1oIVMIrn4moGQac0kqDxYoY+9YMIazngLQf1p/SAPHeYQZ93heQcbkBZs1YF2lYCwBu0kA/if64mN7QEKhxtjTcR3YAT7vf2YDMMrspvGnMt0cFX9oj7pmc9fll4LFYuo81wG828/k/dDJapCzxmSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Alison Schofield >Sent: 07 March 2025 19:20 >To: Shiju Jose [...] >> +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxld= s, >> + const uuid_t *feat_uuid) >> +{ >> + struct cxl_features_state *cxlfs =3D to_cxlfs(cxlds); >> + struct cxl_feat_entry *feat_entry; >> + int count; >> + >> + /* >> + * Retrieve the feature entry from the supported features list, >> + * if the feature is supported. >> + */ >> + feat_entry =3D cxlfs->entries->ent; > >Do we need some NULL checking here on cxlfs, entries Hi Alison, Thanks for the feedbacks. We had check on cxlfs before https://lore.kernel.org/all/20250122235159.2716036-5-dave.jiang@intel.com/ but removed because of the following comment. https://lore.kernel.org/all/20250124150150.GZ5556@nvidia.com/ > > >> + for (count =3D 0; count < cxlfs->entries->num_features; count++, >> +feat_entry++) { > >Was num_features previously validated? Not in the caller. Had check for num_features here before in cxl_get_featur= e_entry() as seen in the above link. > >> + if (uuid_equal(&feat_entry->uuid, feat_uuid)) >> + return feat_entry; >> + } >> + >> + return ERR_PTR(-ENOENT); > >Why not just return NULL? Will do. > > >> +} >> + >> size_t cxl_get_feature(struct cxl_mailbox *cxl_mbox, const uuid_t *feat= _uuid, >> enum cxl_get_feat_selection selection, >> void *feat_out, size_t feat_out_size, u16 offset, >> -- >> 2.43.0 >> Thanks, Shiju