From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C45E748E7 for ; Sat, 30 Sep 2023 19:48:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60A188D000D; Sat, 30 Sep 2023 15:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5930C8D0003; Sat, 30 Sep 2023 15:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A378D000D; Sat, 30 Sep 2023 15:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 336B98D0003 for ; Sat, 30 Sep 2023 15:48:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F2E1A1201C9 for ; Sat, 30 Sep 2023 19:48:53 +0000 (UTC) X-FDA: 81294301746.04.6631B68 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf28.hostedemail.com (Postfix) with ESMTP id DDE99C0010 for ; Sat, 30 Sep 2023 19:48:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696103332; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcC6SwP7qdjXAFoG4jG3259BarDGBxj8D5al63ydxNs=; b=Mb8RdoQ6+zLsoiTcxT0TY7+jPPdIsS9FlwS8XgQVKf9aP9aYcyTESo/cHpG1IyPnesUP2Z CEa6oBEmqQgH3AXy2w3n8JyqIG1rSYYkTv2BgV2a8/Q42wdGD5ZTE5jXBgdiWb+nsTOWg3 E48cXD7ogTwtH6d1oh7txeQAwljWHNg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696103332; a=rsa-sha256; cv=none; b=dFierE8Tc6vQilSDvHm1NSwMuiRzNWHks7D5/Oyi2hYAYx7TddsFrxmvdmrUrZQrCc/Kpm CDbwLnIIFfs1f6zwm6bWT5VflgqyNeuRzuFlADufyhNKRn2DwBSt1gLOCKOgiD3ggurIJH ST/aKMVU8SGkJ/bngXzlwXiI4PqkshM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qmfwq-0005GD-2p; Sat, 30 Sep 2023 15:48:20 -0400 Message-ID: Subject: Re: [PATCH 1/3] hugetlbfs: extend hugetlb_vma_lock to private VMAs From: Rik van Riel To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com, willy@infradead.org Date: Sat, 30 Sep 2023 15:48:20 -0400 In-Reply-To: <20230930022842.GA82828@monkey> References: <20230926031245.795759-1-riel@surriel.com> <20230926031245.795759-2-riel@surriel.com> <20230930022842.GA82828@monkey> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspamd-Queue-Id: DDE99C0010 X-Rspam-User: X-Stat-Signature: 9biwh5qbz7df6f95p3bqyxampzr88ewb X-Rspamd-Server: rspam03 X-HE-Tag: 1696103330-366739 X-HE-Meta: U2FsdGVkX18DABu0DlFReLRiAH9YVZg7CzsiYbkeMlTxKVGK2iVhAj+gmGhOxTRMf1abUq0d1bVdYi+KDIfCGrbY5XfXkgLf3Dr8tJbZ8sF4hc6S/+3tqoNPgCIoofwkZjbY5HLOGcsOtazaxnTIHNMSFygDtzINflFzgnVcJqJGhrersQdX4y/eqRI2s57w3O5AclAMp2pgaBIq+L0g/mNFx7BdcALY/S8iqwM0GzBRyXb98mQGIXG7Ztjoue4NqLMww1CBXlqrBsBkgt0JgzMJV6+Be7hLhXIH8w3l1TkRywE1PYozdepidpO73bPs6wHkLHXg2TaU5m6rr04I++y8ifEIUqwldvxe4mvx7LHV3aLq6SbPtQefFfcXHu/bQYrNtuAChVOlVq2XQXwslHpwHMTuTTAn2f2IHFZTxMMMyVbWDNiNRKifQ2uFbKdy3HVG0BYzw/PADlY6rSMo2rsCBpL3X53QS0d5FlEGFTTMQdkmmxN35jvvBX4OxVAI41e+6DyTYTBQzepRrCuRdIrZPFmEFgjBWJx+wvo0meXOUg0dCxaoDgvobu4PzHLec4pzhDRCiU3hJyez/oCx8YnyRPYc6UO7hjF7fDxjpKjgKYMLtEFT9SpO/VEDNMU9TtQxpCImtAHqP058Gs1NPKz9muCP3oQpoSWcsXLtHx3zxZjy8E0G1aKcICiWWoZYqM43tOxuR86TyS6EZMc6nvZRyWMj8NbBrNlSQjt2XpaS9qiVt8cGqswU/P3ZRTP22dOvEm5wI0jYYjzrhqvgPDojh1Rg4PWAjDqtXbHT452mdYsh01s3U8OB6pr2oSebIFMM56b6jNpXXnv6/t9gaIprUkqO999MzgWPQPvLPrQ7AaxSoH60lHU3cLjjC+6161pEgW9qtCbuRSLgRPusMLC1eGK06O7uewORHd6GoEA2bq9OyOp2NYkige8pyYXGLU9ot51nfw9CvnSYq15 GOB9fLog GbsaI7XGb/guYfyS9+Ph9Egy54XuDIbl91EOTcdOi4vIrwUPGCgE1WGdYqobruaQ5wiYH101243o7f94sFz0mBcBhQUJCpiUjMUDlb+7S6Sn20XDFVJ6zwqtRnW/In2ztfoJfsdi4RiNe+jIX0GbMzq2nFHl7AI/cTcJSuiED4azBT9khkftPTfJ+AE7NYhiLHtXbvLzmLj3F97hchsGtZMFbiMXpF3L16l/I8UIy8IWtzBMslgI5lrtJ7aWSooQQQaFUKGKF1flDgma9comTvNbx+sVPQaeQT+IH4qSoQgsJtU/z543XZcyKe6O9J+g9KpDASCyblaIfrjMbaNJC4BZNxMEzY3dUxHRl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-09-29 at 19:28 -0700, Mike Kravetz wrote: > On 09/25/23 23:10, riel@surriel.com=C2=A0wrote: >=20 >=20 > In reply to patch 1, I suggested the changes: >=20 > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index f906c5fa4d09..8f3d5895fffc 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -372,6 +372,11 @@ static void > > __hugetlb_vma_unlock_write_free(struct vm_area_struct *vma) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0struct hugetlb_vma_lock *vma_lock =3D vma- > > >vm_private_data; > > =C2=A0 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0__hugetlb_vma_unlock_write_put(vma_lock); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} else if (__vma_private_loc= k(vma)) { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0struct resv_map *resv_map =3D vma_resv_map(vma); > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0/* no free for anon vmas, but still need to unlock > > */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0up_write(&resv_map->rw_sema); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > =C2=A0} >=20 > However, the check for 'if (__vma_private_lock(vma))' was dropped. Oh ugh. I definitely added that in somewhere, but must have committed that to the wrong git branch :( Let me send out a new version with that change. Sorry about that. --=20 All Rights Reversed.