From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C8CD2B92E for ; Tue, 5 Nov 2024 13:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79FAE6B0098; Tue, 5 Nov 2024 08:55:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 728786B009A; Tue, 5 Nov 2024 08:55:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C9276B009B; Tue, 5 Nov 2024 08:55:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3E7716B0098 for ; Tue, 5 Nov 2024 08:55:08 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AFB251213FC for ; Tue, 5 Nov 2024 13:55:07 +0000 (UTC) X-FDA: 82752186930.12.F58CDCF Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by imf17.hostedemail.com (Postfix) with ESMTP id 382D340018 for ; Tue, 5 Nov 2024 13:54:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.196 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730814738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rrdb5XyLg7NsqMJ99KX/uWDwOQC+nCMkJMaoujk6gls=; b=vXMzXrcFZpVMSkk7eeHi8g8N/Yl3cA4j1guWetS8Rm1vIq6dKhoG3Tggj2Km9TtYQubDtQ he+oIG0M/WCKFNGdHXMHAWOpMN7glXAxuUiGQOmMIzc2YEr0X5REM1cy7qWPFhrymxEML9 4DpFg82/Z6DOIXYc9InKv7Ql3qTfmpM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.196 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730814738; a=rsa-sha256; cv=none; b=2G1A8I4GDfAC5bIbNkv89QXGBf/ljyIG5VaEzOu11UBILn7dzVAaVG8WPBpvpFXk690kZK 3knWOM3h6sPWiJivh/3V2ss/3qezTo+W+7U+L7MiqykmJBpJCvKFzPUq2Jp5RpHerhsc0I bvif7fvlFkS4H3w76H9PInHA0NKvoBk= Received: by mail.gandi.net (Postfix) with ESMTPSA id DFB34E0003; Tue, 5 Nov 2024 13:55:01 +0000 (UTC) Message-ID: Date: Tue, 5 Nov 2024 14:55:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/9] riscv: Align the sv39 linear map to 16 GiB Content-Language: en-US To: Samuel Holland , Palmer Dabbelt , linux-riscv@lists.infradead.org, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com Cc: llvm@lists.linux.dev, Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti , Will Deacon , Evgenii Stepanov , Andrew Morton , linux-arm-kernel@lists.infradead.org References: <20241022015913.3524425-1-samuel.holland@sifive.com> <20241022015913.3524425-8-samuel.holland@sifive.com> From: Alexandre Ghiti In-Reply-To: <20241022015913.3524425-8-samuel.holland@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 382D340018 X-Stat-Signature: 5f4ipwtd6cokmn91njjcb6wmhj4doh8m X-Rspam-User: X-HE-Tag: 1730814879-164365 X-HE-Meta: U2FsdGVkX19NszL6393lNwzIFbFWkIKwGgicDJ3Eapj5oFimjZjBTqY72Pt3jbBIVtJOKhWAvIzGBX+IpU+26tWdBMFpQAxD7/Uda1taPM1s/Nodue/Tp25V8WHejm2XK6k+ass90sqOuHGXjo2uTllujHZgd8eIPxAi3BfziPhJvoAJLeOPDX9/BD3/uxp6UVtpiJt9CgN+L3xDE1/0du19n66lDiGpimfpSh1g+PiXkPOZqHEEYqHhS6IFSwG19fZ+9L1jgslJELL4D5Dci0tllI8mzXvmjaxwy9pU/Byr2LRjKaGGQy0r4yXuMRB64QcgiCbCfh4w6DR5DvDlcyJny3U0lgJfuJgro4pirMJ/hcGv1QBrdju8lvhFdP4IZBNVVbvuSP7V3XcbQJzRF5cWUye+f6qjWnWSl4EcMtOiP8Taq1OaRwCTr/z+8htpR31azTPkFkk7aWjZ8mbRMkE+hgBtk/lUSN8quQ0DMRzS+6PIRdrM7dKvXJW5HUkw3E1awRKP72jlXyWmcGpDagp7RSkMxXflGDA9w1n2BSeQb8+rb78+1CdRJgvH8yViwD0AOdxm7ioKCpgaT9KJn1bx5zq7FR08oTPkAblQ+mbTYc4krdS9d4VdGyijXDqmOXIi5TIAVip7DiMk9ftQ1pfcdMVbMOhQYeC4ELzgmsQKehSVDRacpjQH7i8XtmL6YPq0GMM6XsG78ItXF+11Ggzi0r/kLYuGKde82uSgmmIQ2mDKaNteoj8c+Jb+8nZV/VfBrmvOBQy1q18ukeGuPjcHqwaLZMiCD+JqO79GnwkZLqKy1PLes2VBOmXJG0R7U2q1HyWoptPgtyl0XpWOmGd9g9SMwDdak6e7NjEn1bZckkEcNcyKY4r/JAYaHlXT1ajx55al5UUHso3fcgl4SIgHVWBcaB1JJWxlnzFDEwvL91gcM8qsgv4+vxdIbmaC5BiRUbTWsXfX8ol92Jr eJKeb32O sqPzaF0XnQ+nI8Hq0cWOsiw5ViC3/twPR3UCzPFPQm9lHzeXSIVePdkPvxrjPw32PSkySs7UyHqRAxM2MjTXzaas4qCvrTODQH/7xkiCP6SkuerIMI90xFqkOIUBDqpXbWW3FSjLJNzi54K0SHEsbKXchd5XOQNySyoJgoxs6XXoBZmBbwINSOjhFEIs/vF915B/GAbXE09u9n+NLh0WDXam5DW1+p5wQ5o4zrHPy9WFGbF87f4+FZN/SvAJsaMolYwlZYFQNnhBDhjs5YB9nc9IFUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/10/2024 03:57, Samuel Holland wrote: > The KASAN implementation on RISC-V requires the shadow memory for the > vmemmap and linear map regions to be aligned to a PMD boundary (1 GiB). PUD boundary > For KASAN_GENERIC (KASAN_SHADOW_SCALE_SHIFT == 3), this enforces 8 GiB > alignment for the memory regions themselves. KASAN_SW_TAGS uses 16-byte > granules (KASAN_SHADOW_SCALE_SHIFT == 4), so now the memory regions must > be aligned to a 16 GiB boundary. > > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > Documentation/arch/riscv/vm-layout.rst | 10 +++++----- > arch/riscv/include/asm/page.h | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/arch/riscv/vm-layout.rst b/Documentation/arch/riscv/vm-layout.rst > index eabec99b5852..c0778c421b34 100644 > --- a/Documentation/arch/riscv/vm-layout.rst > +++ b/Documentation/arch/riscv/vm-layout.rst > @@ -47,11 +47,11 @@ RISC-V Linux Kernel SV39 > | Kernel-space virtual memory, shared between all processes: > ____________________________________________________________|___________________________________________________________ > | | | | > - ffffffc4fea00000 | -236 GB | ffffffc4feffffff | 6 MB | fixmap > - ffffffc4ff000000 | -236 GB | ffffffc4ffffffff | 16 MB | PCI io > - ffffffc500000000 | -236 GB | ffffffc5ffffffff | 4 GB | vmemmap > - ffffffc600000000 | -232 GB | ffffffd5ffffffff | 64 GB | vmalloc/ioremap space > - ffffffd600000000 | -168 GB | fffffff5ffffffff | 128 GB | direct mapping of all physical memory > + ffffffc2fea00000 | -244 GB | ffffffc2feffffff | 6 MB | fixmap > + ffffffc2ff000000 | -244 GB | ffffffc2ffffffff | 16 MB | PCI io > + ffffffc300000000 | -244 GB | ffffffc3ffffffff | 4 GB | vmemmap > + ffffffc400000000 | -240 GB | ffffffd3ffffffff | 64 GB | vmalloc/ioremap space > + ffffffd400000000 | -176 GB | fffffff3ffffffff | 128 GB | direct mapping of all physical memory > | | | | > fffffff700000000 | -36 GB | fffffffeffffffff | 32 GB | kasan > __________________|____________|__________________|_________|____________________________________________________________ > diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h > index 32d308a3355f..6e2f79cf77c5 100644 > --- a/arch/riscv/include/asm/page.h > +++ b/arch/riscv/include/asm/page.h > @@ -37,7 +37,7 @@ > * define the PAGE_OFFSET value for SV48 and SV39. > */ > #define PAGE_OFFSET_L4 _AC(0xffffaf8000000000, UL) > -#define PAGE_OFFSET_L3 _AC(0xffffffd600000000, UL) > +#define PAGE_OFFSET_L3 _AC(0xffffffd400000000, UL) > #else > #define PAGE_OFFSET _AC(CONFIG_PAGE_OFFSET, UL) > #endif /* CONFIG_64BIT */ Other than the nit above (that I think should be fixed though), you can add: Reviewed-by: Alexandre Ghiti Thanks, Alex