From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93045C369D9 for ; Wed, 30 Apr 2025 21:35:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 537EE6B00A9; Wed, 30 Apr 2025 17:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C1E66B00D0; Wed, 30 Apr 2025 17:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 317476B00D1; Wed, 30 Apr 2025 17:35:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 10F6C6B00D0 for ; Wed, 30 Apr 2025 17:35:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 758D080E6B for ; Wed, 30 Apr 2025 21:35:11 +0000 (UTC) X-FDA: 83392016022.07.9CF3F38 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id E413740004 for ; Wed, 30 Apr 2025 21:35:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VVAQycOJ; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746048909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZEvd/2WbHpfpk4D+SrPk6a3wGOjXXdb1q/zENL2a9PM=; b=Htvv1L8o0gKdHEGj5Jsb7b699TaJaVeK6VEZpGcv/BulqhenMBCXFg/2pXS6PY72xGjZhv Qm7CGe7yiV1MJUUZm+Bl9Iurth85uyM3dIGzym+PGJ2jZipXq3zxfdBpz1oBuIo5OKG9LJ ZlZymDM+0dpVDAwO4GH9pMH11CA27xk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VVAQycOJ; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746048909; a=rsa-sha256; cv=none; b=ckU7x9SxC5o5R0b31oRFFmp8zrjoGQpNd6xdQx40Xcaz7dmBDS4bLjljCewe5EA6SJgZB0 lVeyppxqIaC4PujuT5/Aw9Veb5s26cDRK8fb6GJqetrNlKl56n3KLl/20N6MO7tyY+ZVnp kLweHqTKwjDvvq1fphMW8Dtpd+MbPfU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746048908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZEvd/2WbHpfpk4D+SrPk6a3wGOjXXdb1q/zENL2a9PM=; b=VVAQycOJhEzZwRli6nIdXS/oo3Qa9FNZFDmjDCQmheV8ySUYsNX+I7uXaefiTepOABqKI1 r7DalwKhPfn1usp7miV7mMQhp9bq8qo3hgM/USGqPBj0Goh0iuuS3y5xuErdo6T+tycLEm LTwbWRTNSrljq/M+tJAMvyEHNBZkdj0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-xU602et1NCG_mPKaXACOEg-1; Wed, 30 Apr 2025 17:35:07 -0400 X-MC-Unique: xU602et1NCG_mPKaXACOEg-1 X-Mimecast-MFC-AGG-ID: xU602et1NCG_mPKaXACOEg_1746048906 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so1485975e9.3 for ; Wed, 30 Apr 2025 14:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746048906; x=1746653706; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZEvd/2WbHpfpk4D+SrPk6a3wGOjXXdb1q/zENL2a9PM=; b=iQkFY/nWcdmQtAHRGjYtuXC9zoXR6JP0YlI9fqc7fKngwvSCgjMkwTLuf91dquAYwX agXq8cHZWKXsqxPiLV4f3UY9Ng2nZasdSQkEiActpBDKZw/6aj2oYtaKw9yS1LaF4HRt rU7CVpfCFJoXbXeq6pEXUQGOxx1zruqQafWlAwjGN0XYzQoQarFOwbpN8HQWCeFyE8V5 /+eSXX6QOor0ka/eb+Op9gBG01770OIYEI9WWJ4YBNltLFacQyVSul6HMP6ULL8JT+Ge /xzsTqM6RF7ZzryICO38oIzidwSKsf6QLC4Y+QqhtcA746GZuSg1G7Bm+tqKPMoO/5N/ 9vCA== X-Forwarded-Encrypted: i=1; AJvYcCW6wHBQMdMPe8/ksMX5sm2YApxBTVlTuiZMtVB4UQ1dRzgLjm22vTbKr/icI5DfTLK8dMQzYkKkLg==@kvack.org X-Gm-Message-State: AOJu0YzFBP6F2MT87KkCr4ZSUqqFFaJV7INTeypxJm4HQDe4ymr4V+kT BZdj6ty7P2n5ez+/1tQ6fCM4RtFW11eSYNRPj9ZJ2QrtKKRquuOpQkIgn8uBSZRPIsBhI0q4gpQ lSuYUdVE/SJ0HI3aQlxRhp1v2wzjWT1QFzEDyH9Pz4jA6AnaT X-Gm-Gg: ASbGncuemTyd12gxE0hFEEWuGYl6Wmg1t9TxJgYgOlumursq6/E6POrxW6BdXN9Pw+a RBtmSeJwwnn+tiiM7AuI4fD4I7T/xw5m8HYWDOnz2kK1fFaRMHDniT7lPphknUokvDw18O2m9LW W9rEF5LxJIQINTewSmjWfbVK96fYXRYoIs2RoFcbCqh5gfuw8+Kx7qISrl9Ykj8Rr4GcAErnNod 8p8L5s1HsiYb2olVKa9YT9RR9NlrmaH3Cd9Q7M89bioK00IJiT4GJecK9VUX4IZ3S/JU/K2G9rf m9V5gBs+6xXld37/38W57SwuJHG0/mf2OQfQdh8NPsVE2l1F8lt+92su25xwSCtVvKA6Sm7lwOe eSrM4vyir21IsByOK4q1A0FQqMmT8wuYavK0jzms= X-Received: by 2002:a5d:59a8:0:b0:391:3915:cffb with SMTP id ffacd0b85a97d-3a08ff465b4mr4159492f8f.43.1746048906020; Wed, 30 Apr 2025 14:35:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDsnJ7UsOJ4zyi2oQX3stOqawfO+nPr01iLeKcMN7k8b72nohGXmMc+/D7Bfp0WGCM46RMBA== X-Received: by 2002:a5d:59a8:0:b0:391:3915:cffb with SMTP id ffacd0b85a97d-3a08ff465b4mr4159469f8f.43.1746048905648; Wed, 30 Apr 2025 14:35:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cc4025sm18265545f8f.56.2025.04.30.14.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:35:04 -0700 (PDT) Message-ID: Date: Wed, 30 Apr 2025 23:35:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 09/13] KVM: arm64: Refactor user_mem_abort() calculation of force_pte To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com References: <20250430165655.605595-1-tabba@google.com> <20250430165655.605595-10-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430165655.605595-10-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iaQcmuKEFmXtuEvJd9K1yxS5zjol9Y4Zp-G49I2o-aQ_1746048906 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: uzkk9dkhp4fhuyepqdfzzggggosw7xc3 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E413740004 X-Rspam-User: X-HE-Tag: 1746048908-301950 X-HE-Meta: U2FsdGVkX1/sOF+0PT5K2zWNH1lBUBROdFx6S7CW3aO3EVM/zPf2wtz3+Zwnrn/Z1635nOHTfuVu8nJAtvO1al0uzZlsUf+i8RZZozyl76pwOomGsZ7X6z31hQmxnwhXFSpd5DOGAlpGWplY6NqeRtJBKlWbLUtX1378CUhU1ie7VYnnV1BK+UsdOuCGvxBssHhpxyI649TSpMFs/UV6xQuzY5eSXbO7FDlK+Gc6GH+jzngn2CWyfn7ugACn2NacHUQ5L/S4wpxcwp1j94BtQRwQOtApIxQ+LNMyPo1f5ZzecDOcQgJkDVQ3Rcm2r5Loy+aGoVUdNTZmdox/ZCDWJsc1vmx7eNMQhKls15qLxlM6VX5uPBIrDF9y67cEgGEFc52fFSLn8LtU6T7qJhca9KvQ/t0ANlRtvBgZkgsy7Vx3SSBf+Vd6DgAQGZBKL954FPuggFsgmf9iy0GsWV+DK91lMv0F23bokSH9LzsmYTQyY6Oqsdh30ptinEbIEmaAcgcn0rargNDDpMYAlbLRTHK0FfvCbul1zFp0rlktD0dCBE0w8N3HlUKgmjVjF/lH6bMSvvan4oeMmReUYilP+pKyfhqX6fwlE8fYTUA/fQDSS8kR3conaAoz2kHh5P94oDEe/nXMA7AZVw33lE3+E/1mmwEd0vycO/nEGv1948P0kSZQnaSghPNqqnd2gx/YviZlfkHpv8yDMnkaFBxkbkEJVpYRjvMQacYL8JaRwdaO0GDoIIWguNl/LqVXt0Y4dRdhob7LalbXAFUtedzs8xoGXJyd5B74m+y1dlY5gunIPHtVeXUb5C4bxlRWom5VLtkOCTXmABxDEvanZ1wq/ShIuoMxGKhkft4RK1CWfUqzFo4HV7TMcmTSCQnDliJ8GOKOGUPKAuqlrPSQmM4tBwOUUo5inxOVPY3qQhz4V2ASTnvOp2Zfvp7kp1JpyNwg1HhPQtB2phsVKqYFxMU 8AiT/ehm PaMjtyjk5KaxGkVayD39kPtkxdaH/gWApRR3kymYCq8rHKd04GNm+rezLeSwyEnvpb4J6y17aWJf9k0KznOBK/WHOhxzzWotRFkpzDQ9GdqRZ1ZhdwR7jqBZJxkGo1dqOvgFhvU4WMxtcko/zwmoUm0lvBFamUy+Y4IDdMuYoODYQm+xh1pEQJFfr4zzD9kPnkRbTD5LM0VGfXb70qfDYy9Riik2SVqgbI0OLjh3IS+NDfe69/BXkW7koN8AmEMfT83A1frXl7CBXtHteFzjLJNYux8wbz4/hhVOYSQFMw5klNR2Ctfr65GoTNmLPumEDlyTPz5up3h6N2XQ6AZi/e9Kj7BzFEPgfAx8DygQHowf/UIdvEVpozkWkfIc3PPawhDZdh2DnHWS9T26FA6ofp32RYgceWjsavMomGNfbJHAXdq7DwJHwIRHYojFVXbI3WEmnHuQJqjy7cuOsaBVvF09Jl3R/QjS9MJsAWdTOMGZ2VHrxWUOnvpRAIprogRdyTEqoLp8Uiqh+naTQ5QrcOd7ndSKQ3RMyViR1OVf3tX/SqRergkIELtuzDf8jd1NCpv/z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 18:56, Fuad Tabba wrote: > To simplify the code and to make the assumptions clearer, > refactor user_mem_abort() by immediately setting force_pte to > true if the conditions are met. Also, remove the comment about > logging_active being guaranteed to never be true for VM_PFNMAP > memslots, since it's not actually correct. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb