From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B49C531DF for ; Thu, 22 Aug 2024 06:52:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 317A26B02A4; Thu, 22 Aug 2024 02:52:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0FD6B02A5; Thu, 22 Aug 2024 02:52:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B5FC6B02A6; Thu, 22 Aug 2024 02:52:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ED5506B02A4 for ; Thu, 22 Aug 2024 02:52:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9A2A11213F3 for ; Thu, 22 Aug 2024 06:52:51 +0000 (UTC) X-FDA: 82478963742.24.477F22C Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf01.hostedemail.com (Postfix) with ESMTP id D601D40002 for ; Thu, 22 Aug 2024 06:52:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724309462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KFlQVFYvYT8t1yFycNSIVWKk+lvlPAxEu1QO7O4vyMI=; b=QOpWDKH+LovgcoFuB9eBpyvtEilk9o90nboWv/wf0u4G5UpRA6pfGURy8GrY3Xd0bHjfm0 6MB8KlG//ycOtYBEmrcPbZRp5nHC50s59RZP2UX/3ZJAaQHM+GhoE27Xjla/+dlOfkfhHm 0nmsjuD4yPjM4i1cK/lIgnxdzfFIVCk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724309462; a=rsa-sha256; cv=none; b=KYPyOUPW+/4CnJiFZ3h4gpW1OlorhLPQIutQq3JS4uh+3lDQcbqYnkLULP9S8lRKYqbK25 lqk3s0ExWdERqq9yr+kj7+j8xhXmnZ8uBP3v4mT5EI4dE8tTURheHnCFvsbuGpXR18MUgw /1+tttlcVMcy7WpGDbYsPKRcnDT2FAI= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WqDKp2J4Dz20mBm; Thu, 22 Aug 2024 14:47:58 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id DDFA31402CD; Thu, 22 Aug 2024 14:52:40 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Aug 2024 14:52:40 +0800 Subject: Re: [PATCH v2 3/5] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Kefeng Wang , Andrew Morton CC: David Hildenbrand , Oscar Salvador , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-4-wangkefeng.wang@huawei.com> From: Miaohe Lin Message-ID: Date: Thu, 22 Aug 2024 14:52:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240817084941.2375713-4-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D601D40002 X-Stat-Signature: 4kndmkpmqyhwywtztppduhcrped6ybkq X-Rspam-User: X-HE-Tag: 1724309567-2998 X-HE-Meta: U2FsdGVkX18IfjS/5ofp0/99YHZybWpNZ2chEJQHWAVGJrCr1cJWzvr2dmU5+4l7Uj2XtHI4sBvms5U1dLIXz8QuWcHssm5pAnK356x9L79g98BSHKwRPf/K1GP8bKEwIhja6hn2Yp2fxzhiY6uSccOVxvPdPMhOtiHeHWHSc6yjEs1MUufykPmv7QEwyjxSsiUVwJQq1FdrA9zbLc/sLq9vaJbX52SVvUSfKRq0fvwS6OEDXn+iIfLyUhBU8fO4rvdWLmew7NcQld/+6yKJIzCUxx3YoHXLo/RIUvsWlwTQP3fVgpvmXiUKikwTcFrKpZWEy/96WY7qWlVey//xK4SG79j/4tUna7lmUO0bc5Q/V5CWXuH3oIpT+qdDBCbIgKg8LJquDS5nTU8YR5RxTLQZA2ClBEjJsnJ2+WO29TpRRVcV3I1I1KhOzl/eRtgEcZvkNEZaZCsAMmYskBz1DBYL1yh38tBo9Bgv4i4i2q+PCnjUMm8AEFG75/sS/T/ZoBLUin5Dmci3Sl/Ua6RfRquhNLdrUVY+eYmDyYc73+avol1nvPkbKVmPhDu3HP9X9LWQmUs/aBqTzyqjn2WC7rC3OmSlxDqjt+Aftbm3BjZg6CHjGH2yZqGefAZ5eL91I3sOLdyW3K9K/soF+lblmWIynij/0J4t55vvqRr/9al8lXQeUb49iqoG1W98tELvBPboI/Eb+CJf0xiFpCEKprnHIuHI6dHrENZMqzb8RU0vYw6SaLNIqo5auKHqSrJAUS2BR20Hl8NvauPYz9Nu1GzAHVRe44EIkvg+mJP5fkG3rmTGgIZBYtwFz0rcB7zKG8vulFWr0qQjtmUamApLVTC6SeTmQ4jESblB3rN3tHRvLUf9u860kvF0HLXy5khn3+sUeicbbXyuuoALXULC7oRmj+NxzYh5wxf/7y4MZ6a2LFUwMuHJGSons3XV0w9BlWewa766XaTOZV8u0Cy d1TFlpjr liGowMF3JMp5DIgWfgFwUFL5Blf/Cn8wpVSocIwKtbBvTVD0DUh1HLw+h0glUzOHNSHg051JySn97WMYJKG1L8M3W4HjDWb7AeUDfCozsYR5jiZaVR9jJS7cMhIB7YagPI23cxDuKoXkOGONA+xqD8OZofp5KxEsgLpnA0xxza+qDUt/Hrwcs5VEblA1v8OWbUWIY14/FYCbxYMQn/DMp1JUN5nPQModeqY5XFBR92bZbETpLzPJ7FF6D04ZclNZvJusQmJV4aUmDVOYHYG+CJu8bdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/17 16:49, Kefeng Wang wrote: > The commit b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned > pages to be offlined") don't handle the hugetlb pages, the endless > loop still occur if offline a hwpoison hugetlb, luckly, with the > commit e591ef7d96d6 ("mm,hwpoison,hugetlb,memory_hotplug: hotremove > memory section with hwpoisoned hugepage") section with hwpoisoned > hugepage"), the HPageMigratable of hugetlb page will be clear, and It should be commit e591ef7d96d6 ("mm,hwpoison,hugetlb,memory_hotplug: hotremove memory section with hwpoisoned hugepage")? Above "section with hwpoisoned")" is duplicated. Also s/be clear/be cleared/ ? > the hwpoison hugetlb page will be skipped in scan_movable_pages(), > so the endless loop issue is fixed. > > However if the HPageMigratable() check passed(without reference and > lock), the hugetlb page may be hwpoisoned, it won't cause issue since > the hwpoisoned page will be handled correctly in the next movable > pages scan loop, and it will be isolated in do_migrate_range() but > fails to migrate. In order to avoid the unnecessary isolation and > unify all hwpoisoned page handling, let's unconditionally check hwpoison > firstly, and if it is a hwpoisoned hugetlb page, try to unmap it as > the catch all safety net like normal page does. > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index dc19b0e28fbc..02a0d4fbc3fe 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1793,13 +1793,8 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * but out loop could handle that as it revisits the split > * folio later. > */ > - if (folio_test_large(folio)) { > + if (folio_test_large(folio)) > pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; > - if (folio_test_hugetlb(folio)) { > - isolate_hugetlb(folio, &source); > - continue; > - } > - } > > /* > * HWPoison pages have elevated reference counts so the migration would > @@ -1808,11 +1803,17 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * (e.g. current hwpoison implementation doesn't unmap KSM pages but keep > * the unmap as the catch all safety net). > */ > - if (PageHWPoison(page)) { > + if (folio_test_hwpoison(folio) || > + (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) { > if (WARN_ON(folio_test_lru(folio))) > folio_isolate_lru(folio); > if (folio_mapped(folio)) > - try_to_unmap(folio, TTU_IGNORE_MLOCK); > + unmap_posioned_folio(folio, TTU_IGNORE_MLOCK); > + continue; > + } > + > + if (folio_test_hugetlb(folio)) { > + isolate_hugetlb(folio, &source); While you're here, should we pr_warn "failed to isolate pfn xx" for hugetlb folios too as we already done for raw pages and thp folios? Thanks. .