From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40C7C0219B for ; Tue, 11 Feb 2025 20:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CBEA6B007B; Tue, 11 Feb 2025 15:22:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57B866B0082; Tue, 11 Feb 2025 15:22:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 443826B0085; Tue, 11 Feb 2025 15:22:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26B746B007B for ; Tue, 11 Feb 2025 15:22:42 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3DB3160A79 for ; Tue, 11 Feb 2025 20:22:41 +0000 (UTC) X-FDA: 83108786922.05.291745C Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf14.hostedemail.com (Postfix) with ESMTP id 1452610000F for ; Tue, 11 Feb 2025 20:22:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739305360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sFkhB2tQiPOfHp1RZdvQ2uGxidw5nbYCgxULFFMUepw=; b=in4Q12RniVlpdGY7F4M5TOlpHv57QjJBxLYxDj8lE36TJ1sIoHff2zAqroyNOTID/mvoXg 9QtL6aTPqfhmgVNyxQnzwvZ4R+Nue/WlO0MriuTYLcGUTijiXitFT9sdXAZQK6D1hrPwX9 hF4Ik5JAA5iJJPn9LXdd4kpdIK33YLc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739305360; a=rsa-sha256; cv=none; b=fUK0gwWW+xeOT3L48S3wkUv1U9uYtZL3zegCUUpvKp37KR5RDny0iXvj1stluahqD3/1Np 0fcVbIBfouAw8QG5aF2qGn09KOPP6xzg1YfCOjrDaa0PVLtNz+T087XcfcIe556Y3L9TV5 BQHMXSDpPnUEvT+nbR8lAqNFmoMUwPc= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1thwku-000000007J8-3SrU; Tue, 11 Feb 2025 15:21:16 -0500 Message-ID: Subject: Re: [PATCH v9 10/12] x86/mm: do targeted broadcast flushing from tlbbatch code From: Rik van Riel To: Brendan Jackman Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Tue, 11 Feb 2025 15:21:16 -0500 In-Reply-To: References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-11-riel@surriel.com> <2d20c333400b890f4983cf799576435abf1d8824.camel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1452610000F X-Stat-Signature: d8p61wn6expnym6fwaec1muww3fnurho X-HE-Tag: 1739305359-607753 X-HE-Meta: U2FsdGVkX1/qhba/PUKCHdS1r9/o0mBdg/B/7/gxgHxKD52SLsommMrsAJPq50n/h73Xv6RPx+gDQ/l52cXIOIKbAtZkB8TNB0IiHdYZCA2r9Qh2AvoM6lR/fSBZJz8Xgc+w9QSuf2uMZjLGPya7LZYp3PwWoAmt49sMeWt8wbSr+X4rq/JQ3FUuyDQqQqQWV2UzzFUFfdg/trXWrmkdQt5BtFkNhjiFyiIz5uuB4eAXw65pn1QiXXoDLZ8NWITvtqjXYGYmWv3joBsuyEDM2Kh7CMdLVQc7vL6lI0f0hyJgBV29edR/Kbhds8r/j83yyVA3Y5niLoueqIviW19WeNsXsZkn+bt0zMThWWq0gocM2pxmli6U4ggCTGt1zot6y36JBRIa4ljr/kJlOEIchp+/ny/krjazPG47jGmD95r/bcltBMqKxlNbsbeVbUN1iEc+scwnhvVeRBnxYOpBrAnCoDAX/PHQR9WkhSQ/WU5wYCkwMNHf2Yc5DcryuxllmDHp1jUf4RqFH3fhFciiGN6C6cDXlRch02AFimay/fGpNr35DdhFXU+JwKL4PlsgoobBqCRDs3tkQJ/62oJ+0qWqgOwEmmom+s3LDseH8ehlzUNabjteqbx6NkkJIUndNzDn+MBNdsy9KOK88aFnMKRhtAUXWaEvW2LUfwIEJu88OJ/r4s74KdmlEM6GEVn6QvZCeDyt0AdsBgQHglaEVnmoRR2+//YP81y+cEklukn+FIcJ5Iw/9pk7ovveo5CN0MIAE2r48SUjghUAydl0BJDKSJdLC5xgwDQJ6QaUJGzHR7mMOLeo0/UwmGJJ0B56PfDhWAjfvVOS4npwiOnRC9AJ9ng0SrBvAoYjsiKHRUzvebWOWz41ZA6wG07FNNJw2Gjo1JNj099s6MgsUybF2R0LtUZE0wuiAk3E5RGnKZ9O9oWbqjmNa85ZWYkCEm0royMPIG7lZhCTQdRJVuU rxXOMkHg ZnXQ5RX5nQCzA3xVtZ9IpjJv9C35jVeRiCy/pp8xF82aA1cXO0ab4rorVqPsJmGVXotohkajRpbSRaIAU9iQst2zBrjdL+xtS+kztf6WVhfxerYey9M2w40IHYcywxy1klYzlmFKzwt9XuUFBo4zgZ07Jf2IH3+gVCu55+q/6FlTMSa2xfGSvxTn+ZIiv8v8GwVcReDqONe/nAnySjv/OEVy8Mn9uSEN5PSxx1at/KbqVDQU/U5WmaJyJL69i10vabXrC+2C9K+ADD5514RWYWDydPbxguRTZlGafiaHh3eGcDuOELKRF7CRj/H2/D0PjcVOIp0pFuB+llDK0nomdk4O8ZcZHeG2JkMpKBze6oHQk+Mt4RtqANRlllztiCv/sAEfx+COoLfD6L9NsRCOLqwLKGWvCD1iEUfBngxEl0nXiPAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-02-11 at 11:02 +0100, Brendan Jackman wrote: >=20 > So I think here we're encoding the assumption that context_switch() > always calls either enter_lazy_tlb() or switch_mm_irqs_off(), which > is > a little awkward, plus the job of these functions is already kinda > hazy and this makes it even hazier. What about doing it in > arch_start_context_switch() instead? >=20 > That would mean a bit of plumbing since we'd still wanna have the > tlbsync() in tlb.c, but that seems worth it to me. Plus, having it in > one place would give us a spot to add a comment. Now that you point > it > out it does indeed seem obvious but it didn't seem so yesterday. >=20 While that would be a little bit cleaner to maintain, in theory, I'm not convinced that adding an extra function call to the context switch path is worthwhile for that small maintenance benefit. I'd rather add more comments than an extra function call :) > Now I think about it... if we always tlbsync() before a context > switch, is the cant_migrate() above actually required? Probably not, but I guess it won't hurt? I'm running tests right now on a kernel with a bunch of debug options enabled, and I'm getting all sorts of warnings, but not this one :) --=20 All Rights Reversed.