From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF8CC4332F for ; Thu, 8 Dec 2022 23:00:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360C58E0005; Thu, 8 Dec 2022 18:00:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 311698E0001; Thu, 8 Dec 2022 18:00:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D9218E0005; Thu, 8 Dec 2022 18:00:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0E7788E0001 for ; Thu, 8 Dec 2022 18:00:17 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D90C0AB7D4 for ; Thu, 8 Dec 2022 23:00:16 +0000 (UTC) X-FDA: 80220659232.13.EDE1DE0 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf19.hostedemail.com (Postfix) with ESMTP id CD8C91A0016 for ; Thu, 8 Dec 2022 23:00:14 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=yTcgxVv5; spf=pass (imf19.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670540415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qA/8x3qQdNdaodHCr0eE0GAtxigSH4TPjOKKEAO/Bfs=; b=O3DwAI+diJ2g0ACoPQoQts+47f/SYasKeaw2cdybQc4HxDGJLVEaRKvc6jYULD7wvKmsPR zJvUjGQ7IyEABiqVlycHbr+q3Rj4pMSl3XTJiXPmF4ib3vWclsaxSvFvVlV+3ICLDe6Pqz n80OEz1HnM0UbIELrQWMi0MZ9AcY9XE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=yTcgxVv5; spf=pass (imf19.hostedemail.com: domain of axboe@kernel.dk designates 209.85.214.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670540415; a=rsa-sha256; cv=none; b=ERnOLBRaDsQdU2Cmqj0PVm6j3CqVtdWvnmljQZlHmZjHFi1JcImyfZyz+Of1hA/T/i8ke/ 1MccapRLcHZgMsisZ7HPFC11z9YV46TZlPXzWsVB7PNR3nZOW9uMsq2ohv+bUqa5zYOn8u XsEJHe9cv6Iui3W8JXWx2TezUxNGgTU= Received: by mail-pl1-f170.google.com with SMTP id w23so2996320ply.12 for ; Thu, 08 Dec 2022 15:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qA/8x3qQdNdaodHCr0eE0GAtxigSH4TPjOKKEAO/Bfs=; b=yTcgxVv5xnN6FJi+ORQzlz6vau8+1mowWfm4xWV7+tRilP8R1pp7r2blxMovsaU9dw G7q08tOeuCHieA88tqcVOI664eu6JoUcCuS2RCS0+daHrqOPLD+bgYd3PItoWq4xE1LQ HSnyEcrB7QcC2PJ3x+50gqo1BJBqtGSWrsSg2WjFOINYgGtsyH6RQ5K6bLaPz9g8XqPs 6SEvntKD+/SZl3BgcbEQZTwX+oKOzqcoBInz7tR9w4xOTLS1ho+ZRpDNpLxqN30vbeBj l4EMgdll5K3roSPmsGNkvpLTCyIvwNzA4gVTQhsn7YZV++H1Jiz7C0hDFw6XjnMFCpRa j6Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qA/8x3qQdNdaodHCr0eE0GAtxigSH4TPjOKKEAO/Bfs=; b=MOi8vZffgVlAMCuhXhjBI4XcKxbgjdjdfEDkkTu8kZavKSYzcRY3hRboQvuA1/EvN2 vmd4doWOMGAzDEs3T6PBILkZF7nNj+2FmcyNqdrCgdvTBXjA5y9sU5SaqOfkTz3hkFoF Y1ZofaiplGP+bBRiFe6kzRrC6pTatmpzrg0IcUxKmvOFvVSkKQvCdWUqEN0FKu5XswUQ heEVYNxHUKjLE6VH3rhAfyoPNQF+h2wY9Wh6l/BDwuZjgn4aL6x5X4pM+WbLjXZbAH3Z cSprBh1FXrhhDpFIjozFhanvUFVkFfbPzdxodvTIMVL8XCJ1g97tcAij40jm+0gK9dtQ ETeg== X-Gm-Message-State: ANoB5pmFCyuY0noFVqQiaaVJMIsb2nXbTn1uqPmHbtp4oUJZG+4XhU/G LDcT5OrGCExWH5hApfGTWkZQcQ== X-Google-Smtp-Source: AA0mqf630rvvC/n5u3xrY1usx1wprEKA+LVGZdu5kB34zojm+nhtIXgF0xOrLXwJsdMiwuiSRa0H2A== X-Received: by 2002:a05:6a20:c197:b0:a8:a203:ec90 with SMTP id bg23-20020a056a20c19700b000a8a203ec90mr1468445pzb.0.1670540413369; Thu, 08 Dec 2022 15:00:13 -0800 (PST) Received: from ?IPV6:2600:380:b444:c00:74e0:9880:f256:e2b6? ([2600:380:b444:c00:74e0:9880:f256:e2b6]) by smtp.gmail.com with ESMTPSA id 33-20020a630b21000000b0046ffe3fea77sm13570293pgl.76.2022.12.08.15.00.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 15:00:12 -0800 (PST) Message-ID: Date: Thu, 8 Dec 2022 16:00:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH-block 3/3] blk-cgroup: Flush stats at blkgs destruction path Content-Language: en-US To: Waiman Long , Tejun Heo , Josef Bacik , Zefan Li , Johannes Weiner , Andrew Morton Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?Q?Michal_Koutn=c3=bd?= , "Dennis Zhou (Facebook)" References: <20221208220141.2625775-1-longman@redhat.com> <20221208220141.2625775-4-longman@redhat.com> From: Jens Axboe In-Reply-To: <20221208220141.2625775-4-longman@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CD8C91A0016 X-Stat-Signature: j47zgbzsjbosxaignrcigr3bp1uy9q73 X-Rspam-User: X-HE-Tag: 1670540414-955872 X-HE-Meta: U2FsdGVkX1/7fdFqBPGJxXhZBvz4IvJBiQ1SS3uU3kxpPzKPVNGkusy/vlD+qCAT/SQVQsrZLpKjII0UQriETThEvXaCaW4qTCXoUXuCojNQU6/mqTXK1MKfunA8rDTA49A2ugDGvFuPVvEF3boZGW5TSHAf/SRG67bpV4Xouj2MWMpE4FykXrAJm5ZLfAgZGs9O+o11YkB02gn9xLlEXyXbewFM98TITNKMaJzc5nwrR4l3DEZ8OISDVdNV1oLFvEfCTQHgy7pYtYQOyAXEIGu/0sFtyexUzVsJN4c4nkAvUd+cBVNbkGlXJdnpM3gSgW5NEoej/SRI1F5b8+cqskKsy/X84vw2h/S1ZPYr5qwH0vvhkdkBpLbdM5Gbkg+hvWKADUvwD+5MgZypvjfcE4rw6uaje0KsgnWgVzNLyYm6t8osM+lbkra/tOAoqPq61tB/TJW8HLZEFV8yZtIrtSdkoQ9BV9W3eaCvYFS+to4OkwyCYmvkK5smeXwFAT25aYw1JnGIi228IprGMEx6cLuSJyvi5KaIVUqwHZTU9AEm8Q4WgFBIRKy4BBT9GFatjrVA4BfojZl/vc0HbDz8WA7hcx0Fc/IeEps9t7aDbnMZwU6IyHIIJJSb0iZOCaPQxGgwFzuAbXvZy6dH1fPZG4tGHmnnIdRgBs3lD8AQ6dl9DQm7la6XQLJWqIN9jytvlkWpXG/hyeCL3uctbk9INRXqRIL+c/sL1/A/7gWJjrzR8r+QA/YIBbNRjPQZ2KTN9qyMQtOMHpS6cTuXjlZsX7/h0XD/RcAYHX7FKZ/mVHqflCUHl2bixJ+E787fiIAfEA0RxkvdH8twtw7GWX537WKZ1Rs4MyaTEgabtPgGg+RAbgvM2ns3idRehb8OxAFuFQhr5GEwfOz9gZoKzkphCSO98JZXrSnEgKri5/xthoZPGe8BgiZb+/HrLedtkc6iurZY8qYMwDE03nqhN57 s1+TbK4J sxfSDfhjG8Yf9E5pkF0tXEi28IFwhZ6DSqmr3pSZ4TyGL5Y+wmpKIjaFxhY3pbvIoictQoGdbuiLODdWcTLXRfdyyrfeAVYW+UTwfYENEUB5NpnvJdX6dlj7oFPSQBWDc0fEX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/22 3:01?PM, Waiman Long wrote: > diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c > index 793ecff29038..910e633869b0 100644 > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c > @@ -281,6 +281,26 @@ void cgroup_rstat_flush_release(void) > spin_unlock_irq(&cgroup_rstat_lock); > } > > +/** > + * cgroup_rstat_css_cpu_flush - flush stats for the given css and cpu > + * @css: target css to be flush > + * @cpu: the cpu that holds the stats to be flush > + * > + * A lightweight rstat flush operation for a given css and cpu. > + * Only the cpu_lock is being held for mutual exclusion, the cgroup_rstat_lock > + * isn't used. > + */ > +void cgroup_rstat_css_cpu_flush(struct cgroup_subsys_state *css, int cpu) > +{ > + raw_spinlock_t *cpu_lock = per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu); > + > + raw_spin_lock_irq(cpu_lock); > + rcu_read_lock(); > + css->ss->css_rstat_flush(css, cpu); > + rcu_read_unlock(); > + raw_spin_unlock_irq(cpu_lock); > +} > + > int cgroup_rstat_init(struct cgroup *cgrp) > { > int cpu; As I mentioned last time, raw_spin_lock_irq() will be equivalent to an RCU protected section anyway, so you don't need to do both. Just add a comment on why rcu_read_lock()/rcu_read_unlock() isn't needed inside the raw irq safe lock. -- Jens Axboe