From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE3ED2FFEC for ; Fri, 18 Oct 2024 11:00:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBCFE6B00A0; Fri, 18 Oct 2024 07:00:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B91256B00A1; Fri, 18 Oct 2024 07:00:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F90A6B00A3; Fri, 18 Oct 2024 07:00:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 614A66B00A0 for ; Fri, 18 Oct 2024 07:00:51 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 33B1AA0710 for ; Fri, 18 Oct 2024 11:00:29 +0000 (UTC) X-FDA: 82686430092.18.B2BADCA Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf19.hostedemail.com (Postfix) with ESMTP id 225741A001C for ; Fri, 18 Oct 2024 11:00:33 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=i7U6nu6l; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wqFUvqGX; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf19.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729249102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aN8MsLzdiQHU6y1OEezilCRmoFPQly4jQMnSitMORuY=; b=sn6dd8ZnFE1z2rhcmCJFH7Yjivh3FxW+hdMsUegYm7YJ5R4yRIQEoiWQ5giRxQEFBarPTV 0wPqSMZR+K77bJeJet/g1PrQXC50370UES+Q+dEgdnt5jJZ2cglFqjJQKardd3QEk4Dok0 HwAARcutYzVDZ/e+2eLSAOcCi0myoI4= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729249102; a=rsa-sha256; cv=pass; b=Ag8l2vqHLv5AJHmr5BkCJJkKv77VUVGJEcwGTMTqBJ6BCQeCAOpiKjr+IPDW1wrczp8M5R 9eYhHWLHOM9qQaHhHR1jK2i2dFjEuXkAfndjUZR5jh3y7+ms79AyINZ+Chf/7534jc9YS9 KS8STlttBUUWkPBZ/kqXoFUaePQBGQE= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=i7U6nu6l; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wqFUvqGX; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf19.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49I9ipeq008536; Fri, 18 Oct 2024 11:00:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=aN8MsLzdiQHU6y1OEe zilCRmoFPQly4jQMnSitMORuY=; b=i7U6nu6lIZGVnYKA5pzxCJhae2UfxUK26P egqgOeAm502wTJmMaglZpi3LxMEv6P7haqs4aXMa3T7ceL+f6sBxdMCcDFjuG02a wgeSNQbpRvZv+T0EOYRL2SPJZtjgK+O9WLlZgcrV3BaVpvqSnbHkb6Bm+9AC6mkC e1Hc8qv4gKFtgvbh4dW6tuiPQzZy8xwL0OHE9y10ubbdberRUWfwr2HqHsBTHbN9 PCHBOpVJK/mWZWLIatE+ZXi68QBuafscOF65pNgCC87o5aIzwFpnxil3uKfRPAmM hb4qGRYvx1+nDtTALGoylm4JVHY25TO4L2eGVDoEz2KM8ygo2Ebw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427h5crx0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 11:00:28 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49I8d5UX019899; Fri, 18 Oct 2024 11:00:27 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2047.outbound.protection.outlook.com [104.47.58.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fjbf8vy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Oct 2024 11:00:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DMctPKnPby94yOwQC9kZlhmyFbeLpw9fHs0JCHntDZbosuyKlPIwAFtSJiJNPNloHjI54VTgKDoKXudsRJ5y/UhgNLtCE3vA9i6qbZ8amL9pdPDQICLcM2PNalp6AOnYwRRR7Rw1A6T7ka6HmvmOQOSQaY0cl05zam747Lg6I7z7PWiLarrYcKHu5JcNlbMzyBtQ3pGLl+8Oz8VVni0Soe1tc7kSAlajpEgzaElS4mxG7UalAVaoA1kzvM7xCYpecFNqMV/P+pdLBdQZeVZ2gwPtdISfSl5P6/U33NjWtbsSzo0JcNPYXMKhFmJlGD2zuMAEBGoAFUAM585HVxXV3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aN8MsLzdiQHU6y1OEezilCRmoFPQly4jQMnSitMORuY=; b=JmFpeiGvlPiSiXuU8b+3w5piJLh8ri+rhwXbAn5N23oyhh9sMSkTX1I4LDKewQ3ZDP4ogfDEuD/BhS96HxYk0Yu0rpAzRcUm4Hi0tTLooAR+/h9gGecatCyRnCjqeQcf6Uw+TlzqbpuokujJkHOZ/dz/z7DMSP88DDxD5yGrS+hr5bMB2qoAdpCUG7kY8Qgp2dEJlYhFHK2NOD84THwYctPZZax5NSDB2nF7+dC27wOPIrVo1wbN+V5hrc2DfO1ULuVYallQQHxh/Rn2pDE5VQGNdAKf+TK747aAfnCoy9K8lo1un67mStjjqd19gAdb+sqp6KYXLcmnPmby1/JFuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aN8MsLzdiQHU6y1OEezilCRmoFPQly4jQMnSitMORuY=; b=wqFUvqGX6+WQSXgojCYrmQT3qZUxgdHsyGiHS+rvHaQN94vUrR1jUgJWF40erJzC5/wCHlhAL4Q7TCwWbOFV+COMRMW87/q25I/s2jABbmMi9WInhKAy6HQMq6rqD+wKlHha1PIzH+IxPqh1xH4NLx0FGX44DJSMciznFSN6ynk= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by CY8PR10MB6907.namprd10.prod.outlook.com (2603:10b6:930:86::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 11:00:24 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%5]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 11:00:24 +0000 Date: Fri, 18 Oct 2024 12:00:22 +0100 From: Lorenzo Stoakes To: "Kirill A. Shutemov" Cc: Roberto Sassu , Paul Moore , ebpqwerty472123@gmail.com, kirill.shutemov@linux.intel.com, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, jmorris@namei.org, serge@hallyn.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Roberto Sassu , linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, linux-fsdevel@vger.kernel.org, Liam Howlett , Jann Horn Subject: Re: [PATCH 1/3] ima: Remove inode lock Message-ID: References: <20241008165732.2603647-1-roberto.sassu@huaweicloud.com> <7358f12d852964d9209492e337d33b8880234b74.camel@huaweicloud.com> <593282dbc9f48673c8f3b8e0f28e100f34141115.camel@huaweicloud.com> <15bb94a306d3432de55c0a12f29e7ed2b5fa3ba1.camel@huaweicloud.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO2P265CA0052.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::16) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|CY8PR10MB6907:EE_ X-MS-Office365-Filtering-Correlation-Id: f2297461-69a7-4e63-4156-08dcef641143 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?i5GQ3YvlRRG0ivhDbpQ9sXt9Mw+mzqpfcK0O9UtkT7rFC6VqhfXeyOeIpnPO?= =?us-ascii?Q?Phe0IFf20+gCjkd+MEqhVpNYV5F8SbKJ6UrUgdwimfSOtanhV83O7W9xigP2?= =?us-ascii?Q?7Hsnt3dLrMmpespQUGqIR8o6Vze32qmphSO5yn9YNxIbgSXzVBqmkv/tD2SX?= =?us-ascii?Q?Gm7INxbt7qLydenpf34W3ecv0DCQsaxmAbGF9GUnJf8kCVAMY6+pRVfizDL2?= =?us-ascii?Q?xfdIHN345WWwaSrXnxVMazS4mjZz+DFMP+UYJk5VgrjBKetAL3liVTTkyAAW?= =?us-ascii?Q?GYEVqwl1Tge+rIFYVMadGsNmPFYZxJFoQejGvj86f4YCVIKscqVlCOszqLgO?= =?us-ascii?Q?rO/zL4P+znnjZtaNul29L1AHb+OhJh2C3yhPiQnARsYWicBU0qnR1zMbrtEb?= =?us-ascii?Q?Iyks+dAfGT4RpoOAnllU4GNHbpcfmWm3PDIKPuQehHac7VsRDwInkRwihox0?= =?us-ascii?Q?mKF7rD87K6svMlhumJvod6fCQpDznjS4555s9AtkDiSrS/0fK4owrAMCIsil?= =?us-ascii?Q?INdtHCuhyYyEfYoA7AbBEQ5ViD+XlDlbsfSXX0UpxvUxBdKFMS2LkFB5wviz?= =?us-ascii?Q?G3rWEJp+bfdluLWmtkdWacky6v5U78VmLLncs/COxkwqXGHBGyBC2E5Rsdyb?= =?us-ascii?Q?G3Gx6/tpfFWHRCXrowxtkwDki1DWAP+6V/lhgW22HRPaYE9Dt/ByWVmIjYza?= =?us-ascii?Q?iU7yaonSunMf5dFqEk9ai+DlsOszECmqWK8AqCbIFnHv4xC80qvmMO8/VUZW?= =?us-ascii?Q?pig59y4n7/8yhVoZqMludj5RJGO5IC4tTOiYQ4BPI96yBRzk3ArA/xo9RTRX?= =?us-ascii?Q?wjBE+ubTzjl6NCQ77IArutE1LkmskL20r3JESx6bXwFSzfvn69GbzJ1jkHwO?= =?us-ascii?Q?KJVaePPu4Lf4W8t7CHd3GZMHY9PzRGx0j6Jk7fSvvLVIyw2JnQgCE9JH9rfF?= =?us-ascii?Q?SZdXcCtorDP9/ZB/yKXRYPgLD3N56avvQNSmzKF0T8tb9mmMFholO2OyQZU1?= =?us-ascii?Q?q52aP895KlibAkaFpx3YNU5ViOqu7uaeqBsCng57h4k70onxSX8o3B2IEMdz?= =?us-ascii?Q?5DBpvqKRLjYpL4YN8ESfNk8R9SabmZwH9pMOowzTigdlOagSRYagutdLyr0e?= =?us-ascii?Q?OnP28ANpeAaODHdluFeDFeTx2YKT5QU22MEzQ24l2cb15Q+hXWo/lPc0tU1F?= =?us-ascii?Q?rCxK4bIsUcmXUMOI5Bgk5GP+dan8rwhdRImasYgIYtnYXImCrFoDZ8Ouv65O?= =?us-ascii?Q?iDVlKAqNimxVv1+J2dsrPJD7d/NPCjapNI391U9LuA++jB6QUnXJNux/kntW?= =?us-ascii?Q?AucsnLddPh2YxKJiMACnKehZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0Fya/xuOV59yx/8omllOno1vCY5S8sEvAFCR+5SYMnVfMdK3l8D0/G2MGzAq?= =?us-ascii?Q?C9qUBsJU+lpjbBDL6livQjP+kdbVpf+D1Z45L4pnJd3ieIsYNax8gSOCEb2H?= =?us-ascii?Q?gY3ZlGKe+mmcFjL6aZXOt4sWAr/9bgdhthShr/R9EUXB6LZ7zRVuI7U2FXrI?= =?us-ascii?Q?n1Msy2QlXvQIXr+8tcPU6DOYxw29dVw2odfkP+Uak2bEorKgDkpQfeLgl5lB?= =?us-ascii?Q?jnIQ5oAr69QEMfhnLaip0hxXz9HiWSQH/ym6pgkLHAVukBLjFQfi0Z5y+pCN?= =?us-ascii?Q?qhnxeYYrBuANmQu17WVGFWhZNywVQ+oamDkS0osSrnM/ms3fzkVMPPAX/M49?= =?us-ascii?Q?58W1XgYY2/quNUd7p+ElM0Wvsav67G5EWCCI8jwQLeVRCohO7Z7M0qIk3MhN?= =?us-ascii?Q?0Xt3dFQnHwozhOnNmfpUWMIzJ94CIO7kS+vbPTqJOFzHNpBFXIeZs0G38Gsh?= =?us-ascii?Q?gQ9ktbV/oTxVHUTKGyUh3glMd/dY0gYI+Lbk8V8km9Ri7vIN915NHLbeWD7y?= =?us-ascii?Q?muakiAffRgMcD/dlRot0eShfUs+pEc2Z6h91ZfEq+FcV9kYPYr+XmQR/UQ1C?= =?us-ascii?Q?CLt0krI52grwU8zxIEKhadoEQvzJgP9XUxXqTLWs9iaTpClW9xxvyMlshJB4?= =?us-ascii?Q?2MHdp++4KeG+jpUOklzdatkOU4z55lqOdVdeg0z9ULryKC+NcD3Jwml71I4X?= =?us-ascii?Q?C/GF1TjebOpDStx78G7M0F0vLP5akXwpSNvPHUibbT1D+7vK4MP+cMPMX5OY?= =?us-ascii?Q?c+hjy9yHhPyGLqKsn6u79V8gS3ad33twtV0YOrP7qROwdi37jrRqfHHJJlKZ?= =?us-ascii?Q?IhWN4E4Tez+RL9r0ds155oK7r1yj7dJ2HmELEruqxxAFcLZkUw7cIeovEUYl?= =?us-ascii?Q?2SL5YvJmrihcqI9Mw4s6JfslVH8/DV46Ptz/GYh0XtjfkQ6NfulnyhZR6z2B?= =?us-ascii?Q?mSjnXlYZv5/aje1WX+PoIXkUGcKC8GvMl17viooymHo1DOLrElS/L3kB3Z4P?= =?us-ascii?Q?wltDiDjIiOOEXNeW9nOom751ZPM+FL9sf4Jzfgj9aSBSW6rY63avkiHftRth?= =?us-ascii?Q?cxD/hAlPcdxCu9ZpU9fYMj74gyXy7vh+GrlnD68whv/DYrJlGSaYg/gbZ4hu?= =?us-ascii?Q?HsNRpYtfI2rI7KYeib8ac4PXL2cGQ8IGkNQSQPjY5xkX+vxDyB1l7vhl/ypP?= =?us-ascii?Q?Bmw9MZGHkEGgCit0VM/3xXkWvSE5yT+K/ifbGiIiGnOc96D4XmelvMuUOu4t?= =?us-ascii?Q?Vi4Q3o2d8AetmeaU7o9rTsdDQKlo9cYJ0jCK9LYoOegTnVcCHOd5ZJCSN8WY?= =?us-ascii?Q?OlB5VpOfVZBscdI7DrbtBAp6dgoddEGU3pjquOKWdLQ8Koli0vXbF4udKfBn?= =?us-ascii?Q?4c6jwsnmx/ZhdIdcEQFP4Ib7gJt7wyfWheh7YnUjbgdGxTDNBMvEY/0ly0WL?= =?us-ascii?Q?AOBtdjMTIQJxOHGQX6GU+RG5gN2CsLUtj7hYlVfXNadQh5QcCiLcxMX0ROKm?= =?us-ascii?Q?eyiDq0NLGahValKbh/f/o/xxIX62PozBJKsA8ngm173/kMyvb6Sc5VF46AQq?= =?us-ascii?Q?PJzFyvl4O5y1ECldOvLMS5xyxr4VuCoWOjdHY1pjxZ0mxAIGRRW/laUYgKa0?= =?us-ascii?Q?MQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qAzoEFybE7j2s5FZ2c6CM39xpcSOII4sB6SBDJyU2sMBlB4r9BOqOov/VPLXrVfQrmD2F8gu4iIZDvDWVczgpWq68jWVtlH3gTxAkA1lOogg1UqmDr4uYhrxtvrx7AksaqXMCzIUweHiQbQ1Wkb5UuIphbnOi16E/4HLmUaqbfW/b0Sd+BvAtjX/8JIXxKWPoBlLn3C8cUVGFOJ/XWaEwfllzClv/kLHhk/9ROvPqBsQAjcQPWBR+KTuntmqMgrecgK6Emylr/MlM/2lAWYdCrfmPVTkxVJoeYPHL7UnoIJQ8/EcBElw7Q346FBX1XiUQ0+OI4q652os0oXoziBqte4OPlmQrLW6NeYgGD3v5bsmisQHs0CuOGJlJciBUQT6o3OcuBW2I129YsjTCf0FRys2qZcAqm1mFwbYe2UelzRFoz6N1ASOOu8vRoMDxKQdh7Z48n690cPZktXAbPH+SogRSDj6VWIOQBgTznNIEVf/yekbL4CfcuiB7+L1krci3YmHl1OM38FOmwA4nvUAFaDEdJf8s0XlJWjSa2bxaU681nDSbr0O0yhwei0f8XbDatnfBcanOtbBNeSA+SD8UP+Aa0l6axUp1ncZSnRsOmg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2297461-69a7-4e63-4156-08dcef641143 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 11:00:24.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ChK/qQfqDV6plgo6l2qDMbi+iigM8qHZ7fVq4yz0HTMH5cV9xFOvymTUCap4v5F2XziERWv3aVatx8Ty6bhCYhDz2/yN8pLIfoube1TQL1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6907 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-18_06,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410180070 X-Proofpoint-ORIG-GUID: 5qrdI7BYbkcIGDpRmezheuBXk_g-D7e_ X-Proofpoint-GUID: 5qrdI7BYbkcIGDpRmezheuBXk_g-D7e_ X-Rspamd-Queue-Id: 225741A001C X-Stat-Signature: dgz1ewz813gn5ssq9r7fjbwkq7m6b59g X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729249233-26340 X-HE-Meta: U2FsdGVkX190/q0ypt2SYD1iTAYiD/JzpHWazU90xVRSRz6BkSRNYkmZrdCCH9zRmznL1UQKnkgwnWjx/rdGgn+OnqfEZOnQWCxjOum0x3b8zJpxiH7sHKAqfJQkAtDudfvtKK23ATQSFNSvTYQmG+d/w2wvddYesKnAbA0x4Ikj06U+X/a2X1Mpt5S4Gx7Y3rd4KVLqenn+zM+WcIgcsvnM6lJQgIzsXEMf70Ri63tu4P6kf+MrWa+IkJkQk7psjC7HWARwMptqOaJhpHzQeCl1b20UIXILPZaJxQndVcOo0JnbtCW+q2H/9ZF5sEycGYWbemQG/S2Sth7+cVKewzLmTdRAbMZwCtEmd/ZaVae2+L51LWQjoweXv6GKmMPwkZJhJAItORwrDw86DrTvVGzJj/umSrlhtQbSRQ2hdIaz/CqmRPPX42m9T8cXYz4rATHr0MH2vaH7kPiRImrjzB4NlnTKuA5a34uPDvZ8Q8daWAHoX3Zn4pgHlTzNU6e0xrN+SC4WLq+BBIEht3CI94kHn++P0lE0TUGp4MO1JbI/rr0zI0M7r6zXECDF/VMDiLhoB4+LdG4X9dwul72CD/D2A5YYIO2Cq2ILMJQq1vL1GP0RZPo8+bK9emqmqJBAd/zo2wVq4LkmiKEkbsGohdYS3DunpViCPXb6J1S6jAS9yB65h6IKkObbcsDJbhjKEBwHRI7fjc05mSl1clKuSRWjC2oTCiNDE3TYkMvrsMgeg3gADHHorwn4CQS1lOOkY4PNFTQsc4rfhZd5OLsFttSFVmoKo7Pnm31eF93wvb5PPIqgtgMLz50oofy7TPUjhbS8nTVT74BkC2nDVAIzgsKXk+VBJD61aAUkClevAooh+KegtprmGTeyAQcPn9k+i9jj6b3R6f9l4bEnqWonVk2bZ09rCicLUWC8l8tATnOHDqpFTCtKbZwVFxcEdNwOl7kp18n2mVbOd975ExJ bM40avcO xhmtjjD1y2lcEwDsG/b9RHjGpkxXyDNf2YmfZTyeAktGZ0MQWaf3Iq8VyBMf1msVOwkBlr+mqqw9pEciw2AEk8EtSIr7rgHzFmmrNoOz3io4KkwGVMXanPBG9mdypoN6uguZddWN1L8+1rtiwOrggYU6qFX+2Dr6UGEYFFSX1xaxrmhPWvcGAhtC0alhc9sCRk3XY6XFGNdxg7HMyFDyLUBr3R+prDPDvmiEtVgXtqjz1MQMQSlm9OWHKbqSjf68colScBlzNRmDQZGW6V4hbVmRFXmz6cSM7Rogz04FtfAkifrzzww8LVOIgszwljYO90YGuDkn55PLRMlqKk/zZhsn88MpujRcPcmTDoNTYUeA/nPaFSpdMxCyI3+5yuTIPSY+vCMZ3EUxsfH80TrmfUE2olCX52tfvxcS75hhpEWsrMdG4eA1zF6TLDeuwszk0LonId9T8XZk49dL0EQxl+CcTX758CgV17TMo4uYAy53F78/zIkPByOM1VW6OI4RmQBvUBx11/pi0zFh9vB/KTV3SylhYPOhdxZeTENf0QgSgwvqrvtVeX6Amlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: + Liam, Jann On Fri, Oct 18, 2024 at 01:49:06PM +0300, Kirill A. Shutemov wrote: > On Fri, Oct 18, 2024 at 11:24:06AM +0200, Roberto Sassu wrote: > > Probably it is hard, @Kirill would there be any way to safely move > > security_mmap_file() out of the mmap_lock lock? > > What about something like this (untested): > > diff --git a/mm/mmap.c b/mm/mmap.c > index dd4b35a25aeb..03473e77d356 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1646,6 +1646,26 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > if (pgoff + (size >> PAGE_SHIFT) < pgoff) > return ret; > > + if (mmap_read_lock_killable(mm)) > + return -EINTR; > + > + vma = vma_lookup(mm, start); > + > + if (!vma || !(vma->vm_flags & VM_SHARED)) { > + mmap_read_unlock(mm); > + return -EINVAL; > + } > + > + file = get_file(vma->vm_file); > + > + mmap_read_unlock(mm); > + > + ret = security_mmap_file(vma->vm_file, prot, flags); Accessing VMA fields without any kind of lock is... very much not advised. I'm guessing you meant to say: ret = security_mmap_file(file, prot, flags); Here? :) I see the original code did this, but obviously was under an mmap lock. I guess given you check that the file is the same below this.... should be fine? Assuming nothing can come in and invalidate the security_mmap_file() check in the mean time somehow? Jann any thoughts? > + if (ret) { > + fput(file); > + return ret; > + } > + > if (mmap_write_lock_killable(mm)) > return -EINTR; > > @@ -1654,6 +1674,9 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > if (!vma || !(vma->vm_flags & VM_SHARED)) > goto out; > > + if (vma->vm_file != file) > + goto out; > + > if (start + size > vma->vm_end) { > VMA_ITERATOR(vmi, mm, vma->vm_end); > struct vm_area_struct *next, *prev = vma; > @@ -1688,16 +1711,11 @@ SYSCALL_DEFINE5(remap_file_pages, unsigned long, start, unsigned long, size, > if (vma->vm_flags & VM_LOCKED) > flags |= MAP_LOCKED; > > - file = get_file(vma->vm_file); > - ret = security_mmap_file(vma->vm_file, prot, flags); > - if (ret) > - goto out_fput; > ret = do_mmap(vma->vm_file, start, size, > prot, flags, 0, pgoff, &populate, NULL); > -out_fput: > - fput(file); > out: > mmap_write_unlock(mm); > + fput(file); > if (populate) > mm_populate(ret, populate); > if (!IS_ERR_VALUE(ret)) > -- > Kiryl Shutsemau / Kirill A. Shutemov