From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49536C54798 for ; Tue, 5 Mar 2024 15:32:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5CBC6B007D; Tue, 5 Mar 2024 10:32:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0CF86B007E; Tue, 5 Mar 2024 10:32:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFC746B0080; Tue, 5 Mar 2024 10:32:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A1AE16B007D for ; Tue, 5 Mar 2024 10:32:58 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4AAF2A1420 for ; Tue, 5 Mar 2024 15:32:58 +0000 (UTC) X-FDA: 81863378436.19.D2B8A1A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id E84E2C001D for ; Tue, 5 Mar 2024 15:32:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UqD4YlfY; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709652776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H4WKXO6HRBiCO+Jm9cr0kkJOy4F8udfhngxHNNpjHJ0=; b=iGsAnbAL454PXdZzm9N6C5KYERdQg5Ga+wuyxeQqe1REpryVahEYtk6mAXIV+GxdW28jpg ScnakTmI83knR1N6cpa2u8jrci3GdcEGmiUGx1Bcm7TqUVyr0Avl496ZEvKGb30I0GROqC V9cfJW+BQRsfH6KANodELiomygsqWi8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709652776; a=rsa-sha256; cv=none; b=qZAnHzinai7eGOhJ3TASj7R+ZjCyGbzJeRL45qxIYuEM/69eR+UJBw11WHPBuxUrG14KtU QBM2IlopDhIu3Z6Qm1aqj83R8Bg+4tiXekya3foeS+PqAh2kVLwNtOY11XjCwqEgqTCpVT WkRm8oKJ8BsSRo4sxmO+C8X3joTTfJc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UqD4YlfY; spf=pass (imf22.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5C87DCE1C5D; Tue, 5 Mar 2024 15:32:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6520C433F1; Tue, 5 Mar 2024 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709652770; bh=H4WKXO6HRBiCO+Jm9cr0kkJOy4F8udfhngxHNNpjHJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UqD4YlfY7IpEXvGZ8UgwTFpEOZlZXAXICdaUzn/gFSnHUdAZc+RwtBMFppFXWg96i V9bPAh30pzAdrigUBAy/ZcK2aXV8ye77tYx91ZvW9+86QEOi/cv0aHIVtENmltKVaS Z8NhOlzUYHIk4BoNZtBu4syIVaCZB+qLLwrlRuaz1EVsXcp3vys6OpAiHeKbuyZBpm 8d1OpqIFOeShzAUdOMWf/J2n7LySJv/SFE8+W/hj4X84CnvSBwnRkjI2TFnP9TGlDg AuFDPV2vqDMFUePugPd/T1mmrHY1YLK9W4noaNsucvhUq5mnkjIwVeEFuNWggwAwLS 4f5aacXcfCYQQ== Date: Tue, 5 Mar 2024 15:32:44 +0000 From: Mark Brown To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, ivan.orlov0322@gmail.com, perex@perex.cz, tiwai@suse.com, shuah@kernel.org, jglisse@redhat.com, akpm@linux-foundation.org, keescook@chromium.org, linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next] selftests: avoid using SKIP(exit()) in harness fixure setup Message-ID: References: <20240304233621.646054-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6/TVXBM12eZLqI3t" Content-Disposition: inline In-Reply-To: <20240304233621.646054-1-kuba@kernel.org> X-Cookie: Ahead warp factor one, Mr. Sulu. X-Rspamd-Queue-Id: E84E2C001D X-Rspam-User: X-Stat-Signature: 76917nrhjao83x3jxs1wj7uwwwttd6fy X-Rspamd-Server: rspam03 X-HE-Tag: 1709652775-56107 X-HE-Meta: U2FsdGVkX18Uc6Csisq58va5HmojxzUS/XQ1Ap7tvst539QokI1agkidmOWpsKqkgkrBayTw0K4/3FYDyr8XiMjn6Yo5Yzfw6mAtpXgWgEILDU8vb0p5pbiJArIomVTCks6I8cKznIBKPWvI0eQOd0tmMWlwFluO3GALnWQyCcT4/ym3rTxuwPO1Pr6VpWxnRgG8ayA56pAnw8mATQ9YeqK9W1Dn1NOGD0bpujO3CGCgr14l8DSp1CjIK6LwPMYV/u+7cPmTBt9Ia2R62bprYbYg3BmHpvZIuuXUGLHAS2aH9+2O5PdfhnY7kk81cq6gZ/KnPGfJf6Sqh3prjNDUcG2dadoGIdPbv0h2bPSpVcGtgAGID6XuCliGbmtgdY6LBhTJsCv5EfQ6hDSYKlwUliFKrBtMImSQ7DvRVNEzVLvsyf79CA9q5ncSB4HgKMKAH/U3D2R1pmBDs7a3t9qEZedGRPoGrDNxYS2agIM+9wd3P1h+gOJAaY6j1Aq9AuHB/6Jf8ZbYl6AK3lh++cMYV5o6BV6XHBvsZ+33pIaiYVgZ9gsbqDe3jQg9V5qq+EbhHR6CBY1UOzQt0EDlRcwN3lGAulwViSXlIzqQ5JrcCfnSO4Hg8+ZUvGdwf6JHZhbmXkzevcqtgjBFaoG7OBYUlwN/cSxzYuBf4dKHLqzABDNfjqQAH6l2NncsWYKIHNB7Ik2KSNvuScockR9us8wNaiSTuzOW2prWvceGh+AC3+I1dZc53NcBR5xN8NcUIl0S3hoVu7tFk7dDhgCeEj+2hurCi1DrSXVroS+fgWCZtu8vruL35CTxn5p3FLPwjlrM7/k85gCG9Eptdn+77DAPAkm8xuE7NmMRpFKSi1fBgymrKgbLjvfH14Zic81xLBOQIkYveUveey9pI7wcDkygqdtGVF/x1T+noVlnDWHCUOLt6XVE+bKWNbBZSincu5cT8YL1jQDQ86MxCtBDk5j +2qey7l0 d+enZ0XiYg4hE76pWXLPblImXbpHo3f03MXK4nhw5LFC9WKlWF7Pz7ifmz6Pm0zYxatdL2d+bTwHZMwy2TDAuPkYAIfyL9Qjcw/Aa+nq/6++yNx7n0Tw/YC/y68VaPuH6x9qtrJ6CeoDsjMUh/InycG/nG0p8OjrN9IdA8JUwqIHQcL/AFjv15AvztJ6lRw3h4/BFe/5dtuDl6Wnjf33V4hhsJBlMKfUqsOEc7B2M0hyW4LvyUjwj/exEMM/9J3f147pecBKicsMxWwKmhHUfA0y25h3PRfM/o0XjfYXq+UNf6msWM6TSejkzZWepTOakqBkBA9kO+FbVKIZ3SdbVFj82iQoN5Dx4Dg5an9gIgDrIenysVFweZ1FZED5/PahGwkTCuior2yJjqGM3V4tgZUY4gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --6/TVXBM12eZLqI3t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 04, 2024 at 03:36:20PM -0800, Jakub Kicinski wrote: > selftest harness uses various exit codes to signal test > results. Avoid calling exit() directly, otherwise tests > may get broken by harness refactoring (like the commit > under Fixes). SKIP() will instruct the harness that the > test shouldn't run, it used to not be the case, but that > has been fixed. So just return, no need to exit. >=20 > Note that for hmm-tests this actually changes the result > from pass to skip. Which seems fair, the test is skipped, > after all. Reviewed-by: Mark Brown Tested-by: Mark Brown This fixes at least the pcmtest-driver suite. --6/TVXBM12eZLqI3t Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXnOxwACgkQJNaLcl1U h9AzHgf8CS2NurGGG34xASpGL/e5wwpiuCpZF4zkh6Kixza35RYYIn81k2gVvrYP lbsfY3vaG3KSz8mxAyZKthtfXJkdS0sg6qa2m12LapPhczwMWardH5znv3Sti5G1 7JJNz9t1WBKd1P9Cv5R+1RUR9Iq5Jeus/Te+yRuSlBJuOj0HZz81zSZKy9QlstfC mWcJO+JKLm+tsnKB7CsYc8adHIP85scDGFp/to6k4Mo0okSkvslyTxW7Ew9ZDUXd L4J2j/DHHJFmJMMk7TgbsNaJMrk4ZccfVJI7ZHBgFSONwi/QrmfD4DPv6j+ARlJz 5HX+/Stgl8tZX3fr91jPNzBgMczkBw== =2N6s -----END PGP SIGNATURE----- --6/TVXBM12eZLqI3t--