From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE2ECFD30C for ; Fri, 11 Oct 2024 10:12:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89E2C6B00AE; Fri, 11 Oct 2024 06:12:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84CD26B00AF; Fri, 11 Oct 2024 06:12:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714A46B00B0; Fri, 11 Oct 2024 06:12:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 51A696B00AE for ; Fri, 11 Oct 2024 06:12:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5C731C0FBD for ; Fri, 11 Oct 2024 10:12:51 +0000 (UTC) X-FDA: 82660907868.17.E9E0341 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 781D7140021 for ; Fri, 11 Oct 2024 10:12:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dXdq8yye; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728641503; a=rsa-sha256; cv=none; b=OQP86yzHX4QVotRSw1+1YC6qSbhWFmh3rk3jWg8mvSY9AbxvGOUbL1ZgHOHjNfzwhMJQqG QCfpCpvE/alTUROC3s4s7RqHN3pI9SlJU4I9/BAbN6ytdm9fiIj2FWz9DjMdg+TtNEDBeh al4GrfuozAx9tX08dLqYUDGzeKEh+tc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dXdq8yye; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728641503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WQWsLiswUAEolJ5Zq+g89OXnK9lDNhB/HZWV87yKp0E=; b=YxfQ3f1Sde0YN9ox0VIbfvbgd1jiOC05p0s9L8ZXRxK157Trxubgg7pymMfDCTHdl37wRU /NW4j08xNAy0Op5mwGUW1TrZWVtl27/Q+c+vxiW9QLs434zwph+Ia+FPfaSdA8P4TXXM+r np9U4UcGLw8hgu40EraSUP9kBFiqMyI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728641573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WQWsLiswUAEolJ5Zq+g89OXnK9lDNhB/HZWV87yKp0E=; b=dXdq8yye7vvpG751rRYOg+ZJdILsjyarBxQMbb6w2/DuE7XEwRpkpPpTdGreGxATYXEtp2 s9HEqjFXltKpknpeq1r7lMijH/2Nt1gGdIUA2NGwNYgaFRBo96KyZUTkcXP2gf97bonDYH 1PHFhue9ylr9U/5SPWtm7vfLFTF23PU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-apkN1n1rNQ-8Lstat7fXsw-1; Fri, 11 Oct 2024 06:12:51 -0400 X-MC-Unique: apkN1n1rNQ-8Lstat7fXsw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-539944cd95cso1600652e87.3 for ; Fri, 11 Oct 2024 03:12:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728641570; x=1729246370; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WQWsLiswUAEolJ5Zq+g89OXnK9lDNhB/HZWV87yKp0E=; b=N2HR5sisdxyKG7inw3PuWzqxw3s9ZijMYumMJVN84Ol9S5fQfXre4Rkn4Jl0XNJXhu U2aabur+eeCM1R3R7X1Srb/qmRcxWWZbFytpA2o3oUPB1QKIM2YO1H0nswvGS708mz7D iSKFPEu/fPv5Yf9j91oebHhquANaT4mJ9w9SAT6hr6y47r68UxmAC6wj9x24lEaDQiMf Wud62uvhnaCmOy+/9AMgL4jUdv9k6sJ8GcY2G5pTggwhkxY1Yf5zGjYnrwLFAuj+Ipcl x8Vp9paWLS+ZycdYWWx+hwQrFDHxHMjI3YcGutCWTdyntwxQzj1KTOhYXRDotn0tM2Km K6rQ== X-Gm-Message-State: AOJu0YzmiinLzFgVnOBdHRfVX+WW4BurLaU5IbxZMOVS6simJmyfTqGW u9a93x9Go1tGMQO+fth/z/92oe4qt7lctWZA4Jgl/geoz8za0qIi+YCOM3c7UWwqzuSuAAB/7Lv Ry01LO6NJWZnC8ICtjPCSxojUSQiVuPvHxWUVN62/PMrmAEwV X-Received: by 2002:a05:6512:12d4:b0:539:a3cd:97ca with SMTP id 2adb3069b0e04-539da50f0c9mr1054409e87.36.1728641570301; Fri, 11 Oct 2024 03:12:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFN+eYs3u1dWQ+McbGmavTYymimZPrm22yBmTSLd/38O6XNRnZ0tYqOCLDaL1+Rkdsb4vOoxw== X-Received: by 2002:a05:6512:12d4:b0:539:a3cd:97ca with SMTP id 2adb3069b0e04-539da50f0c9mr1054357e87.36.1728641569770; Fri, 11 Oct 2024 03:12:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:9100:c078:eec6:f2f4:dd3b? (p200300cbc7499100c078eec6f2f4dd3b.dip0.t-ipconnect.de. [2003:cb:c749:9100:c078:eec6:f2f4:dd3b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431182d7934sm38293995e9.3.2024.10.11.03.12.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 03:12:49 -0700 (PDT) Message-ID: Date: Fri, 11 Oct 2024 12:12:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 1/4] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem() To: "Ritesh Harjani (IBM)" , linuxppc-dev@lists.ozlabs.org Cc: linux-mm@kvack.org, Sourabh Jain , Hari Bathini , Zi Yan , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige References: <8579f887412720bd6f2fbce513c1c9904772ead4.1728585512.git.ritesh.list@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8579f887412720bd6f2fbce513c1c9904772ead4.1728585512.git.ritesh.list@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: b5qor9q7zcb5aa1iq476d71cpkiq7kis X-Rspamd-Queue-Id: 781D7140021 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728641572-706409 X-HE-Meta: U2FsdGVkX1/RB2uwRSLwgrXU9rM4riCClE7jM6QU93POTR61xA4agyuFHhdxledcSdvJwzZooZcNoWbuPxIdCMscCMjszfwAkWqBM+HMp/F+YrqdLopp0Gr8Glc8M+qxOzi65sceur+fuDAsk8+MIzUzMqlumRQpl5N9eyDBHzkhv+AlOgqMJYR+9P2GoUbfAeuLbpVfLirM4TxCx+wR2XsKae7wuPRguuRYIBpOuKClGJx93sVM4kCsc5+SqEMmB/kszQW2ATMOfDQlc254HBZKGV4i+fiRP3U3yrnko8oMRwWFwWm3sAacjnf++h/fCHZC1uVOAxw9v6ezzYRedVoHqx9XwPHd3rxxk4b4u9gD9uBgaHc2urAu7XqPQc9KHHEi7Kwj4ADRL8LTtjYJYdLGdht7BmR7O9LCbm0ldqVr/LQ/8329JRxrdwcInf2luqRmXyCtBedf7hHmLAbuqaHvaxhtjeO6UTntMEeYqRYA+ndZTwYXZBSso/q8GnjVo7HZk/WXxskI/aQdYixxrRvPsk7TPa6P5FuhHpmp+1EuPI6zyN+25kldVeNAaT/SoUSFxCX8S7/MCOdZkS649VAl2lnjBp/yLYmwi0GrFlrvUA8KeXZ1NktOg6fSmOy63ELblLY1HTQahUNl7oWEdHuUeDwdHQTBmCpOMROJqa7kGfJ783FPrymU11c0/eHJufv6FIvY7a+MZx1aKaT2133Vol/sHeA2JZiOkXkRCsGFqrzOdCd8TT6zsmISdA3GTSAU9KrjjTNoKHEFGedGRDIBbrQ/8yig+X4XV4AHv+sXgkk4mBz0P+g/69GiZ8qM7hybbKjiXy7JlEo5I2j/hyyikclDuEyZg7WYlELhg26bV8zZBzWXi723LRf7PyJ+xjs7bHJKjHq9/ELeX+s5ALEKJE+zbelYd6BKqsr+wXd31H09OehMaXvpfObhHp6uvuQPj3PdObzU12CY1cf E4XGfRDG OtVwnMRMnkgpz4WYu6wofR2IolVwqiySyvHD5U8KhxCA8/ZPqknCrVSU3XSPxeNO/P/d5Z6uT7uOStYyIYMIIGbWXH94n0lafZS5l8y910i/2vH+PDeM856S2CFMMmqEPeN1qsrff3G9vOjI0b4JCjvwBky6HrjZ+ycx/fzM/2WkGADcYQkQhtwmc6yl28uNfZsK437iUVJoPGszqVD0uvw9lUIKfSPWo0NGkelVzVDNTKYjndD/4JLxsKqc7+UjxKgPSPoOWWRdV3SblM+u3bdAuo5vjFLYH02xJKACpyn9NgIElBtGHR5eru2hAZTmxpOM4Wy3ELRgnht/JFwSSaGPadcRduM8cUaoKzB53mD2PcgnKlALwcB9qua2n7jLgltLdTJOaTcaVJvJCj3taEaD3Vhuyjq3CD2mGW8vG6CcLwtnJqHOYDsSO3wQy7GNzpOIbpQMlu3Vjkc0eL335RuvH/Mqj+sbQv2TXifaGND5ZnKtWs+MY94AUAYRLrZmtlOKwoKeaxdipp4BVlhFgGDbaK1cX6kNgxAl/haxnY8w91GSIqJH+ogrFgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.10.24 09:23, Ritesh Harjani (IBM) wrote: > cma_init_reserved_mem() checks base and size alignment with > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > early boot when pageblock_order is 0. That means if base and size does > not have pageblock_order alignment, it can cause functional failures > during cma activate area. > > So let's enforce pageblock_order to be non-zero during > cma_init_reserved_mem(). > > Signed-off-by: Ritesh Harjani (IBM) > --- > mm/cma.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/mm/cma.c b/mm/cma.c > index 3e9724716bad..36d753e7a0bf 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -182,6 +182,15 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > if (!size || !memblock_is_region_reserved(base, size)) > return -EINVAL; > > + /* > + * CMA uses CMA_MIN_ALIGNMENT_BYTES as alignment requirement which > + * needs pageblock_order to be initialized. Let's enforce it. > + */ > + if (!pageblock_order) { > + pr_err("pageblock_order not yet initialized. Called during early boot?\n"); > + return -EINVAL; > + } > + > /* ensure minimal alignment required by mm core */ > if (!IS_ALIGNED(base | size, CMA_MIN_ALIGNMENT_BYTES)) > return -EINVAL; Acked-by: David Hildenbrand -- Cheers, David / dhildenb