From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBD7C3600B for ; Fri, 28 Mar 2025 01:27:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4A2280126; Thu, 27 Mar 2025 21:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7410280120; Thu, 27 Mar 2025 21:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91747280126; Thu, 27 Mar 2025 21:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 73E87280120 for ; Thu, 27 Mar 2025 21:27:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D4D491CD03C for ; Fri, 28 Mar 2025 01:27:53 +0000 (UTC) X-FDA: 83269223226.24.A883AA5 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf24.hostedemail.com (Postfix) with ESMTP id 06E1218000A for ; Fri, 28 Mar 2025 01:27:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DYQfKvIi; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743125272; a=rsa-sha256; cv=none; b=aQT+K44YzVSygnudMUI7tiYug8Aqn4F8n+n0AECGOSxjpB9bJkm/BAQ7fjpsqZ8H8PjbFB tisdnvkpYXKZDx7I0TZsoA1J3h1xv4NeiwecBC+gbkEf0IQi1eReFSGnw1FzHqYbu52JsR EzPuUAFpNSSznpttsIBxfe2aMWmoNik= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DYQfKvIi; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743125272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wE83imfpv4jYwyzkj2RZFMFxxi58igB08hX6SRTGFRY=; b=qZ1O6/Ur/7V/JhzgYjpeLjWfw44dZb3d7wyw/Mmbuxb9fCILx17H4sccW1wXlAN7erivgp DvT4xyd3mUCCxh7R6FkrARCllwTAJBrQPREfBqAXdVqQI0apBwgjVUMkdi6xdE1wkhJXe2 /tOnEMREny14e++PKiVdMKckFheqFcM= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743125270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wE83imfpv4jYwyzkj2RZFMFxxi58igB08hX6SRTGFRY=; b=DYQfKvIiwYCt/XH395Ge1y/3Ug5CF84ZMPDealDlsFFbndHOVVy0wzpR5ngurQhutoicjh W5x91E1mH33HOuDhWVtmcDV/IFWGYdUccl4kWzTrLbMJ0/V5m2Zq/CWD9SdZ4JKiKTEG88 6lONkmc0KlmfGX/Nmhg2O17T2rQ3xZY= Date: Fri, 28 Mar 2025 09:27:44 +0800 MIME-Version: 1.0 Subject: Re: [v3] mm/page_alloc: Consolidate unlikely handling in page_expected_state To: Markus Elfring , Ye Liu , linux-mm@kvack.org Cc: LKML , Andrew Morton , Anshuman Khandual , Sidhartha Kumar References: <20250326011752.917564-1-ye.liu@linux.dev> <0ceb4ab8-adb5-46bf-98e4-61a1bd908e20@web.de> <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev> <49276ee6-6eb5-418e-99ad-3ed9d3e82414@web.de> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <49276ee6-6eb5-418e-99ad-3ed9d3e82414@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 06E1218000A X-Stat-Signature: 8iaqes36kc1exqixfmt1pt1wqqa7sfb8 X-HE-Tag: 1743125271-991804 X-HE-Meta: U2FsdGVkX1+FpK2Vy/xFe68UxX+YF18JbNzON9qm5cnlgvFt5TJhM0DCuBuDom0phcAfi63htXFYf4D7gX6crM3bEgCG612xKLBKHK/DWaOhs1NGayGz5p+Hb9tHPDN5kC51JM0BfEZYnYBtRE6ytQuXyqPCPZZR8xb9F/F+sE6dGKilrQmVTjl3VVF/ZmG3elQ1aFlwYe0udqYBNaobAo4xTajPDK0oh3sWhX5A1zRCXdsavksy24wCO5WKtwrG1pkLxqx33YQ/AMUaD0C0qiVhpOeFYeWjfU2zVoKDKjIgorEfutbMxaigOtuLQAYq6eS+thESMj/NOvZkxA2LAS8VSF2v+TVpqILjgpKn3RcJLLXGKaqItjQIAvS6TUvq0nigXVlNnl/zkOtOJothL6ce+mO8cAmBmhNwg9cAtIsCMKvsuf/Ir9xAJ0SRckTecnextc1fySSHFPKZgfP13BM2uqPenmZ/iV+G3gZP2vfky/1yuc34Qq3RlGY8WPlTiCG+0ioQ3EyBhgvqEuUHAGCEul/edt0KgjxwnthJnJCxfshQS3nY5lt9YkWlLsPc1jbMMG9OTe8j5AsA65CH+1XHKwCfHNNHBNTUT6V20CsATUCYVUhR25lDqGMiKglTsaHAhNNxWD96gs06x/wQWqTgCAvrg5+Y68yXLBPSeDha03RKxAa+sN706Ry9neop7MPIQ7Q4Kzkc8tDYIb5WJTn4JtC092rBbwCBEHoZk8DdIaAVqVLAJuajurD6iSM/J8OkQoyRGogljXVi7tCPmEyjfSn9Vm3gqQfgOm/mH6mBndgQE1iz1Tc4a5rzvctUs22YXEJ+CI/ANRgFAN0rPX8jQ3T5FowlCG9fiZCGvTjNKIk7mysjQKxKccmim2dEGDyYRb8ruBdKtnbotkWxFS1F1BbY4iPQ7JftvpTY2RroR5IWNL2bJ76Y8SPv+gbcVUUkgY4iEPsLYVr72gM Oll7ztcS X4W2PTf4BaHqfB1FwTDDT9fNlEp/uZEi0cHsixFvh0dIj9vZ/CZYUrHXkkHb1WGguAQ2geYmQDfZS9nTxjNe+OUL41V9/lR+LFIbpafKYOeF4ccoC73Z3hVUMKXm0IgSMzgmWJNOR4U0yujOK800pBkH7lqYkyAPG8CYofoZN+LtYveihnxVYtIxUwYbqIEhjenjzYD/96fxSdEt5rfAgv1Iz4taz9bXcQM0igsaTyJBoS0OHELHqd8yE1+ZeVPKaSJnOIldY7qnAygGKdAnQqsBN7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/27 23:05, Markus Elfring 写道: >>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n94 >> How about this? > I hope that such review can trigger improvements in change descriptions > for further patch versions. > Thanks for the review and suggestion! I appreciate the feedback and will improve the change descriptions in future patch versions.                >> Consolidate the handling of unlikely conditions in the page_expected_state >> function to reduce code duplication and improve readability. > … > > Would you like to append parentheses to any function names? I'll adjust accordingly. Best regards, Ye            > Regards, > Markus