From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB5C1CA0EFB for ; Fri, 30 Aug 2024 10:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A3866B0104; Fri, 30 Aug 2024 06:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 554276B0105; Fri, 30 Aug 2024 06:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41BCE6B0106; Fri, 30 Aug 2024 06:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 24D636B0104 for ; Fri, 30 Aug 2024 06:18:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6C46120E4A for ; Fri, 30 Aug 2024 10:18:17 +0000 (UTC) X-FDA: 82508511834.17.D68C269 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf05.hostedemail.com (Postfix) with ESMTP id F0576100012 for ; Fri, 30 Aug 2024 10:18:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="N/fqXxpG"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of hughd@google.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725013029; a=rsa-sha256; cv=none; b=1rjaTFiyHPdwhC16dx+5GBqJ8ljtPdIq1olIIphs6XBkA/ReaNw1WfdDPg5Rw/AkFxVVUJ 818xJUemjquGebc0+Dz0its6qndEy1cPweQ/i9VJJXBzK7yHnO9VyYkkbVSk14hOSc9MtX 6SgzYLZnV1f+ntv2t81SpezVk3CaG5U= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="N/fqXxpG"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of hughd@google.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725013029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RhjXrY66aQqjBoYOxAvINjNegNxb7ZOaXewyBkVrXPY=; b=jj74pphzb+2nH4Jhac+pqkO1C2fJWEBC8zkFD7Bu5pScH3tm67W/xVjW/PkTpxtsGCs4Xm tj3vqYtiM9fCNvvM5hbnrD+eWVb4t5qAPpb9GBm+N8TVtbc5Rvg1Uz1cNR3O+8BNtVI2Yk N3CzVYL9Qo0owZWL+SVgjHVJB84nAkA= Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-7bb75419123so1010768a12.3 for ; Fri, 30 Aug 2024 03:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725013094; x=1725617894; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=RhjXrY66aQqjBoYOxAvINjNegNxb7ZOaXewyBkVrXPY=; b=N/fqXxpG4IiMbAuOIummVrSn9boyDVsxhy4XJ34WZ1YwCboFRg3+u1xVw1DhbEgWqA y9xBrL1815nljzDF6RhWzvvZ+OeLWMu0883nUpH5LX1OXYYjaqHMal+q8mxnzREl6oH4 7tPLqFtTvAbt9OVcRrkmfciRTmy9DFKUa4HC0rxVqjEl9SqYyFVrvFvrtF7MrigZb5ZV XkGp4xdpTd7hP2+BncsxR26k8yA2rI08/kMUCXEFKvhkr7npsWSG/PBn2ub/yn51xb/r 8oLSFxbEx/joSHhWTkowHGGBRm2a98PJN6ZQv7Rq2M6Jhr3x6RTWsrsYhSUr1gHT29jL F+Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725013094; x=1725617894; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RhjXrY66aQqjBoYOxAvINjNegNxb7ZOaXewyBkVrXPY=; b=PXDTZAAUkfY3nv3otpZ0dV4oywMef4Pxct8MwWhWABXuBiUIrNqB8YOMfKEiWM402M XgSo2rnCxg6N3iLbR3WDeFHTuHN9slrUe5yne7CjiwU3qDBZoK4dEj0RTGTaXvkh2AnJ /UumVXfWk8MDpGj6PA4ovA49ez0rIS2+IQXptDA8yPpMomOFYnOcvap1BM2jSl0FIvZg NkHn04QAK4WmYh5Yo9MrooZ3lNDLocOAM8wSCfAhLf6Sr8id6xcOqtkOLc4tOz0EAoFC DoFCRGwkEiE2616TR1E7p6oPIG2kO5Os/u/5Puag8p/yTBlGHoTdR2tJiXQDDZ8hWxnx v0sw== X-Forwarded-Encrypted: i=1; AJvYcCVfYCLCqsvwuDVd0x6hPYOxWsZMptngxksjs17tRNTLECwvx1eponfTn8Gtz+01moLo81nxd4b9tA==@kvack.org X-Gm-Message-State: AOJu0Yy9Zb3HQt/RX39ABNIdxnfV58QcdCkEPnKmtiqAk3hbd9rLXgdg fkv0pQhTGBMpTW1uwRISOfc82kIqjH5116aCx7ucgPLMxRFmaZ/lg/AVt5yzAg== X-Google-Smtp-Source: AGHT+IESiNr+ViFs8CZa9rAsO5YWji9DJdOcgxH36+ht1foL3djmeL/yUo6l5fw66rlGTYuFv4zHzQ== X-Received: by 2002:a17:90b:17c7:b0:2d3:c089:84b with SMTP id 98e67ed59e1d1-2d8564cf3c0mr5704198a91.29.1725013094189; Fri, 30 Aug 2024 03:18:14 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d85b39d03asm3372089a91.43.2024.08.30.03.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 03:18:13 -0700 (PDT) Date: Fri, 30 Aug 2024 03:18:11 -0700 (PDT) From: Hugh Dickins To: Baolin Wang cc: Hugh Dickins , Andrew Morton , willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/9] mm: filemap: use xa_get_order() to get the swap entry order In-Reply-To: <3c7e4800-ec9c-4288-85bf-89f3fef18827@linux.alibaba.com> Message-ID: References: <6876d55145c1cc80e79df7884aa3a62e397b101d.1723434324.git.baolin.wang@linux.alibaba.com> <3c020874-4cf3-418c-b89b-4e6ed158e5b9@linux.alibaba.com> <3c7e4800-ec9c-4288-85bf-89f3fef18827@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463770367-1789196680-1725013093=:16809" X-Rspamd-Queue-Id: F0576100012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ejxqu3n4hfaiynommbywpoxbryib14ee X-HE-Tag: 1725013095-809823 X-HE-Meta: U2FsdGVkX19x5ZwF02fKQ1na0IqjmFFbVSplEzeB/4cxS+FdyPyjnmCUKJnf2Ztow4zVLm2WznBy8Hkvjk42bFcAJkl0vOxMVidjrxCxYGsywV9Jo6y/8cEQJqtc2RRc92X6o2jlUxKUfbzUPJr3uppChV0F9qde63UeaHgEqaczvq12B5YpvBkSFLIUaGz6sw1zj57FC2SwiYruKT5uMwc67UbUdZ4235VcE3MCQLTm+Z1h1fmKorB/11sBexMPVR1lHqX+DysMhh8w5LNDTGc58JvorAiVzVTBc/T8bx97M85YCttqyUaVMOYrrbdKEoufNEZIqJC/i+kJEg+nqn/zyZrEX+mTii4A6DJ1L11my8Vev5TMswv2a1Lv5p3y+g0iGyDffTcopkYgkc4jjGwa6Ubx5ZzTSkH6O/hrZu+AVhifAujK0QAExnzURuO2tcWaqFLmCqF2x7VDMHyWpZOY2Chi4exEM3nhPIyldZUueI4a2EmF8KBxl18jk/a7aHYsZPcTh1wwH/yh7z2kChhZvPmyykK8Y6OwXtT3vA7Xj/F7Ba3+G72BJW4VT1qAi98VbWXC0fqqvD+WgkSO+ylM1g4IN1DlMyWG7mkSOC0T1G7/ksCXs+Ow0gubzzSfQ90IEcofbFZzW1xofR95U3rDidkH9JBX+CV2O5F+jSR31H0RiVMmzc4mQTKDGULQ24021hLywm2HExR/IIA5pK/R7mQnj+WmXeFvuVRZjTU1OgAWyE2eaEtW6fVYnTaGFFjEheYEjgHjQBYXVGZe63zohbWjfSA0n5prtr/+xBxC3v+SwjdD6d5Ip4H9duiVXzu1b9bOtPB6JV22fji46X5UDmspyRhNBoUfyA++mkxdRFMazNGDEJv1ROnjpozZWqsX6X17tQw/R2ja71AQZMWdbIW3SVBn+HJf6vBqCibyrXVo3P1i0C0rxl0djT8GLaYWMEsaNjeSqh7OCMm JmLuzfQH 1OhpHN2NIteV0J89/u4FrpFlPdeokd710kZ43e0GOS94czrZnVFbLt7jcvmxFCqcZ16edfwfiRWuSB4EnXVdilClNeoVxx+SBgaxXWxOa6kl991dap0r49atYe/LPiPQdqfEnhASC0RRRUNCt9CNCEPcl60ggY3arWCU1gZB0EnjykotN4Mjd3FeGXDCJ4Yx1iDY2XJfJXgnNK/QsDuQGZTk+KgDslVaLsUpNO1pl280G+qfANhLsBOism6cZuAPHycjbtJ1jbxYMP4qZ0vLqiaX5PY5FEt8hYr5TCgEQ73nfbtwoykKjmEkwfMrqqiY8EIyOIS89qruQ4uQSswALja+n/52HuTMyy2x616Tx1b54pqR8F45/pRuBY76bqwGxQR9d34l6vAnE/VWqIk0Erm5OCWF738lhxGwGywy1s1xbF8ywXDeH8qNdFIYoW/qNGffcgwS05x/iAGpNO+c5yHvOLGTWHmdRFtcURM7gW53OeElWO+UW5z0QvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463770367-1789196680-1725013093=:16809 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 29 Aug 2024, Baolin Wang wrote: > On 2024/8/29 16:07, Hugh Dickins wrote: =2E.. > >=20 > > Fix below. Successful testing on mm-everything-2024-08-24-07-21 (well, > > that minus the commit which spewed warnings from bootup) confirmed it. > > But testing on mm-everything-2024-08-28-21-38 very quickly failed: > > unrelated to this series, presumably caused by patch or patches added > > since 08-24, one kind of crash on one machine (some memcg thing called > > from isolate_migratepages_block), another kind of crash on another (som= e > > memcg thing called from __read_swap_cache_async), I'm exhausted by now > > but will investigate later in the day (or hope someone else has). >=20 > I saw the isolate_migratepages_block crash issue on > mm-everything-2024-08-28-09-32, and I reverted Kefeng's series "[PATCH 0/= 4] > mm: convert to folio_isolate_movable()", the isolate_migratepages_block i= ssue > seems to be resolved (at least I can not reproduce it). >=20 > And I have already pointed out some potential issues in Kefeng=E2=80=99s = series[1]. > Andrew has dropped this series from mm-everything-2024-08-28-21-38. Howev= er, > you can still encounter the isolate_migratepages_block issue on > mm-everything-2024-08-28-21-38, while I cannot, weird. It was not that issue: isolate_migratepages_block() turned out to be an innocent bystander in my case: and I didn't see it crash there again, but in a variety of other memcg places, many of them stat updates. The error came from a different series, fix now posted: https://lore.kernel.org/linux-mm/56d42242-37fe-b94f-d3cb-00673f1e5efb@googl= e.com/T/#u >=20 > > [PATCH] mm: filemap: use xa_get_order() to get the swap entry order: fi= x > >=20 > > find_lock_entries(), used in the first pass of shmem_undo_range() and > > truncate_inode_pages_range() before partial folios are dealt with, has > > to be careful to avoid those partial folios: as its doc helpfully says, > > "Folios which are partially outside the range are not returned". Of > > course, the same must be true of any value entries returned, otherwise > > truncation and hole-punch risk erasing swapped areas - as has been seen= =2E > >=20 > > Rewrite find_lock_entries() to emphasize that, following the same patte= rn > > for folios and for value entries. > >=20 > > Adjust find_get_entries() slightly, to get order while still holding > > rcu_read_lock(), and to round down the updated start: good changes, lik= e > > find_lock_entries() now does, but it's unclear if either is ever import= ant. > >=20 > > Signed-off-by: Hugh Dickins >=20 > Thanks Hugh. The changes make sense to me. Thanks! Hugh ---1463770367-1789196680-1725013093=:16809--