From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B81CC36010 for ; Wed, 9 Apr 2025 02:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDF7428003F; Tue, 8 Apr 2025 22:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B904B28003C; Tue, 8 Apr 2025 22:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2D2228003F; Tue, 8 Apr 2025 22:45:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8412728003C for ; Tue, 8 Apr 2025 22:45:42 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 38723C0D74 for ; Wed, 9 Apr 2025 02:45:43 +0000 (UTC) X-FDA: 83312964966.08.5CC0757 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf23.hostedemail.com (Postfix) with ESMTP id 8447A140004 for ; Wed, 9 Apr 2025 02:45:41 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jH6PQnQa; spf=pass (imf23.hostedemail.com: domain of rientjes@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744166741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BmxZmo58ew2ftJX5rQO9pW0Vz0g/TuLGaDlR2qDVOkc=; b=MzQmojkdOsQYPq7SBkXNmNTCt4oeNrYH1SzP6kT5SW9rYN9FM4hYUAvsvjo+cqwCsEKxRk wsLox7BegCVhYReqMGZ8B4m943AJQaOF6bUicdFoNJaX+BVdAx3QkEqUSaeg/HAlSTF0Sw JqoZUZRg0/nuDc3DzZXdDJOpWjvGIws= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744166741; a=rsa-sha256; cv=none; b=R4Dq4JRJzop+cpmw7EuPxU0YTDFT14HQ25AIOUZ0wZaEMhC7Qfx40YygSbFBUNw8uq3TAQ FaEHba3h7f97uMRIOMcrJPTWFHTPT3pDYpVbkLrg7VW+NVSNFt0KXmL4F3uFW4zYNkCy8U LotJdQKn/Zd3iUajuc86nVw7h0kZ3wU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jH6PQnQa; spf=pass (imf23.hostedemail.com: domain of rientjes@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2240aad70f2so117135ad.0 for ; Tue, 08 Apr 2025 19:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744166740; x=1744771540; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=BmxZmo58ew2ftJX5rQO9pW0Vz0g/TuLGaDlR2qDVOkc=; b=jH6PQnQaP9DYrArfDni5GETbAX6gf96MGOsdonl8hM6xdyOW55CMBKl4UNW+R3HnXy LBXaUe+y6zS/xSCMCXxf5RJRaUqsaRCBvLogvzTaumpaiualgCklU10u28LDa1ty48Qz BT0tRX8mhb/rL6abSh1N6WCiuuEGLixiEksfPjzSwk3E1iIlRH4QMrih5BNBi772E0sr NiwIGahAkZK6Ib6XoY5fFt7VV/5vQ8mi5XxMor7GC5uOjik6IKCGzyThivefn1VKxpUh 4Gcg/4ql9OVKqBqeFxULkxsby4N/i6d84z0Ms7V+DvVCxyqcKgFIkshh9dDrgfIAx3nH 2/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744166740; x=1744771540; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BmxZmo58ew2ftJX5rQO9pW0Vz0g/TuLGaDlR2qDVOkc=; b=tqSaXGA445IloI5zptfzi7+El2lugEbLOZ2NWHqwJautdzM40A44tiDO187KaUowFx b0Sblz/EQYWW9HORoLtmG2Co58jh/hFueZNY4iAZeZ7alDaUOOcyBLtve1r5Xd1SA2s+ eOArjCYH23z2iUNEyj58KgdBIOsu8/+X1QDo21GMlEDH0l+b5La1ic8CB/EUnf/x4TOM JEkHfRM/XA9zh9D/DWckvXj/VJB0Vuep02DweTXSN0sTwaoe6+gCnzvMELsVbCQvdgIz F9Nj3GWue3NKH1Vem81Ni9S7uyBv9uCLBHtKOO5yOX7xRv/28Jj1E2aH0krp7IQLl6sT qS+w== X-Forwarded-Encrypted: i=1; AJvYcCXVNZCJ3D4FHO/Z0E2xsSqetSSjCQZYAG63wZO+P6BRXQum5Ga9DkpopmY70UV3Kg+3iCMXhz5c9A==@kvack.org X-Gm-Message-State: AOJu0YwWVJF0NllIhOOcSAQl0hybU2/5ovVYIYWmO0kN1gVOkTI2Z9mv P+hps/YtnWFKI9/1IxKUYhu/vnIVTVuJveyFiW89ONqhmQmVyvIUs2jULqlBXg== X-Gm-Gg: ASbGncsEr1mw5ifAryc6RKZ1G224yDSav3SqR6PNLvkqSmF46dwwQ2rsVuo1MIQKXtD 6lJJVjmlsxKe58YUyowlU41GgRg9G9vb2D8HHqxEz6xqUc518MflaJeA9h/BOpBfX3DRHJlaP4q tWfE03ioUsShmBtcmf1XATyMguAm5XMeBHQyDTqPOf5BWWbCjI2/OZE8gVRFQ+pikZ1OXSS/gHv sL0du3PrdWuhIvCgaeAJZllzmOikkqXQ+YPQnWXKCcNuuE3ClTxhYTt9lLuRQFIXCqat84R0EO5 sPVJOfdgf1yZKN/ONFmywiFsSNPDo9IpgWnjjj6cglkPW8Cf4qvEQEk6biSiZZYyJNVzl2l3fgQ kT1JgVC0A/caEmmQBwKfhcgvI8zWFaUPGtjodSppX1KVmsM0tbg== X-Google-Smtp-Source: AGHT+IHGKKnGy0cgYxT5C5PTZT3YS7LxtLBeQ1iHVOfo1Mx/+lcNT4rzhCl/TMMtJz7KzkO9cYaULQ== X-Received: by 2002:a17:902:c211:b0:217:8612:b690 with SMTP id d9443c01a7336-22ac2f8f5edmr1353505ad.8.1744166739917; Tue, 08 Apr 2025 19:45:39 -0700 (PDT) Received: from [2a00:79e0:2eb0:8:75be:1e2d:e4e6:bd95] ([2a00:79e0:2eb0:8:75be:1e2d:e4e6:bd95]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb54cbsm598925ad.187.2025.04.08.19.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 19:45:39 -0700 (PDT) Date: Tue, 8 Apr 2025 19:45:38 -0700 (PDT) From: David Rientjes To: Harry Yoo cc: Vlastimil Babka , Christoph Lameter , linux-mm@kvack.org Subject: Re: [RFC v1 1/2] mm/slab: add sheaves_enabled read-only sysfs file In-Reply-To: <20250407041810.13861-2-harry.yoo@oracle.com> Message-ID: References: <20250407041810.13861-1-harry.yoo@oracle.com> <20250407041810.13861-2-harry.yoo@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8447A140004 X-Stat-Signature: 3tw9jxd6h3mcbbdjgk6rea3n9je6fcyf X-HE-Tag: 1744166741-154133 X-HE-Meta: U2FsdGVkX1+ausEDnkmO6V7ofOrwlBL72mm8JimpIsNmqyahn1824P8jw2vaausUaJ1NMgDcSXTCSb/ashZB+BAH48IVQyQafo6RZ2K+kVhS00KeUVZk0RwKoz/KisEnWxUIp+zehnXcaJpI0Z9BU12wEEIFdByK2V3fjoKlYVFwIRLZg3jpPLEpUJbTr4xilUcgJ8zxmEWbIMMdP4u80u8MLglK+xYFzHBM6++JX3oxo+GlTcvVhgFt/U/K6sxRfAfvmismFVT7za1Ds6D3dnJUOW5EgpXmzc1lh8YARYJIDe1CZ3LhAereaQRCglECKzPjrrPA1Ug6Yp1rTjZOZlW/sp3FGAndn4lxmJwz99Z+ylpSkADRSOXxXmzrUawU+1LQLP9demXuWj4A91RusQxpo4wOaegwEWgPtZxGiAgt6RN8tccAS1IQehqtVzaFV/Lt2E4KG7HnF1l1I3tv7L4gx/Z7WaCv2TbVeoIfduYpz2DZnxSSS5qh4305hkqiw3knYFFt+RBnvdsu1vR6lBoNaIMhLz8q4sDffo0ujbtdXP8jLZmGCCIH6Wqpy6VyG2VFerrTn6GonM4hHceyjCMXzzyfgUZ6KkKp/c3+PGJYo2uO8F/5DjlH8y/4hGNSnDKwrIzDpBM4TnhSuwaFmqcjK37dszmG/vV8XhoqrRWjvwfZaajRpIINoyXkwwR0iAG2r5gpuTvfUVt2rGg4KL5VR+P1GBm69CaLGKl+mEFT99pOkWbVa/IVEKUmm6FOG42eXqkOEekfvO5MmBKHzyfJEMGtCBPGXr1desCaSpp7tCkPY4ZAdQmB/lBd2DUuI3KTMdop8fixrkzlOOSpefTPi8TTpmFFqs+CXfd7G7KO1FuQKIIajVmiPUnTwsPSxBTZjXvPwGZGYc/aFRGRVZy9bl1MaS1lpbuuMLXJC/cxEvkNJnEJm/0YTBSx3BkJBaQtdBdTP9JWmpfRwwI i78FXVVv cIFR/KURS9YCodNaeAEYVaqWFGxsKorzuEFiAP2iluH5pKjNd9owcnQDJ57T4x/ZEHWRK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 7 Apr 2025, Harry Yoo wrote: > For user-space tools like slabinfo, it is difficult to determine whether > a cache has sheaves enabled. Expose a read-only 'sheaves_enabled' sysfs > file to indicate whether sheaves are enabled for a given cache. > Thoughts on adding an entry to Documentation/ABI/testing/sysfs-kernel-slab for this one? > Signed-off-by: Harry Yoo > --- > mm/slub.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/mm/slub.c b/mm/slub.c > index b5ea66cbbe68..32db440a8b05 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -8504,6 +8504,15 @@ static ssize_t remote_node_defrag_ratio_store(struct kmem_cache *s, > SLAB_ATTR(remote_node_defrag_ratio); > #endif > > +static ssize_t sheaves_enabled_show(struct kmem_cache *s, char *buf) > +{ > + if (s->cpu_sheaves) > + return sysfs_emit(buf, "%u\n", 1); > + else > + return sysfs_emit(buf, "%u\n", 0); > +} > +SLAB_ATTR_RO(sheaves_enabled); > + > #ifdef CONFIG_SLUB_STATS > static int show_stat(struct kmem_cache *s, char *buf, enum stat_item si) > { > @@ -8656,6 +8665,7 @@ static struct attribute *slab_attrs[] = { > #ifdef CONFIG_NUMA > &remote_node_defrag_ratio_attr.attr, > #endif > + &sheaves_enabled_attr.attr, > #ifdef CONFIG_SLUB_STATS > &alloc_cpu_sheaf_attr.attr, > &alloc_fastpath_attr.attr, > -- > 2.43.0 > >