From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281DCC02194 for ; Fri, 7 Feb 2025 17:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A041280004; Fri, 7 Feb 2025 12:48:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62996280001; Fri, 7 Feb 2025 12:48:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9C8280004; Fri, 7 Feb 2025 12:48:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A613280001 for ; Fri, 7 Feb 2025 12:48:40 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A2AA4141D98 for ; Fri, 7 Feb 2025 17:48:39 +0000 (UTC) X-FDA: 83093883558.08.92BE1FA Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf07.hostedemail.com (Postfix) with ESMTP id 1184440002 for ; Fri, 7 Feb 2025 17:48:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738950517; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xffAXOeB7CcEVAxLfyCmc8/yi/rxwPbOPmLMuoUe6qk=; b=Pj3cv2VS11x3K5JOwo6PaWFfP9kY/iHiXQ8wTjMivlkzX3aE3SFlFIDCe/U8WnagDMDT38 4dCXEJiSlbTzfezKvVsk9ueS1GXI/VqGDSxh19A3wUASQ/vXtI64b4tQH8cVZRdc0h/q9j vZJqEAGc660c9McACRGYtZmVkyldQYE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738950517; a=rsa-sha256; cv=none; b=nwHKfNT9iFqeMj+fPB+pNAX6KkfTceDFjfL+0lZiW3Ke04JmH/38zcn9uPLVvjPAa/SCjU qJBRo0+XaAOOhVSmxd0bqKJOf6pbH+8arEbtnDS5L/u4AmHnS6pLfQpy9wVEbXboiAEugP AAINhBVfh7LO/TctBrWtePYrKI5pUPQ= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tgSRK-000000000iv-3IAC; Fri, 07 Feb 2025 12:46:54 -0500 Message-ID: Subject: Re: [PATCH v9 00/12] AMD broadcast TLB invalidation From: Rik van Riel To: Peter Zijlstra Cc: Oleksandr Natalenko , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Date: Fri, 07 Feb 2025 12:46:54 -0500 In-Reply-To: <20250207081629.GT7145@noisy.programming.kicks-ass.net> References: <20250206044346.3810242-1-riel@surriel.com> <12602226.O9o76ZdvQC@natalenko.name> <8111558b52cec1152746b05a9c1d657d18df0fe2.camel@surriel.com> <20250206142308.GR7145@noisy.programming.kicks-ass.net> <20250207081629.GT7145@noisy.programming.kicks-ass.net> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1184440002 X-Stat-Signature: aausixtuzsu1qupqmaedowrkoo6oqeh1 X-HE-Tag: 1738950516-154960 X-HE-Meta: U2FsdGVkX1/XtiXTEFnw0eegBBTnjT33IYfhKvcgKQxhKVLw+0CmhSJp6Z4jnxDHz2FmUrKwhbxkz9jW2A+hXj85lH9G9uAhGueydH084W5XLySuYsdoxJmh7t8qR3mjO9gUGEjg/U7phWNY73EcGENUHCgDxH0l9gQA6P+i9DUm/XiKgnYiN5qaLgLdLTuAMVxGrx4gtr9r2w6NTr9wQ4un5XXr5tmvLpmUssJhoI+nzpA9+BtVrFf/q+b97OV5ID3qtEMTNHN2CBPebfaf6XmxnhgzRQTzN03jKRV8HJyCaEiCrH4zBMZvDKjm1ahoYHjESFgv3dNtd8rHL1pdm2/vgHQ7iR1OQLUIxz+5WZo6CpMJkmzjDXaem9Db+0eMupUorEAa3SqoxWI8tbcWYnGPammrNvtTESwtUGvsYS6nfayecrtSzP5Q/28ilWrOklUEsXKgf+f2WAi4bDUuyYgDwi9v7gNtjrqGUdsArWCEoOhbUHKcOKveKFm3bEO/z/PLZnn+ZtJxi8xP0Y/IJf/CFVTr8se8mGCc9ZyW35sWosOQI3qj3TDusYEKVyQxJzFBPs2Ww3e7ceCmsmVp0VGvsf4LnMgQOBF+plJjY13YctHJGJ9HnvTDl62jL7T74blJx0pl07/p54QYWZ1wc0PL3h78pSza48CsVpGBcC9tePXf+c++JM+DpV5+/q871nOLQ635tuExM1iSW2i7w1ummeu5Ud/JaeiDHk9WWQuutmoxSYVfgAHhCr+0gPZ3Sqt8lY/V5Pp8G6is1/aqufZzA/oSc7PcrNSox8da2Hp5DzjY9y1nTtkmyMdh0VyVgby0o2bP1EUwyqB4pVxoGqkm4oIRKocHOFTnynNTFfylrOpDVlue5uNsewmY+NpRXvSWhYuKCc/RzoyZjWWbVlIfeR7HBhHGSyNm0x44cFsoOu8NnW8naFzgpoOYZKE/sJZ1ygQhnfaFJYZCXgF sJYNB3vx L+2/Jidou6yMT43HVR7cZsoSU0Ip6AJl+odshb4At1SPQ29/BTU5/eHN7VjeRHH7crc/Jkujr2Uiorg1VUyJimr+riJa+thEE1WqlDzDxdnXqK2NZMq3VB7InhsL4dDXO+kqQ+0iLZCE+O9rtk7WeoNetTMz/T34L0d2cFR1NXTm8qCb/GPOP04nrLNkyaCieLr0UwUJWkFIeD1Lj8lDAOx7ixa9BxXp9IXRoE4uzAbX6OQN+kWzTXGZevRZGOBDyheJhcrUszuo8ZbZ6N5uMsDTZmwJPEds8d+o/gnPOYSX/PV2xM4rP3cBAIvUkOl/hpTFrOylSmtFnoNUtsbu00dDT0gCwdQuKl3phwYhn4YQ2s5g5MnkxGAo4GqmULUqszdMvYc9iFJft7T/t8ZFlWPee/NACMHqFtHrF7VL2fZQuuhs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-07 at 09:16 +0100, Peter Zijlstra wrote: > On Thu, Feb 06, 2025 at 09:48:25AM -0500, Rik van Riel wrote: >=20 >=20 > > we can just round up the > > end address to the nearest stride boundary > > there, with a comment explaining why? >=20 > Well, why are we rounding at all? I don't think I've seen an > explanation > for that anywhere yet. >=20 > What made you do this? The only real reason is to not end up with a 0 value for nr in these loops: for (addr =3D info->start; addr < info->end; addr +=3D nr << PAGE_SHIFT) { nr =3D min((info->end - addr) >> PAGE_SHIFT, invlpgb_count_max); invlpgb_flush_addr_nosync(addr, nr); } =20 Which makes me think we could just insert a "nr =3D max(nr, 1)" in there, and round up partial pages that way? Looking further, I already did that on the userspace flushing side. Let me do the same thing on the kernel side, and remove the other code related to partial pages being passed in. --=20 All Rights Reversed.