From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F120C433FE for ; Sat, 13 Nov 2021 17:21:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71FCA6103A for ; Sat, 13 Nov 2021 17:21:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71FCA6103A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 73E9B6B0075; Sat, 13 Nov 2021 12:21:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EC756B0078; Sat, 13 Nov 2021 12:21:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DC1A6B007B; Sat, 13 Nov 2021 12:21:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 501EA6B0075 for ; Sat, 13 Nov 2021 12:21:19 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 073A61840B3BF for ; Sat, 13 Nov 2021 17:21:19 +0000 (UTC) X-FDA: 78804573078.09.C185AD1 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf25.hostedemail.com (Postfix) with ESMTP id DF898B00019D for ; Sat, 13 Nov 2021 17:21:05 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id v65so15392219ioe.5 for ; Sat, 13 Nov 2021 09:21:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TDfD+2bBYCBWin4XicpoFuRSKI+m+KUd9LWnrt6X60o=; b=RecRxP9GQY9WZodIQaGoqVQaRon+QchYM3wC2UPU3ayZfCTDfb4EFCwRYuQVrS40mi UWqDjpR84iu07SXVxX5pbqCEs/uOmAIP5MLfL4olCX6Caf4ssYgVLBp3maN8j7Yl/aA0 awt4x//hqVEahsn7PjF4/FXNG+87GveTk5ck/5hvamg2xwxcwBBdXIv0eY57YYF2+Rjj PTbrgf7YpqPyAwsM+UJSYFehw2qjGxJ6+/+SWS/SvKUztuqs2f9QRYjuroMSumex1tj7 AiaOFj7VwNBxjbcGS6Da0Nw/OdkLIeAWP/IakDkQVSz6FHQGEgIYNNSbNpFXBN09pxpi Apmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TDfD+2bBYCBWin4XicpoFuRSKI+m+KUd9LWnrt6X60o=; b=gbd47GTawdM8Cx2Gt06nHTLzRUrei6Q1TvkJEA4ljzsf1CfKXUe97F1qdigzLlnkbV WpblneHifeav6rEvspmDyjQDZDe6eTQsyxhVt7R1/5U6MVAPat4C0eczZKq+F34XeMAU kKtTE0FGQ11CgqG7i8vEnTE/xRhdu89YNYqamS1K0dKTCA1AIGFai1HDR8PyG3JKUCY6 vqWUFtmrsN1N6W7AS/koRzt2OtsomGmPtWvK6czCcFoFXXc0DT9kxhKxmKmkKWzdP4ze nySbO2+FCGflDONlIglV1ORRDC+uDCkCGFR6RMbyoU0kKN1m77IVdAHvMOn7Jn8l8bZ6 fjtQ== X-Gm-Message-State: AOAM532bC6z5SXZZlbr9sxNZ3QOj/PaHUUs1jzpGzQlqH2KVOfKmyKvT 2ptwBWNPlyjqAMa1cESZLeZlvA== X-Google-Smtp-Source: ABdhPJwEHCuN1iJH0gAfnwHyL+TisVAQjvYrzZUnY5vwUBIbeHkCNMq/AUx8cSksK2PUv7Fiqrvg6w== X-Received: by 2002:a05:6602:2b0b:: with SMTP id p11mr16832447iov.62.1636824077343; Sat, 13 Nov 2021 09:21:17 -0800 (PST) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id y3sm6166352ilv.5.2021.11.13.09.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Nov 2021 09:21:16 -0800 (PST) Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page From: Jens Axboe To: Ajay Garg , hughd@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk> Message-ID: Date: Sat, 13 Nov 2021 10:21:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DF898B00019D X-Stat-Signature: yrqirbep9cya7monw6ff189rnc4q1ixn Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=RecRxP9G; spf=pass (imf25.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.41 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-HE-Tag: 1636824065-801852 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/11/21 10:59 AM, Jens Axboe wrote: > On 11/11/21 10:45 AM, Ajay Garg wrote: >> Another report of the issue (different call-flow, but the same error >> at "shmem_read_mapping_page_gfp") at : >> https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m52d98b6bdb05764524a118b15cec048b34e5ca76 >> >> with a tentative approval for the patch : >> https://lore.kernel.org/lkml/6bb8c25c-cdcf-8bca-3db2-9871a90d518f@kernel.dk/T/#m24c2888a879d428cde5b34c43838301de544eb7e > > Andrew, I've hit this multiple times on resume on my laptop, and it's > a very apparent bug in that b9d02f1bdd98 commit that it doesn't factor > in error pointers. My oops clearly shows it being one too, with ...fff4 > being the dereference address. > > Can we get this pushed upstream asap if you're fine with this patch? Maybe Andrew is out - Linus, if you follow this thread, there are two proposed fixes for this. It'd be nice to have one of them in -rc1. Backstory is that commit: commit b9d02f1bdd98f38e6e5ecacc9786a8f58f3f8b2c Author: Yang Shi Date: Fri Nov 5 13:41:10 2021 -0700 mm: shmem: don't truncate page if memory failure happens adds a pretty obvious error, where PageHWPoison() is called on an error pointer in shmem_read_mapping_page_gfp(). I can trivially hit this oops on resuming the laptop. -- Jens Axboe