From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623EDECE582 for ; Tue, 10 Sep 2024 09:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE018D0041; Tue, 10 Sep 2024 05:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9E9C8D0002; Tue, 10 Sep 2024 05:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17308D0041; Tue, 10 Sep 2024 05:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1FFC8D0002 for ; Tue, 10 Sep 2024 05:19:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 56786C1511 for ; Tue, 10 Sep 2024 09:19:34 +0000 (UTC) X-FDA: 82548280668.11.97D18F9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id DD7961C0004 for ; Tue, 10 Sep 2024 09:19:31 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lfBDbMgK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="hSw/04k5"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lfBDbMgK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="hSw/04k5"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725959889; a=rsa-sha256; cv=none; b=huUJTx9aOyH0h1dL08hJHeggApcaUVRM616rA5izuxufiIVhPencLKFkeva6/ZWEB7EIl5 2loR3ZecANq+MJo/l2D8mbW7/Prs0FLzZfkVIQ+oeSUggNNLp93CAelYq9o0bxjywEpEXr ySL+zx07jp+TDiuyjywDFp/SLPlx4r4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lfBDbMgK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="hSw/04k5"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=lfBDbMgK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="hSw/04k5"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725959889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHifeSDy1hOrQBMy6zAhiahj/omSnqHRNld70oH1lB8=; b=gEekncntH58fblTTW4RO/ryAV6GRNGJFEx7TjqkcrQ8OKAGK19skAow4ijIE3gH3GPs2qU Ulaty97cBe261Eqng8ZeDUjSJfFXOv2uNBCgaxZSOZqiN5DqHqGGGfVDRbWjcUlm4dV6LE Wg8yS/evt9rc2J7kf7WzeYgEHyxQj1A= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A3511F7CA; Tue, 10 Sep 2024 09:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725959970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iHifeSDy1hOrQBMy6zAhiahj/omSnqHRNld70oH1lB8=; b=lfBDbMgKn59KuCOI0BmhZrdL9u8jnyJbSi73Z7nnY+EtqtYEha6puIOgROlT/1gI7b/jPC wGH3HmSlYoslgSYlz/LQ+htJiAvqlZTgBQgeEmMu8jDSRUe9mXrW67iGIhMn5+7XBG5WIh KKC5XX8oA4Rt6IpJ02G6DCiaz6OE/CQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725959970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iHifeSDy1hOrQBMy6zAhiahj/omSnqHRNld70oH1lB8=; b=hSw/04k5A0n+xQJ9JF57ti/nISsxO3zKM1aEff2RfwKn8MnQBzyWdU2SfB0Mhmtikd9e1D cIkIbBglasWMt0CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725959970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iHifeSDy1hOrQBMy6zAhiahj/omSnqHRNld70oH1lB8=; b=lfBDbMgKn59KuCOI0BmhZrdL9u8jnyJbSi73Z7nnY+EtqtYEha6puIOgROlT/1gI7b/jPC wGH3HmSlYoslgSYlz/LQ+htJiAvqlZTgBQgeEmMu8jDSRUe9mXrW67iGIhMn5+7XBG5WIh KKC5XX8oA4Rt6IpJ02G6DCiaz6OE/CQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725959970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iHifeSDy1hOrQBMy6zAhiahj/omSnqHRNld70oH1lB8=; b=hSw/04k5A0n+xQJ9JF57ti/nISsxO3zKM1aEff2RfwKn8MnQBzyWdU2SfB0Mhmtikd9e1D cIkIbBglasWMt0CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E97CE13A3A; Tue, 10 Sep 2024 09:19:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aBWeOCEP4GawSgAAD6G6ig (envelope-from ); Tue, 10 Sep 2024 09:19:29 +0000 Message-ID: Date: Tue, 10 Sep 2024 11:19:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] memcg: add charging of already allocated slab objects Content-Language: en-US To: Paolo Abeni , Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org References: <20240905173422.1565480-1-shakeel.butt@linux.dev> <5d48fe26-1e18-4941-99d4-8c03e83f5e76@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <5d48fe26-1e18-4941-99d4-8c03e83f5e76@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DD7961C0004 X-Stat-Signature: tswndfyb7i7dismmxpg1zqg14ah66854 X-Rspam-User: X-HE-Tag: 1725959971-236620 X-HE-Meta: U2FsdGVkX1+mheYB0pfILHbEwyFBx4WHqMOl4h7QYBkiRBa067+H5XLBf+ED5cqNYhj3weFlorX64wp6Na12rcQTNlciVPFbTrXMdMAvj7GyIf7aVT+igGYurtlugg4jqyzqBM5qS8HzOfcCsk1dZ5GFyCm/E/10Euqbq8bUZMJrQWfMumBVOJB0YSD5UzjrimgDwQp8GTNqO0CF65vaeLNgR0+zg2Prquo+GFDcWXIqtwZFfjtYq/YEwHMZhYG0Jga4svIEI7cD2SE2z/lsGYPnIVPXGu4v1froa2gR7UoW0qUw8mjABBMJdWrZmU7JtUBNySjFgd4Y7td9s4DY7DQhsWNhzsSJ74f6hlNBOFRRxE398PLymIbtcQDnDmkXV8KTKbW7BxxfOqqstshMSuZuVoS4RhVTCZCg7UrglboM0YQrNjwHeZP3UjrVCWu8zeOY3emhWHsqvQZM4vJlqdOpfUVtyib6w9XdizWlinJt3A9aDWhMkbbDB2iN4bB6uVe1nq5rPR3uW0+JcMF98vbuckMxYX4p34zd/o5gCAN3G30Ft3B5RFJKKhvQd2P8EEzfD22aw3Kcd9BsgD4NCJ7vvuASZoDSs2txpkklGHmxlsylq/aB6quO2Zg7q5Q+tm3rKQXY0hwVvFER2qVu85uXar18+uGreRNaNRCNfl3kpikvjaMWyNkXt3cKBFow1MPeueghhuAOs87B6XR8PALVA+Wj3KExIKOeApx+9hUINOCQutaXnVV8a29Ei3xovXZ1oJbEEA1YkOw98wnAdI5VYEmKjAsbrDKr88aVKYkO0VuDLyyS7TpAOEHF7eAu5cauP+xRJynFfFClHAUlKy8kwgMPnaOudhouAh+EL9RC5m4evNzHw8E+qsNHy19oYqEVJNbAJwzsczaRlYa5DL8BBcoFgXsp6AgDmMQP8wZw2ZSn9MjOXSnkV3JtjTbKVwvITAgsziqENs3Th7a KjIjG/HX WAYhKiumZN84M2hR7KeBl399ojR1p74GipowpdAdrAChgTSY3n4xosgxOALJfENcR1ORbJ5MvjRUotO2DRtV7ZKc4MwFPLZVlnU5KbMA8jbKiLV3J2ZA/d/uS5KffcxQYkxhK5/UaYd6zxC0iZCuwNcAUY4VGK6iARwAuqoNAaXjhzSaD9cgXTs4VWFZFh1BxVnvgEUf1lTH63tV73DPrLxv8qANKsg82h5TQroaYPsWJEW5xqG65YFb90vjozW46iIID38HE4Tnk6/fUwDf6+xaJyjzr8thUp7l/2w1qs1awUuIokSC4zOSJsWT5zL1sbylFg3Z86WSG6ExafMNYSNW++qJZ6ZuJvc7gm0hzUVkZUDuXRgIOJlFStL+RyC5PzLPK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/10/24 10:26, Paolo Abeni wrote: > On 9/5/24 19:34, Shakeel Butt wrote: >> * kmem_cache_alloc_node - Allocate an object on the specified node >> * @s: The cache to allocate from. >> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c >> index 64d07b842e73..3c13ca8c11fb 100644 >> --- a/net/ipv4/inet_connection_sock.c >> +++ b/net/ipv4/inet_connection_sock.c >> @@ -715,6 +715,7 @@ struct sock *inet_csk_accept(struct sock *sk, struct proto_accept_arg *arg) >> release_sock(sk); >> if (newsk && mem_cgroup_sockets_enabled) { >> int amt = 0; >> + gfp_t gfp = GFP_KERNEL | __GFP_NOFAIL; >> >> /* atomically get the memory usage, set and charge the >> * newsk->sk_memcg. >> @@ -731,8 +732,8 @@ struct sock *inet_csk_accept(struct sock *sk, struct proto_accept_arg *arg) >> } >> >> if (amt) >> - mem_cgroup_charge_skmem(newsk->sk_memcg, amt, >> - GFP_KERNEL | __GFP_NOFAIL); >> + mem_cgroup_charge_skmem(newsk->sk_memcg, amt, gfp); >> + kmem_cache_charge(newsk, gfp); >> >> release_sock(newsk); >> } > > The networking bits looks sane to me - with a very minor nit about the > reverse xmas tree order in variables declaration above. > > Acked-by: Paolo Abeni Great, thanks, I will adjust the ordering.