From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472ECC4332F for ; Thu, 8 Dec 2022 22:01:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF5B98E0006; Thu, 8 Dec 2022 17:01:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA6C88E0001; Thu, 8 Dec 2022 17:01:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A466E8E0006; Thu, 8 Dec 2022 17:01:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 911578E0001 for ; Thu, 8 Dec 2022 17:01:25 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 584F71A1063 for ; Thu, 8 Dec 2022 22:01:25 +0000 (UTC) X-FDA: 80220510930.15.8C5C73A Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by imf04.hostedemail.com (Postfix) with ESMTP id 5E4C140018 for ; Thu, 8 Dec 2022 22:01:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=O1mYzep2; spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.77 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670536882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dv6rBuCUHWtWGaSGfackNETsiX+wHtjMl/4knqFEBdo=; b=kL8dWsxUosE+IUoD/3s0VSjG/peoCe+W1vIf9d8xtB7uQsKgFzJOWNsoRxqhXpPDaLg6Mm 2wyp0SyXhoY12Feen2leYGfKq1Ay77IsDYcq7sxvoi+fY+zL+CR/MnKGG+bICfysp1lt/0 apHmwOoQvbgP5/jS0ie77vw9fRF+h3I= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=O1mYzep2; spf=pass (imf04.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.77 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1670536882; a=rsa-sha256; cv=pass; b=TT5iVKKifqM3PbHrAvqERFNuTareA9CXctGRQB7Tty7wyDDa0PT5I1CXMu//KSrKCfKrSJ S6MKYrbzJYM8drHpAkCJbWvMop+Ab3pdRyUWhBPB3Vc9tsdsA6vAzbyAa1ZJa0M8E6u/Zm +3r0JPL8Sv2svQnbCTvv19+5Kil/Q60= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMfJijiyFI7zvYcp9k+oXICzJ1MH9Ld3mkEqhzZ9VcSWp8b23ZATn7pNEdA9eu1iiR7kl3Pjk0C5IQeuo/niZTDOeUL3PaAE0qjQSh16FiiUYd/GUrMyP6bSEdTprG5CjGvPBrYafH4anGTEK72Tq0TluJ+8iIZirwOcK53VfiKSUvC1pEedMHN5uw94rI098j/kPb1eu6RxSoLpTNWZj9Ny63faAyxJh21HrhClhbGt9+xKJY+1UJIc12x2T1hbsDBDRO95zlMWeJe6kdtsHHXI4I8ncTghIDnLf14sIOZ44F+AZ8q4NUSx5G6SZLGMAjeIjPiw4+KXo6WPV8P7aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dv6rBuCUHWtWGaSGfackNETsiX+wHtjMl/4knqFEBdo=; b=d3Zv4DBRNAP2F6x9IQ+L4XDr7Zp/pD2GVoSSdaBmYZV+Fz7ZvzBA49Oi7edAScGaOoseNMi2fVC9bca30egAuJr0xlPbIFVa1XExbzlkyo/mw6P4gj2NuGojWxri+rBk73nX7jnM8mJMkwR2+GmQvE5BMwkthY2M2grlJVZqX9H1+2KjS+8DL6LTiM/z/d7CBdpJ5Ag9vdByH3OMQoM/cjv7Q7LscH64IR2wnudHl5vIzbxZP4tTtOmGHDr2EbUhlD9HDnd8w89bI6LdbsNnS1gZb/dKK4S3sbc7UmHZAMZBkSKZf+TwtS1YhQ8m1YI4C/GCaZ07oZkFS0iRIJ8qdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=oracle.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dv6rBuCUHWtWGaSGfackNETsiX+wHtjMl/4knqFEBdo=; b=O1mYzep2kZL38SnaFr2S/bgFZJkfJw8OmNGDr9lH7c65UUwnQPuft6YrJRTH1+NVSyGCpnXzt4ymi3BPz/skgzZPaO8miuMb0/YDmJbmdopI28oG+4Ai/Y6NCghrQsCMfFH5j3UQuc+r6/R0GQRCT9GYjuIZ4pPf051sbg0oMRNToG1Zc9TZuPMa6pD+pXLGXU40MYy0SVeEVrLmOWcNNUS1LhcZbU54v3kPH6v/xiL+sJ35hPXL+PNlHowkiq8hzq+taGNNNXsr9oegp87TbfFwywBBX61suJaQotvoBs+TVJscNj3ExdW0bLM/KSZVGyUf8aOHkR5vKGtHM7Xaaw== Received: from DM6PR14CA0071.namprd14.prod.outlook.com (2603:10b6:5:18f::48) by SN7PR12MB6789.namprd12.prod.outlook.com (2603:10b6:806:26b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 22:01:19 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:5:18f:cafe::f) by DM6PR14CA0071.outlook.office365.com (2603:10b6:5:18f::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14 via Frontend Transport; Thu, 8 Dec 2022 22:01:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5901.17 via Frontend Transport; Thu, 8 Dec 2022 22:01:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 8 Dec 2022 14:01:07 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 8 Dec 2022 14:01:07 -0800 Message-ID: Date: Thu, 8 Dec 2022 14:01:06 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH mm-unstable] mm: clarify folio_set_compound_order() zero support Content-Language: en-US To: Sidhartha Kumar , Mike Kravetz , Matthew Wilcox CC: , , , , , References: <20221207223731.32784-1-sidhartha.kumar@oracle.com> <92965844-c430-8b8e-d9f1-705d7578bceb@nvidia.com> <0187f9c2-e80a-9cde-68bc-c9bdbd96b6fe@oracle.com> <2723541a-79aa-c6b5-d82c-53db76b78145@oracle.com> From: John Hubbard In-Reply-To: <2723541a-79aa-c6b5-d82c-53db76b78145@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT025:EE_|SN7PR12MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 81b86ca6-de2c-49ee-2474-08dad967bc8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GiJOdkrv/L2jQteBxos+yzxVAREO5NJekVFb4dp7LFEVRAQ6XKImOgUD02QyXoQaJjmZpsA4lhjolOaz3rA7Bs9nzUOXxo2aiesdZDe9ufoRkRLipnRXJ44BHMd4AjGw/hzhsZFbf/Oo+jVRf+5+M05V2dKrygEi3njs6VVRA03435kZEkgYMz39etPvhaAEMYI7kHj7l4IEQM/8MaPz+iGrp+Z9qJW7yeJ+RKD2rEs8mSWKaSHiC5Nq2ios3hAeb/+rRg4jtae5bwYB7xdgx0KtVHB4Jn+z0JWUY32iyp3oWMSb0WVKhVjTLcO56XTJ6AvnLq5yddJjNRvhaBfzB/6PaP9cv2si2m929CSrEtxK1R8UVPn5qkd816XCN+sBYOzAPmAuafm9/94utlHue4dQzxoZVkCmA4CLwxx+j8cDOXETBNvtwi0azny3xSWk3aMoGpi632WN4d4kgTg132q10mkxbZqC+A5A0x8QuwcA4mUBPXXR0ZMZR6tyeF3JQkJZqQ/A1nCMs7O9wsjbawdj/Rz+jFGXk0SteyPdOyXjSng3Aujf3czgDoebs3S5LV716icmBcNoIPMfzN8fV/r26J/bHNS0Ue0pdg2bU1Ncmlwt5yIyMKMdfn6aJD8w6exC/leofyodullCsLUafyN5bnucvSxNhAsPRZxhSx0xgUh7KZnzhpiJU/tFpd7Mb/GK+tBP6WgCexDj6vKm/xCt0LiEk11U82X2JMCocus= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(376002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(54906003)(5660300002)(70586007)(8676002)(41300700001)(316002)(2906002)(8936002)(16576012)(4326008)(70206006)(110136005)(31686004)(36756003)(40480700001)(82310400005)(7636003)(40460700003)(86362001)(356005)(31696002)(83380400001)(426003)(186003)(478600001)(53546011)(47076005)(26005)(2616005)(336012)(82740400003)(16526019)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 22:01:19.3140 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81b86ca6-de2c-49ee-2474-08dad967bc8f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6789 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5E4C140018 X-Stat-Signature: dbugke5zmh8n5sugy3xfpxk5bec548bz X-HE-Tag: 1670536882-549399 X-HE-Meta: U2FsdGVkX19g9zc2cZIztGS4ynEl1l2FVhbeLy/iedquUM22Md6EhJpFCJRbU7uWiNHJE73kzlzouo03/Lpth3f6rVYICn6F/W85Ed5k5s4M/h0bYQP2KFZijpUtLRD1vOHA8uxauEVER1XLRqFf40bkNXCGKUoGoeAUGOSlwNcB43ZSDlQAbU9fHdGzjwxwLvEGTdPkKU6FPapji7fWCWRQ6kBFjOj+ILML/feam7INA5LMun86+b7TgkZZ8lPm+lYto+BrfdXmvKRDAMtF7yBc4b30H1R1uPVCeWcbg0BJK4wCetAXfCSaxDF7VfYNxMehu5suYiqfMkx8Qs1VatfAgTrT9sdxsIicykepYCnr3yrQwbFeqUcjBLFZamayFYGMMoazi/4yMbBLpyMSHVdz8RB2drYia1Z89M29OxRB4deOYUYG/hgRweZ0wquANZsnkZDEx5jXUy4K85AHI/dcQim2kYfTGXzENzqM8VZHM/GVBqZGIEB1E0ASHurno+hml0vyYABCUb1wa0w1qEB8mX4hp/R6MyJULDDwHZdEcAAKEKWhCAFnOHI4jVlkKIJvLpsMSXEJ/Ua+fFbDo3LNe7aUiKiU5KDetSh7L70N+S5xypzQYRmLNF/uXtDgW50YnFqEYDWUzifhgNLnlYHzpVMYgEzncYaPre696avBFTO+4dB2cX2kZzzgcZInu4mzXeRYCs3Ud8pzmg4cRtiJKvZA/ZaHK4i1ecmomT7IVEhi/h+u1YOXOg7mUIQB0ZO3NzO6195LZBpVyqfZBzGdDRGeL+k/6O09EVJq0XzmGteiSN1mAz/VircMXgq0yzWTqg5GUediIyxiOWEJEq7lWdkSw6iTkI1oJbWQlytaxbANTgStkCd5Y8csc2Iu4v9BCN/lZhnY88Wuw4nRsw827DcF5Hd9lnGeCCf5H3uMVU4A5Jkc3ITDCToSR3ebdFz6P+4H7abdawuaRlg +lkbvLNM XRAjByMztuaDbp69k5yUo0o/cEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/8/22 13:58, Sidhartha Kumar wrote: > Thanks John, Mike, Matthew, and Muchun for the feedback. > > To summarize this discussion and outline the next version of this patch, the changes I'll make include: > > 1) change the name of folio_set_compound_order() to folio_set_order() > 2) change the placement of this function from mm.h to mm/internal.h > 3) folio_set_order() will set both _folio_order and _folio_nr_pages and handle the zero order case correctly. > 4) remove the comment about hugetlb's specific use for zero orders > 5) improve the style of folio_set_order() by removing ifdefs from inside the function to doing > > #ifdef CONFIG_64BIT >  static inline void folio_set_order(struct folio *folio, >                  unsigned int order) >  { >      VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); Sounds good, except for this part: why is a function named folio_set_order() BUG-ing on a non-large folio? The naming is still wrong, perhaps? > >      folio->_folio_order = order; >          folio->_folio_nr_pages = order ? 1U << order : 0; > } > #else > static inline void folio_set_order(struct folio *folio, >                  unsigned int order) >  { >      VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > >      folio->_folio_order = order; > } > #endif > > Please let me know if I missing something. > Thanks, > Sidhartha Kumar >> Thanks, > thanks, -- John Hubbard NVIDIA