From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C95C3271E for ; Mon, 8 Jul 2024 07:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64496B0093; Mon, 8 Jul 2024 03:56:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E12A86B009A; Mon, 8 Jul 2024 03:56:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C66496B009B; Mon, 8 Jul 2024 03:56:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A2AFA6B0093 for ; Mon, 8 Jul 2024 03:56:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2D9FC1A112E for ; Mon, 8 Jul 2024 07:56:29 +0000 (UTC) X-FDA: 82315828098.20.982F455 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id C459520021 for ; Mon, 8 Jul 2024 07:56:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gRRXdKkl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720425363; a=rsa-sha256; cv=none; b=QdsnmWJi37AzLlgO6/Geq4OyMEjnxhUEDJzhhhrVV1+eq+3SXxIqqdO1t1/mVCOhRT7QRE Cr0xt1Ci2CxA8vkIbQQoX/kfiXavje66P7tfQeAM1Fg8YzQEPQ4cDQAOPU0Wcw6HXRzyrP MQdxYgqYFu9/ZxYm1Nm45akJGCvEfak= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gRRXdKkl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720425363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CMc2ljlt4DMiI4aPglfAN02tbdUjIn7sPq8R8D118xs=; b=n8YAgngo1nE2s1IRzqotVE7mHfympC/5Bl54yFzPqDzplVpjapD4+2HpSC2jg9r0gEEsha WEDrx5F6OWAQHR4MD1kSS4ZOCcPizMIrLOCGOq2Fx5u1fghhGLKvb2JffSgVLdSx2ViTmg UzcbBFwyBIbFmtenVIrW5BzKsFFTxy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720425386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CMc2ljlt4DMiI4aPglfAN02tbdUjIn7sPq8R8D118xs=; b=gRRXdKkl2EbdF2qZ8Hm+lPtOLwbr4Lp+gI1bYk+LCfYg+04kzDoVQu0LRHhF3+hWive9LY pHoCBYmyGYDYqq4tJWccA5cUauZmn8FF7Xs+n/ICuWm7vxszoRcWYKKuassZNv1dT9sfZq wSpHM9efz2SV8PIc8PYNE5IEaSDQTAU= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-428--oFpkPjqPzmiAQ1nMhIwdQ-1; Mon, 08 Jul 2024 03:56:24 -0400 X-MC-Unique: -oFpkPjqPzmiAQ1nMhIwdQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a77bfa15f92so276781166b.0 for ; Mon, 08 Jul 2024 00:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720425383; x=1721030183; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CMc2ljlt4DMiI4aPglfAN02tbdUjIn7sPq8R8D118xs=; b=Rrx/w3MOMqg8ZX4fsji5kwHGm9f3dG6rRRg4O8OkYmvAlMo7WvVR9n8+aNmtSer/o1 Xmwqcx605Oj8GDjOKg7mK8jWBiZyp7ONiyr2SK6NtYkidfMEg5GBXyIs3u7OxP3RN0HC l0MKBRauUll8O2QCov1qcTSBGgAVzKxPtrFC6P/dUFwN6gcn8lju4fCHhvK5zPh5bBBx /GriQaxqk01q9AthA2+tz1fw7L26IU6YGB00v8IQ0RPeF65JBdBdjp4IPzvdcxmChmqx IhvsuifkZKzrt6PQNOLEUntSkwB68KFFyfEpmSHa2KtChmQK1MNKgYjJ+MjXZufqjm0I tUQw== X-Gm-Message-State: AOJu0YzCY2TI+yeuwQeSA72iv04ksrMSfXday6Rw8Bv5eFe/XHZI0jiL 12XBpoYEpbkSXcL6IcUmke7LgLr/3HuvfQCpnIyNdPk6UuOwSIurTSEe3BU7iIFUQicUJCLxsIx WKr8sMf3pH4Rpkq+tUKrPer0c3Itqb3rSACh5swnTayOmLZ+k X-Received: by 2002:a17:906:4556:b0:a77:b8d2:4566 with SMTP id a640c23a62f3a-a77ba72c927mr623127266b.77.1720425383419; Mon, 08 Jul 2024 00:56:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwDhwbAOT2+jYH36rgsrg8H3M7HtgM6YMwgoIpy3dUhj6MLIdOwlXjThJoWDnueuyn7b4vOQ== X-Received: by 2002:a17:906:4556:b0:a77:b8d2:4566 with SMTP id a640c23a62f3a-a77ba72c927mr623125666b.77.1720425383010; Mon, 08 Jul 2024 00:56:23 -0700 (PDT) Received: from [100.81.188.195] ([178.24.249.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77abd2b5e8sm404843766b.26.2024.07.08.00.56.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 00:56:22 -0700 (PDT) Message-ID: Date: Mon, 8 Jul 2024 09:56:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages() To: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, oleg@redhat.com, mjguzik@gmail.com, tandersen@netflix.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240708010010.32347-1-richard.weiyang@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240708010010.32347-1-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C459520021 X-Stat-Signature: urcpnxuag167ru1qsihymnek8cyycuyi X-Rspam-User: X-HE-Tag: 1720425386-480433 X-HE-Meta: U2FsdGVkX18etY1CqyYiKLcXWoRa8gwQapA9uUouu8TBzf6/87HfpnaWhno5FTVbuR2LC+cvFPvmjYRXSezhSQ7cJ8noMrXN2PXGAmIWmfIukDxu1AFASGlD3/LqKX1ddCS0nSjrJ12qa+FDB9a7bHRcA0Ve0eO+yzDLZhofKdC9/rfohJ8n+esoSvdHIhPkx3cC/z5XOVu1LaGorBtkkR5s9XiztqUkXZJRyRR23IvSyg2AMjqokNqMnm2QqGeHkFXmUjYZUpw3q2k9V90e4V8gVu/z9CquDsqPawa3pUsXGQnQMZVcsnkuMp6v9TlekRITqtL8VUNW/kP44xzusOXz0vYuUYK8zxqaqYy8MfaGC+uMb8jBO7cFPFAEcjgSr9SvDpkdhccPEYTooHCibYjGvpigt7U007+H70yMNTEizWd/k+SDwlegRrB/yWIp8zqPu4+yDWQOZ/tlmf5mYGzpcUJQi419Vgv6qRfUCmkREsRcJ9aC6nGc+upZ/ktIKDj6KbL3WSM5W6H3YZ7JLa9k5q8JpuRoNmJA5VAMt2bJBODCD3JAA5iO+dlplfNLOvXeXzfwAFetHjmg6ysTgQ2Kgc3LthnCTytniVqHlbRJriDclo4dlXAGX2+gOzN/Q/prOj+cstQRJPB2R1cOvFUZHf2XiFtt/qeR5kFUlxL8s8EHcQ6WKusBXUgaT38rt3Zr45OA2KIcyD9s2NxafpTh0fV4v90LTTPESKtUS9A92OTWZcuB7ztS/HKhvu95o0DPdFNtCr2u55wA5/rzNY8dR+QqG8Zl6w1mRQ/iekI8Orq1Fh2ztmWTvFXvXjR7C8PFUgQOGr5ERAYhISgUWPH72QZ9K5SPmiiCD55jhKGKkzfQrJq7Hj544XCEjiNblBbkJxlJ5cYsxK6g1GWsK0JC/V2ReuAkkzuuS+fE605k5+/TA7/rsnYpSk1bMkSVNmG727GqM5LFLRiDg4f kan6TxQ/ HZ64iQ1ftLuqgp4K8JAdIlYD35DsPaxzbF/yCw64j+nN1AHNzdQW4HX1TKRuanUWe8aZdD7P94nnahs9T3ARoY0H3hVqP/cAHsMdZkqq95WlXCQyHxsvs6XbUQ4yq31tp9gY2cUf2hVvgi1ljz5qNyWnc8GX62Plp8lmzwYspBXdWVjazSD+u2kTm7BZslpkFlj9l0SZsyxrF0sS3ieH9DmBuolV89HX4A5SuE713kLCIV2J/xbMb+MqCBkZFiixubfFI7oLDpK1PwTXqsdDdYlKUQRyevHb/FJ+Vi+vhZ3N2FvjY5+J9L7oqVtim8Vn1fl8joRmR5d68NukHJA1SG67KWxFof9qwPkkvuAzFw7iaKxgMIfc+ozify3c0KhD1LAqer66ei05Ryi3TZYqqRn6qGg/iuT0NhIkxq0NdJGlRDA3dbo61ezZC766sfgP4FS3mVzbqjUxGSRcqi8LLHK1Qg7unEH6mQjHlaqLiW5ajwKtgsnxzp6KCrFUOeA5+/2co X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.07.24 03:00, Wei Yang wrote: > During bootup, system may need the number of free pages in the whole system > to do some calculation before all pages are freed to buddy system. Usually > this number is get from totalram_pages(). Since we plan to move the free > pages accounting in __free_pages_core(), this value may not represent > total free pages at the early stage, especially when > CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. > > Instead of using raw memblock api, let's introduce a new helper for user > to get the estimated number of free pages from memblock point of view. > > Signed-off-by: Wei Yang > CC: David Hildenbrand > Reviewed-by: David Hildenbrand > > --- > v4: adjust comment per david's suggestion > --- > include/linux/memblock.h | 1 + > mm/memblock.c | 20 ++++++++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 40c62aca36ec..7d1c32b3dc12 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void) > > phys_addr_t memblock_phys_mem_size(void); > phys_addr_t memblock_reserved_size(void); > +unsigned long memblock_estimated_nr_pages(void); ^ stale name > phys_addr_t memblock_start_of_DRAM(void); > phys_addr_t memblock_end_of_DRAM(void); > void memblock_enforce_memory_limit(phys_addr_t memory_limit); > diff --git a/mm/memblock.c b/mm/memblock.c > index e81fb68f7f88..26162902789f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1729,6 +1729,26 @@ phys_addr_t __init_memblock memblock_reserved_size(void) > return memblock.reserved.total_size; > } > > +/** > + * memblock_estimated_nr_free_pages - return estimated number of free pages > + * from memblock point of view > + * > + * During bootup, subsystems might need a rough estimate of the number of free > + * pages in the whole system, before precise numbers are available from the > + * buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the numbers > + * obtained from the buddy might be very imprecise during bootup. > + * > + * While we can get the estimated number of free pages from memblock, which is > + * good enough for estimation. I'd drop that sentence. Apart form that LGTM -- Cheers, David / dhildenb