From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63B1C2BBCA for ; Wed, 26 Jun 2024 02:43:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AD766B0092; Tue, 25 Jun 2024 22:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 536626B0093; Tue, 25 Jun 2024 22:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AFBC6B0095; Tue, 25 Jun 2024 22:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 164FC6B0092 for ; Tue, 25 Jun 2024 22:43:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B65AE40868 for ; Wed, 26 Jun 2024 02:43:52 +0000 (UTC) X-FDA: 82271494704.11.A0D85A3 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf17.hostedemail.com (Postfix) with ESMTP id C54FC40011 for ; Wed, 26 Jun 2024 02:43:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jnVVlLmx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of hffilwlqm@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=hffilwlqm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719369818; a=rsa-sha256; cv=none; b=G7JzsTg6mRXlh2ixRIrIW0+TE+hg1Bb0UhP0sRt4djAgWi3Ea3gpw94xuG0rJ/3agNHt65 d6IBztcsCckKKfVqeSizrkLzwlNTbSqtI5Hk5MZy8T1XShlHTk8dEgMwXDsYtkjc4AbZ8O 7BOUW3Izlh7Ccptu3bUmkNKZNT7giC0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jnVVlLmx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of hffilwlqm@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=hffilwlqm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719369818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rG3w2INBk5u/Jo1IIm6PkNLzmbMpq9WYWJppu8bUdBY=; b=tvY5DGP9gp5vlmLfcaY7OJ+QdXNXGd+W+ES5khwc7kgYVJOnHjV1/fNZOzsMxYtAQyHMkp QakROCbTsoS5j3Kvw8RpOsxubDKRA7bODTon6BKV6tMmOrve5GUJFa2rkkAW7suu7CcFlQ eRxpUBmVFAfXhIev8knvWYyOxg+avGY= Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5bb36de2171so3044705eaf.2 for ; Tue, 25 Jun 2024 19:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719369830; x=1719974630; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rG3w2INBk5u/Jo1IIm6PkNLzmbMpq9WYWJppu8bUdBY=; b=jnVVlLmxcMbWhmUxyKYuS+wlOZ7WygVqCQAK7yOqZ/UxEYCq0Pah6z/wg1l2QaoJxy 0aBysESAygXQm3gcFI/xymhpNrLycM46XRehq7tZ2VEFh7mVJjTK7Q3CZYsKLmBsEsks /1aFD4FEG7M1aXG0QS4Ee7mi6mdfhrpjRhOjqTbtMBod8GYZC/lr4RYWJsiLqzm8Xj16 uQre9hkxl8Dhke88bEUpN78GKDdfhJCRRBEc8Pll5E8uDTWH3gSO1AbePpbXQzFbuiG9 AP8bzU+uQ8KtyY8DGQJ6KRn62hJIJbLNSrIlp6hxVRIPjk8ggmA2Dby9hWXeGx1SKvS/ 00Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719369830; x=1719974630; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rG3w2INBk5u/Jo1IIm6PkNLzmbMpq9WYWJppu8bUdBY=; b=nYU7ueEtGvZ6t7U/dSDwlNb7LLTzQ/mZDeUpqN3ZGfj1PJqcuJlnkmXzPUlZiVjTMz 3KtTYorHmCVPXgG5CnJDZd3alDWxKfoggXVFZ5AQTIjcXqXGd1mrSclsJkIkwT1MmzIf 9+pab/Hx+CxaXw51QbsbLqAhTNd3Y//MSPzOZzurnMRBzEOQWANSAIkReOw/X5148/SA tzdgRI8uxBUlFtY44CfhOZAGSamfPG4WA/B1WuyB+83pvapmQhL2AkhTHFPjBYKJpV0t IFVU97ZBaT3h99JWjvdGta19owLf+te4VbwOVugE5doF8Wm4IsoMnC/Xjz0hbKBs9j/r Y1zA== X-Forwarded-Encrypted: i=1; AJvYcCWv5qwt7TdA/qs9NX4ccQS21Kf6vcXo4Y3yQ5AFcdV3/3OJaS/xPhwqjZ/TVcGkigLLhKVmgtFgSgQw1+3iGpko2qU= X-Gm-Message-State: AOJu0YxbFM3+dEuOhPLtV+EcWNhwfMsLRNYAEdMhuH9XrsUbVjID8sDF R3uDayYUZcBtJhXygPKjxcOSk64Md6WssP0DjuI7LkC4qjO310+u X-Google-Smtp-Source: AGHT+IEjxmrGj+JcppGKsHuvAml5K0hl12hsilsm8VxYcrA9SLuZHhJ4SZn30SN7L3TgCQBWYTWv2A== X-Received: by 2002:a05:6359:5fa9:b0:1a5:b0f7:259 with SMTP id e5c5f4694b2df-1a5b0f706b4mr62750055d.21.1719369829652; Tue, 25 Jun 2024 19:43:49 -0700 (PDT) Received: from [10.22.68.7] ([122.11.166.8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-716b36487a9sm7856921a12.2.2024.06.25.19.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 19:43:49 -0700 (PDT) Message-ID: Date: Wed, 26 Jun 2024 10:43:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [bpf, x64] f663a03c8e: test-bpf.Tail_call_count_preserved_across_function_calls.fail To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Alexei Starovoitov , bpf@vger.kernel.org References: <202406251415.c51865bc-oliver.sang@intel.com> Content-Language: en-US From: Leon Hwang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C54FC40011 X-Stat-Signature: 19qgcjmigspx8whsc9ptqgebt5ysy4i8 X-Rspam-User: X-HE-Tag: 1719369830-358263 X-HE-Meta: U2FsdGVkX19TQ/U0cGvHGM7XZpN9h2OorGfNBkRXU36/e2hrhgdJeFrBLP90hvs/ONzc1/iJXXJbE3hovAiiGpKF/MDU5UB3mqNF/o04NPEubIxRW4NEobcfx7Cuy8y31hSnvJAI/tFungLBfvTQiOTdZVq0/s+S2vkItiwfyEF8hOE+GU9wFiRb1ZUMKP72x+eTDG9I+aCGVJdAGn24ERd5FU/B/pW2Lceq1wOAdwz4D62P3+JV7d+wfLtV+SY9Y3z8EUP5nyxxKCWmYL2Q1o4rSFf9zGvk2TJXLNmSOofZapKFL3vLjISOBJQnEAKpyyQ1aZWPMHfhcmOJQGiu+FtIcI1i3xL5n6Xs/7iQ/evTA58HdFAoInfsFckg8icNa43gkL5qw7Uvn5NAR6t4Qk+tzK7NPj3dy66nYGeo5lm8i+JxzIC09mVuwIF5d/klEI15so7GObXpkVV7aguAc5mYiexrLNaO8tOEkKwfxR0RK+oCldk9n19fU+FiQ+LCpZlg/nNbDf+/y/by7kyGTn8cQkknit9ptwpPudUH2sUE2uBdbPCcS2rfwoHVqwTF7ass3Mpwi1gq7xbne2CUfwhVkjtwU9jtufK/ETmSonm7cLiNk+heZtbKtirtPQokGkoJEFTdDzbu558V4CyudQZLWznTbP/shs5zpofZM03mAfz5953qyhh46n211RS2dglD2ucH6AHmRwP0gNP+vo6Ag6GvOg/qyVh5/SGE5i5eWcFaCFFgA0Dy5RnG4Zy0kBssW6Csgc29ZaiPgLuI5S//WqU3wS0s47dJ81NrBfb9OiJgp5Sm6Mp8+WiAiHr0skbdmRtLbQHEtY509pofhOcY/DnT3rDoxUZk/AAaibJ26TJtjp7nkQwio3frByXakzxl9eHBwQBgaSF6Sw8TNuutaO590mZw7i7ZV3m/wdYnXs4c+l6kSf8VtpMtOVPwWkmKAiiAN7JQuFGiBLZ U+yaA+n0 DuDlMGJcuD/zrSsZLIhmRyVVKKW6pO/xEBz2Fz1aDrWV7sAcQIPpcLpRYSaakDHcwmIzoDHnbLw92SDY+HFnqdRbhLcDdLnSt00FN9FTe9rehXMJtuXbthZw10WPq5g9O+T2fN1m7gTcK5E8nXmFliNAtTXB7WaFl/DeBEVhzEMnoE/Ffxle/EHgfTnuMpmiqJ0OmmHdm//8N1Jgpbjmahz6vD+P2t9NqkG9704tEzfH03g7SuB9GY6TKbMkhvvQS42zdoPPNlheGJ826pmlFiSgpe0c4yMViPVJbdAQChGQcCy6CG5BuGKFnUaO8msveHVhZFReBrCec81URBTm1edWb9bogHjzb8aHOfines3G6vvhQOgfopRsIbPE9//VcD0ow5sxFcb82p3Eg8cTUVdulGpVwm8QNby+QaD3Y7CSeR+e1fTGebnfQt5WyGcQ9fB07AjvGKNatrF0KzsRM8g+pWeBRePAlx3a0RwkH8x+f+D3kau8CLZhp+09UqRv2nvhqkP665sR792Qgd5GTfUrmESbEx0bk8uQ4UKwvkDsaBDw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/6/24 10:19, Oliver Sang wrote: > hi, Leon Hwang, > > On Tue, Jun 25, 2024 at 04:25:00PM +0800, Leon Hwang wrote: >> >> >> On 25/6/24 14:55, kernel test robot wrote: >>> >>> >>> Hello, >>> >>> kernel test robot noticed "test-bpf.Tail_call_count_preserved_across_function_calls.fail" on: >>> >>> commit: f663a03c8e35c5156bad073a4a8f5e673d656e3f ("bpf, x64: Remove tail call detection") >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master >>> >>> [test failed on linux-next/master 62c97045b8f720c2eac807a5f38e26c9ed512371] >>> >>> in testcase: test-bpf >>> version: >>> with following parameters: >>> >>> test: non-jit >>> >>> >>> >>> compiler: gcc-13 >>> test machine: 36 threads 1 sockets Intel(R) Core(TM) i9-10980XE CPU @ 3.00GHz (Cascade Lake) with 32G memory >>> >>> (please refer to attached dmesg/kmsg for entire log/backtrace) >>> >>> >>> >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-lkp/202406251415.c51865bc-oliver.sang@intel.com >>> >>> >>> >>> [ 43.913560] test_bpf: #0 Tail call leaf jited:1 5 PASS >>> [ 43.913572] test_bpf: #1 Tail call 2 jited:1 ret -1 != 3 FAIL >>> [ 43.914138] test_bpf: #2 Tail call 3 jited:1 ret -1 != 6 FAIL >>> [ 43.914756] test_bpf: #3 Tail call 4 jited:1 ret -1 != 10 FAIL >>> [ 43.915374] test_bpf: #4 Tail call load/store leaf jited:1 5 PASS >>> [ 43.915993] test_bpf: #5 Tail call load/store jited:1 ret -1 != 0 FAIL >>> [ 43.916636] test_bpf: #6 Tail call error path, max count reached jited:1 ret 1000 != 34000 FAIL >>> [ 43.917319] test_bpf: #7 Tail call count preserved across function calls jited:1 ret 1000 != 34000 FAIL >>> [ 43.918799] test_bpf: #8 Tail call error path, NULL target jited:1 5 PASS >>> [ 43.919720] test_bpf: #9 Tail call error path, index out of range jited:1 5 PASS >>> [ 43.920474] test_bpf: test_tail_calls: Summary: 4 PASSED, 6 FAILED, [10/10 JIT'ed] >>> >> >> Hi, >> >> May I request the source code of these test cases? >> I do not find them in lkp-tests. > > test-bpf doesn't have source code. > > you could refer to > https://github.com/intel/lkp-tests/blob/master/programs/test-bpf/run > to see how it runs. > > then > https://github.com/intel/lkp-tests/blob/master/programs/test-bpf/parse > to see how the results are parsed. > I found their source code. Then I fixed it by "bpf: Fix tailcall cases in test_bpf"[0]. [0] https://lore.kernel.org/bpf/20240625145351.40072-1-hffilwlqm@gmail.com/ Thanks, Leon