From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BC3C48260 for ; Fri, 16 Feb 2024 15:36:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 178396B0088; Fri, 16 Feb 2024 10:36:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 128EF6B008A; Fri, 16 Feb 2024 10:36:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F32B86B008C; Fri, 16 Feb 2024 10:36:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E2C7D6B0088 for ; Fri, 16 Feb 2024 10:36:22 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8154A04C9 for ; Fri, 16 Feb 2024 15:36:22 +0000 (UTC) X-FDA: 81798068604.15.64D0A31 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 7571140006 for ; Fri, 16 Feb 2024 15:36:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fXAS9CXU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLNfUmnQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dSrBHIt3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fpMAcemL; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708097780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l4vJJ3H+AAWRQYjB/9/s6lx7LTkhnUXf/MDDTj+Stkc=; b=25785mywpFzsGx3WjPn3VbuDvSXsohrkcetE/qP91Hsl987gpCCRZSXblwuwmoN212bA2z tA3eBTAyMJo+w62F8WellU7F9PjVmjWVVAirWnfZnxdDAnHjTzpzMq4rr543V7F32TxFhe ynNiPWtHGLQZji3fPFkWEFFmc/xvrd0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=fXAS9CXU; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wLNfUmnQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=dSrBHIt3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fpMAcemL; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708097780; a=rsa-sha256; cv=none; b=hqr3CJK0+P7tnw9aga3qItP0j96L8ru19RAxvUBFY6XiYxP9ELK+o321qn21Sd3uu+5qyc QJ4WMnpsfrX8WiOaqQqK5WyeXAAJx+QUv1TTgrzJvhFn0jvAtX3xbi5O1L6BSp55Fio6Cn Fb5Se/9NjMotTNgUW6SAv6Rz/U0iaEY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 883E21F8B2; Fri, 16 Feb 2024 15:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708097778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4vJJ3H+AAWRQYjB/9/s6lx7LTkhnUXf/MDDTj+Stkc=; b=fXAS9CXUF42GhTQH6Dk0ERLDWz+szvtqS4hbHz5hlzO72H5LWH2Wl77vKwF3bU9qC4xybd HjdmQMfgq/Ycq/gNBcmd7PjKo0cEFheG5OeZ6u/bHVMIQAXHtaIoL5Yj6ebO2LJG9XS+CX 3+Vje1sZ5ixTYH+20X2ftwyiFvloZpQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708097778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4vJJ3H+AAWRQYjB/9/s6lx7LTkhnUXf/MDDTj+Stkc=; b=wLNfUmnQHWUDcdPKHwqLu3owRKTcVnwUnzDkwDQ8YYC0pW/hmoNyjQ563BD46+xsjNDUuK MhOxPwPapwY2PFAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708097777; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4vJJ3H+AAWRQYjB/9/s6lx7LTkhnUXf/MDDTj+Stkc=; b=dSrBHIt3uKiS6UBDA1LDFuJGGqb41Kz/+40/qb22uPi50OBP7amfOHDriG5mkg+NJmWi+U qsA7fyXiGrj2MiQRrsQVZThBVvedh2cLeqzrNBzmZGLofYe75EsMAx6s8Xg8OeXMG3SdXd 43cxzKzLMshU7AwlCJqyXmmWyY6b2aU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708097777; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4vJJ3H+AAWRQYjB/9/s6lx7LTkhnUXf/MDDTj+Stkc=; b=fpMAcemL/HQ2lY2evYrW3COdALzWdIIUtvO+/lOtuXTDIKbWXIYZrSnv/m78K626CI9TBX 31xVPf3QzycPgYCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D3BB013A39; Fri, 16 Feb 2024 15:36:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Xg0ZM/CAz2W1QwAAD6G6ig (envelope-from ); Fri, 16 Feb 2024 15:36:16 +0000 Message-ID: Date: Fri, 16 Feb 2024 16:36:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 20/35] lib: add codetag reference into slabobj_ext Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-21-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240212213922.783301-21-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7571140006 X-Stat-Signature: u5pjp8czwmua338m6dnk7iz868759rep X-Rspam-User: X-HE-Tag: 1708097780-265750 X-HE-Meta: U2FsdGVkX1/8M2SQ+JvlpHCLMeKt+HYX+IAiNyATOt8UwiB2MlYop+znoGR8uGl6MeF1GtNHUeePEU+a5pyDwtPTgCg8H56eCEdQYtGBTzN968IL1xPML5aZH8n70QN7rPpICcCaGl+p2I+cg85ODMbcIvNiQm7ailNKx7BQkfX5zi3AY2GtuUxF/fVlgW/nZbIDd72bk+DdxRdqUkei3Fd3bDcp8++nj7WCk5HVll3at4gJlDARh9WcTxOMHyxhP2/jHdn/HBimAjocTAO6/2OO+SXDfBlgb1H2wnjn0WkmtFhmfJWeYcCfaKtc4NLL8EyRIQ7dhcMLNNXiRa8MOFokggfkWoUWajW4Y82CLUbi69SN4oyrodPhFhUrN2IzK2MuXTcOfYKlM9j+M+GQ6EJOzmfsGOWSzxp2smhgwqusd2p3DBBK28q7QWi0J7KC9+xwt/H+WUc0vFcYxqULupqpAvLINA2H3kfl+UsJsEbFlG3tHpVtcKHPrd8f/1ef01yaL78B1RiSZEUEIVkTHCkh3+5fhch6JYKTcSDhylGbyDhBPzBSSg7QUOVbwtoC62dJUsYB3lvzH71f4YIpP44EkpRF1ytluIHrugJT1Di8nwJHt9OPsfJne2ZVVxZw9CtJd3iCqcQBAnf5eA9H8mI4CxUJwkln9t/pmnl/AEq1oe/jFIdyZ7Gb9pmOpovVKXvRHLtnXds5YHEFgCyOk9Hmx6wPTrLCinKuvP0hA6YAUck013/9pS1e5oGP5eSIKOoDZHCk8awk5P+WkhsCSxy8kQ7y1gk0nMgazdQwg9mxX7OM55lIx1AihjF/Jz8H91dCcJfw0oM9EkKiaBqCWvJko+JoYaDtP5wlQTqDhClziUNH+iNSXgJqVZvt69RI7lvEzmXyc74+sww0i9NeRCuXHE4PqZhRDjbegmBqyQRBrEaZbPggSmH6oNhQeFARPkMqL8ucjb3ctfmerKQ 2TBwChhw ld25ZIChgV9kw7xtAzwAN7AW0GiEQtgwaRXxpF76L4cq93O+zP1Z4RpN8eMT60HXuzAsqd4Ga08Vypva4MvIrQYgzsw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/24 22:39, Suren Baghdasaryan wrote: > To store code tag for every slab object, a codetag reference is embedded > into slabobj_ext when CONFIG_MEM_ALLOC_PROFILING=y. > > Signed-off-by: Suren Baghdasaryan > Co-developed-by: Kent Overstreet > Signed-off-by: Kent Overstreet > --- > include/linux/memcontrol.h | 5 +++++ > lib/Kconfig.debug | 1 + > mm/slab.h | 4 ++++ > 3 files changed, 10 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index f3584e98b640..2b010316016c 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1653,7 +1653,12 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > * if MEMCG_DATA_OBJEXTS is set. > */ > struct slabobj_ext { > +#ifdef CONFIG_MEMCG_KMEM > struct obj_cgroup *objcg; > +#endif > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + union codetag_ref ref; > +#endif > } __aligned(8); So this means that compiling with CONFIG_MEM_ALLOC_PROFILING will increase the memory overhead of arrays allocated for CONFIG_MEMCG_KMEM, even if allocation profiling itself is not enabled in runtime? Similar concern to the unconditional page_ext usage, that this would hinder enabling in a general distro kernel. The unused field overhead would be smaller than currently page_ext, but getting rid of it when alloc profiling is not enabled would be more work than introducing an early boot param for the page_ext case. Could be however solved similarly to how page_ext is populated dynamically at runtime. Hopefully it wouldn't add noticeable cpu overhead. > static inline void __inc_lruvec_kmem_state(void *p, enum node_stat_item idx) > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 7bbdb0ddb011..9ecfcdb54417 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -979,6 +979,7 @@ config MEM_ALLOC_PROFILING > depends on !DEBUG_FORCE_WEAK_PER_CPU > select CODE_TAGGING > select PAGE_EXTENSION > + select SLAB_OBJ_EXT > help > Track allocation source code and record total allocation size > initiated at that code location. The mechanism can be used to track > diff --git a/mm/slab.h b/mm/slab.h > index 77cf7474fe46..224a4b2305fb 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -569,6 +569,10 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > > static inline bool need_slab_obj_ext(void) > { > +#ifdef CONFIG_MEM_ALLOC_PROFILING > + if (mem_alloc_profiling_enabled()) > + return true; > +#endif > /* > * CONFIG_MEMCG_KMEM creates vector of obj_cgroup objects conditionally > * inside memcg_slab_post_alloc_hook. No other users for now.