From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A61D41D6F for ; Tue, 12 Nov 2024 09:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8E88D0002; Tue, 12 Nov 2024 04:10:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B671F8D0001; Tue, 12 Nov 2024 04:10:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E12A8D0002; Tue, 12 Nov 2024 04:10:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7D5E38D0001 for ; Tue, 12 Nov 2024 04:10:15 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 24840415CC for ; Tue, 12 Nov 2024 09:10:15 +0000 (UTC) X-FDA: 82776870330.23.1732676 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 6447340009 for ; Tue, 12 Nov 2024 09:09:30 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Uy3RiwD/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731402550; a=rsa-sha256; cv=none; b=WtqwFeSg2diWMuuJO819PIvvRr+9IeVmlgM5wE6zzeX91hTq7ABzxVPr70ggSsdXHCdaUe 0xKlD8GSnK43S06wSw28kJQ//BZF7Bom7uFY7SWkSt7mXEKzufpwzFkwCxKNPS2bkgNAJR irJhd9Z8vFSkOCkHwk7Nkt344VmODys= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Uy3RiwD/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731402550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0abqq4HZmJTT43InWewFIhaF6DjSCEzT4iGToh9hhNU=; b=V7hjFFMh+EhES8L1OmKY2OjlWptPHn8rCybaDeet377fJBmIQ6JixeCVtwBXAKtTvqLXXe C7rNtiqigTpmcKnEnw+MQVfpfDB+MiOTHtHMTnMpepQTqc43bl1dA+DaPnIfQV84DS9suV VdP1HF7FYfW6KXQFcZpJzR35ZIXV1go= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731402612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0abqq4HZmJTT43InWewFIhaF6DjSCEzT4iGToh9hhNU=; b=Uy3RiwD/uKCzJo/t/ECCkDEhNCN2QQfX4liC5DVeSCDFCq1CtE4XduN6f0Gvjv+XcGJevF fZZnFGpH7loP5J9S+aTIQsTBLcrE73uG1nvL7ov3BKdoAAXK0BecAvOMZKV8fjCmKlsSWR Gtbp6R/BZdCUbXMffEx2PYzrPyaeYhs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-7SqmerfqOkaEoVVLhFHoFg-1; Tue, 12 Nov 2024 04:10:10 -0500 X-MC-Unique: 7SqmerfqOkaEoVVLhFHoFg-1 X-Mimecast-MFC-AGG-ID: 7SqmerfqOkaEoVVLhFHoFg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d432f9f5eso2865646f8f.0 for ; Tue, 12 Nov 2024 01:10:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731402609; x=1732007409; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0abqq4HZmJTT43InWewFIhaF6DjSCEzT4iGToh9hhNU=; b=PoGVYtvq6X5iWtgsjlaJ2um45VR37orla1xz2ub9Laxb1iZxM1wBXzuN8LMUTwl68c O3iZPgaKRei2FY19+m+z8Vnga8Xp6GXos4qRDlx9OvJjNWXa7egDbz7up/5fhBXa4eZi 4u4damdzhsHhdz2FGKDt4cw+CKPcn3MSRCxLtUAkIu5f+IuPYSCypXpb2KL4ZQGfZirQ KZGuJ63euTWZ7Uv80XS1JVjMMWyM/XZCSWAHXuX2OPanEt8+EVcx2FWxqDrkY8cL9qGL zZDvoJLyjosC7ikJKKgD2Gc3weghjd1bwpGQC+/aqOkj037vkrTjPLGxRWjiRKOiNZ/c 7DEg== X-Forwarded-Encrypted: i=1; AJvYcCU5yPmrmvXcDvTDI+6nfSPpD6RegTvNYTYIZHUuRLZbrECyclYemKm3Ea8ebh7h/Qg5aok70wpSvQ==@kvack.org X-Gm-Message-State: AOJu0YzkmZ4jp6rFUyHtQ1cRR7eHIaATep8U9MiSXI8HjAK0ryhUzYkJ CcF11BP794wUUkSWFQJFu8qIk2sNIYyKvgQ9UQeoR0cu3F0IwriqasRsB+Zlws6bt0aSfRT+/nl CeErq+jAuPFG4PjCr9VPZtTfEWJH+4uzu1mO/Q/tJiNdgjV4t X-Received: by 2002:a05:6000:1a89:b0:37d:45ab:422b with SMTP id ffacd0b85a97d-38208124c87mr1123733f8f.31.1731402609208; Tue, 12 Nov 2024 01:10:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhoEJKfaThyjDpOjkf9H2w8qMdYtKNWB8k1DPpyFyo5lEgerpeKPRk0eEOg+FsUVAPIPX/8A== X-Received: by 2002:a05:6000:1a89:b0:37d:45ab:422b with SMTP id ffacd0b85a97d-38208124c87mr1123700f8f.31.1731402608775; Tue, 12 Nov 2024 01:10:08 -0800 (PST) Received: from ?IPV6:2003:cb:c739:8e00:7a46:1b8c:8b13:d3d? (p200300cbc7398e007a461b8c8b130d3d.dip0.t-ipconnect.de. [2003:cb:c739:8e00:7a46:1b8c:8b13:d3d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381eda051c6sm14739925f8f.99.2024.11.12.01.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 01:10:08 -0800 (PST) Message-ID: Date: Tue, 12 Nov 2024 10:10:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 00/10] mm: Introduce and use folio_owner_ops To: Matthew Wilcox , Fuad Tabba Cc: Jason Gunthorpe , linux-mm@kvack.org, kvm@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rppt@kernel.org, jglisse@redhat.com, akpm@linux-foundation.org, muchun.song@linux.dev, simona@ffwll.ch, airlied@gmail.com, pbonzini@redhat.com, seanjc@google.com, jhubbard@nvidia.com, ackerleytng@google.com, vannapurve@google.com, mail@maciej.szmigiero.name, kirill.shutemov@linux.intel.com, quic_eberman@quicinc.com, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk References: <20241108162040.159038-1-tabba@google.com> <20241108170501.GI539304@nvidia.com> <9dc212ac-c4c3-40f2-9feb-a8bcf71a1246@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tJ-Ye-DbB-7AxsBtDcc3rkIqv9qO4Z0H4I4m5cINdzs_1731402609 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 6447340009 X-Rspamd-Server: rspam01 X-Stat-Signature: q7q78kyt7gf58cq6r8wbw3hgeb9b89xf X-HE-Tag: 1731402570-846218 X-HE-Meta: U2FsdGVkX1/cco1d9OABdwYRDtqwfzu+qxcI4Rq1VelRJKhoiDDNJSCSaKfIzsg63YcPWnmGULqds622LE+KCYb34Jw12ZX0zl285Kd6XvU8h2GOaZaN8n8m3b+f+m4ZnzNMyUzrlAXyHdyRKYy8usVjJIPlyrRZm++PSHqRsAocsBJVZs2AAA2Sc3PtumKfKwDhs5P4pNWPgHeZE6rRiDnDZP3Ot/32MaTbXEgZVvfhKaCpT6kKlX7C7y7C0ogLCJysIaeknubAwPU9xqQsx8oCbDy7taKeh7ACsYsvvgbBt7u4kGMrTNbbtQPqDDvo/0jw7LnUmP6y9Qd7cv1YJ+N3S6lTeTpqdTC/Gmr4MxtTy+prrcntZhj8VbXSobQ5pn0IP2W6eZ65Uu4iAjiIhamkRKm8m6lY2zdv9uWpHPrAM8BPkVc+o3i1DmU940N81jVsgO6p/22BUlsw0HAWjNN4M6K8xZWP/f6H8yLM8I8h1Eq4V7avZmTEpavVJECkAoQG4xjXDiE+2qYCtR8kvCZfqoNbTY6QJfWbai6A3QRCMIjQfJSUjZSkh36ucNKU7w0A3Hm/mXxrdxr2hiPGLmhEWnlvjhy+/KNsVmy0JApNNyTn4EstmWVqrm1G+rmIol4BIzkN3+XPMET9SUDoNq7BH8wdTauAf3EhV8fLCtnOir0uppvYdSY+NcQWfCIrfXwWjrR9r0fPjcB9E3z+uId8/pCfqvkxr1kkj+VXgjaTr0kaDpv0z9HIzmFNlQu72JB7EyJZ48AGD0mES95a+u9MM9N4waXXPN3g5ZegEqd9JytTLmD6MIhy0hqIlDuPpOa2qt+rHyRb2Egrf8jGQb85CrzZblx82SwmpaH3vYq2z1y6xgp2lg/CS0K0XnoA1KVqXgGvAswz+j4Caolf1BIlayD4Ox/GNSQn06wR1vySwOyyxkEq7YEqeXg6RWo8ByUWPfW4E6LN1BVilN+ 91BED/jt aFdkY4TDgSMK2L3a/uy0URXh//Fk7Jd3JvUlSNab6V4AQR98EIuPZnH0t84vUV/62DSP4NETDBfQm1XF+AAucnOX/D8PQnVaFr0iogGIMgrwAI5+vJVawK1zY+0lSYFX52hRUn3DvPK+UXiCLKuld1g1SXeDDTNlwn1o3HdPn5zA2lMz74cWi2YkAmthtiQh6q8qgEfLiQu9WQa9vfFpHaKdF7bij8V1eNAGOQ5CGTgMpwEWr/fOT2LIDoSbM1VFX7ZtHKdbcjTaxV9UHBBL+gHD1rIpcgCSD2s8dpMTolk117O44J9uA4t1EvzIndCW8FUSsDuUlrdZrd0l/N7JAnQMTdxPWOFOd72hbtZ8n4eGY/4ULmNmOzZEzNnfmgAv7l0rMv/1yybUy4zWHz8UG9kYpIJNTCrq17o5vRHw9PH3EtexSiN9kOogrmOYU122kie4G X-Bogosity: Ham, tests=bogofilter, spamicity=0.009625, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.11.24 06:26, Matthew Wilcox wrote: > On Mon, Nov 11, 2024 at 08:26:54AM +0000, Fuad Tabba wrote: >> Thanks for your comments Jason, and for clarifying my cover letter >> David. I think David has covered everything, and I'll make sure to >> clarify this in the cover letter when I respin. > > I don't want you to respin. I think this is a bad idea. I'm hoping you'll find some more time to explain what exactly you don't like, because this series only refactors what we already have. I enjoy seeing the special casing (especially hugetlb) gone from mm/swap.c. I don't particularly enjoy overlaying folio->lru, primarily because we have to temporarily "evacuate" it when someone wants to make use of folio->lru (e.g., hugetlb isolation). So it's not completely "sticky", at least for hugetlb. Overlaying folio->mapping, similar to how "struct movable_operations" overlay page->mapping is not an option, because folio->mapping will be used for other purposes. We'd need some sticky and reliable way to tell folio freeing code that someone wants to intercept when the refcount of that folio goes to 0, and identify who to notify. Maybe folio->private/page->private could be overlayed? hugetlb only uses folio->private for flags, which we could move to some other tail page (e.g., simply putting them into flags1). -- Cheers, David / dhildenb