linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, dm-devel@redhat.com,
	Song Liu <song@kernel.org>,
	linux-raid@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Dave Kleikamp <shaggy@kernel.org>,
	jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com,
	Bob Peterson <rpeterso@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	gouhao@uniontech.com,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible
Date: Tue, 30 May 2023 08:49:22 -0700	[thread overview]
Message-ID: <e809b83d60d9fb0f65a8116b3e50f1432f594725.1685461490.git.johannes.thumshirn@wdc.com> (raw)
In-Reply-To: <cover.1685461490.git.johannes.thumshirn@wdc.com>

When the iomap buffered-io code can't add a folio to a bio, it allocates a
new bio and adds the folio to that one. This is done using bio_add_folio(),
but doesn't check for errors.

As adding a folio to a newly created bio can't fail, use the newly
introduced __bio_add_folio() function.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/iomap/buffered-io.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 063133ec77f4..42c5fc0ad329 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -312,7 +312,7 @@ static loff_t iomap_readpage_iter(const struct iomap_iter *iter,
 			ctx->bio->bi_opf |= REQ_RAHEAD;
 		ctx->bio->bi_iter.bi_sector = sector;
 		ctx->bio->bi_end_io = iomap_read_end_io;
-		bio_add_folio(ctx->bio, folio, plen, poff);
+		__bio_add_folio(ctx->bio, folio, plen, poff);
 	}
 
 done:
@@ -539,7 +539,7 @@ static int iomap_read_folio_sync(loff_t block_start, struct folio *folio,
 
 	bio_init(&bio, iomap->bdev, &bvec, 1, REQ_OP_READ);
 	bio.bi_iter.bi_sector = iomap_sector(iomap, block_start);
-	bio_add_folio(&bio, folio, plen, poff);
+	__bio_add_folio(&bio, folio, plen, poff);
 	return submit_bio_wait(&bio);
 }
 
@@ -1582,7 +1582,7 @@ iomap_add_to_ioend(struct inode *inode, loff_t pos, struct folio *folio,
 
 	if (!bio_add_folio(wpc->ioend->io_bio, folio, len, poff)) {
 		wpc->ioend->io_bio = iomap_chain_bio(wpc->ioend->io_bio);
-		bio_add_folio(wpc->ioend->io_bio, folio, len, poff);
+		__bio_add_folio(wpc->ioend->io_bio, folio, len, poff);
 	}
 
 	if (iop)
-- 
2.40.1



WARNING: multiple messages have this Message-ID
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Ming Lei <ming.lei@redhat.com>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, dm-devel@redhat.com,
	Song Liu <song@kernel.org>,
	linux-raid@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Dave Kleikamp <shaggy@kernel.org>,
	jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com,
	Bob Peterson <rpeterso@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	gouha7@uniontech.com,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible
Date: Wed, 31 May 2023 04:38:01 -0700	[thread overview]
Message-ID: <e809b83d60d9fb0f65a8116b3e50f1432f594725.1685461490.git.johannes.thumshirn@wdc.com> (raw)
Message-ID: <20230531113801.oqrRQw9_ZJBj2bneKuRQoPnF-jA9BsQyVPDudu74HWg@z> (raw)
In-Reply-To: <cover.1685461490.git.johannes.thumshirn@wdc.com>

When the iomap buffered-io code can't add a folio to a bio, it allocates a
new bio and adds the folio to that one. This is done using bio_add_folio(),
but doesn't check for errors.

As adding a folio to a newly created bio can't fail, use the newly
introduced __bio_add_folio() function.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/iomap/buffered-io.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 063133ec77f4..42c5fc0ad329 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -312,7 +312,7 @@ static loff_t iomap_readpage_iter(const struct iomap_iter *iter,
 			ctx->bio->bi_opf |= REQ_RAHEAD;
 		ctx->bio->bi_iter.bi_sector = sector;
 		ctx->bio->bi_end_io = iomap_read_end_io;
-		bio_add_folio(ctx->bio, folio, plen, poff);
+		__bio_add_folio(ctx->bio, folio, plen, poff);
 	}
 
 done:
@@ -539,7 +539,7 @@ static int iomap_read_folio_sync(loff_t block_start, struct folio *folio,
 
 	bio_init(&bio, iomap->bdev, &bvec, 1, REQ_OP_READ);
 	bio.bi_iter.bi_sector = iomap_sector(iomap, block_start);
-	bio_add_folio(&bio, folio, plen, poff);
+	__bio_add_folio(&bio, folio, plen, poff);
 	return submit_bio_wait(&bio);
 }
 
@@ -1582,7 +1582,7 @@ iomap_add_to_ioend(struct inode *inode, loff_t pos, struct folio *folio,
 
 	if (!bio_add_folio(wpc->ioend->io_bio, folio, len, poff)) {
 		wpc->ioend->io_bio = iomap_chain_bio(wpc->ioend->io_bio);
-		bio_add_folio(wpc->ioend->io_bio, folio, len, poff);
+		__bio_add_folio(wpc->ioend->io_bio, folio, len, poff);
 	}
 
 	if (iop)
-- 
2.40.1



  parent reply	other threads:[~2023-05-30 15:50 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 15:49 [PATCH v6 00/20] bio: check return values of bio_add_page Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 01/20] swap: use __bio_add_page to add page to bio Johannes Thumshirn
2023-05-31  4:20   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 02/20] drbd: " Johannes Thumshirn
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 03/20] dm: dm-zoned: use __bio_add_page for adding single metadata page Johannes Thumshirn
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 04/20] fs: buffer: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-05-31  1:20   ` Gou Hao
2023-05-31  4:20   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 05/20] md: use __bio_add_page to add single page Johannes Thumshirn
2023-05-31  4:21   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 06/20] md: raid5-log: " Johannes Thumshirn
2023-05-31  4:21   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 07/20] md: raid5: use __bio_add_page to add single page to new bio Johannes Thumshirn
2023-05-31  4:21   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 08/20] jfs: logmgr: use __bio_add_page to add single page to bio Johannes Thumshirn
2023-05-31  4:21   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 09/20] gfs2: use __bio_add_page for adding " Johannes Thumshirn
2023-05-31  4:22   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 10/20] zonefs: " Johannes Thumshirn
2023-05-31  4:22   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 11/20] zram: " Johannes Thumshirn
2023-05-31  4:22   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 12/20] floppy: " Johannes Thumshirn
2023-05-31  4:23   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 13/20] md: check for failure when adding pages in alloc_behind_master_bio Johannes Thumshirn
2023-05-30 20:40   ` Song Liu
2023-05-31  4:23   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 14/20] md: raid1: use __bio_add_page for adding single page to bio Johannes Thumshirn
2023-05-31  4:23   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails Johannes Thumshirn
2023-05-31  4:25   ` Christoph Hellwig
2023-05-31  4:58     ` Song Liu
2023-05-31  7:54       ` Paul Menzel
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 16/20] dm-crypt: check if adding pages to clone " Johannes Thumshirn
2023-05-30 16:10   ` Mike Snitzer
2023-05-30 16:20     ` Johannes Thumshirn
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 17/20] block: mark bio_add_page as __must_check Johannes Thumshirn
2023-05-31  4:25   ` Christoph Hellwig
2023-05-31 11:37   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 18/20] block: add __bio_add_folio Johannes Thumshirn
2023-05-30 15:57   ` Matthew Wilcox
2023-05-31  4:26   ` Christoph Hellwig
2023-05-31 11:38   ` Johannes Thumshirn
2023-05-30 15:49 ` Johannes Thumshirn [this message]
2023-05-30 15:58   ` [PATCH v6 19/20] fs: iomap: use __bio_add_folio where possible Matthew Wilcox
2023-05-31  4:29   ` Christoph Hellwig
2023-05-31 11:38   ` Johannes Thumshirn
2023-05-30 15:49 ` [PATCH v6 20/20] block: mark bio_add_folio as __must_check Johannes Thumshirn
2023-05-30 15:58   ` Matthew Wilcox
2023-05-31  4:29   ` Christoph Hellwig
2023-05-31 11:38   ` Johannes Thumshirn
2023-05-31 11:37 ` [PATCH v6 00/20] bio: check return values of bio_add_page Johannes Thumshirn
2023-05-31 11:50 ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e809b83d60d9fb0f65a8116b3e50f1432f594725.1685461490.git.johannes.thumshirn@wdc.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=agruenba@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=cluster-devel@redhat.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gouhao@uniontech.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=rpeterso@redhat.com \
    --cc=shaggy@kernel.org \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox