From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31C2C54ED1 for ; Wed, 28 May 2025 02:58:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EFBF6B00AC; Tue, 27 May 2025 22:58:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7656B00AD; Tue, 27 May 2025 22:58:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DCEA6B00AF; Tue, 27 May 2025 22:58:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 43EA16B00AC for ; Tue, 27 May 2025 22:58:18 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C50A6BFF6A for ; Wed, 28 May 2025 02:58:17 +0000 (UTC) X-FDA: 83490807834.25.90AB024 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf08.hostedemail.com (Postfix) with ESMTP id 61EE4160004 for ; Wed, 28 May 2025 02:58:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748401096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCBIUW9uaBv9Ffr4YbE6c0pY6Bm+TvYpaVYXBprpIRA=; b=BsVpKvOgGCRrfYtFsi8HmDQtRBq/m2SzIwIB+0gp6S89vH9aiuB0T5jlCadEpHwLzO1PES WumTv7yHK3ZDIBGz77KajtaE794RwEMyVMYWOUF9oMX2GhICyW4Bd5LfPzmyIJeg454j2v Bz+tmTmyYQFpFihUEKkM3rokIHTETPA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748401096; a=rsa-sha256; cv=none; b=plE9KK9zre357Mzrrw33CyIUeOSIaOi70Ynb0kZal9xDLwPSTHd5NifN816pSYFLd3OQaz O9oJ3sgjTm/NU3ilD6AqRUExwqQE18Kw3E/emG2VRxaI1v32XybgMIOcJx+Odt6xIObxi7 YLieXnm39Igus26EflQWXyPbhlUoOE4= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4b6Z0S6sWJztRYt; Wed, 28 May 2025 10:56:56 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id 5274B180080; Wed, 28 May 2025 10:58:11 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 28 May 2025 10:58:10 +0800 Message-ID: Date: Wed, 28 May 2025 10:58:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] mm/contig_alloc: fix alloc_contig_range when __GFP_COMP and order < MAX_ORDER To: Zi Yan , Andrew Morton CC: David Hildenbrand , , , References: <20250421013620.459740-1-tujinjiang@huawei.com> <0a6fa00f-0e48-4101-b2ad-23c9a964b740@redhat.com> <5CD028AA-64B7-4A93-8679-AAC5869B8C15@nvidia.com> <0b4308e5-97ed-4a82-ac8c-a9061cb4d5f0@redhat.com> <4023fc44-aafb-1895-e6db-b27f11ddc7cc@huawei.com> <20250527191948.2ffdc5d432dbacedeb473965@linux-foundation.org> <3B848F95-2904-4E47-B682-F3EAC2877D14@nvidia.com> From: Jinjiang Tu In-Reply-To: <3B848F95-2904-4E47-B682-F3EAC2877D14@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemo200002.china.huawei.com (7.202.195.209) X-Rspamd-Queue-Id: 61EE4160004 X-Stat-Signature: ztcxbz6fxobsfau5sixkafby877b8gpp X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748401095-941069 X-HE-Meta: U2FsdGVkX18+0fEDwX5QSCBNSQzECQo4xurWpcjRT60p/ijhQlNg1dPf+XuwbtEzDbfYmEAi2oiklKH72MHgvz4W4lvDJiOpmq5LnO/90pd0xCQwNl0cfuqE4MUP7lXABuV8RxoyexqxC4O524Vmyf5sjq35qHvvglumzi/jmgzqUoFTH6JBK68kU7vGG3yj7cu+0GwDJIPXig/O2IZm7xL+SrtQzF35TPWha828NKNxm0SZIkyeFSr+4KRrKazPj3vtfwa4h7eWIp1LT9AFGkkMQSOFjOHN6Shjwt/v0kLB/myPkiprspQRdpf4yMrYxCF+tQiPHFMHR+unkwqCAGJ0e1ThU8RhjgAAorF4VoZHeMnUUrh2onwNxYCONmqS8bQiXNwyXNIc1e32X+fVUjuDQpAPaASv3Papb35pznOqs6wMw0iftwk7OiVTPfClO8sMXNKR5MAWrm7u3HdCu/5Fld3qLNYQmMQqMSZkaMi3er3q4yEjjl6DuvNTQM21MIArI6MKHytJOgcebBRLGiUhpaEb/RpY8yogz3Q9ZS3GWazDiI7MhBJ+Sde+BG+ggnqSeLPhBmtaUd0eRsPCl//TE2hF4aRBFTKqCUdxSr8HgIapzWV2WHmREGKHuq90nATeIM8fiUfsyPqlzteA21YM5cu5dxAUrMP5TVfzT0tC+9DaTjcpOatVT8Q1LO0I2oZO7Yn6Ii64QAMCyV433f3B+ueeoNB7XqDmphTMlOOPH9uFxi5Ppr/UDuCkIep35kJj9kPwdKWMHJVJc/DAKOuOPcX8sVJYVj3vau2zGV6G1LkO84w1jJ/KP195BKW3uzWw4J8lo367WAFIk946scs0ytJDMZogUoQOpbyMkDVEgBbJaQ6evipLP0pVS0zs9MxQTN1Rjqr1gzLgGzNBhWNRC5ZvSqHGLPpFdjYhvJkjxHa/y+CimlZtk+28MirTpiuySB3eUd+ZtbWtm4+ h8tv3Y9a gPA+6HIfL65dpXN6gVWOMFbntXQERQnTL9P7HrtlDK9bZ4I+xkH8521fitT2EijZ+4T/evn1KDLuG9ccd7N2zls6N5Ka/vIqnJvtnokEctA5gsKfdGTXEq+5ZYhOZIH9OtZZI1kui6QUstbTlut0sNkDn0kvdXTBZL5GPnpkUV5K/mvbgEK1wAYaG4xwvIfP6cqkwzBUdG5zC2k8FnWEqpUZso4SeEG32O6BVY/7Eu7bnbZtYmYYI0dhj7qsEcUkBJcykT9zjzqKRus/oZxaGXZes0jMATqtWblIyFsjlg1GSzU2wvh186+59+kjKDI/x6Uvm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/5/28 10:25, Zi Yan 写道: > On 27 May 2025, at 22:19, Andrew Morton wrote: > >> On Mon, 12 May 2025 09:13:31 +0800 Jinjiang Tu wrote: >> >>>>> The change below makes the code cleaner. Acked-by: Zi Yan >>>>> >>>> Jinjiang, can you integrate that into your patch and resend? >>> Sorry for late reply. I will do it today. >>> >> As far as I know, this is still pending. The patch does address a >> WARN() and it's cc:stable, so it's rather important. >> >> I'll move the v2 patch back into mm-new and shall keep it there to >> remind me to bug people about it ;) >> >> >> David (and everyone!), please don't be afraid to grab someone else's >> patch, apply changes and send it in. Stuff happens, and doing this is well >> within accepted processes. > Hi Andrew, > > Based on my understanding, this patch is fixing an out-of-tree driver > issue, so Jinjiang is responsible to resolve David’s concerns. > > Hi Jinjiang, > > Let me know if I miss anything. And if you are not planning to keep > working on it, please let Andrew know so he can drop it. Yes, this issue doesn't exist for any in-tree users. I found v2 patch is buggy and reply in the v1 patch (https://lore.kernel.org/all/80039e40-a518-a85b-b955-96fb048a2dd0@huawei.com/). The fixed patch is little complicated. Since there is no in-tree user currently, it is enough if we simply fail if the range order < MAX_ORDER with __GFP_COMP. If it is valuable to handle this situation, in case in-tree users in the future need to allocate folio with order < MAX_ORDER, I would like to keep working on it. > Thanks. > > Best Regards, > Yan, Zi