From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACAA1E77184 for ; Tue, 17 Dec 2024 22:33:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113DB6B008C; Tue, 17 Dec 2024 17:33:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09CDB6B0092; Tue, 17 Dec 2024 17:33:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E315C6B0093; Tue, 17 Dec 2024 17:33:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C2C896B008C for ; Tue, 17 Dec 2024 17:33:19 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7A304A03EC for ; Tue, 17 Dec 2024 22:33:19 +0000 (UTC) X-FDA: 82905902352.23.41686D7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 3708580020 for ; Tue, 17 Dec 2024 22:32:16 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M9r+psXA; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734474762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oasFH9YS/5nOK6GsM6YHhbVvy+xnvzjUtw4Gpik0lY0=; b=ZKudWxp7EcIc8YGafOjE9w1QSSPT/hgLtBmu4ZQOcNlzBhPzosAmD55BfXSwAvQ4EQ9UJ9 IXJuesoKSSIpTkk5gQibDeURntvIsIn+wg6ekEBF34hcrcoRXKCiASoItU/EDF2nrQHtQD j2jhrOM6v/hst1WOqu8DwMMwQ6vqQOQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734474762; a=rsa-sha256; cv=none; b=EMzD59zk3FGXQzRd/Cxz8Xnpu+x8MJJBQyV+saprj2w3WFJz7JDKdxBb41Yx/NVS9Gf5C+ QgI92gjcQLiJqlAIDD3DdGXsZXjj0qV4DgcQ3TJvkT2677pK408UyudtMiwHpq2zVNBRC6 f51hiL45GlV5OOwOMyoD7ucc8tQGGyk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M9r+psXA; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734474794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oasFH9YS/5nOK6GsM6YHhbVvy+xnvzjUtw4Gpik0lY0=; b=M9r+psXAW9Vn1tW0jD44KqM4BshPlvEpkEiuvrIC5uqoFVpUf2bZgidDEaCK+igjZ9TcLP GcZxIIWRmrMYSUs9tAna3WcfCYXidVUy+hMJ+EzceTA+vQG0sVgT723viK2nEIge6HCLed dKvbKMgwPgP1T2d4qalBvye3JusLCQQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-FQN2mOqhPmSsPt0Hhbxzsw-1; Tue, 17 Dec 2024 17:33:13 -0500 X-MC-Unique: FQN2mOqhPmSsPt0Hhbxzsw-1 X-Mimecast-MFC-AGG-ID: FQN2mOqhPmSsPt0Hhbxzsw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43627bb20b5so45046065e9.1 for ; Tue, 17 Dec 2024 14:33:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734474792; x=1735079592; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oasFH9YS/5nOK6GsM6YHhbVvy+xnvzjUtw4Gpik0lY0=; b=Eg/jQ39GJ5LU8DSqfUQKxcbbkx6XxTqm73cFHsZK9ZcESXF+VbsLq3j9dbyMoDiZwu 4KnpcBax70ORj8DUZObro/9JOg3Ge8PW3Mo1hd4zHkxz2hrm5fXn/loRdnHZTViTd/Hx rG8SfQcBBfHd/t1UhyJizUeuG5SM5zt4SvZNpY96QDevr9vpu2hc3a++y6WW8NBcDkiK KrOCmd/Kddg1nih6etgWiy1+fSRkNsfUTdUTF4KxOZIwtPan27xgmMZNAsrWexDaWEjj 0Y1XSGGhKbzExIhvnxThagCbPqPTCL5dAvnviPF7J0nJGqg+hdBQrmS/S1PPD6b4EPn2 g96w== X-Forwarded-Encrypted: i=1; AJvYcCX5sXpBhUcsSOvsnP/+3ZqAfbCk7Z9Y7FADf4jgI8dQfEvuEQ0VfF3xkVlSbu0IzOEeDhoKP7vtdw==@kvack.org X-Gm-Message-State: AOJu0YyEWvaRmTHyXhO/cgQBL+cAfZCp8/Nqz6X1qOAxeQ7ZnwRsiCXg TCfXIREvtoTGgq6JsSMqg7SzwcJ62HxlARmIFtEly9Kbl6zMlelhRia6R5H/gLSzXn67fk/vdof WpP+JM4GKhS7SLiPAvTikI0K7kP02vhZx7oxjq8socz0aOsjtNE3eDEtt X-Gm-Gg: ASbGncvl5f0zwpT/MwytzId8dPqZlNXU5pXfQrw+b3lzrSoJElS2Fn1woGeusrkjy5w FlNa5xnOPCQSxL3XouGctt+t9XgIiyKAnA70enGcNpTfu2ULGxGVvRiEfFvDKJ9ZgKgg9P/ywta lOlQgtxeo7RHA32tqayc29gqr9qiYJxjvbKBwSFRY7CwxCDUJOB+SYsOiphwBtsN3pCJrtHP9g1 2xJl6n1iG3aIyTz8HWYwFr/3lArWIsL0p83h1pd/zydUN4d3BwlNoO7jhlGNlES7Rbf4qiNiqNl Tm0BnzgzQ8yNNKT3J1dhIp7CFsZY6lBwH0BeA9m6A/3S5wkMEuNZDsbwRy+iopiMC0mJNZCtQWv rh3tms6nr X-Received: by 2002:a05:600c:4448:b0:434:a90b:94fe with SMTP id 5b1f17b1804b1-4365535b4e6mr4138085e9.10.1734474792406; Tue, 17 Dec 2024 14:33:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHu5Rpx/75DKHPvdCspqV2eTg6oVqu83uuIMN0kGm64YISiw1ESXOe+JcsaDrCGOH1qe5B+Gg== X-Received: by 2002:a05:600c:4448:b0:434:a90b:94fe with SMTP id 5b1f17b1804b1-4365535b4e6mr4137665e9.10.1734474792038; Tue, 17 Dec 2024 14:33:12 -0800 (PST) Received: from ?IPV6:2003:cb:c73b:5600:c716:d8e0:609d:ae92? (p200300cbc73b5600c716d8e0609dae92.dip0.t-ipconnect.de. [2003:cb:c73b:5600:c716:d8e0:609d:ae92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b1a195sm190205e9.36.2024.12.17.14.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2024 14:33:10 -0800 (PST) Message-ID: Date: Tue, 17 Dec 2024 23:33:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/25] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kol2y56h_duTnOqPK0TdUi7scy2DQCNmITlLSepTW2o_1734474792 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3708580020 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: qtfi99ch59739d1apo5pjnwwe58aq3sy X-HE-Tag: 1734474736-991478 X-HE-Meta: U2FsdGVkX1/5yLlGBgWUSmZZeXCMiOKqdkLM0oQMkb111jf5ZbS0iz0eBeElNuxGM9O3YEXQSnwSL1yypzOI4j8sNcvluafvy7BtDjXIZC7VtMXd7TByOzJKaOyAM8jUogYreMQMBKppdQYzLrbSuC0E83BvoCNXHm4ba3kCtuNYHbcofQikRlsiI3NfMyZ9Jotj8egAdwytkD8rggALDGOg2Dj8x6wC9uIkR5VsSZGVShr5jLOiTIqdnqONUfdTCFUl4Pm5wvU2xrLHsWIOUD1ovcdTcD4imivKiJLm6CDC0qqfA6TpjIbZ7PVt2o7TifQBn2iY2sEOB2RuKfybI9X6InMvsDopUnHn9MIVgIETSMdD/wdpTcfPNa5AbWpJP0jBG9QSW3iWGp5t+IL1oitpv82LkO56t+REETeyMJpCaZw7up6t4tYgYfQIRlkMKLzPUNVMsOYQxlDNm7shMVWag+Z8ZkA8YwZNrM3M9CbTWfuCMb7p1QxemPd3tx2hRY0Y5jl2Pvno7HCqE2x2SF6Tz+GJXyz1xXxboVDGWnAP5w+SqE1TRdMJncBK5qoI6hZ45FRAVWZN/zyllVzksSjo5yrfxrpCcE2zETIZwTOeD+jaDRsES+TBukgErbW/7YfHhzavDfhlGl+dPZEc2AG120ubMREdN8BgQqfEPI0Q+5n0EwU30A2UMhDUz8QeL/7qb7ZWsZAT8LLRzEhFQFX/8lbF1sPL6hoNFMS+wpxmSYAn00k/twc9A59xycuaA4YwBsm+4ArYEDhyjlRTnqzkgnDWjL3bUeDyyJN7g9RQ44T03a4r51jNElOtEHns+JBvBtSRy+c/zHs4dmAxYGxlVbVMjnrZ4HW9eQTFDXHBzDogsJamaLiXisCKCQ9W2OBneo+qkt4gAFjUfQ+J6LZrh2EyxCSFgHwkdjaNXhTi6kGUUknhgLLhdcQ0v/78GK6tWbfCCGFaGspVc4N WsazSU9J aRfxnCZZ3RscD8/yX/sx3dN1j05eoEMEqQLjHV8u4X7OQH0UKPaxkp5Zs+Vw8Za49Zd77/eFafSB2EntXfebFLSkT25/tZsOexn3g0DHGVva35+E9DWuA86qxwYo0/sOJ7HAxm3ufSTXglf6TMjI61K7tbTWhmAqWAQD56GIO7+HJiilzaSfyaJ2rw+XqE/2xLWhooKuLOklwSU58BNcTTaAT6LVOmJMUJSUiWV2UB4WJlCNiCLE5aZ82Al1rxhljbT9f0augyNnz3TESouz+2Py1mYtrdncEwv0pnN5lRBzqlRrqPTsxktvcAMHqH/s+4Cd3W7U/X+yZR5Viia34DgAQnql8Atlgu4qP0QD1biJcrzJLE+hvbdIrqslDBNnfEb+nKjM9DGP4Nfn1MELbr1nxDOothMo+ZgKFLiVfjalvvBmZ7KlCfswvOvZdw+RoPpeMCt4AV4H+6CHMjXXE8DVwTv3HXeNsXCTr+Vye6hFHWA0KiDfV/REoz8Vgy6o9N77DmG3L0bX7fEudw4Cqqr4hnfBoCD5BbJDopiUlX9o85Y1LdG9pb692BQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.12.24 06:13, Alistair Popple wrote: > Longterm pinning of FS DAX pages should already be disallowed by > various pXX_devmap checks. However a future change will cause these > checks to be invalid for FS DAX pages so make > folio_is_longterm_pinnable() return false for FS DAX pages. Nit: I'd consistently use "mm/gup:" as prefix for GUP-related patches. (similarly, mm/huge_memory and mm/rmap in the other patches) > > Signed-off-by: Alistair Popple > Reviewed-by: John Hubbard > --- > include/linux/mm.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index f267b06..01edca9 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2078,6 +2078,10 @@ static inline bool folio_is_longterm_pinnable(struct folio *folio) > if (folio_is_device_coherent(folio)) > return false; > > + /* DAX must also always allow eviction. */ > + if (folio_is_fsdax(folio)) > + return false; > + > /* Otherwise, non-movable zone folios can be pinned. */ > return !folio_is_zone_movable(folio); > Acked-by: David Hildenbrand -- Cheers, David / dhildenb