From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB55C63777 for ; Wed, 18 Nov 2020 08:55:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B55862463B for ; Wed, 18 Nov 2020 08:55:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B55862463B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24D8E6B0036; Wed, 18 Nov 2020 03:55:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FD816B005C; Wed, 18 Nov 2020 03:55:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 113846B0070; Wed, 18 Nov 2020 03:55:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id D6A1C6B0036 for ; Wed, 18 Nov 2020 03:54:59 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 883FB181AC9BF for ; Wed, 18 Nov 2020 08:54:59 +0000 (UTC) X-FDA: 77496929118.23.sheep50_601348527338 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 6FF1D37604 for ; Wed, 18 Nov 2020 08:54:59 +0000 (UTC) X-HE-Tag: sheep50_601348527338 X-Filterd-Recvd-Size: 4033 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 08:54:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 65CA0AD45; Wed, 18 Nov 2020 08:54:57 +0000 (UTC) To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Mike Snitzer , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201118084800.2339180-1-hch@lst.de> <20201118084800.2339180-20-hch@lst.de> From: Coly Li Subject: Re: [PATCH 19/20] bcache: remove a superflous lookup_bdev all Message-ID: Date: Wed, 18 Nov 2020 16:54:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201118084800.2339180-20-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/18/20 4:47 PM, Christoph Hellwig wrote: > Don't bother to call lookup_bdev for just a slightly different error > message without any functional change. >=20 > Signed-off-by: Christoph Hellwig ist Hi Christoph, NACK. This removing error message is frequently triggered and observed, and distinct a busy device and an already registered device is important (the first one is critical error and second one is not). Remove such error message will be a functional regression. Coly Li > --- > drivers/md/bcache/super.c | 44 +-------------------------------------- > 1 file changed, 1 insertion(+), 43 deletions(-) >=20 > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index e5db2cdd114112..5c531ed7785280 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2380,40 +2380,6 @@ kobj_attribute_write(register, register_bcache)= ; > kobj_attribute_write(register_quiet, register_bcache); > kobj_attribute_write(pendings_cleanup, bch_pending_bdevs_cleanup); > =20 > -static bool bch_is_open_backing(struct block_device *bdev) > -{ > - struct cache_set *c, *tc; > - struct cached_dev *dc, *t; > - > - list_for_each_entry_safe(c, tc, &bch_cache_sets, list) > - list_for_each_entry_safe(dc, t, &c->cached_devs, list) > - if (dc->bdev =3D=3D bdev) > - return true; > - list_for_each_entry_safe(dc, t, &uncached_devices, list) > - if (dc->bdev =3D=3D bdev) > - return true; > - return false; > -} > - > -static bool bch_is_open_cache(struct block_device *bdev) > -{ > - struct cache_set *c, *tc; > - > - list_for_each_entry_safe(c, tc, &bch_cache_sets, list) { > - struct cache *ca =3D c->cache; > - > - if (ca->bdev =3D=3D bdev) > - return true; > - } > - > - return false; > -} > - > -static bool bch_is_open(struct block_device *bdev) > -{ > - return bch_is_open_cache(bdev) || bch_is_open_backing(bdev); > -} > - > struct async_reg_args { > struct delayed_work reg_work; > char *path; > @@ -2535,15 +2501,7 @@ static ssize_t register_bcache(struct kobject *k= , struct kobj_attribute *attr, > sb); > if (IS_ERR(bdev)) { > if (bdev =3D=3D ERR_PTR(-EBUSY)) { > - bdev =3D lookup_bdev(strim(path)); > - mutex_lock(&bch_register_lock); > - if (!IS_ERR(bdev) && bch_is_open(bdev)) > - err =3D "device already registered"; > - else > - err =3D "device busy"; > - mutex_unlock(&bch_register_lock); > - if (!IS_ERR(bdev)) > - bdput(bdev); > + err =3D "device busy"; > if (attr =3D=3D &ksysfs_register_quiet) > goto done; > } >=20