From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5FBC02198 for ; Fri, 14 Feb 2025 07:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C902280004; Fri, 14 Feb 2025 02:17:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 552296B0085; Fri, 14 Feb 2025 02:17:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F360280004; Fri, 14 Feb 2025 02:17:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1ECA16B0083 for ; Fri, 14 Feb 2025 02:17:48 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C069081EE7 for ; Fri, 14 Feb 2025 07:17:47 +0000 (UTC) X-FDA: 83117695374.19.E6970CD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 73793140002 for ; Fri, 14 Feb 2025 07:17:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739517466; a=rsa-sha256; cv=none; b=i75WIOWDJH77qmUCTATKUc1NmvE/dNr3ImxfvLlXfv8Y5OPp2+8Txwquh9ikexyoy8yacd /CpOpryvl43kjwh2cayPs4Lvg5/Spx9+yA1Y35vlna3wuXiS4oEvNwfQfc9Sy67jVA/kN9 qzW0nYS6ZK37Igx1DOn6qUMdJV0WI0E= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739517466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5liOe1ZfB0Q57IX2e/O41rSLKkELnsqj5ECCxID4SXY=; b=5BhrBtjWJgZQWNrdrW6+SNiE+INtDHOOjmRD5d4zVxP95yKsSkfbOHuv55h1RNyjz5o3/6 vIYI7doppNjqvoMnBvcmw9hvK4MXLMQA6pqBNjjggKHYlGMVhrfwgZFjfqURDEsbgEokl8 /twsYxlMBkd7Oeo0ySQIDCfp+YU47MI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D429D113E; Thu, 13 Feb 2025 23:18:03 -0800 (PST) Received: from [10.163.37.128] (unknown [10.163.37.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A8453F58B; Thu, 13 Feb 2025 23:17:34 -0800 (PST) Message-ID: Date: Fri, 14 Feb 2025 12:47:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Christophe Leroy , linux-mm@kvack.org Cc: steven.price@arm.com, Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <4fa83d76-117f-41bc-9137-676fb0c204dd@csgroup.eu> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <4fa83d76-117f-41bc-9137-676fb0c204dd@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 6hx4xrinra6kzh7sc3e8c8ykd4oukp8x X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 73793140002 X-Rspam-User: X-HE-Tag: 1739517464-516694 X-HE-Meta: U2FsdGVkX1+PB5mX91leydmA8VjeRbp/5HtjjPxIrgVIpoTKazhULgFKdzv9sQREANpCyWC5DwcNmLus+RgqxU56TpKLg4y13KID1hmDeC7NtrYwqBG4P0BEtiuYCTKQD87bLGRhP2Gda31l58IPO4SQt35FZ6OGe6rIsE2Dc7IvetZAf1KOwLQ3oyWHFVCNkBX+s2Gf6ZqcX9Wt/fZK2u+boAB8658cPc8+Bw77VsSC8Ly2bRB2VTDQZ5y0RwIBDaOqrJMCvgxG95A3IWE1vll+5886qEIZKaYWQZ3mNdoNLqnmKHwKyYEdABnkn2fDf7caYVLr8ZPNjgokmKF49GQvCnL+IGGDpAQR6pYu+aY4aH92xgnZb7oxqLxPbca7wqvSsht0GQYEhtvZtTo9KNnenw26OHjkaHrKyMJdSbI3f29ACoYg64nNdJp/6LptqsdlUFP6kIiNbERrEltJsgnfen2J+0yn4NTfE7VWrRLbFaPRWALgNp/wj2BThDnr22x/DYGLYTOVqI4U3uxDWFQfSyQYZiVFXlWRzDk/vNxaCjXuMZEOmE2FI93f9ZAZWKGc1WudWEA+32ppuL/si/RbJNJ93WrZgaHPXPC8Qvq0J9pxgnjlAmS4zZ8FktKXmED+PIPAfBLvvmTTyfG7AJ/o4gHfyJEviu8Dr2tSbNSxQ6PbEvNJSjIF9RoShNsWjU6vm4Unl6QawLp7paybEsGjpWohdxr6BHnEKy8OsPNnA+efQ+cIdcMIThgaY3ZtA6VlgWCE3D9WzLM6FgbpmlXqBFEjqGbYp6Mw/DFCLbDmaHO2VqFBCPEM7K0zedZIIKRh8mwNneSF9Ng33hkFocvDa3hiCoAZMhZWOniHT/wBylBYc4XQCCageCRJ/jr+T3Z36+jciPjteAfHU6DePrfyBEEj+/vSzUCHLOaftYhITYCmmftbFlBx/kBHwQTnv5TdHp59/qkubwLOQwv D9nxAl6w 6/FpXe6NxGM6wRj18g4cE2qqVBC9cKveoSqU99YqenbrOXt9KRPHFaGkPPztJK6qFnp6a/6hZuZW8834fshDwilIdjcE96JlvUBqLtclCjsG6Hk/JPc37UFuINgUehK3PYOQVajAP9b9sCoC7Mv37KTSQjrQhpIy1un5PqhaAL+vkd/MDCx6B/DPofhB/6GdPvsxxu5we60/MhwGt/TfSFTweJ8mVaiH9w9EScb2XCm8OkzGbBjQ4YkSbeEyw/Qa/uX0F9o2I75wJ53/p7WASzqPNlYbOHNYvUjppLAvDbIrSFTfioj8Knwtz6EJtSoetHWV8DFrhF17jQn2BpfSIy9lsTRG0AY5FyM71lLvpFfu3BWC+rTcXWN53hI+zzLOCqbusut+/RKnGNui4sjx+COTuApz903oBJZ5A/r4THOg4Zf2DGS9areU6aQza+lViaSYK9RKnkYfIV7A3Ggp3EntgWo4n+B4uuA4DN+ZHaR/RbzOrGcGAn/aKwuoObL9zSUo4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/25 13:08, Christophe Leroy wrote: > > > Le 13/02/2025 à 05:09, Anshuman Khandual a écrit : >> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >> is confusing as they sound very similar and does not differentiate between >> platform's feature subscription and feature enablement for ptdump. Rename >> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >> readability. > > For me GENERIC_PTDUMP is more explicit and similar to GENERIC_IOMAP or GENERIC_IOREMAP or GENERIC_GETTIMEOFDAY: The arch provides the necessary helpers to use the generic implementation. I do realize that GENERIC_ is another method for achieving shared feature across multiple platforms via providing necessary helpers. But I guess there might be a difference - it might not have other similar but separate dependent configs ? > > For me ARCH_HAS_PTDUMP just mean't that an architecture implements PTDUMP, it doesn't mean it does it by using the generic infrastructure. ARCH_HAS_XXX indicates that an architecture subscribes to a generic feature XXX, by implementing all necessary helpers. But the feature in itself is a generic and a shared one. If the platform were to implement a feature on its own without any generic component, it could do that via a separate platform specific config without requiring ARCH_HAS_XXX based subscription indication. > > For instance, arm32 implements PTDUMP but without using the generic one so I would say that arm32 has PTDUMP and expect it to select ARCH_HAS_PTDUMP Actually it does not need to select ARCH_HAS_PTDUMP, as it does not subscribe into generic PTDUMP. Let's see PTDUMP configs on arm (32) ARM_PTDUMP_CORE ARM_PTDUMP_DEBUGFS --> select ARM_PTDUMP_CORE ARM_DEBUG_WX --> select ARM_PTDUMP_CORE The platform has a self contained PTDUMP implementation which does not depend on generic PTDUMP at all. Hence all these ptdump configs are marked as ARM_ etc as they are platform specific.