From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 430DBC49361 for ; Thu, 17 Jun 2021 09:28:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBE8A610CA for ; Thu, 17 Jun 2021 09:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBE8A610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 68B4A6B0070; Thu, 17 Jun 2021 05:28:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 639336B0071; Thu, 17 Jun 2021 05:28:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48C036B0072; Thu, 17 Jun 2021 05:28:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 11CA06B0070 for ; Thu, 17 Jun 2021 05:28:56 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 90545181AC9CC for ; Thu, 17 Jun 2021 09:28:55 +0000 (UTC) X-FDA: 78262691430.37.1D48169 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 287E7A00024C for ; Thu, 17 Jun 2021 09:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623922134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZHuAloMa0AoC5AC95gAOi+y4HlERZPMXvHRDbIrYdzQ=; b=IPPRr6b6MMiZwJeqKw2eCgYAG0gt8r2baZbCt2s/jbm+lsI14Y41xVxcVhgtVvsx2LFXKK ETax3YVCv4Ej7U0aTkDS4fotJhu94SdQvlWdRQl0mYqVnGeNXyuAy65ZAyc9NQZeOub0Qa Kz0grdg/LWZi63xDXBFqZCqTcJPzxfs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-AnEAyEHMNpuLyOpWmaocfg-1; Thu, 17 Jun 2021 05:28:51 -0400 X-MC-Unique: AnEAyEHMNpuLyOpWmaocfg-1 Received: by mail-wm1-f72.google.com with SMTP id v25-20020a1cf7190000b0290197a4be97b7so1917139wmh.9 for ; Thu, 17 Jun 2021 02:28:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZHuAloMa0AoC5AC95gAOi+y4HlERZPMXvHRDbIrYdzQ=; b=uCGuZvQiXyLCW6Ju+v2eT3km3oF/W7YFyqbH+VeHDJJAlY8sK2ovIbtGfreT4JdhZe pKZZHTOJEF2UgkcNfYQ1X1lWnReKBbI8/fNyVDJCbijIXP1pTLGvpvFhzEdpCgkcE2xA ho+GjMuw2Cs4bjTOGCSvmPeIxDAsmTFu9RrsW8B1wXXIE5OU6adkDtmWOYYeo9aXRYW7 eppw5eDZSBYKWxjyiYZ/Ex/IB6EdXwy4GCpE983t5wmfkXkx+ormtDKjNZCRpdkUH3o4 CHqnNSugmkmvn41UsFtyy0OjkrcgpYRJYfMZ1LQii4leU0xpe5G+3f0RqbyJRIo0QSM/ JhVA== X-Gm-Message-State: AOAM530jYgu6w+4zXzA589tf4G1+GcNmeRi8bA+CneOrJfYsZWEV3UwT bXdgZPlBqIdzMQObvguPNcMN1ihaSXADOPPnTTimV1TooDZw51BVD6gmpCwvnBlRsu36FVHYcg/ 5YGjp0AzFe/Y= X-Received: by 2002:a5d:630f:: with SMTP id i15mr4441966wru.155.1623922130138; Thu, 17 Jun 2021 02:28:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbp/CgEWTSA9q+X90xdM1xBCuvBeZxwu3T85kkR9KT3yteRTWZ5b4a5zBMKxntq75+BWb/8Q== X-Received: by 2002:a5d:630f:: with SMTP id i15mr4441947wru.155.1623922129949; Thu, 17 Jun 2021 02:28:49 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6170.dip0.t-ipconnect.de. [91.12.97.112]) by smtp.gmail.com with ESMTPSA id f14sm4526726wri.16.2021.06.17.02.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 02:28:49 -0700 (PDT) Subject: Re: [PATCH mmotm v1] mm/hwpoison: disable pcp for page_handle_poison() To: Naoya Horiguchi , linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Mike Kravetz , Oscar Salvador , Michal Hocko , Naoya Horiguchi , linux-kernel@vger.kernel.org References: <20210617092626.291006-1-nao.horiguchi@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 17 Jun 2021 11:28:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210617092626.291006-1-nao.horiguchi@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 287E7A00024C Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IPPRr6b6; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 5ccjmciamp4kjfhextwqm7qd35fyts83 X-HE-Tag: 1623922124-153765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.06.21 11:26, Naoya Horiguchi wrote: > From: Naoya Horiguchi > > Recent changes by patch "mm/page_alloc: allow high-order pages to be > stored on the per-cpu lists" makes kernels determine whether to use pcp > by pcp_allowed_order(), which breaks soft-offline for hugetlb pages. > > Soft-offline dissolves a migration source page, then removes it from > buddy free list, so it's assumed that any subpage of the soft-offlined > hugepage are recognized as a buddy page just after returning from > dissolve_free_huge_page(). pcp_allowed_order() returns true for > hugetlb, so this assumption is no longer true. > > So disable pcp during dissolve_free_huge_page() and > take_page_off_buddy() to prevent soft-offlined hugepages from linking to > pcp lists. Soft-offline should not be common events so the impact on > performance should be minimal. And I think that the optimization of > Mel's patch could benefit to hugetlb so zone_pcp_disable() is called > only in hwpoison context. Mel, Oscar, does alloc_contig_range() now have similar issues or is it avoided because the pageblock(s) are set MIGRATE_ISOLATE? -- Thanks, David / dhildenb