From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f71.google.com (mail-oi0-f71.google.com [209.85.218.71]) by kanga.kvack.org (Postfix) with ESMTP id EAC6C6B0006 for ; Mon, 12 Feb 2018 06:26:49 -0500 (EST) Received: by mail-oi0-f71.google.com with SMTP id t193so7377458oif.6 for ; Mon, 12 Feb 2018 03:26:49 -0800 (PST) Received: from huawei.com (lhrrgout.huawei.com. [194.213.3.17]) by mx.google.com with ESMTPS id m196si2729668oig.361.2018.02.12.03.26.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 03:26:48 -0800 (PST) Subject: Re: [PATCH 4/6] Protectable Memory References: <20180211031920.3424-1-igor.stoppa@huawei.com> <20180211031920.3424-5-igor.stoppa@huawei.com> <20180211123743.GC13931@rapoport-lnx> From: Igor Stoppa Message-ID: Date: Mon, 12 Feb 2018 13:26:28 +0200 MIME-Version: 1.0 In-Reply-To: <20180211123743.GC13931@rapoport-lnx> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mike Rapoport Cc: willy@infradead.org, rdunlap@infradead.org, corbet@lwn.net, keescook@chromium.org, mhocko@kernel.org, labbott@redhat.com, jglisse@redhat.com, hch@infradead.org, cl@linux.com, linux-security-module@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com On 11/02/18 14:37, Mike Rapoport wrote: > On Sun, Feb 11, 2018 at 05:19:18AM +0200, Igor Stoppa wrote: >> + * Return: 0 if the object does not belong to pmalloc, 1 if it belongs to >> + * pmalloc, -1 if it partially overlaps pmalloc meory, but incorectly. > > typo: ^ memory thanks :-( [...] >> +/** >> + * When the sysfs is ready to receive registrations, connect all the >> + * pools previously created. Also enable further pools to be connected >> + * right away. >> + */ > > This does not seem as kernel-doc comment. Please either remove the second * > from the opening comment mark or reformat the comment. For this too, I thought I had caught them all, but I was wrong ... I didn't find any mention of automated checking for comments. Is there such tool? -- thanks, igor -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org