From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 227BCC05027 for ; Thu, 26 Jan 2023 09:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82DEA6B0075; Thu, 26 Jan 2023 04:52:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DCFF6B0078; Thu, 26 Jan 2023 04:52:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5718E0002; Thu, 26 Jan 2023 04:52:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E66F6B0075 for ; Thu, 26 Jan 2023 04:52:28 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3AE8316011E for ; Thu, 26 Jan 2023 09:52:28 +0000 (UTC) X-FDA: 80396485176.05.39B5D93 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 0FEE714000C for ; Thu, 26 Jan 2023 09:52:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AtBDEYbo; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674726745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HWZYDHaST13TpclKR0o87AcgsReRxfEYg2kbamKtxjw=; b=QzOgZ9qo4xOQCHgT2y/cPBJiskSpwfG4m8FMAfcEsOm/0apUW2N5tcCLKouLDXFz7isUOe 46mShutU25KJDPL4DMf36AStUAeoQ78p3t5Ehu5azC5kPm/WyhCLBXLMjMJ48dtNkiqcwZ Ssus/lwZMWLE5JUTRzer1RV0YnEgbTU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AtBDEYbo; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674726745; a=rsa-sha256; cv=none; b=h/Jm2ault47H5naOmENfudzjs9Kfb1lc9oDQw0Z3GfbRkrvR+yZyu4p6Yqlk9wItB8QimN JEu+apsVJ1IZWeMbkno+WBuYD1F2730P+z9TIJrvnwzh7XQcTafOby2u4FKgFSH+fw1oMh KiBLWT59BtWXxduL+QXdHyPH1lEkzgU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674726744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWZYDHaST13TpclKR0o87AcgsReRxfEYg2kbamKtxjw=; b=AtBDEYboMRa0IlO4EH28yBvnQGsUIUTQoTs2hN/Uy0d9iJ7Pt3HggE1zisyha075+2Sc0O P8Ou6lr6apXxOSmVCk8bAevxMSL7ynwO5sEVG5BGz8mEESpAy43SB6r4XqBbW1BY21xev2 0LuEBwWUW8WpiLrB1e7UiYizMb+x90I= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-576-2CSPRdHpOAujf-06CSlcSA-1; Thu, 26 Jan 2023 04:52:23 -0500 X-MC-Unique: 2CSPRdHpOAujf-06CSlcSA-1 Received: by mail-wr1-f69.google.com with SMTP id l8-20020adfc788000000b002bdfe72089cso173630wrg.21 for ; Thu, 26 Jan 2023 01:52:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HWZYDHaST13TpclKR0o87AcgsReRxfEYg2kbamKtxjw=; b=HCkQe5Pt5BDQbhR4VxiRlZrkC87bPxZlhd6X++IVj7OQYmnxxRDcX2EQGxhom4WfLZ pG9Yua3RUw/lZGwN9asd0+luaJLm2pAsJlpv4edapokpaJlZOc5y4yfDbisvKmgLoeJ4 0/M9b28qfQQsdEoxOIS1zpaRd0ilUrz/Nev7vAkU/l6neqZYtO9WWu3GpVJnnXLG5ijg +0sjh99g4VawWkg/zQhY8iOnxyAmpnhMadynU8Dkja/RarqMuGsy2z4H0nie/4gpeQL8 CT8IAxkKypfOqsNUbYQsxi8r+2VQ/Rbf0mfhDRCQ8Nf6RykZ2svYIBqXzcd1akPEEGIf T0Sw== X-Gm-Message-State: AFqh2krMya0vgF5Ouc5XiBD1IRt5EQiGWX6MI1TF2Z2tRUtSkNRZUQlW lMbZAlksT+09eSlU0hhgTmkMsqNPcydpvyLgpugJGOfEJzUvCKUHRxFUWRiEMfAHqLFtjOl+Ryv lq75ErrDdT/M= X-Received: by 2002:a5d:6e42:0:b0:2bd:fcd3:44c7 with SMTP id j2-20020a5d6e42000000b002bdfcd344c7mr29558738wrz.29.1674726742108; Thu, 26 Jan 2023 01:52:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXt6POr1Th+z4xBilbq6MD55kPKMFdkWNrVBw8NH64BJ/rotUwhIVj/VoLFHThktbZr6ujT1Dg== X-Received: by 2002:a5d:6e42:0:b0:2bd:fcd3:44c7 with SMTP id j2-20020a5d6e42000000b002bdfcd344c7mr29558712wrz.29.1674726741832; Thu, 26 Jan 2023 01:52:21 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id f12-20020adfdb4c000000b002bfb1de74absm839299wrj.114.2023.01.26.01.52.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:52:21 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:52:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 1/8] iov_iter: Define flags to qualify page extraction. To: David Howells Cc: Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-2-dhowells@redhat.com> <2613249.1674726566@warthog.procyon.org.uk> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2613249.1674726566@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0FEE714000C X-Rspam-User: X-Stat-Signature: bu1ix16yfu96sj5y57s77r9mmodeocj7 X-HE-Tag: 1674726744-28908 X-HE-Meta: U2FsdGVkX1+pVJznGX3+Cym0wyqcRvD5GiRO7RgHXS//euLAwM5X40tS84TWjC8/c9h6KLOYofVhlQeFbyjbI71deuS1BcGlSGgBZ4/UHoB9qnc2EsYH94AuK2yPfDa3+DRbylkzzX/tS6GRA/aSp9bZwb+SKMFjg5rMjicV7OQPuEwg2+4MYtuZWtKtCzZ9wvNnSFv47YGs+W7CbwS7tCEKeA95ZUlpMjcv6HzUVE0je4pNK+QJCdjYtR4zybaC8lLuQUBROEmmcUan4xzf/QDHF6UIOFmLcQJMSUQcP2glOgX+odSky5HM5zHjO/jVgYJ/mmxF5X7ueXecF7DYkIuS3BMJiFPRkXbJ5h+HPStv/UumPCCStHdyVM5j/kU1fnBK8hMBF5Jfvr+JKJDCX0fQZBZwUMRlc5fgWbwRF+ww4u87OA4ocFNiBVC+ymS7PfsScHe1cuAw/gCNLrspJJ9p0Yq/yN6NWLuSkiE9ZqI9vJWyxVzKrf/ondbWUvA4RqwvxxIEv9axEHR3kxzShWLzpSDKNzxcYN+MLKNpBfJ7u5pm2zabvsAcraDzMH3OaCTbmk3UE4xSUorQVomhnNeDpBA+4h6V5MGEhFOIp8KYdIkiDduPTeQiaUePXQ0+B/VehrJokB+2VaVRGtzKRLJH19QjiqgbYTj4ksUI024LyEUytCROlpqAZdKI9vm5CDMH7tmI45TzS9l3jGs18VbTZah6Mft2xW0Hai2W5w1uI/4/xBJcL33+urhIaHbmgJl6+u77piHzfobiCk0OkKkUqBKkcs5vKGF4Tid/rYUVLClrWQ8yhV/RRo0SWYsnWUIkSus2H0QXtMb8OFrmZ4Aiig3+aj0PZ7Nn6FKjuCUayVbPPnggzsfwLRfhtw8auM9pVSYKjib+aU4BjzgYk5s6ARd5iVBhHCYqU4/eZwxNaxjJw+8H1Y3MF8DhcVbtbFXb8Ztjbhm4Z/V3nD9 KzM7gfLf C6WyVgq8RFWl/a4v50xe2kMK6Fvv89x7Sbd6F7wQKo7vJXPgh+aF3dc1F2y29F8mG7VRuzsUdLwUp6QkJKaOes/lcILpP7KoowFbEVQY1/CyB2SSbXL6k0CZp/YY1QW/oTzdCmVJpDOTbKYEYuQJD8E6gOTi9WxN1jrjNmNVIVneQje12U3RIagcacdnqtLx+VRjeCqZB5vSCr0lgk3jmv2CsIKFGIurq9WLjfee33YYZH1AKCT7TGEVvb/ty3tPl5NkaB/qO1c2UR0tACMEWA9UndfoRDZUw5yaIFL+UrmXdNZXmOKxwklFA1k9SOWGJmp8ER8LPphgKK/csIad04oiuJ2qKO0WRVn1W6ihIdiGRcHWzV6VHwQ8fOx71QbdXXmAey9syf+4NdEEmB1JDBwuAa5D7x85hfov4Ch7XudJhU1OBZt8aSCOxWPk5kGXU414vRsvaQXRnfLDzyp50xQ+RqRMDtt5Op8lA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.01.23 10:49, David Howells wrote: > David Hildenbrand wrote: > >> Just a note that the usage of new __bitwise types instead of "unsigned" is >> encouraged for flags. >> >> See rmap_t in include/linux/rmap.h as an example. > > Hmmm... rmap_t really ought to be unsigned int. Not sure if that particularly matters here in practice, ... anyhow $ git grep "typedef int" | grep __bitwise | wc -l 27 $ git grep "typedef unsigned" | grep __bitwise | wc -l 23 So chose what you prefer ;) -- Thanks, David / dhildenb