From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1E9C61CE8 for ; Thu, 12 Jun 2025 16:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19F626B0089; Thu, 12 Jun 2025 12:01:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177236B008A; Thu, 12 Jun 2025 12:01:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 040096B008C; Thu, 12 Jun 2025 12:01:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D768F6B0089 for ; Thu, 12 Jun 2025 12:01:07 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 663CA1419D1 for ; Thu, 12 Jun 2025 16:01:07 +0000 (UTC) X-FDA: 83547212574.18.59C344B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 9766DA0026 for ; Thu, 12 Jun 2025 16:01:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NyTRBMcG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749744064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1+3oax1J1i7ak04ZkCE12qfZ9Apo/D3V00Ng4YzGTGw=; b=R1drvFKJbEfN4wU0fd6oSfgo+wIZQv4y2R3bx91g6+OKCh997FeXuco3l3BDuUiWcmRIzK y80FecFxl9MH5g0kiaiPCjOfyfXsmr0dEbs34QVSTg8U7opdExs9VJKopHrTDb5JSn/NSw y/Wj9o/6l96yfbZEEOyOH7u/MiLo2FA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NyTRBMcG; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749744064; a=rsa-sha256; cv=none; b=6OG+oGZ+7MjbsoJRagvsf6Ep228L98qA+SSypAtxNhVJbgXvGEHsQ5oNuBNyzh/rvGlTx5 oPANOy6XI8q4pzcMwDFnemUWmuR2pDakRgZUiJozbH51u+s5sycEUNLn9ZQ52TkIlADfD4 ZFHgvycVtKHOzEmxtqayhcPGJM95rGE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749744063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1+3oax1J1i7ak04ZkCE12qfZ9Apo/D3V00Ng4YzGTGw=; b=NyTRBMcGz+mxEO9A733jNlCdAXBZ3kyaaDCOrQIGGEhTX4HUw6+4AogWnJKwJVIIBr3l+z wvgiLBeT3cSYbq7sfTMetZf2NrrSBjWulrLgxNpCHyb8AJZ+GGnYVAtZf/9qYouVw7Our7 lsN16PCqGiyyPOjLjeHXcYyCH7ROH3w= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-IxdILwWzN7y3XdIsy3YntA-1; Thu, 12 Jun 2025 12:01:02 -0400 X-MC-Unique: IxdILwWzN7y3XdIsy3YntA-1 X-Mimecast-MFC-AGG-ID: IxdILwWzN7y3XdIsy3YntA_1749744062 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451ecc3be97so5059115e9.0 for ; Thu, 12 Jun 2025 09:01:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749744061; x=1750348861; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1+3oax1J1i7ak04ZkCE12qfZ9Apo/D3V00Ng4YzGTGw=; b=TpERFH4S26IL90fus4WOguIsa0AIha7xx7q65t7mVjHA9sTehk+HDV8uD75jEO0zUe jjBwsmV3ujMbcPb6TDrdjHHYE4cfcMu0aM7tDxQ3YoSTnxKBMeuzw8GrfMFAWibOMgRJ drpjX2gO5vAoMaU6fRYf5UkArOo0kVpJlhZGxYvM1sr3zPBAMxGFR8im/hKWv5hMUBNf zq28Q/+FbpRvORYtD6aWuw/nbI3IzbDJOOgmg4gljtg+LmjoxK9T4ld8fAf0dxHDgEtk BGEoj6TTsRxmSmqNY+ebnDxJ58qjVq49pW9neB/Gmw5UQm851LODWuYHBLO9AW7+yAxN /A2w== X-Forwarded-Encrypted: i=1; AJvYcCUXDrPghNEJXMaiHpoqhUCviJ6S96KX+X+N+hod9cGUMb5yjyzNbRCHHNyxz27axwcLIL3CITSb8w==@kvack.org X-Gm-Message-State: AOJu0Yx3vk87kTmv+RBl3Ddhxo30/nSGJsQ3m7EAUCF5n6keF7j8ruxR cLw032K63JSWwXBeaS1+PPgcNw8FsDbBgG1s+Vs++x0Que6atO7AoXU1F0yKZf9t+hFqxHwmPx6 65hQgJhQGY4fOF6BDzNWWZZvN4iKGycir4K0WBN23QNAx3uncTtlV X-Gm-Gg: ASbGnctGTUn51kRvtAjaD2OZyJ2lU6V7oR2/zcGLZKb5oo3wbQCzXXssDwj9H8+Q19x yPpixQUzU+op90lmLSfNuJjlFmXQG66xPMRl6h1+9BX6HqZ9E5dQGybfc7ofPKAxmfItJSmaiJc oohybvIi0zLbLWEqgg+5Vp6t73fMGegq0UFDQlvW8HAlUSpS6MXGz3AHuknmIP9DhMDvJnPNtAq HgAje4tj0lydaqdpZQb7UuqrJRdbfcB3N3opGMF2x/CLIafslHR/sYOlwLYJkWBNa1ZEdR2JrtF nqTueE+lkyZl0L9ZPkO4e8u9V/NBkXW8zvJ5J+UuICJth1RihNVyGPaZaH54Whw7lAFaPHVfOeH dnlwZE2Pqg5LpcaFSgh/kFx2exqLwnUViLuuSBCW3LQccV057mw== X-Received: by 2002:a05:600c:154c:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-453248b0ee1mr89059935e9.10.1749744059146; Thu, 12 Jun 2025 09:00:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0KtUKkeA/MUPEemOjB1IBDhV6fF8nnUrAFkhywiGcZIhXOz4QfMznW4XH/6cl0sFuqudtsg== X-Received: by 2002:a05:600c:154c:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-453248b0ee1mr89057685e9.10.1749744057159; Thu, 12 Jun 2025 09:00:57 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e24420csm24149245e9.20.2025.06.12.09.00.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 09:00:56 -0700 (PDT) Message-ID: Date: Thu, 12 Jun 2025 18:00:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador , stable@vger.kernel.org References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-2-david@redhat.com> <02d6a55b-52fd-4dae-ba7a-1cccf72386aa@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1Ret5yD77iaobHV8-bihN4RBRAHPeezwJUtPDqM1EB8_1749744062 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9766DA0026 X-Stat-Signature: 4dsk8ikteifxfgstoueh4m4q7tzq3qi4 X-Rspam-User: X-HE-Tag: 1749744064-441624 X-HE-Meta: U2FsdGVkX1+8EylzP0Q/IWcq0Dp3/lsrznA/aiSRlXvtUvxzFMjYBydzmTDfgTmvSiwyRQ2iWfzBgxiqJKoSOW1SZsaT1bkbJCzU2iV/Yw2+hzV39rnazyyx5GBiUngsaEStGV90Ka2HFRc0f4BKhqOiSW1LRmIREWAJlC03UCu5j8vWlawRExd7mMhiXD/uQrGE/5gJ0eohLMFHmPMcI6k/65T1ke2CN6WjL6gtFVtxLcTv6ShJVu5n82ZEvCWvL2RoZGaurzLX7qD3qP7MXlt8XEJpbj2Rph8CNfBcfa4pmzIBahXKyla84ddP1H91QQJwPmqbnee4d2tLtbBKW/MNwsD/naWYPSJvrGLhiaFohIvytgX9fCSOtlpqxbAcju2qQ74HK3HOiRlHjU6V0xJJ4oVSItzMKdnUlIpJmFbUxZeNv76IyyAaAeZOTKBsEq1lsE4E3Emr16wxXe6x7O5JZdp324ywRAr2iWvYFpLdpLJKRtheNzWI63P1S9GNVLrqYWr1xpbWbIHu++/5kZa1xS+1hkN/C/V8+qh/AO2GFN6ZNPMMA6fTadg0m7twK1sp9SxlMRWYFN/6V20vuAAHWDYr1wXE+izPzGXTb4KeLPrYNOdnya1I6W20XriZjRJGZlP088Rh1WzdxzmvJDL0evENa4iRAWdaZRqAKAvj6PwKU/6JvowROVe6CMCDKnqD1CDQPThFRO9eLf0MOgJ0jJ+VU0MysMjyYHxzCMi/E5ooaIG3BX7nhDqvtT0W+BNUo8bQ+B41DYtidCQYU4CbGDUf/IpZmtBnR40nvZ64P7S8kQ8LY8TBeXmeIr6JwwiiLPSD63pptdGsYj9CR1fG0x98zFwXYS1cjiKMALrClT8pODzprip4YoF0f66jLxzFG/YLBsxRaOJOQ25PMLh7pHH3yGYQK7XeuYapBnlqu7H2EH7xqT1KcKv0bMsgUFu3jLbiZa3baugIvI6 TY+NrPtQ 0t3yQl936D1AMYWOlVmk0aVKx2Ub0gF6jwTcUhgPgSp1iMm/3pehYZQd7HouyjwS5H2U1y+0BYui2QuDBRY6Egwe/ZHzVkQiFPZLO3Lop8My0QyWPR6mX6pmwBH1Oz1cP37cdNSXG8DAabra+knM5qxIS/kClL50MYxiOQpupj0pVjRGaLWI3iJhMo+jgNc4YIXJfcK4y2qhFwRerp0Omg4ohknddNHEl81QWm56pFKpZHXOWmebBTEp4HkBIvJAgAN2iVIrScKljgoxuYZXDE84KV88x5pYbs7x1JjdkTBFny6hCTzN8WxkLzf8zpl256+zYE5LIChbyujg1m4vgBFy+xPFpubG8BojHYvOQPlmWXqja2hJAsAzBhn8XYQrOAK5uUxfYyhB2U72tbd1Wyax4+cjSxED2Y6VlDAK9F+L2l/cPVuk0Z9g+1HIssWp7dwjTq+D+qzIDaSG+632SnS5KmN10TDGqENioZPKrpIr1TUZTlQvf6bB+BpaCn3xMOwYjR8EGZV4DhtQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 17:59, Lorenzo Stoakes wrote: > On Thu, Jun 12, 2025 at 05:36:35PM +0200, David Hildenbrand wrote: >> On 12.06.25 17:28, Lorenzo Stoakes wrote: >>> On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: >>>> We setup the cache mode but ... don't forward the updated pgprot to >>>> insert_pfn_pud(). >>>> >>>> Only a problem on x86-64 PAT when mapping PFNs using PUDs that >>>> require a special cachemode. >>>> >>>> Fix it by using the proper pgprot where the cachemode was setup. >>>> >>>> Identified by code inspection. >>>> >>>> Fixes: 7b806d229ef1 ("mm: remove vmf_insert_pfn_xxx_prot() for huge page-table entries") > > Ha! I don't even remember doing that patch... hm did I introduce this -ignoring > cache- thing? Sorry! :P :) > >>>> Cc: >>>> Signed-off-by: David Hildenbrand >>> >>> Nice catch! >>> >>> Reviewed-by: Lorenzo Stoakes >> >> Thanks! What's your opinion on stable? Really hard to judge the impact ... > > I think it makes sense? This is currently incorrect so let's do the right thing > and backport. > > I think as per Dan it's probably difficult to picture this causing a problem, > but on principle I think this is correct, and I don't see any harm in > backporting? Same opinion, thanks! -- Cheers, David / dhildenb