From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5649BC2D0CD for ; Wed, 21 May 2025 18:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6CF26B008A; Wed, 21 May 2025 14:48:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF67C6B0093; Wed, 21 May 2025 14:48:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBE366B0099; Wed, 21 May 2025 14:48:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A90566B008A for ; Wed, 21 May 2025 14:48:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29AC0BEAC4 for ; Wed, 21 May 2025 18:48:43 +0000 (UTC) X-FDA: 83467801326.03.DC28F8E Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf17.hostedemail.com (Postfix) with ESMTP id 5490440009 for ; Wed, 21 May 2025 18:48:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q19jg+60; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747853321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsqU9qNRxySE5M3OcMeV4Y3nlFq/W7yx3WEYqpKlexI=; b=he4EPiSra2a1aljwIH4rSR09p0W/b4dW8i47wDNuDVV4QI3Uf79YTA2Eav5VJ/YEPMZMgp w6sYkPAIeL6LWq0NzR9BtxWIKoiQzbqBoWF7r2E/z28pSZbk8sXMNPFViBscCmsL7coPyC NwzLA3p8JRz1Br4R9n6Kgnh3OPe+i2U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q19jg+60; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747853321; a=rsa-sha256; cv=none; b=JKLvXzPAq5aoDcQ3jea0sHgjn4MbhhGR/fi29x/s1ZlBYc0UrDYEZSlQ7ADyYmnwowxqjj 5DNm+FvsGEuywuf/9LJviw17HwpTz2RNS/Q9I+82t9VTwG+yf9CKMspodxenQcJ+78OKJN o9oXHO9pcnWOrqbdrlj40xg9FKHQulc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BB89743B3B; Wed, 21 May 2025 18:48:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37936C4CEE4; Wed, 21 May 2025 18:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747853319; bh=+SDgkPsuW8atvb4ZDN/7K6R70SeeWuKOV3C3tPVuScg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q19jg+60JIe2Y9J1lBfDCYCNtrGdlH9RebVOzWFZ6BS2ArUz7RgOSWb2f8fKVVMBT NU8d4EeJ+Tu0IueiPN0jHfVAS9oCWo/9h1Wbnfbn9oWKp59soJ8ov23lk9mUeFmfbk Jc+zmdE1Rc5PvCjQKWUJYbElEUgXtmuQsV8by3tepNuNlvEyg1w4mYmxmPEKhxZzvn Naw5APZDe5zYIR8BJIrOkY2Goc5a5YYGCN/qu/ZIQx2kvZYR3D3NsAy6/QoH8eVWnz UZkQj9hyqxTYvqvV+RZhwAAg/9Wwz9U9f5UQElQQg4o2L62gydVNE2wuDkFacDnveb zJw7/K9xnvz0Q== Date: Wed, 21 May 2025 19:48:35 +0100 From: Mark Brown To: David Hildenbrand Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm Message-ID: References: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org> <58dbef73-6e37-46de-9092-365456306b27@redhat.com> <46d151d7-c04b-4538-9725-dc4f46ac8ac1@redhat.com> <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tXPModrryQ9N1T2N" Content-Disposition: inline In-Reply-To: <8131ce62-0cee-455f-9eeb-e2bbed244402@redhat.com> X-Cookie: 42 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5490440009 X-Stat-Signature: hjp7drg5jy9ffzbkgph43f6xxbjirxge X-Rspam-User: X-HE-Tag: 1747853321-451382 X-HE-Meta: U2FsdGVkX19zb2G5MRN2oDy9JavcUece9LjTdBax6nT3OTX5yjLvkYv3kXXh/o9TCVwbZuLpdfe93pM2FQpfxsJBCvE3O7PL3beGH3TqIa3EiGaJoNeAf0WnzrXaiNS2KXNpcjTSwVPBxDqbut8JaDn9QIROHCtk9FSNRoBWnvXWsfOm6oNDPTb0LDOcfQn+U88dnUjuElDTGuru+xO7r8lqhvNuHh05vwSF064/a8WIGzgx28bFwHPxE+SY57jZkrX/cEDAMA0aV3cAicDGfiKxfk78w6rvc0Z2fhaXzh7K3t1pFDkoREXTThaVOstjV94Uw9NFQbcV0vhQciLvRFXVvUsFUfzo8GlNKC58KlM9/xd5H9XRdNtCdEYn0DHfgAiRbbDPfhAJRcWfwvS9HVAa5MQnxeaxaTbbzdETpnRn31yl8yA2PlxheXD0wFE+3PeWjD41ZWlDuPjItt7SrBWFLaIy3COnwhgs6lO8++HVaHv3ha92cDKMLUuEjj4AyfS41/vhYUTrb9RMu/rq7aPmG4E7DsDZR3nXWJ7hsFJTjMQR6v6IURiMKXZ6tWfqXbAs4qo73e6GpJEykm0jSVTDicC7yOgy93lY5UoObAUnwV5+MFuLTMn6FQn2uybTuEwQ7gUrtRvBg+FIGPoEtL2JzpGNOUsBvzMPCmzzb3t8QEX9gKd5Y+xIThWAvL9y96lk1lq21T74XRRXFMEmilf4tW9rdbq9wiETh1YosLYk8HEDplCEzCbNS66a6/nWb82rs9CnVBqVpGYktnQNZP8edVgXY7s20Gc5PJkvVmrAhH+L+rIoOzEX8TA++R8Jlz4d9k0erZo5Cl7KamEOdIki1WAYbv24nlAeD2M0KNWdfJPyi1yrgVDGM+sg/Wx2qrU1oXUBqr7Non3RsZOh3j0A99kt+B8vOnmnXtFfbwJpeHftJnc/5tIU0fLNJo102JfodA1tEgiUBLBHQVe DPleI92e cWabozYi6L4eILiZ79WW3rg887bzep5TmYZDz7LZ4UkWNm69zrm0nMjG2+b0EIzYdAVzrEDBvL9xSTky0E7kd5ywZL7Jh2eGJeNd52aeswT5wG4Kurr4oKFQWO8SJZwIoFd4bvvyVb+8WgfQk/i/QbZKrRG+kidg+53d82Zf1bkT15gDeqdHbOaxjBu0L4bMNpje+yYfUT8ZnRJmb+Uz5IUBG5cIk1F6bDQL2kcAArFiY1YSou4a3+ODLIJptJd9eem23eK7o5lroEsVR7It158x7Itg65SUxFE94YwtUpO0km063Ev1pbwwUbq8PrM+5bC7BQ7UOFpg8O2HYno34ITeSb86fq9uzog5VxunJ5658czI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --tXPModrryQ9N1T2N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 19, 2025 at 03:28:47PM +0200, David Hildenbrand wrote: > On 16.05.25 20:07, Mark Brown wrote: > > On Fri, May 16, 2025 at 04:12:08PM +0200, David Hildenbrand wrote: > > [Converting to kselftet_harness] > > > > That'd certainly work, though doing that is more surgery on the test > > > > than I personally have the time/enthusiasm for right now. > > > Same over here. > > > But probably if we touch it, we should just clean it up right away. W= ell, > > > if we decide that that is the right cleanup. (you mention something l= ike that > > > in your patch description :) > > OTOH there's something to be said for just making incremental > > improvements in the tests where we can, they tend not to get huge > > amounts of love in general which means perfect can very much be the > I would agree if it would be a handful of small changes. > But here we are already at > 1 file changed, 107 insertions(+), 56 deletions(-) So, I did have a brief poke at this which confirmed my instinct that blocking a fix for this (and the other similarly structured tests like cow) seems disproportionate. =20 The biggest issue is the configuration of fixtures, the harness really wants the set of test variants to be fixed at compile time (see the FIXTURE_ macros) but we're covering the dynamically discovered list of huge page sizes. I'm not seeing a super tasteful way to deal with that mismatch of assumptions, the most obvious thing is to switch to having a static list of possible huge page sizes and skipping if that size isn't there but there's an awful lot of potential huge page sizes most of which won't appear on any given system. That'd be both ugly code and bad ergonomics for anyone actively working with the test. --tXPModrryQ9N1T2N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmguIAIACgkQJNaLcl1U h9D0PAf8DZzGB9b1u4CO6VHCHIRfWIVJmgUByM3bLYGJLVXCi7i8dUDQlE5xS2o8 E1tEH5ivN9CMoWN2JU6yNQ8poc6LTLsRuek5yRR1Zmq6JPLi3WlO2eWeP5Qjx+rS qBuVu8bDB9MN/wx98DOdAFiC0sjtVSyApOBzl05BuJr47OlhFW/a3y0TzWuR42Fd OOIXBxLtN48u8Oa94q6S9u6ZX23tBvk6oaikVx+rLURUa8zl7oX5p/8ZMm1BFCwY bgQmQK337NBiSeq7l08Wd34Ot9p7lpX5LR2swwd/hSaBKmYU6JIwl21vCixQUhOQ CdwgC3YAnAP/HTAb9CWHTLRZJFROyg== =qji1 -----END PGP SIGNATURE----- --tXPModrryQ9N1T2N--