From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472F9EB64DD for ; Thu, 20 Jul 2023 15:45:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C74D7280125; Thu, 20 Jul 2023 11:45:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C254928004C; Thu, 20 Jul 2023 11:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5C2280125; Thu, 20 Jul 2023 11:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 98BD528004C for ; Thu, 20 Jul 2023 11:45:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5DCF34016A for ; Thu, 20 Jul 2023 15:45:36 +0000 (UTC) X-FDA: 81032415072.29.FD17CA4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id 035D72000A for ; Thu, 20 Jul 2023 15:45:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qwJKksOH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=q+mWssqw; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689867934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aTba3o2kPyRQo+UGixsLvGCxMe88Bb3EA6h99cQRtps=; b=0GYQjh/ndu499/yBKTqw9/zes/NZH8UHdEhGv7CdiLqus+h4w5pCnkSIgaenVmyFYoF5Iu IY3InGCZndLAiPp5DdnHmlmwujdPE1qlSEdZvbXIQX2u0PAoxE+LbZKw2Chwu9r2+bvTw7 2t/YAWMTF6rxwHpEW9xpI/yVFF0C5S4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=qwJKksOH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=q+mWssqw; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689867934; a=rsa-sha256; cv=none; b=KLxlfMhVuHD5PAE2hXCaqqtCZTwqBfQDh7Bu5IHFf/89pi02y6iw7eXkavdUHTIoadK0qG DehV21o3ne+V4tc3Gve7JRZ1nYstaY+CYJuULlZLXYpRiMVUD9Sk/80VFlKk1lDpsIvX5S mdlj1RbUtk29W5gEe2RvtdT05gleZy0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80E0E22BD5; Thu, 20 Jul 2023 15:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689867932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTba3o2kPyRQo+UGixsLvGCxMe88Bb3EA6h99cQRtps=; b=qwJKksOHdTuFkyFwhRtlp1LxANP966bXCKrJEG+5m9/hdDiiLELUR8k5SWL+g+17AMoMtK PqZyd/GAZJVC3YADkrIKx2an4UXF5kowEwhjx7a5uCVUI7ReM58aktrYbnoxz9Lk0r4uIg WB/GEV9X7fnfP3XzO1YaywemMkiupKY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689867932; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTba3o2kPyRQo+UGixsLvGCxMe88Bb3EA6h99cQRtps=; b=q+mWssqwkd56oXHR8sXORz3ZI/rQgTF4jkb5FtlroAYjyypjl+qRCJT/9jX7clWCW5PTxq 1ZsMm3v6IGYwm6DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4689A133DD; Thu, 20 Jul 2023 15:45:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GrMgEJxWuWTvIAAAMHmgww (envelope-from ); Thu, 20 Jul 2023 15:45:32 +0000 Message-ID: Date: Thu, 20 Jul 2023 17:45:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/6] fs: rename and move block_page_mkwrite_return Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230720140452.63817-1-hch@lst.de> <20230720140452.63817-3-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230720140452.63817-3-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: mqwam85yffw767m7o3pyyaziyayg8wh5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 035D72000A X-HE-Tag: 1689867933-443298 X-HE-Meta: U2FsdGVkX1+IAHGuVQSLqV/3SNpyI63Bp4dXeqw+1r79CLnDHAQwcEJyrZmpf8CkUi51cYEk4MNBDz5K2yC278KgwX0EezZuRbGtssi4GLA6qwO3JbMG8c/kfwX75kxvrULgm+ukIsU+w7BlC2HZAYxgAD835ro4GyXC44ILW0I/T7Z8yKJ21Qz2jO66XEgJYlAdlEzNaweZzS7YrGY3Zp6EuUqlUnzovYCfL0Mu8F7TZxTOvh8JofxccN0NOJO/TAFli+1nRWxym1T9LPlMvOInLhbNeypHPrEav5X09B9lVqNXsJl300xSga15d2gcp9Mz5PsAK/IZy9K7nbCpqRcPOAOHoG7NAS/4/grsG0TrMRVhl/vzs0S+OyDG6ynnsMngA0jVtNcNojPg8fOr+qBuax0HrPImapdOmRGW/RrYfAlKaP2pGtcvxXEKaAmNX/no0H9NakvqFHwLwRXbmBrDdmGY82yaAuAROGPeOVj04sfNsDQZudYUNlzvo9udlPXw0akLxeImRETwtfc3QMUqxmFqXSZOymW4zjEBN7trjozXTI6W0nP7P8s67MaI7br6r+xP6qM+KFfmj3+mWQ4vCTpO3YEYg9Klu1LLQmRRQjAtOvH3gnvAg7w+AP3dsSfhQr+5JG1fSrHx/lHnGezQDuhLaiRn4ELDTw6UVPITbFQRp07/aLSksNPUmZxSdlFBbpPuWTuwEyjWY7wYm+Qy1MiLkhiMwbQK8P+bvHsHU1ErNRvk00KWGh89pF33UH1McHerF01UyenlajOuN1vG6ZGDsnJNCiRlNe+XCKmWSTBaEZq8veW8MXZ3fF6YuI8gJ1Qb7mICj5pAuItAzPD1Dal5hybFWV75jx5TXi2/3VOCZgJh2OJnIZYAz6WxHvwDJNBAxJigOjZOxM48dDnb2T/KCnqgDahVAfRQEfIF9TsGpePA5CdyUpJ945af9XtWCAP+0j0zEHMQRko X8UlrJVY Vi5aHtjEGJPyGlDE+EpDSsWUM1RDBifcVo4I1FTptqHRgk4TS+dsdEEkicfVslq8aKgX50wcQdHBvJfypNzK93UTCEOgmjEEeYCTxNqiSCq8h07YcZNTV3PxmpGmBBdpsJTiBc8Zoi5vE0f3v/WP+32dXK9S0boIS5busqoWE29QtnzHH1Kh58PsDzPZWaaWaze1q0zjKWGpZ4uXXZmpIkX8cRtrHDXQ/B4OawGfOCtcsdIsr/GWG35o8co4UHh6Pk3hmcakUbr54Wus= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/20/23 16:04, Christoph Hellwig wrote: > block_page_mkwrite_return is neither block nor mkwrite specific, and > should not be under CONFIG_BLOCK. Move it to mm.h and rename it to > vmf_fs_error. > > Signed-off-by: Christoph Hellwig > --- > fs/ext4/inode.c | 2 +- > fs/f2fs/file.c | 2 +- > fs/gfs2/file.c | 16 ++++++++-------- > fs/iomap/buffered-io.c | 2 +- > fs/nilfs2/file.c | 2 +- > fs/udf/file.c | 2 +- > include/linux/buffer_head.h | 12 ------------ > include/linux/mm.h | 18 ++++++++++++++++++ > 8 files changed, 31 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman