From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1155C7115D for ; Mon, 23 Jun 2025 03:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 414336B009C; Sun, 22 Jun 2025 23:37:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C5256B00A4; Sun, 22 Jun 2025 23:37:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B3CD6B00AC; Sun, 22 Jun 2025 23:37:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 17CEB6B009C for ; Sun, 22 Jun 2025 23:37:34 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B61171D3D35 for ; Mon, 23 Jun 2025 03:37:33 +0000 (UTC) X-FDA: 83585255586.02.6D2716D Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf19.hostedemail.com (Postfix) with ESMTP id 058F21A0006 for ; Mon, 23 Jun 2025 03:37:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=W4RaVgj0; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750649851; a=rsa-sha256; cv=none; b=1LAjW5/6T0beGbaxmEnk1NXF+SYR8fGwRndqHXimbX6jg+NGwudyjx3zKj+Gj29rd8ilKN MJXol+Lba1gGvYFS0FtV3AcfC5MvE2eF8C8W92QetPWzGAurqOGU93YHXjzOpC8yXCnW8s fK0h/rIovLJkHvPlCkeUnGOVqMBNXa8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=W4RaVgj0; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750649851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X95Z8bS+8nuD4P3ijqDpImaVXrUo0x81pQGKzn2BuJY=; b=Uspwp40eobZOWtvMIXkHajrvISKt7J84Gz2N6cAQcQLfq4LH7YJ1gyuFJ7tu0q3ZvXWqBx j38xOMcfSStl8GNMR1dXVrib3dzKuz8oh62fVfwyLlRD/ayR8x8mty12MP+LdrKdpIHdpY 6ULY8VR6D7XZNxSdEzvGrGVXAN+KeSs= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750649846; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=X95Z8bS+8nuD4P3ijqDpImaVXrUo0x81pQGKzn2BuJY=; b=W4RaVgj0pTsrIyBpRfiDCqsQIdrgr6gkVNGlGj3+oxc9En93XDLe8sOpJnntgDrHZEz232/fHiZQAaIxBgida57/2BMcrAOs77dZcMBDhb3iLS9xPjMNZ9nKVHSV/cVKvRmbeQH9LHVCI+YM6VMc+UzN6kXq7ZJpLC/n5aV/ntM= Received: from 30.74.144.128(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WeSQwSG_1750649844 cluster:ay36) by smtp.aliyun-inc.com; Mon, 23 Jun 2025 11:37:25 +0800 Message-ID: Date: Mon, 23 Jun 2025 11:37:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] mm/shmem, swap: improve mthp swapin process To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Hugh Dickins , Matthew Wilcox , Kemeng Shi , Chris Li , Nhat Pham , Baoquan He , Barry Song , linux-kernel@vger.kernel.org References: <20250619175538.15799-1-ryncsn@gmail.com> <20250619175538.15799-4-ryncsn@gmail.com> From: Baolin Wang In-Reply-To: <20250619175538.15799-4-ryncsn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 058F21A0006 X-Rspamd-Server: rspam10 X-Stat-Signature: pi4xyq6sq9cpr7gdo8m5oeg7ajw9x1qm X-HE-Tag: 1750649849-78808 X-HE-Meta: U2FsdGVkX1+VenmMvKx2+syYsWAhFjmsOm/rlteN/XU8QvPyUyvNr3MAnv0gUWziuCqyOgZ9sSadib+bP7/Y6PSk5mXDhxHrku2QbMdQpzBTrBByikwflq5N+E1/XAs3c5qULqOkrpWj2rWOXIBHGo2PUrtjjnf27O+xUTdKdof0DTTulJ7+20Ox/OzFymLp11Ajf/UgRb89w4bCcrg4zvSEeET/uSTt4HnhNeFoYVL7qTnwkUwYl0Bo1xM/JgP4NOYO4hRWttsYMx+GyehXqTOMYEIX4dZjUszSoQnKL9S/kgy4OEc4SFX+oMPh8/pC//pkZ9Ik5Jw6o/0SIQFR1pdIyJrz89YcNlF1xv8NLUi1jCSgnvkpbSZ3meHC+LiTMBXg9OjWsQi103Huw+GicZ/OEAwQ8LsUJjG9oWrq9OMLYFIVUZSFU3XlrVKUFkbaPmufg7xp7jvs53hRu9uNvGD5qRflrGOsgb44KRoDRb69r0sVHsXQjLJAqPMsMTZ9banDLewmJNYeTlsQuiAU5Z/CwS1n0JwIoxKgj1sMOMPpGUBDXq5ITjsofobvUtrVjy7eTxAujJURbSgNcgyqiyHFsJ0VGNItpTXNUQbEzIY2D4lcU9v3X0Y4F0VmmzkmYGPqL3tJHN32i6237DW9EURISa+S4wEK5UxYJaqChGyF7qWGN+PjCZmp4SUMEOw6hyOKdlJrHnSHtiB1tsGZfu/nXQpRSFmJbPFjzoC2PKRhrBzmxPRSln5gYYZxjl3sADzsQioisHLHGTZdWkJjuUUkjzFdc+prAOxXMOp4XRZmI1uBbanz2619eAmYUZmeen9onaDzjYAdYGYZAe0CWT5rDP9sHmFq+FS/thvoCK379RV/yqET6Wy1+/8nnsrWTkVQhXBUuQFkoRCjMxQgUe642UvtQdIUqfrwYNhToxSyhGj9TWoa8+Mi2X8yqso5hepeO1prVXUD8nwf9ga w4r4bdQE JLIxFYPUdNYXX4awJrlQeJVm/wBxI4XUT472AikKlsyDUGW48TxVMoOY7ZxUMLuvdU9G7ILAx/d46NCiXx3kWs3kXrL2eDYCPOhyifntyGCB9rJ9pRAtxhn+Eby2VOPSx1TRfmNOdg80LMobUj/HntLLcMOObu4cNO1BD8rdWlwLdg7yKkx+QszlhI1EM8lQWWAU167axw7yLBngzW9mE27+CeVxAQ7m/dwoSs9CXp69Ke35o05cvfU4BGqmt1ixeLIj269l2koeYMbtsnkPTS500oxQpT1MsybvzLRmnC4bE6Ve9BhJ8axSZ6G5EZzzzNlxZnXpsk9lNV+afO4aq1dw6PEcugJKJr6kf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, On 2025/6/20 01:55, Kairui Song wrote: > From: Kairui Song > > Tidy up the mTHP swapin code, reduce duplicated codes and slightly > tweak the workflow. > > For SWP_SYNCHRONOUS_IO devices, we should skip the readahead and swap > cache even if the swapin falls back to order 0. Readahead is not helpful > for such devices. Yes, agree. > Also consolidates the mTHP related check to one place so they are now > all wrapped by CONFIG_TRANSPARENT_HUGEPAGE, and will be trimmed off by > compiler if not needed. I like your idea. But I found this patch hard to review, since you you mixed too many changes into one patch. I think you could at least split it into 3 patches to make it easier for the reviewer to review and test: 1. consolidate the mTHP related check to one place (cleanup) 2. tidy up the mTHP swapin code (cleanup) 3. skip swapcache for order 0