From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99716C25B75 for ; Thu, 6 Jun 2024 03:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0A796B00A0; Wed, 5 Jun 2024 23:31:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E900C6B00A2; Wed, 5 Jun 2024 23:31:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D31686B00A3; Wed, 5 Jun 2024 23:31:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B56E36B00A0 for ; Wed, 5 Jun 2024 23:31:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 46F4F80B29 for ; Thu, 6 Jun 2024 03:31:11 +0000 (UTC) X-FDA: 82199037942.03.1CA6170 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 3D6281C0005 for ; Thu, 6 Jun 2024 03:31:07 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZIFXWHne; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717644669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8bvsBpySglCFgXdNC5I77P307WaretQBqm5HvmnfVMg=; b=GaDtNzLV7aQXOg0QIb9JoTAMj6i0XKokuss3lBnLSzaDwS+lvBySTNEr0Bye/axQLNSIDH exFEjcNQX1XM/y0DbaTWM79DM2oz/62QOEleR+zZPCnQ8DucNeO1i/j87ORplZY7/uUWR8 /g6bnRhdmkzaWu7xOfncwHJHeOckigc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZIFXWHne; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717644669; a=rsa-sha256; cv=none; b=S9iM0mnwtbontnhDpItlys/+1pQgqfyCz6FMr2KHrD3vChC5lZG381sCsfCwtw6Ew2ks8T I8nB14NAj+NwMmSluk5nd5Ku/dlzJjEesdf4rUjEm3G9cGsacMapZo90EafoFuuuqMN8KT j40C8QnHrMWqTUWC+Fak2ueJLyC9tVY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1717644663; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=8bvsBpySglCFgXdNC5I77P307WaretQBqm5HvmnfVMg=; b=ZIFXWHnePPmkKLU56CKHDPbKKURNOoyTEzNcPcDVbMK+mSZ93yZSEgYECkRiO5gJetq+IcyuWSjewJggXwsByCaE7flpNNWFeQgMDx/LuyW2akDTjTOV6HL5I/hUxNTyOeOlbUA+L+UnXbeZV4EdEnDndoIC7CiplWFFi44vnSk= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R591e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067110;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0W7wss4x_1717644661; Received: from 30.97.56.72(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W7wss4x_1717644661) by smtp.aliyun-inc.com; Thu, 06 Jun 2024 11:31:02 +0800 Message-ID: Date: Thu, 6 Jun 2024 11:31:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/6] add mTHP support for anonymous shmem To: Daniel Gomez Cc: David Hildenbrand , "akpm@linux-foundation.org" , "hughd@google.com" , "willy@infradead.org" , "wangkefeng.wang@huawei.com" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ryan.roberts@arm.com" , "shy828301@gmail.com" , "ziy@nvidia.com" , "ioworker0@gmail.com" , Pankaj Raghav , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <502fb3df-b42b-4f0c-a98d-348c3d544721@redhat.com> <5mezgqzg7wmd4iq2d2q3aentziosetwcll3tgdbl3mhriseyv3@pgxsux7qvxno> From: Baolin Wang In-Reply-To: <5mezgqzg7wmd4iq2d2q3aentziosetwcll3tgdbl3mhriseyv3@pgxsux7qvxno> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3D6281C0005 X-Stat-Signature: 4bwiba6ecumcbxe9z4ruyj8j9j7q9ewt X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717644667-332995 X-HE-Meta: U2FsdGVkX1+wTS+UTcQzNoPv32lGJFrSBwXrhUcq5gCPpmQt7y1K/DI65h5Yy1UONlDVbViTaOecTBAQIPbdII/c22/CHUQH8J/ySCs8NDTsK1cQqsAamEPrPla55y5hlZdfwok1VB3X9+z4aypON1k9MNu1+lDML9PcuLvUw3oXMn6owYDYkI8oKXIsAEQAgRF6yWToXVd+JEiIu08+Ylj+eEuDNOhj9bdH3OUjDtMkpj6keF1j8vY7X1yh264tTL6sxIn05Su5umMr+K/AoBINdaWj/epJuRkAxT3QrOsXk7cV+Xahf+OI+4j3LsR09Hsyz3KfE15Z23yzvgeqQE/GRAGSJ1JlvqfEA+Yy/fZRB+LjLpFl1TkwY5rFFVF0C89JM4iUnmsfmPA83NrUkMu494lEfZVkvQPsqUyZnea8KtvhECUCdiLI1xCPoYjii7HJZNhce2kI3FUnzkuU3PyvVV/uhTN5AoM6a+M+54O3znsxwzPgJnXtugJStjk/uut9DCpbqSo4oZJfZbB8rFIpMpKRkMrA0ysBbyeBobFUwm8jWtDgsmfMdGsOpBYSma/eSnjOPb+LqX8m4m5okVLI520s1UOqgKWB0Yn6R6yeogpr5EETgvuyEGx8xenTCY+oe9xscoNH2Kd3a+wU77WsHRGOTZ1dNhv1N98mXWpIZ6RHUyDEEPglBFv+6dQg4Y8zwGIsGJHHfTegR64DBZ/GbOFZbrX8lhW0v2/WkVA4W9uL+IWBYOYE/xAroYscAsxa19Q7cwrscIqYy7NY9hGvFJ8saF9FEDEDs/SGmIRDz1566hxxj+UFeS7JEsFucT0kk5z1PXSJF2nZ/v22ieP0BqKxBD02nnfHbwG1nvwQjNjpLfYgYy3FBvxfZjPkoMtgKsvoSm9e5G90yMkfkRFKp9L/OKgB6IEC1N3vXfaAmpu4XxwbZEMqVf+pwZVRf4g8VgKhlHRiHh95ulK uAyctbHU kKO0ogXF7+UHLYnXCE3Wd1aGYEGUHmu4SkfQdAmJumYnyXU1RnihSax/RdOv0I/CgIP/gWaxCrYMKw0qL2J/21BY99zgTU0u/fr95Pi8s3tbrQ1l5FzKBOCepOSF3KeZkPriBHkJkiI6zO395/7MjJGDQ3g9jCvxbQWX+s+m1aSPHivNhgUWqDe1AFL/gr9JZkhcn/dHIgbEziHyKX2WpHJmscOokNitrQq4ZNYsxUIKdPCc3mEgn/zjcemPEBgRsKxvKcmE7MJg+FdtnJQAdYi7DTj7GPBpHW+rP2FeqitgLvvgugIsKsCDY3X8KuVbLCLRadTANATQyEqJdINBMFlIh7uv1yh2L2czQ5WEmqnUn+72pzbcwSzNlotzX9Z+Dr8ih/0Jk255KGg8xbRWZUOsSGp8t74OXAozjKo5rs7b1hcw21wC8rktuQ1FMek24U/bB6PY/el7Iro9rI1qATpWNPCXhsYrWDaszcOJyv/TxJM78E7Ivu5kg/6GER3Uo5fe9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/4 20:05, Daniel Gomez wrote: > On Tue, Jun 04, 2024 at 05:45:20PM +0800, Baolin Wang wrote: >> >> >> On 2024/6/4 16:18, Daniel Gomez wrote: >>> On Fri, May 31, 2024 at 01:13:48PM +0200, David Hildenbrand wrote: >>>>>> >>>>>> As a default, we should not be using large folios / mTHP for any shmem, >>>>>> just like we did with THP via shmem_enabled. This is what this series >>>>>> currently does, and is aprt of the whole mTHP user-space interface design. >>>>>> >>>>>> Further, the mTHP controls should control all of shmem, not only >>>>>> "anonymous shmem". >>>>> >>>>> Yes, that's what I thought and in my TODO list. >>>> >>>> Good, it would be helpful to coordinate with Daniel and Pankaj. >>> >>> I've integrated patches 11 and 12 from the lsf RFC thread [1] on top of Baolin's >>> v3 patches. You may find a version in my integration branch here [2]. I can >>> attach them here if it's preferred. >>> >>> [1] https://lore.kernel.org/all/20240515055719.32577-1-da.gomez@samsung.com/ >>> [2] https://protect2.fireeye.com/v1/url?k=a23e7c06-c3b56926-a23ff749-74fe485fb347-371ca2bfd5d9869f&q=1&e=6974304e-a786-4255-93a7-57498540241c&u=https%3A%2F%2Fgitlab.com%2Fdkruces%2Flinux-next%2F-%2Fcommits%2Fnext-20240604-shmem-mthp >>> >>> The point here is to combine the large folios strategy I proposed with mTHP >>> user controls. Would it make sense to limit the orders to the mapping order >>> calculated based on the size and index? >> >> IMO, for !anon shmem, this change makes sense to me. We should respect the >> size and mTHP should act as a order filter. > > What about respecing the size when within_size flag is enabled? Then, 'always' > would allocate mTHP enabled folios, regardless of the size. And 'never' > would ignore mTHP and size. So, 'never' can be used for this 'safe' boot case > mentioned in the discussion. Looks reasonable to me. What do you think, David? And what about 'advise' option? Silimar to 'within_size'? >> For anon shmem, we should ignore the length, which you always set it to >> PAGE_SIZE in patch [1]. >> >> [1] https://protect2.fireeye.com/v1/url?k=0d75a0c6-6cfeb5e6-0d742b89-74fe485fb347-904fa75c8efebdc2&q=1&e=6974304e-a786-4255-93a7-57498540241c&u=https%3A%2F%2Fgitlab.com%2Fdkruces%2Flinux-next%2F-%2Fcommit%2Fedf02311fd6d86b355d3aeb74e67c8da6de3c569 > > Since we are ignoring the length, we should ignore any value being passed. > >> >>> @@ -1765,6 +1798,10 @@ static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, >>> >>> order = highest_order(suitable_orders); >>> while (suitable_orders) { >>> + if (order > mapping_order) { >>> + order = next_order(&suitable_orders, order); >>> + continue; >>> + } >>> pages = 1UL << order; >>> index = round_down(index, pages); >>> folio = shmem_alloc_folio(gfp, order, info, index); >>> >>> Note: The branch still need to be adapted to include !anon mm.