From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA9FC433B4 for ; Wed, 19 May 2021 17:57:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0C1F61353 for ; Wed, 19 May 2021 17:57:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0C1F61353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE2096B0036; Wed, 19 May 2021 13:57:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B0E6B006E; Wed, 19 May 2021 13:57:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBE6A6B0070; Wed, 19 May 2021 13:57:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 95E886B0036 for ; Wed, 19 May 2021 13:57:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2B8A69411 for ; Wed, 19 May 2021 17:57:21 +0000 (UTC) X-FDA: 78158737482.09.BE21A4E Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf08.hostedemail.com (Postfix) with ESMTP id DB8008019114 for ; Wed, 19 May 2021 17:57:19 +0000 (UTC) Received: from mail-qk1-f199.google.com ([209.85.222.199]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1ljQRb-0004r6-1u for linux-mm@kvack.org; Wed, 19 May 2021 17:57:19 +0000 Received: by mail-qk1-f199.google.com with SMTP id 140-20020a3704920000b02903a568b50545so4723169qke.7 for ; Wed, 19 May 2021 10:57:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BcZ/T9imHACo8Z4kSI40UuANWMVe6/Ole5+QagzVCe8=; b=Ftp3s6osKD/cNZEcELpmHFmp4eeS0GggpBaSwFmxtuWdIXMlSuprX51DcRyBL6/5+H 0LT//oAAikzFXn4onN9Q7HEML2rzeaFofYe0b0lUN6wqlIkpU0eOnbS9cmxNqNQj+9pN 7SpfH5p9PwbO83Mb5ym9dhDsPKQZ3fw3AP/n2dFjcCQvm3oOb+HNcme/M43CpJLUxH2J wKSzJkNbQopKfyZxHj5Y5K2hKgjn8X0RQsWXefOYwJ9G20SFZWv1cV/sMF03tmmoq4uc /IRmJhljR3wgRdYfsBGPzUz+i3QEyn0/tUZI7PUCx6wHJd0Kq9vJdfxoJKRvyBq1X0qO j4Tg== X-Gm-Message-State: AOAM532l1VvzDUY7t9vyoTbppT+QtWRHVJ6Gk7k/QYGHsVLjB1eNbfel UsBy9edU+2JnYI/EkJvrWcIW4OoTQ6tDm9FWMwh0+TqfAyUUXLDaKCgxzotSAPvtRVG8mqII3r0 LsEP6UxU+WNsT4LN3lrADPvvpFiLl X-Received: by 2002:ac8:4256:: with SMTP id r22mr743237qtm.207.1621447038144; Wed, 19 May 2021 10:57:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKraDoCFPHZbxvHQR9nlAIXYbb9X3n0gzCd66TMrZlnS/PJn2nu80hkAHPonSh3n4gmge3UA== X-Received: by 2002:ac8:4256:: with SMTP id r22mr743216qtm.207.1621447037980; Wed, 19 May 2021 10:57:17 -0700 (PDT) Received: from [192.168.1.4] ([45.237.48.1]) by smtp.gmail.com with ESMTPSA id x13sm117197qtj.12.2021.05.19.10.57.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 May 2021 10:57:17 -0700 (PDT) Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation To: Vlastimil Babka , David Hildenbrand , Andrew Morton , Akinobu Mita , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Michal Hocko , "Rafael J . Wysocki" , Andrea Righi , Guilherme Piccoli References: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> <515ca9c5-ba60-5b90-0941-2b3dfe1d61f3@suse.cz> From: Krzysztof Kozlowski Message-ID: Date: Wed, 19 May 2021 13:57:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <515ca9c5-ba60-5b90-0941-2b3dfe1d61f3@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=canonical.com (policy=none); spf=none (imf08.hostedemail.com: domain of krzysztof.kozlowski@canonical.com has no SPF policy when checking 91.189.89.112) smtp.mailfrom=krzysztof.kozlowski@canonical.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DB8008019114 X-Stat-Signature: ci6nf9xwyn475md6crzua43ttek7jwbd X-HE-Tag: 1621447039-308735 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/05/2021 11:48, Vlastimil Babka wrote: > On 5/19/21 5:30 PM, David Hildenbrand wrote: >> On 19.05.21 17:28, Krzysztof Kozlowski wrote: >>> The documentation of DEBUG_PAGEALLOC states that it cannot be used wi= th >>> hibernation, however the Kconfig entry would allow it if >>> ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC. >>> >>> Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix") >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> =C2=A0 mm/Kconfig.debug | 2 +- >>> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug >>> index 1e73717802f8..0ace5b2a9d04 100644 >>> --- a/mm/Kconfig.debug >>> +++ b/mm/Kconfig.debug >>> @@ -11,7 +11,7 @@ config PAGE_EXTENSION >>> =C2=A0 config DEBUG_PAGEALLOC >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool "Debug page memory allocations" >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on DEBUG_KERNEL >>> -=C2=A0=C2=A0=C2=A0 depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PA= GEALLOC && !PPC && !SPARC >>> +=C2=A0=C2=A0=C2=A0 depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PA= GEALLOC && !PPC && !SPARC >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select PAGE_POISONING if !ARCH_SUPPORT= S_DEBUG_PAGEALLOC >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unmap pages from the kerne= l linear mapping after free_pages(). >>> >> >> I remember this should be working now, as we temporarily map the pages= in the >> direct map when hibernating? >=20 > Yeah, and if the problem was the page poisoning based implementation/fa= llback, > that was also fixed. >=20 > The current dependencies come from the unification by ee3b4290aec03 >=20 > The question is if PPC and SPARC still really need to disable hibernati= on. I tested slightly older kernel (v5.8 with few backports for poison support with hibernation) and it worked fine on x86_64. For the PPC and SPARC I don't know. I can update the Kconfig option description to mention x86_64. Best regards, Krzysztof