From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40D4D64079 for ; Fri, 8 Nov 2024 19:22:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 447F66B009C; Fri, 8 Nov 2024 14:22:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1568D0001; Fri, 8 Nov 2024 14:22:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2229B6B00BD; Fri, 8 Nov 2024 14:22:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F38676B009C for ; Fri, 8 Nov 2024 14:22:11 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 99E3C120266 for ; Fri, 8 Nov 2024 19:22:11 +0000 (UTC) X-FDA: 82763898084.02.AC3796F Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf17.hostedemail.com (Postfix) with ESMTP id EE1A340025 for ; Fri, 8 Nov 2024 19:21:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=VCBBynZb; spf=pass (imf17.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731093541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/2xw6bQGR1qVT12RbfKbkIMjqt4HqMiwUGLwAnBMYg=; b=gqC31GJ1frVcLZ0OC6rHDK93qzPXaMVbx1dJpOgEDSgG3Ku8gqxhcsMiABDaQIqb3vVGDQ nEKLXkYA/2qgQx+3vO7VaqaTLc3072pyrD4T3/GKObJfKZpyX2kA+BjZSQvNvW5TyRLLpz tVJ8qwi99zZnnjZ1NMdZ1wA3PGveeHE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=VCBBynZb; spf=pass (imf17.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.182 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731093541; a=rsa-sha256; cv=none; b=4HmB9H5nAPvY2al+PYLjYynCYvFU8p0GvP0TgPUm/Dx58KfbKaFtRrszCVFb7ppOi3UDAR srht461dQRbX76zFaBfCMlzEPjI2Dah88P9FPpL535gc2CGLtgei57697LgHgBD1c+lTUp azsvt2R9KRt7EG/IeiDUYZVgr2ZCEKE= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-71e681bc315so1936357b3a.0 for ; Fri, 08 Nov 2024 11:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1731093728; x=1731698528; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W/2xw6bQGR1qVT12RbfKbkIMjqt4HqMiwUGLwAnBMYg=; b=VCBBynZbLhkUZarbM59g3yfK5TIAGrumWZDRtcXpk+cJaYwo7g+U9Blp6cYWasRHA1 ToQ+Bq6Fx4pILsJJLbZKo+fXZ9IqPpqFH45HUUfngCS9SrlWTynJOu/YPWxuFoJkpuV4 MxOF4N2Bo0BlSk7wrX7Lbx3zkoxIY5AHUgJFRhoTR9GwvsrsISYzBWKEMr6XT5dHkGjr DXgDQnn7B5JtToDGh4idbRhMnTiLWxA/s2LViZ9KwXklECB0zYHn2fEA5N668JVIB2m7 o97VJEwnAUcuZjc+bpHH5LsXmDHcBJU9aqFeojMiU7oVOm7Y84ZgEHI2NWBLmDlXDVaW d5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731093728; x=1731698528; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W/2xw6bQGR1qVT12RbfKbkIMjqt4HqMiwUGLwAnBMYg=; b=atr6mFXLBTYJiA4XLLQWKYZasHvWTgiUUZPPIa6JImCChrsQ7A/uQ8FA/Uz9Kut/LA yfByJH97u3edTqg3IZfLwjntwm1CjVwpvWubzqSzvC4kYRcCf8aWVnJ/xLh/xlTQka3e R+6F5x8BOl4TqwzKoFu7dwyREj/XNjh0o5RRZou99RsmKDgU3S7giVw/uaETE776eJVP UEHJeBFhgldy476NURO9wvWmZCh4N2o0Y/5KUiUwzbqImXWleAyeyXrHH6cFbg/ls+04 7t3pkagpuArI/kz/EafFW/c9f5dh1k7HUWYH6lYNhsMLKpCn5YWO3hmSh6IPXx8beJ4p CZQw== X-Gm-Message-State: AOJu0Yy7qzOhyl9YZVbhLbxHYws6ps9iZ1+nlb8A0raGNqKF5dYXX+Tq 4qWU+7prVIPp2uiBdeS2vgz3jEnc8TjVm6YLWKDnIauFSxKK7vULWcZYzAy3ddE= X-Google-Smtp-Source: AGHT+IE4GpRSxNEAACaLFtf3NzAfVlp/T4+DBCJgGssmHg8jA29R5sIhhTXp3PgmzohpeqnGTSBFEQ== X-Received: by 2002:a05:6a00:18a5:b0:71e:4a46:fdb6 with SMTP id d2e1a72fcca58-72413f52db5mr6397257b3a.3.1731093728157; Fri, 08 Nov 2024 11:22:08 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7240799baf7sm4278733b3a.121.2024.11.08.11.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 11:22:07 -0800 (PST) Message-ID: Date: Fri, 8 Nov 2024 12:22:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/13] mm/filemap: change filemap_create_folio() to take a struct kiocb To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org References: <20241108174505.1214230-1-axboe@kernel.dk> <20241108174505.1214230-2-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EE1A340025 X-Stat-Signature: y5p1cuhqcbjykyfgtq5w4kdymftjnui8 X-Rspam-User: X-HE-Tag: 1731093700-849517 X-HE-Meta: U2FsdGVkX1/lAUTl0+6MKevHyye9wmnRrIXdyZi/lI19O0VPxEvxz633Qv9ZKZUnRol7Cj7W7ad3QpVN7N0+M2LHUA5v6PQuI7pKGMEKq4f7ABvL4/CmfHmmsx6CnHfQL+U5rAPH+odY5S3tYpVWZabM1vRx4baGuJmBiZrn7XvA71K2vpr4MEaau1UL8lAlDM4ypMBsGuwGN31EQ7G+cT8vG2uSfAogwguZzlst2ajMJoaEudxSirpNz9Vnvw8JVs53FSIEYDy72BoULVqA00HtF9Bi5OwVh0V3DNJCTGr4qCq0DIrLDawJC85ls4bQqMD4FXIOVRZfuCfbl3nG0e1+GWnSsY0MaQOdBQiIwX+1e2gmMTZIoGSv9OM1KU4SNgrbiIEgkoNjcc0AwHV+JEFc7VgEkqXnbCVaOHlwi5HLqn8bl2TfBRzJIUvQ1hR08yoqqYFV1PoFgi1MQ7i1PZuDEkDAAdBduSih7X8yEaXn2Dl/u2qwiO05J6Ur+AXKnzdazaX+QS56Tk1pTDh9nIPKKDr5iayNcqZBicr/C/Ca8pslJgVqdJEaoQTwKoGM6qfkHr3cANZ3d/8ft5HA+Uct63BcSUJ7xON66+GPKC6vmBcoLaNSI53/oFRPrUFUO5fT4nfC7UpMhb2mhV8YOyTxzl4zcDwEmL9nFIVuEYiAXCw84oR7gnDvuoMaG4UWl6Kd4ErSZNk3U62ttwrTrehd836kd8WHTh5YP/nvPbg79hrzlnASaSXHksyMcaDx2ubLbFAnzM1LSeZX3tbv3ojXw+5hsp0lJG7rRgLHdOnWYTPRtKu2JMZFTyhONZr4dcqfYAPiEuDq1GFpFh5aqvxQzfJ3Ra9zXWhPbJARtKoLXdG85YfD0BTOPDadOA0loqvgkIwxDNjgUncvk0/rMNqwWJhFxN7MGjyn89yac7ZvTRXxBQ3B2gBMVDvZKV+6R8rmBiSp1IVTpxhizX8 wWaxJSDb dNwhrTuTQeKbLUCoHDJDASl6+m90smLG5E5mvlmJQZD0A4zyOZRoFoUpu25TbwMkJH0BjD6i7gpcxcGnYJuHQFdKVfp0FekFKOQqCXSxJDEbCW4+E1CXwUUDoXfLAFPPSY44xdXcTAqnFhaA5qsMslL18cTshhaD8CmCr63DBYAU6j1RnJMX7MavZxq0sSE25uOAWBlm1Nu/lDGjmAYH7vpEPqLsD5I3ci83PmheGsm9ECeTcgV/qgFAA5h268iRDKPXab116p7uNIgu6fbqOddUQ1c9Mv2yNMJV1P2XrIMcHB5ReaxkL5SdDAvEwVUYMdpnGQlmAW3GzLNdamTir6KAxiMb8+/1IT6iTTi7Md82ckAW2dpf/Z7FvVUzXg9p3KNnxP7zgXwP4hXJauukwy2b1k960Fu53l5a6oSvOOjHtR34= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/8/24 11:18 AM, Matthew Wilcox wrote: > On Fri, Nov 08, 2024 at 10:43:24AM -0700, Jens Axboe wrote: >> Rather than pass in both the file and position directly from the kiocb, >> just take a struct kiocb instead. In preparation for actually needing >> the kiocb in the function. > > If you're undoing this part of f253e1854ce8, it's probably worth moving > the IOCB flag checks back to where they were too. Ah wasn't aware of that one, didn't do any git history digging. Sure, I can move the flags checking too. -- Jens Axboe