From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33F7C3DA63 for ; Wed, 24 Jul 2024 12:55:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47CB66B008A; Wed, 24 Jul 2024 08:55:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C066B008C; Wed, 24 Jul 2024 08:55:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31AED6B0093; Wed, 24 Jul 2024 08:55:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1307E6B008A for ; Wed, 24 Jul 2024 08:55:06 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B71ADC0952 for ; Wed, 24 Jul 2024 12:55:05 +0000 (UTC) X-FDA: 82374641370.02.063EE8B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id C50A7A0015 for ; Wed, 24 Jul 2024 12:55:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721825656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2gKTFXFgLeaHj4PihhALq8KH3rx1EL16Ct/Boh1H6Ec=; b=WHwoA50oLXQiXYfjzbUiholY7x7HltI4dal+QTEC/QgxWLJVq2Od54Or72LlkQG8qMz75u Zt5ZdxX3RV/ruGTs/SD+GtzFpKQ91coXjDLaciEow9risBm32sjbmoRs5QOn644zg7BoTG aINzMTc7QU9+aQpfytIYXrFM8pWUCag= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721825656; a=rsa-sha256; cv=none; b=Jl3ibf9WvqZDHeJdPkcjTQ+5ztDWbNchZpsBuePQq4vMQDDiCkblgrROt8BQOxiFt+N1oc kXi8Hd3ySj2S2KObnJnk9RAg96ZjYgjB48uYo2ssr0Ae3EHdfRPRrCWgMkFv3iYuqoCQCe 4oSijxJIiRGiww3/1XWKkED0EW1Ti/M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WTYl31Pz0zyN44; Wed, 24 Jul 2024 20:50:07 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id DB3BE1800A5; Wed, 24 Jul 2024 20:54:57 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 24 Jul 2024 20:54:57 +0800 Message-ID: Date: Wed, 24 Jul 2024 20:54:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v11 09/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() To: Alexander H Duyck , , , CC: , , Andrew Morton , References: <20240719093338.55117-1-linyunsheng@huawei.com> <20240719093338.55117-10-linyunsheng@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Queue-Id: C50A7A0015 X-Stat-Signature: pwkdk941shb6m4p7nem1p7fdhejbphbq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721825701-585114 X-HE-Meta: U2FsdGVkX18Tc0fVbAlqeAATjNG0pSwbgVRX97R8ryFwXrvnk7vrXwOZRrFVIziaxYeRjmOFl1WPtkbRVJ3MOzXW2chteqK6UhHnUc+0JSAVhyXtOrTYZRWt4utqrdPAHwrxm+ZmyFYMGGLqMsz715sKYImqr11akLpqs7+55LZAqpv++hde/iScMF98I+JmbCdt2Ijd4hs46OEIdLRyEpjSBtxUDvzV7pbbX8TdGf/p39DhbxQSLlm4N1BB0mRvUC/vm/al3bfDw9mu1JKorlGhQNWhEtpKFPedw/37F8EtNMXXi/xZUSsxs5zN74qJ0Cb5vFxg9wClbi+K+iIif6s+Z0X93MFlYtWOGqE2YmtxH8uTFKYsW0rEpwAY5bc69P0a/7ff9HfCLZz5CoYLhDEBB9A/uOgs8Y4OvMKLwJl8lCrSWh4VEPppz5bBYeUUgcQm1VfmaqJKdhLLOLisf/2GNJKJ4cG1NvzavClNuf/ZOHDoUMSfMOWstzzdeWoDcRMzCnI0gX8kGEvI7tl0zpW3hoLovlW7/G7u2NjtFJ9MdzJEL8nh3tcvxbeNofcShlsJXDhYNZTE0kdFNEsNfDOG3f21ehzJvRNAG+3r27hLaUWh+9p2smRSLY+oXFKc1ksmT7OJkn7MMRi9U+fIpHYeLKg5Nz1xuIOffhIT9q6XFmJIhwom6n7JDZy0MVBleS5fG1GJ/VGaUxp/NdTcZxkMd3RAnnYpVdjDICY9zm8FO6+KkCtoSrR92yKtdfZOcvAthHJekqG3MJ3PjBvghWeP1J8n2U18KhLNKTLHguGt43Vtxh/aX1XGqjMyph4M4v+RMFpyhOUHZIkFN0HDrHLy/RwBAx6gYpgcLS+9+XZwl8RIxryq1WXKitQ88QPlc6RArb3ADtQr9jgkgmDV3KXEIUGThx0WKJ3094Iauu+yp+Kq5TXVlUWYGp6aNImv61M65vnApJbam85XWrB r8ngfDhQ ybBGZh13fCRoHGwZS1gqqY1rDLtLdbcJHW2xo9HrQePxzSUqFFJwHuudxbspqqnQGdnlfjEywDfE0v82nrrFP8gPMnnHO+pWWpJzvIober06bljN9m0dBtA3wzbjzRiRG+FT5LO0sNYghWb5ycD6B91SL64ddmwizcpquWgcOUUqfjJaJTcmOkyWM5UA/vgv9xDyu2t6Txn1mZHFI6LuEWonO23jT2XnudjuFDR3r1g9TO6sHUEJ4nf1YtYDcjiVzPKfQlIkkCKyAHu84a1imJyQscy72MHS7WGA7V5zVcA8QYjUEoqJChkAWebelsXgP/il84yKHNwZlBa6XrqUgyOvLAcvFOTB2jTEj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/22 5:41, Alexander H Duyck wrote: ... >> if (unlikely(!page)) { >> - page = alloc_pages_node(NUMA_NO_NODE, gfp, 0); >> + page = __alloc_pages(gfp, 0, numa_mem_id(), NULL); >> if (unlikely(!page)) { >> memset(nc, 0, sizeof(*nc)); >> return NULL; > > So if I am understanding correctly this is basically just stripping the > checks that were being performed since they aren't really needed to > verify the output of numa_mem_id. > > Rather than changing the code here, it might make more sense to update > alloc_pages_node_noprof to move the lines from > __alloc_pages_node_noprof into it. Then you could put the VM_BUG_ON and > warn_if_node_offline into an else statement which would cause them to > be automatically stripped for this and all other callers. The benefit I suppose you meant something like below: @@ -290,10 +290,14 @@ struct folio *__folio_alloc_node_noprof(gfp_t gfp, unsigned int order, int nid) static inline struct page *alloc_pages_node_noprof(int nid, gfp_t gfp_mask, unsigned int order) { - if (nid == NUMA_NO_NODE) + if (nid == NUMA_NO_NODE) { nid = numa_mem_id(); + } else { + VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES); + warn_if_node_offline(nid, gfp_mask); + } - return __alloc_pages_node_noprof(nid, gfp_mask, order); + return __alloc_pages_noprof(gfp_mask, order, nid, NULL); } > would likely be much more significant and may be worthy of being > accepted on its own merit without being a part of this patch set as I > would imagine it would show slight gains in terms of performance and > binary size by dropping the unnecessary instructions. Below is the result, it does reduce the binary size for __page_frag_alloc_align() significantly as expected, but also increase the size for other functions, which seems to be passing a runtime nid, so the trick above doesn't work. I am not sure if the overall reduction is significant enough to justify the change? It seems that depends on how many future callers are passing runtime nid to alloc_pages_node() related APIs. [linyunsheng@localhost net-next]$ ./scripts/bloat-o-meter vmlinux.org vmlinux add/remove: 1/2 grow/shrink: 13/8 up/down: 160/-256 (-96) Function old new delta bpf_map_alloc_pages 708 764 +56 its_probe_one 2836 2860 +24 iommu_dma_alloc 984 1008 +24 __iommu_dma_alloc_noncontiguous.constprop 1180 1192 +12 e843419@0f3f_00011fb1_4348 - 8 +8 its_vpe_irq_domain_deactivate 312 316 +4 its_vpe_irq_domain_alloc 1492 1496 +4 its_irq_domain_free 440 444 +4 iommu_dma_map_sg 1328 1332 +4 dpaa_eth_probe 5524 5528 +4 dpaa2_eth_xdp_xmit 676 680 +4 dpaa2_eth_open 564 568 +4 dma_direct_get_required_mask 116 120 +4 __dma_direct_alloc_pages.constprop 656 660 +4 its_vpe_set_affinity 928 924 -4 its_send_single_command 340 336 -4 its_alloc_table_entry 456 452 -4 dpaa_bp_seed 232 228 -4 arm_64_lpae_alloc_pgtable_s1 680 676 -4 __arm_lpae_alloc_pages 900 896 -4 e843419@0473_00005079_16ec 8 - -8 e843419@0189_00001c33_1c8 8 - -8 ringbuf_map_alloc 612 600 -12 __page_frag_alloc_align 740 536 -204 Total: Before=30306836, After=30306740, chg -0.00%