From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA54AC46CD2 for ; Wed, 24 Jan 2024 12:42:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228456B0071; Wed, 24 Jan 2024 07:42:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7E76B0072; Wed, 24 Jan 2024 07:42:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C7996B0074; Wed, 24 Jan 2024 07:42:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2E006B0071 for ; Wed, 24 Jan 2024 07:42:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A481180D38 for ; Wed, 24 Jan 2024 12:42:12 +0000 (UTC) X-FDA: 81714167304.29.985C6F5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id C67CDC0019 for ; Wed, 24 Jan 2024 12:42:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706100131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FnWbyw98wJnQEVCraTE/GZNQsHNw0a011auzQwarOjs=; b=vmQXOsxcwAUkeX2r91PIVAHw5f14+K2GJnDG+zHaLkQQh218L9ajH2kBKSO5hMJTUFuSnw OWyNgntKyO2RMi90Cx5TqNa1Jig5ZERAa+u2vjdZ9iVyP2fEFVwzqafuFPfUGhjz/WqPm3 S6+9wndstTvX5oM2K34c2bMPE1PHons= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706100131; a=rsa-sha256; cv=none; b=n2npG/cWnPwxuB5NT19DKy77iNlAhrtGafpoD8U9ZqYT1V0xOC2il5A1tO2ru7rmSFz9qP pak919Qn068W3CzOZdUr7OpK6OJB+yXiz1cTPxzDoDXvAgcN7vrOglO7exi1VIbzWXG1qL fEYGjoVzUowwSmYvNPGwVULmowUsuhY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD1361FB; Wed, 24 Jan 2024 04:42:54 -0800 (PST) Received: from [10.57.77.165] (unknown [10.57.77.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3654A3F5A1; Wed, 24 Jan 2024 04:42:06 -0800 (PST) Message-ID: Date: Wed, 24 Jan 2024 12:42:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() Content-Language: en-GB To: Sven Schnelle Cc: Jiri Olsa , David Hildenbrand , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song , linux-s390@vger.kernel.org References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-3-ryan.roberts@arm.com> <41dc7dff-1ea8-4894-a487-88d46ec2b2d8@redhat.com> <1188e67e-5c04-4bb5-b242-78d92c3fc85c@arm.com> <6caaced7-a9d7-4fe4-823a-11b96be83e46@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C67CDC0019 X-Rspam-User: X-Stat-Signature: 5zthofid7eawpi5ce1614uygoooungbh X-Rspamd-Server: rspam03 X-HE-Tag: 1706100130-143570 X-HE-Meta: U2FsdGVkX19VDDxXkyCc19/iPt+pLl2Wd0oUHi0+zCHxwr4yefDB3B6ouGLzKSovKpdpGBQ1eBqMHCWLtqhsPSX9ougj8ATy9AWtBVEG7bvEo+fgF5HmfCNBsqdfn/65w9oAE3ibsBxRVV+Uy0OBIK5h+PPlwvBu1gsZ4/g1aQEyL2iYrPjK6EQ+ou1PCjpi4zmPFLdpT421WUJqy3EIat7EACLZe05K+oNmNR5X5hhqicPQujpXhkFIQp4CKE8jY1AGtuEzK93Aq+1a6XG04AXzPb25/vB4HIWDUKJkTbAu1ulXAZMUBxUfBA1ulVBsMNVqE624Rqkdx0n5Lo26vFzglywevBKQ8uOqt5BXT+R7CS85Nz2bsbeksbZ8h2cY+2mfP+P9AbEOtepqEoIFxEQtWB4OceNa5N53L/Uu8dliyGHUkl7P+srj2y19zOWVa3NC+KdShfq2SzvViU/kiqOzarFp7VGdteW+9Uq+bxVfWjwBQpKckyHFrxX16U3WkGGuezxFUbsYdqIIIXzDoMcvVMS//F86ZthoIXYPSvO3+7bSe0M4lXxkwW1d22mw/P6aW5V1Bta0wqR2j2KrLszc7/yjpVhx9jQUQcWQ9QeGj+nFE7ogeILZtiXZhxv1FW34VajTJknNBD4Ej/vAIlaf3kP3lQHVbwYrX7XjP3c4Sv+81Fz+XU4nRK7lYXY7ZQLQwW95p891oaOeei92kplx3bFeYavaMws5jvFgGR7EyaxSvE3bXotwBMJBBj1MfxDuo7xRpowaM29LQwH7TOpNvhRQJRgDN8oEa9C70RcXrOVY1mzjt+GD/tqrxowrTCaXkgdJkyT0IuYGHX9cDAd4wydtoyu0j6k7Rf9yYCqzyfY6/F48vdqQH8g6IUdoQgTfk2fxI/AMsL3fXT/vtdlEEWGucNeycLky323rKZfdenr/c4OBEeiBKJuqmd/nmFsDA35v7ZWKQxyWHN7 nxvE/gxB u5IUdoZxODM0DCVOXppTGenP12FYyF/9Xd0a/c5fIoHFysGjMUMiatxMmFaqVJzp8So4c57Peuz3mm6FCM6SVPV1ZGshUE+jf6Ii4G3yNO7PPKlTyg2pHTt5WXrVoxSfCY7nImfvMwCC9BzglHR2WzvBdInj39mMbCCXPdTwjXGF1TL9xnsFegRRzrP4kLpS9BHlZXe4kKwzhxKyHilrVUeMKmu8yr+iFIMsOpKbu0G/PjTEjC5eEr7BlAefhLhBViAv/koY/9E4m4j6H5r3hk8qoKbCEyjZAq2IjWUSVCzszxzlD19XZO0zaFhNN0kg1FkIO9BehNUwUp5XRA5wj2+Y+8WxLDlhsmUegse4AqFR2GF6ht9JXaSO0pjq2Jq8wHKde X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/01/2024 12:28, Sven Schnelle wrote: > Hi Ryan, > > Ryan Roberts writes: > >>>>>>>>>> I'm hitting this bug (console output below) with adding uprobe >>>>>>>>>> on simple program like: >>>>>>>>>> >>>>>>>>>> $ cat up.c >>>>>>>>>> int main(void) >>>>>>>>>> { >>>>>>>>>> return 0; >>>>>>>>>> } >>>>>>>>>> >>>>>>>>>> # bpftrace -e 'uprobe:/home/jolsa/up:_start {}' >>>>>>>>>> >>>>>>>>>> $ ./up >>>>>>>>>> >>>>>>>>>> it's on top of current linus tree master: >>>>>>>>>> 052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat >>>>>>>>>> >>>>>>>>>> before this patch it seems to work, I can send my .config if needed >>>>>>> >>>>>>> Thanks for the bug report! >>>>>> >>>>>> I just hit the same bug in our CI, but can't find the fix in -next. Is >>>>>> this in the queue somewhere? >>>>> >>>>> we hit it as well, but I can see the fix in linux-next/master >>>>> >>>>> 4c137bc28064 uprobes: use pagesize-aligned virtual address when replacing pages >>>> >>>> Yes that's the one. Just to confirm: you are still hitting the VM_BUG_ON despite >>>> having this change in your kernel? Could you please send over the full bug log? >>> >>> ah sorry.. I meant the change fixes the problem for us, it just did not >>> yet propagate through the merge cycle into bpf trees.. but I can see it >>> in linux-next tree, so it's probably just matter of time >> >> OK great! How about you, Sven? Do you have this change in your kernel? Hopefully >> it should fix your problem. > > Same here - the fix makes uprobes work again, i just didn't see it in > torvalds-master and neither in todays linux-next. But Jiri is right, > it's in linux-next/master. I just missed to find it there. So everything > should be ok. Great!