From: Alistair Popple <apopple@nvidia.com>
To: akpm@linux-foundation.org
Cc: jgg@ziepe.ca, npiggin@gmail.com, catalin.marinas@arm.com,
jhubbard@nvidia.com, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nicolinc@nvidia.com, robin.murphy@arm.com, seanjc@google.com,
will@kernel.org, zhi.wang.linux@gmail.com, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, rtummala@nvidia.com,
kevin.tian@intel.com, iommu@lists.linux.dev, x86@kernel.org,
fbarrat@linux.ibm.com, ajd@linux.ibm.com,
chaitanya.kumar.borah@intel.com, tvrtko.ursulin@linux.intel.com,
intel-gfx@lists.freedesktop.org,
Alistair Popple <apopple@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: [PATCH v4 2/5] mmu_notifiers: Fixup comment in mmu_interval_read_begin()
Date: Tue, 25 Jul 2023 23:42:04 +1000 [thread overview]
Message-ID: <e7a09081b3ac82a03c189409f1262fc2df91071e.1690292440.git-series.apopple@nvidia.com> (raw)
In-Reply-To: <cover.1eca029b8603ef4eebe5b41eae51facfc5920c41.1690292440.git-series.apopple@nvidia.com>
The comment in mmu_interval_read_begin() refers to a function that
doesn't exist and uses the wrong call-back name. The op for mmu
interval notifiers is mmu_interval_notifier_ops->invalidate() so fix
the comment up to reflect that.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
mm/mmu_notifier.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c
index 50c0dde..b7ad155 100644
--- a/mm/mmu_notifier.c
+++ b/mm/mmu_notifier.c
@@ -199,7 +199,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub)
* invalidate_start/end and is colliding.
*
* The locking looks broadly like this:
- * mn_tree_invalidate_start(): mmu_interval_read_begin():
+ * mn_itree_inv_start(): mmu_interval_read_begin():
* spin_lock
* seq = READ_ONCE(interval_sub->invalidate_seq);
* seq == subs->invalidate_seq
@@ -207,7 +207,7 @@ mmu_interval_read_begin(struct mmu_interval_notifier *interval_sub)
* spin_lock
* seq = ++subscriptions->invalidate_seq
* spin_unlock
- * op->invalidate_range():
+ * op->invalidate():
* user_lock
* mmu_interval_set_seq()
* interval_sub->invalidate_seq = seq
--
git-series 0.9.1
next prev parent reply other threads:[~2023-07-25 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 13:42 [PATCH v4 0/5] Invalidate secondary IOMMU TLB on permission upgrade Alistair Popple
2023-07-25 13:42 ` [PATCH v4 1/5] arm64/smmu: Use TLBI ASID when invalidating entire range Alistair Popple
2023-07-25 13:42 ` Alistair Popple [this message]
2023-07-25 13:42 ` [PATCH v4 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs Alistair Popple
2023-07-25 13:42 ` [PATCH v4 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range_end() Alistair Popple
2023-07-25 13:42 ` [PATCH v4 5/5] mmu_notifiers: Rename invalidate_range notifier Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a09081b3ac82a03c189409f1262fc2df91071e.1690292440.git-series.apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=fbarrat@linux.ibm.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicolinc@nvidia.com \
--cc=npiggin@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rtummala@nvidia.com \
--cc=seanjc@google.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox